Re: [Freedreno] [PATCH] drm/prime: Ensure mmap offset is initialized

2022-05-30 Thread Thomas Zimmermann
Hi Am 29.05.22 um 18:29 schrieb Rob Clark: From: Rob Clark If a GEM object is allocated, and then exported as a dma-buf fd which is mmap'd before or without the GEM buffer being directly mmap'd, the vma_node could be unitialized. This leads to a situation where the CPU mapping is not correctl

[Freedreno] [PATCH] drm/msm/dpu: Fix pointer dereferenced before checking

2022-05-30 Thread Haowen Bai
The ctx->hw is dereferencing before null checking, so move it after checking. Signed-off-by: Haowen Bai --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c b/drivers/gpu/drm/msm/disp/dpu1/

[Freedreno] [PATCH AUTOSEL 5.18 070/159] drm: msm: fix error check return value of irq_of_parse_and_map()

2022-05-30 Thread Sasha Levin
From: Lv Ruyi [ Upstream commit b9e4f1d2b505df8e2439b63e67afaa287c1c43e2 ] The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi Reviewed-by: Dmitry Baryshkov Patchwork: https://patchwork.freedesktop.or

[Freedreno] [PATCH AUTOSEL 5.15 050/109] drm: msm: fix error check return value of irq_of_parse_and_map()

2022-05-30 Thread Sasha Levin
From: Lv Ruyi [ Upstream commit b9e4f1d2b505df8e2439b63e67afaa287c1c43e2 ] The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi Reviewed-by: Dmitry Baryshkov Patchwork: https://patchwork.freedesktop.or

[Freedreno] [PATCH AUTOSEL 5.4 26/55] drm: msm: fix error check return value of irq_of_parse_and_map()

2022-05-30 Thread Sasha Levin
From: Lv Ruyi [ Upstream commit b9e4f1d2b505df8e2439b63e67afaa287c1c43e2 ] The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Reported-by: Zeal Robot Signed-off-by: Lv Ruyi Reviewed-by: Dmitry Baryshkov Patchwork: https://patchwork.freedesktop.or

Re: [Freedreno] [PATCH] drm/prime: Ensure mmap offset is initialized

2022-05-30 Thread Rob Clark
On Mon, May 30, 2022 at 12:26 AM Thomas Zimmermann wrote: > > Hi > > Am 29.05.22 um 18:29 schrieb Rob Clark: > > From: Rob Clark > > > > If a GEM object is allocated, and then exported as a dma-buf fd which is > > mmap'd before or without the GEM buffer being directly mmap'd, the > > vma_node cou

Re: [Freedreno] [PATCH] drm/prime: Ensure mmap offset is initialized

2022-05-30 Thread Thomas Zimmermann
Hi Am 30.05.22 um 15:47 schrieb Rob Clark: On Mon, May 30, 2022 at 12:26 AM Thomas Zimmermann wrote: Hi Am 29.05.22 um 18:29 schrieb Rob Clark: From: Rob Clark If a GEM object is allocated, and then exported as a dma-buf fd which is mmap'd before or without the GEM buffer being directly m

Re: [Freedreno] [PATCH] drm/prime: Ensure mmap offset is initialized

2022-05-30 Thread Rob Clark
On Mon, May 30, 2022 at 7:16 AM Thomas Zimmermann wrote: > > Hi > > Am 30.05.22 um 15:47 schrieb Rob Clark: > > On Mon, May 30, 2022 at 12:26 AM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 29.05.22 um 18:29 schrieb Rob Clark: > >>> From: Rob Clark > >>> > >>> If a GEM object is alloc

Re: [Freedreno] [PATCH] drm/prime: Ensure mmap offset is initialized

2022-05-30 Thread Daniel Vetter
On Mon, 30 May 2022 at 15:54, Rob Clark wrote: > > On Mon, May 30, 2022 at 12:26 AM Thomas Zimmermann > wrote: > > > > Hi > > > > Am 29.05.22 um 18:29 schrieb Rob Clark: > > > From: Rob Clark > > > > > > If a GEM object is allocated, and then exported as a dma-buf fd which is > > > mmap'd befor

Re: [Freedreno] [PATCH] drm/prime: Ensure mmap offset is initialized

2022-05-30 Thread Rob Clark
On Mon, May 30, 2022 at 7:49 AM Daniel Vetter wrote: > > On Mon, 30 May 2022 at 15:54, Rob Clark wrote: > > > > On Mon, May 30, 2022 at 12:26 AM Thomas Zimmermann > > wrote: > > > > > > Hi > > > > > > Am 29.05.22 um 18:29 schrieb Rob Clark: > > > > From: Rob Clark > > > > > > > > If a GEM obje

Re: [Freedreno] [PATCH] drm/prime: Ensure mmap offset is initialized

2022-05-30 Thread Thomas Zimmermann
Hi Am 30.05.22 um 17:41 schrieb Rob Clark: On Mon, May 30, 2022 at 7:49 AM Daniel Vetter wrote: On Mon, 30 May 2022 at 15:54, Rob Clark wrote: On Mon, May 30, 2022 at 12:26 AM Thomas Zimmermann wrote: Hi Am 29.05.22 um 18:29 schrieb Rob Clark: From: Rob Clark If a GEM object is allo

Re: [Freedreno] [PATCH] drm/prime: Ensure mmap offset is initialized

2022-05-30 Thread Rob Clark
On Mon, May 30, 2022 at 10:20 AM Thomas Zimmermann wrote: > > Hi > > Am 30.05.22 um 17:41 schrieb Rob Clark: > > On Mon, May 30, 2022 at 7:49 AM Daniel Vetter wrote: > >> > >> On Mon, 30 May 2022 at 15:54, Rob Clark wrote: > >>> > >>> On Mon, May 30, 2022 at 12:26 AM Thomas Zimmermann > >>> wr

Re: [Freedreno] [PATCH] drm/msm/dpu: Fix pointer dereferenced before checking

2022-05-30 Thread Dmitry Baryshkov
A nit: patchwork thinks that two patches from the same author with the same subject are two versions of the same patch. In future, could you please send such patches with distinct names? No need to send v2 now unless review shows other issues with the patches. On Mon, 30 May 2022 at 10:33, Haowen

Re: [Freedreno] [PATCH] drm/msm/dpu: Fix pointer dereferenced before checking

2022-05-30 Thread Dmitry Baryshkov
On Mon, 30 May 2022 at 05:20, Haowen Bai wrote: > > The phys_enc->wb_idx is dereferencing before null checking, so move > it after checking. > > Signed-off-by: Haowen Bai > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Revi

Re: [Freedreno] [PATCH] drm/msm/dpu: Fix pointer dereferenced before checking

2022-05-30 Thread Abhinav Kumar
On 5/30/2022 12:33 AM, Haowen Bai wrote: The ctx->hw is dereferencing before null checking, so move it after checking. Signed-off-by: Haowen Bai Agree with Dmitry's comment. Adjust the patch subject to a different one otherwise PW thinks they are same patches. Reviewed-by: Abhinav Kumar

Re: [Freedreno] [PATCH] drm/msm/dpu: Fix pointer dereferenced before checking

2022-05-30 Thread baihaowen
在 2022/5/30 下午3:33, Haowen Bai 写道: > The ctx->hw is dereferencing before null checking, so move > it after checking. > > Signed-off-by: Haowen Bai > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp

Re: [Freedreno] [PATCH] drm/msm/dpu: Fix pointer dereferenced before checking

2022-05-30 Thread baihaowen
在 2022/5/31 上午8:36, Abhinav Kumar 写道: > > > On 5/30/2022 12:33 AM, Haowen Bai wrote: >> The ctx->hw is dereferencing before null checking, so move >> it after checking. >> >> Signed-off-by: Haowen Bai > > Agree with Dmitry's comment. Adjust the patch subject to a different one > otherwise PW thin