On Fri, Jun 24, 2022 at 1:49 PM Daniel Vetter wrote:
>
> On Thu, Jun 09, 2022 at 10:42:11AM -0700, Rob Clark wrote:
> > From: Rob Clark
> >
> > The DEFINE_DRM_GEM_FOPS() helper is a bit limiting if a driver wants to
> > provide additional file ops, like show_fdinfo().
> >
> > v2: Split out
On 6/24/2022 5:28 PM, Stephen Boyd wrote:
We don't need to stash the encoder here. Instead we can simply pass it
around as an argument.
Cc: Kuogee Hsieh
Signed-off-by: Stephen Boyd
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dp/dp_display.c | 4 +---
On 6/24/2022 5:30 PM, Dmitry Baryshkov wrote:
Remove extra nestting level from the dpu_encoder_get_intf(), replacing it
with the explicit return in case the INTF_WB was passed to the function.
While we are at it, also change dpu_encoder_get_wb() to also use
explicit return rather than the
On 6/24/2022 5:11 PM, Dmitry Baryshkov wrote:
On Sat, 25 Jun 2022 at 03:03, Abhinav Kumar wrote:
Hi Stephen / Dmitry
Let me try to explain the issue kuogee is trying to fix below:
On 6/24/2022 4:56 PM, Kuogee Hsieh wrote:
On 6/24/2022 4:45 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh
On 6/24/2022 5:23 PM, Stephen Boyd wrote:
Quoting Stephen Boyd (2022-06-24 17:11:01)
Quoting Abhinav Kumar (2022-06-24 17:03:37)
So let me try to explain this as this is what i understood from the
patch and how kuogee explained me.
The ordering of the array still matters here and thats
Quoting Kuogee Hsieh (2022-06-24 18:02:50)
>
> On 6/24/2022 5:46 PM, Dmitry Baryshkov wrote:
> > On Sat, 25 Jun 2022 at 03:28, Dmitry Baryshkov
> > wrote:
> >> On Sat, 25 Jun 2022 at 03:23, Kuogee Hsieh wrote:
> >>> On 6/24/2022 5:21 PM, Dmitry Baryshkov wrote:
> On Sat, 25 Jun 2022 at
On 6/24/2022 5:46 PM, Dmitry Baryshkov wrote:
On Sat, 25 Jun 2022 at 03:28, Dmitry Baryshkov
wrote:
On Sat, 25 Jun 2022 at 03:23, Kuogee Hsieh wrote:
On 6/24/2022 5:21 PM, Dmitry Baryshkov wrote:
On Sat, 25 Jun 2022 at 03:19, Kuogee Hsieh wrote:
How can I have eDP call
On Sat, 25 Jun 2022 at 03:28, Dmitry Baryshkov
wrote:
>
> On Sat, 25 Jun 2022 at 03:23, Kuogee Hsieh wrote:
> > On 6/24/2022 5:21 PM, Dmitry Baryshkov wrote:
> > > On Sat, 25 Jun 2022 at 03:19, Kuogee Hsieh
> > > wrote:
> > >> How can I have eDP call dpu_encoder_init() before DP calls with
> >
Remove extra nestting level from the dpu_encoder_get_intf(), replacing it
with the explicit return in case the INTF_WB was passed to the function.
While we are at it, also change dpu_encoder_get_wb() to also use
explicit return rather than the goto.
Reviewed-by: Stephen Boyd
Signed-off-by:
On Sat, 25 Jun 2022 at 03:28, Stephen Boyd wrote:
>
> We don't need to stash the encoder here. Instead we can simply pass it
> around as an argument.
>
> Cc: Kuogee Hsieh
> Signed-off-by: Stephen Boyd
Reviewed-by: Dmitry Baryshkov
> ---
> drivers/gpu/drm/msm/dp/dp_display.c | 4 +---
>
Quoting Dmitry Baryshkov (2022-06-24 16:51:20)
> Remove extra nexting level from the dpu_encoder_get_intf(), replacing it
s/nexting/nesting/
> with the explicit return in case the INTF_WB was passed to the function.
>
> While we are at it, also change dpu_encoder_get_wb() to also use
> explicit
On Sat, 25 Jun 2022 at 03:23, Kuogee Hsieh wrote:
> On 6/24/2022 5:21 PM, Dmitry Baryshkov wrote:
> > On Sat, 25 Jun 2022 at 03:19, Kuogee Hsieh wrote:
> >> How can I have eDP call dpu_encoder_init() before DP calls with
> >> _dpu_kms_initialize_displayport()?
> > Why do you want to do it? They
We don't need to stash the encoder here. Instead we can simply pass it
around as an argument.
Cc: Kuogee Hsieh
Signed-off-by: Stephen Boyd
---
drivers/gpu/drm/msm/dp/dp_display.c | 4 +---
drivers/gpu/drm/msm/dp/dp_display.h | 1 -
drivers/gpu/drm/msm/dp/dp_drm.c | 8
On 6/24/2022 5:21 PM, Dmitry Baryshkov wrote:
On Sat, 25 Jun 2022 at 03:19, Kuogee Hsieh wrote:
How can I have eDP call dpu_encoder_init() before DP calls with
_dpu_kms_initialize_displayport()?
Why do you want to do it? They are two different encoders.
eDP is primary display which in
Quoting Stephen Boyd (2022-06-24 17:11:01)
> Quoting Abhinav Kumar (2022-06-24 17:03:37)
> >
> > So let me try to explain this as this is what i understood from the
> > patch and how kuogee explained me.
> >
> > The ordering of the array still matters here and thats what he is trying
> > to
On Sat, 25 Jun 2022 at 03:19, Kuogee Hsieh wrote:
> How can I have eDP call dpu_encoder_init() before DP calls with
> _dpu_kms_initialize_displayport()?
Why do you want to do it? They are two different encoders.
--
With best wishes
Dmitry
On 6/24/2022 5:11 PM, Dmitry Baryshkov wrote:
On Sat, 25 Jun 2022 at 03:03, Abhinav Kumar wrote:
Hi Stephen / Dmitry
Let me try to explain the issue kuogee is trying to fix below:
On 6/24/2022 4:56 PM, Kuogee Hsieh wrote:
On 6/24/2022 4:45 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh
On Fri, 24 Jun 2022 at 04:07, sunliming wrote:
>
> Fixes the following smatch warning:
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:261
> dpu_encoder_phys_wb_atomic_check() warn: variable dereferenced before check
> 'conn_state'
>
> Fixes: d7d0e73f7de3 ("drm/msm/dpu: introduce the
On Fri, 24 Jun 2022 at 21:45, Rob Clark wrote:
>
> From: Rob Clark
>
> This was a typo, we didn't actually want to return zero.
>
> Fixes: a61acbbe9cf8 ("drm/msm: Track "seqno" fences by idr")
> Signed-off-by: Rob Clark
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
On Sat, 25 Jun 2022 at 03:03, Abhinav Kumar wrote:
>
> Hi Stephen / Dmitry
>
> Let me try to explain the issue kuogee is trying to fix below:
>
> On 6/24/2022 4:56 PM, Kuogee Hsieh wrote:
> >
> > On 6/24/2022 4:45 PM, Stephen Boyd wrote:
> >> Quoting Kuogee Hsieh (2022-06-24 16:30:59)
> >>> On
Quoting Abhinav Kumar (2022-06-24 17:03:37)
> Hi Stephen / Dmitry
>
> Let me try to explain the issue kuogee is trying to fix below:
>
> On 6/24/2022 4:56 PM, Kuogee Hsieh wrote:
> >
> > On 6/24/2022 4:45 PM, Stephen Boyd wrote:
> >> Quoting Kuogee Hsieh (2022-06-24 16:30:59)
> >>> On 6/24/2022
Hi Stephen / Dmitry
Let me try to explain the issue kuogee is trying to fix below:
On 6/24/2022 4:56 PM, Kuogee Hsieh wrote:
On 6/24/2022 4:45 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 16:30:59)
On 6/24/2022 4:12 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24
On 6/24/2022 4:45 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 16:30:59)
On 6/24/2022 4:12 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 15:53:45)
MSM_DP_CONTROLLER_1 need to match to the index = 1 of sc7280_dp_cfg[] <== This
is correct
The problem is
On Fri, 24 Jun 2022 at 20:15, Kuogee Hsieh wrote:
>
> The msm_dp_modeset_init() is used to attach DP driver to drm bridge chain.
> msm_dp_modeset_init() is executed in the order of index (dp->id) of DP
> descriptor table.
>
> Currently, DP is placed at first entry (dp->id = 0) of descriptor table
On Sat, 25 Jun 2022 at 02:45, Stephen Boyd wrote:
>
> Quoting Kuogee Hsieh (2022-06-24 16:30:59)
> >
> > On 6/24/2022 4:12 PM, Stephen Boyd wrote:
> > > Quoting Kuogee Hsieh (2022-06-24 15:53:45)
> > >> MSM_DP_CONTROLLER_1 need to match to the index = 1 of sc7280_dp_cfg[]
> > >> <== This is
Remove extra nexting level from the dpu_encoder_get_intf(), replacing it
with the explicit return in case the INTF_WB was passed to the function.
While we are at it, also change dpu_encoder_get_wb() to also use
explicit return rather than the goto.
Signed-off-by: Dmitry Baryshkov
---
On Sat, 25 Jun 2022 at 00:51, Kuogee Hsieh wrote:
> On 6/24/2022 2:40 PM, Doug Anderson wrote:
> > On Fri, Jun 24, 2022 at 10:15 AM Kuogee Hsieh
> > wrote:
> >> +struct msm_display_info {
> >> + int intf_type;
> >> + uint32_t capabilities;
> >> + uint32_t num_of_h_tiles;
> >>
Quoting Kuogee Hsieh (2022-06-24 16:30:59)
>
> On 6/24/2022 4:12 PM, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2022-06-24 15:53:45)
> >> MSM_DP_CONTROLLER_1 need to match to the index = 1 of sc7280_dp_cfg[] <==
> >> This is correct
> >>
> >> The problem is sc7280_dp_cfg[] have two entries
On Fri, 24 Jun 2022 at 20:15, Kuogee Hsieh wrote:
>
> With current implementation, communication between interface driver and
> upper mdss encoder layer are implemented through function calls. This
> increase code complexity. Since struct msm_display_info contains msm
> generic display
On 6/24/2022 4:12 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 15:53:45)
MSM_DP_CONTROLLER_1 need to match to the index = 1 of sc7280_dp_cfg[] <== This
is correct
The problem is sc7280_dp_cfg[] have two entries since eDP place at index
of MSM_DP_CONTROLLER_1.
but .num_desc = 1
On Sat, 25 Jun 2022 at 00:17, Kuogee Hsieh wrote:
>
>
> On 6/24/2022 1:00 PM, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2022-06-24 10:15:11)
> >> Current the index (dp->id) of DP descriptor table (sc_dp_cfg[]) are
> >> tightly
> >> coupled with DP controller_id. This means DP use
Quoting Kuogee Hsieh (2022-06-24 15:53:45)
>
> MSM_DP_CONTROLLER_1 need to match to the index = 1 of sc7280_dp_cfg[] <==
> This is correct
>
> The problem is sc7280_dp_cfg[] have two entries since eDP place at index
> of MSM_DP_CONTROLLER_1.
>
> but .num_desc = 1 <== this said only have one
On 6/24/2022 3:19 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 14:49:57)
On 6/24/2022 2:40 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 14:17:50)
On 6/24/2022 1:00 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 10:15:11)
Current the index (dp->id) of DP
Quoting Kuogee Hsieh (2022-06-24 14:49:57)
>
> On 6/24/2022 2:40 PM, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2022-06-24 14:17:50)
> >> On 6/24/2022 1:00 PM, Stephen Boyd wrote:
> >>> Quoting Kuogee Hsieh (2022-06-24 10:15:11)
> Current the index (dp->id) of DP descriptor table
On 6/24/2022 2:40 PM, Doug Anderson wrote:
Hi,
On Fri, Jun 24, 2022 at 10:15 AM Kuogee Hsieh wrote:
With current implementation, communication between interface driver and
upper mdss encoder layer are implemented through function calls. This
increase code complexity. Since struct
On 6/24/2022 2:40 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 14:17:50)
On 6/24/2022 1:00 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 10:15:11)
Current the index (dp->id) of DP descriptor table (sc_dp_cfg[]) are tightly
coupled with DP controller_id. This means
On Fri, Jun 24, 2022 at 2:36 PM Daniel Vetter wrote:
>
> On Fri, Jun 24, 2022 at 02:28:25PM -0700, Rob Clark wrote:
> > On Fri, Jun 24, 2022 at 1:58 PM Daniel Vetter wrote:
> > >
> > > On Thu, Jun 16, 2022 at 06:59:46AM -0700, Rob Clark wrote:
> > > > On Thu, Jun 16, 2022 at 1:28 AM Stephen Boyd
Quoting Kuogee Hsieh (2022-06-24 14:17:50)
>
> On 6/24/2022 1:00 PM, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2022-06-24 10:15:11)
> >> Current the index (dp->id) of DP descriptor table (sc_dp_cfg[]) are
> >> tightly
> >> coupled with DP controller_id. This means DP use controller id 0
Hi,
On Fri, Jun 24, 2022 at 10:15 AM Kuogee Hsieh wrote:
>
> With current implementation, communication between interface driver and
> upper mdss encoder layer are implemented through function calls. This
> increase code complexity. Since struct msm_display_info contains msm
> generic display
On Fri, Jun 24, 2022 at 02:28:25PM -0700, Rob Clark wrote:
> On Fri, Jun 24, 2022 at 1:58 PM Daniel Vetter wrote:
> >
> > On Thu, Jun 16, 2022 at 06:59:46AM -0700, Rob Clark wrote:
> > > On Thu, Jun 16, 2022 at 1:28 AM Stephen Boyd wrote:
> > > >
> > > > Quoting Rob Clark (2022-06-13 13:50:32)
>
On Fri, Jun 24, 2022 at 1:58 PM Daniel Vetter wrote:
>
> On Thu, Jun 16, 2022 at 06:59:46AM -0700, Rob Clark wrote:
> > On Thu, Jun 16, 2022 at 1:28 AM Stephen Boyd wrote:
> > >
> > > Quoting Rob Clark (2022-06-13 13:50:32)
> > > > diff --git a/drivers/gpu/drm/msm/msm_gem.h
> > > >
On 6/24/2022 1:00 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-24 10:15:11)
Current the index (dp->id) of DP descriptor table (sc_dp_cfg[]) are tightly
coupled with DP controller_id. This means DP use controller id 0 must be placed
at first entry of DP descriptor table
On Wed, Jun 15, 2022 at 05:19:42PM +0300, Dmitry Baryshkov wrote:
> Hi Stephen,
>
> I would appreciate if you could add
>
> https://gitlab.freedesktop.org/lumag/msm.git msm-next-lumag
>
> to the linux-next tree.
>
> This tree is a part of drm/msm maintenance structure. As a co-maintainer I
>
On Thu, Jun 16, 2022 at 06:59:46AM -0700, Rob Clark wrote:
> On Thu, Jun 16, 2022 at 1:28 AM Stephen Boyd wrote:
> >
> > Quoting Rob Clark (2022-06-13 13:50:32)
> > > diff --git a/drivers/gpu/drm/msm/msm_gem.h b/drivers/gpu/drm/msm/msm_gem.h
> > > index d608339c1643..432032ad4aed 100644
> > > ---
On Thu, Jun 09, 2022 at 10:42:11AM -0700, Rob Clark wrote:
> From: Rob Clark
>
> The DEFINE_DRM_GEM_FOPS() helper is a bit limiting if a driver wants to
> provide additional file ops, like show_fdinfo().
>
> v2: Split out DRM_GEM_FOPS instead of making DEFINE_DRM_GEM_FOPS
> varardic
> v3:
Quoting Kuogee Hsieh (2022-06-24 10:15:11)
> Current the index (dp->id) of DP descriptor table (sc_dp_cfg[]) are
> tightly
> coupled with DP controller_id. This means DP use controller id 0 must be
> placed
> at first entry of DP descriptor table (sc_dp_cfg[]). Otherwise the
> internal
Hi Rob
Here are the fixes for 5.19.
Namely this has the foll fixes:
- Fix to reset drm_dev to NULL in dp_display_unbind
- Fix to increment vsync_cnt before calling drm_crtc_handle_vblank
(IGT was re-tested with this change and CI also passes)
- Fix to resolve the smatch error of de-referencing
From: Rob Clark
This was a typo, we didn't actually want to return zero.
Fixes: a61acbbe9cf8 ("drm/msm: Track "seqno" fences by idr")
Signed-off-by: Rob Clark
---
drivers/gpu/drm/msm/msm_gem_submit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The msm_dp_modeset_init() is used to attach DP driver to drm bridge chain.
msm_dp_modeset_init() is executed in the order of index (dp->id) of DP
descriptor table.
Currently, DP is placed at first entry (dp->id = 0) of descriptor table
and eDP is placed at secondary entry (dp->id = 1 ) of
With current implementation, communication between interface driver and
upper mdss encoder layer are implemented through function calls. This
increase code complexity. Since struct msm_display_info contains msm
generic display information, it can be expended to contains more useful
information,
Current the index (dp->id) of DP descriptor table (sc_dp_cfg[]) are tightly
coupled with DP controller_id. This means DP use controller id 0 must be placed
at first entry of DP descriptor table (sc_dp_cfg[]). Otherwise the internal
INTF will mismatch controller_id. This will cause
fix primary corruption :
1) move struc of msm_display_info to msm_drv.h
2) decoupling dp->id out of dp controller_id at sc_dp_cfg table
3) place edp at head of drm bridge chain to fix screen corruption
Kuogee Hsieh (3):
drm/msm/dp: move struc of msm_display_info to msm_drv.h
drm/msm/dp:
On 6/23/2022 5:09 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2022-06-23 16:34:16)
eDP implementation does not reuried to support hpd signal. Therefore
s/reuried/require/
it only has either ST_DISPLAY_OFF or ST_CONNECTED state during normal
operation. This patch remove unnecessary
53 matches
Mail list logo
