Re: [Freedreno] [v1 2/2] drm/msm/disp/dpu1: enable crtc color management based on encoder topology

2022-06-27 Thread Kalyan Thota
Thanks for the comments, Dmitry. I haven't noticed mode->hdisplay being used. My idea was to run thru the topology and tie up the encoders with dspp to the CRTCs. Since mode is available only in the commit, we cannot use the dpu_encoder_get_topology during initialization sequence. The requireme

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dp: decoupling dp->id out of dp controller_id at scxxxx_dp_cfg table

2022-06-27 Thread Kuogee Hsieh
On 6/24/2022 6:15 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-06-24 18:02:50) On 6/24/2022 5:46 PM, Dmitry Baryshkov wrote: On Sat, 25 Jun 2022 at 03:28, Dmitry Baryshkov wrote: On Sat, 25 Jun 2022 at 03:23, Kuogee Hsieh wrote: On 6/24/2022 5:21 PM, Dmitry Baryshkov wrote: On Sat,

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dp: decoupling dp->id out of dp controller_id at scxxxx_dp_cfg table

2022-06-27 Thread Dmitry Baryshkov
On Mon, 27 Jun 2022 at 18:33, Kuogee Hsieh wrote: > > > On 6/24/2022 6:15 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-06-24 18:02:50) > >> On 6/24/2022 5:46 PM, Dmitry Baryshkov wrote: > >>> On Sat, 25 Jun 2022 at 03:28, Dmitry Baryshkov > >>> wrote: > On Sat, 25 Jun 2022 at 03:23

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dp: decoupling dp->id out of dp controller_id at scxxxx_dp_cfg table

2022-06-27 Thread Kuogee Hsieh
On 6/27/2022 8:38 AM, Dmitry Baryshkov wrote: On Mon, 27 Jun 2022 at 18:33, Kuogee Hsieh wrote: On 6/24/2022 6:15 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-06-24 18:02:50) On 6/24/2022 5:46 PM, Dmitry Baryshkov wrote: On Sat, 25 Jun 2022 at 03:28, Dmitry Baryshkov wrote: On Sat

[Freedreno] [PATCH] drm/msm/dp: use ARRAY_SIZE for calculating num_descs

2022-06-27 Thread Dmitry Baryshkov
If for some reason the msm_dp_config::descs array starts from non-zero index or contains the hole, setting the msm_dp_config::num_descs might be not that obvious and error-prone. Use ARRAY_SIZE to set this field rather than encoding the value manually. Reported-by: Kuogee Hsieh Signed-off-by: Dmi

Re: [Freedreno] [PATCH v2 1/3] dt-bindings: phy: qcom, hdmi-phy-qmp: add clock-cells and XO clock

2022-06-27 Thread Rob Herring
On Mon, Jun 20, 2022 at 04:02:58AM +0300, Dmitry Baryshkov wrote: > As the QMP HDMI PHY is a clock provider, add constant #clock-cells > property. For the compatibility with older DTs the property is not > marked as required. Also add the XO clock to the list of the clocks used > by the driver. >

Re: [Freedreno] [PATCH v2 1/3] dt-bindings: phy: qcom, hdmi-phy-qmp: add clock-cells and XO clock

2022-06-27 Thread Dmitry Baryshkov
On Mon, 27 Jun 2022 at 20:17, Rob Herring wrote: > > On Mon, Jun 20, 2022 at 04:02:58AM +0300, Dmitry Baryshkov wrote: > > As the QMP HDMI PHY is a clock provider, add constant #clock-cells > > property. For the compatibility with older DTs the property is not > > marked as required. Also add the

Re: [Freedreno] [PATCH] drm/msm/dp: use ARRAY_SIZE for calculating num_descs

2022-06-27 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-27 09:54:13) > If for some reason the msm_dp_config::descs array starts from non-zero > index or contains the hole, setting the msm_dp_config::num_descs might > be not that obvious and error-prone. Use ARRAY_SIZE to set this field > rather than encoding the value m

Re: [Freedreno] [PATCH] drm/msm/dp: use ARRAY_SIZE for calculating num_descs

2022-06-27 Thread Kuogee Hsieh
On 6/27/2022 9:54 AM, Dmitry Baryshkov wrote: If for some reason the msm_dp_config::descs array starts from non-zero index or contains the hole, setting the msm_dp_config::num_descs might be not that obvious and error-prone. Use ARRAY_SIZE to set this field rather than encoding the value manual

Re: [Freedreno] (subset) [PATCH] arm64: dts: qcom: sdm845: use dispcc AHB clock for mdss node

2022-06-27 Thread Bjorn Andersson
On Tue, 31 May 2022 15:47:35 +0300, Dmitry Baryshkov wrote: > It was noticed that on sdm845 after an MDSS suspend/resume cycle the > driver can not read HW_REV registers properly (they will return 0 > instead). Chaning the "iface" clock from <&gcc GCC_DISP_AHB_CLK> to > <&dispcc DISP_CC_MDSS_AHB_CL

Re: [Freedreno] (subset) [PATCH v7 0/5] Update mdp clk to max supported value to support higher refresh rates

2022-06-27 Thread Bjorn Andersson
On Tue, 22 Mar 2022 08:57:06 +0530, Vinod Polimera wrote: > Drop the assigned clock rate property and vote on the mdp clock to > max frequency during bind/probe sequence. > > Changes in v2: > - Remove assigned-clock-rate property and set mdp clk during > resume sequence. > - Add fixes tag. > > [.

Re: [Freedreno] [PATCH] drm/msm/dp: use ARRAY_SIZE for calculating num_descs

2022-06-27 Thread Dmitry Baryshkov
On Mon, 27 Jun 2022 at 22:26, Kuogee Hsieh wrote: > > > On 6/27/2022 9:54 AM, Dmitry Baryshkov wrote: > > If for some reason the msm_dp_config::descs array starts from non-zero > > index or contains the hole, setting the msm_dp_config::num_descs might > > be not that obvious and error-prone. Use A

Re: [Freedreno] [PATCH] drm/msm/dp: use ARRAY_SIZE for calculating num_descs

2022-06-27 Thread Kuogee Hsieh
On 6/27/2022 1:05 PM, Dmitry Baryshkov wrote: On Mon, 27 Jun 2022 at 22:26, Kuogee Hsieh wrote: On 6/27/2022 9:54 AM, Dmitry Baryshkov wrote: If for some reason the msm_dp_config::descs array starts from non-zero index or contains the hole, setting the msm_dp_config::num_descs might be not

Re: [Freedreno] [PATCH] drm/msm/dp: use ARRAY_SIZE for calculating num_descs

2022-06-27 Thread Dmitry Baryshkov
On 28/06/2022 00:01, Kuogee Hsieh wrote: On 6/27/2022 1:05 PM, Dmitry Baryshkov wrote: On Mon, 27 Jun 2022 at 22:26, Kuogee Hsieh wrote: On 6/27/2022 9:54 AM, Dmitry Baryshkov wrote: If for some reason the msm_dp_config::descs array starts from non-zero index or contains the hole, setting t

Re: [Freedreno] [PATCH v2 03/11] clk: fixed-factor: Introduce *clk_hw_register_fixed_factor_parent_hw()

2022-06-27 Thread Marijn Suijten
On 2022-06-10 12:01:10, Stephen Boyd wrote: > Quoting Marijn Suijten (2022-06-10 00:46:32) > > On 2022-06-09 15:12:09, Stephen Boyd wrote: > > > Quoting Dmitry Baryshkov (2022-06-02 03:20:19) > > > > On Thu, 2 Jun 2022 at 01:07, Marijn Suijten > > > > wrote: > > > > > diff --git a/drivers/clk/clk-

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dp: decoupling dp->id out of dp controller_id at scxxxx_dp_cfg table

2022-06-27 Thread Doug Anderson
Hi, On Sat, Jun 25, 2022 at 1:48 AM Dmitry Baryshkov wrote: > > On Sat, 25 Jun 2022 at 04:23, Abhinav Kumar wrote: > > On 6/24/2022 5:11 PM, Dmitry Baryshkov wrote: > > > On Sat, 25 Jun 2022 at 03:03, Abhinav Kumar > > > wrote: > > >> On 6/24/2022 4:56 PM, Kuogee Hsieh wrote: > > >> diff --git

[Freedreno] [PATCH RESEND] drm/msm/dpu: Fix variable dereferenced before check

2022-06-27 Thread sunliming
Fixes the following smatch warning: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c:261 dpu_encoder_phys_wb_atomic_check() warn: variable dereferenced before check 'conn_state' Fixes: d7d0e73f7de3 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for writeback") Reported-by: kernel test robot