Re: [Freedreno] (subset) [PATCH] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp

2022-07-06 Thread Bjorn Andersson
On Fri, 1 Jul 2022 08:47:16 -0700, Kuogee Hsieh wrote: > Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled > by dp combo phy. Therefore remove them from dp controller. > > Applied, thanks! [1/1] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp commit:

Re: [Freedreno] [PATCH] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-07-06 Thread kernel test robot
Hi Dmitry, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v5.19-rc5 next-20220706] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

Re: [Freedreno] [PATCH] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp

2022-07-06 Thread Stephen Boyd
Subject should have 'dts', not 'dta'. Quoting Kuogee Hsieh (2022-07-01 08:47:16) > Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled > by dp combo phy. Therefore remove them from dp controller. > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v3 1/3] drm/msm/dpu: index dpu_kms->hw_vbif using vbif_idx

2022-07-06 Thread Abhinav Kumar
On 6/15/2022 5:57 AM, Dmitry Baryshkov wrote: Remove loops over hw_vbif. Instead always VBIF's idx as an index in the array. This fixes an error in dpu_kms_hw_init(), where we fill dpu_kms->hw_vbif[i], but check for an error pointer at dpu_kms->hw_vbif[vbif_idx]. Fixes: 25fdd5933e4c

[Freedreno] [PATCH] drm/msm/dsi: switch to DRM_PANEL_BRIDGE

2022-07-06 Thread Dmitry Baryshkov
Currently the DSI driver has two separate paths: one if the next device in a chain is a bridge and another one if the panel is connected directly to the DSI host. Simplify the code path by using panel-bridge driver (already selected in Kconfig) and dropping support for handling the panel directly.

Re: [Freedreno] [PATCH v4] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Abhinav Kumar
On 7/6/2022 12:32 PM, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the main panel. This patch call drm_helper_move_panel_connectors_to_head() after

[Freedreno] [PATCH v4] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Kuogee Hsieh
Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the main panel. This patch call drm_helper_move_panel_connectors_to_head() after drm_bridge_connector_init() to make sure eDP stay at

[Freedreno] [PATCH] drm/msm/dsi: Set panel orientation when directly connected

2022-07-06 Thread Stephen Boyd
Set the panel orientation in drm when the panel is directly connected, i.e. we're not using an external bridge. The external bridge case is already handled by the panel bridge code, so we only update the path we take when the panel is directly connected/internal. This silences a warning splat

Re: [Freedreno] [PATCH v3] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Dmitry Baryshkov
On 06/07/2022 20:54, Kuogee Hsieh wrote: On 7/6/2022 10:41 AM, Dmitry Baryshkov wrote: On 06/07/2022 20:38, Kuogee Hsieh wrote: On 7/6/2022 10:25 AM, Dmitry Baryshkov wrote: On 06/07/2022 20:24, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main

Re: [Freedreno] [PATCH v3] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Kuogee Hsieh
On 7/6/2022 10:41 AM, Dmitry Baryshkov wrote: On 06/07/2022 20:38, Kuogee Hsieh wrote: On 7/6/2022 10:25 AM, Dmitry Baryshkov wrote: On 06/07/2022 20:24, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g.

Re: [Freedreno] [PATCH v3] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Dmitry Baryshkov
On 06/07/2022 20:38, Kuogee Hsieh wrote: On 7/6/2022 10:25 AM, Dmitry Baryshkov wrote: On 06/07/2022 20:24, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the

Re: [Freedreno] [PATCH v3] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Kuogee Hsieh
On 7/6/2022 10:25 AM, Dmitry Baryshkov wrote: On 06/07/2022 20:24, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the main panel. This patch call

Re: [Freedreno] [PATCH v3] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Dmitry Baryshkov
On 06/07/2022 20:24, Kuogee Hsieh wrote: Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the main panel. This patch call drm_helper_move_panel_connectors_to_head() after

[Freedreno] [PATCH v3] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Kuogee Hsieh
Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the main panel. This patch call drm_helper_move_panel_connectors_to_head() after drm_bridge_connector_init() to make sure eDP stay at

Re: [Freedreno] [PATCH v2] drm/msm/adreno: Do not propagate void return values

2022-07-06 Thread Dmitry Baryshkov
On Wed, 6 Jul 2022 at 16:18, Geert Uytterhoeven wrote: > > With sparse ("make C=2"), lots of > > error: return expression in void function > > messages are seen. > > Fix this by removing the return statements to propagate void return > values. > > Signed-off-by: Geert Uytterhoeven >

Re: [Freedreno] [PATCH v2] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Dmitry Baryshkov
On Wed, 6 Jul 2022 at 19:12, Kuogee Hsieh wrote: > > Some userspace presumes that the first connected connector is the main > display, where it's supposed to display e.g. the login screen. For > laptops, this should be the main panel. > > This patch call drm_helper_move_panel_connectors_to_head()

Re: [Freedreno] [PATCH 2/4] dt-bindings: display/msm/gpu: document using the amd, imageon adreno too

2022-07-06 Thread Dmitry Baryshkov
On 06/07/2022 19:19, Krzysztof Kozlowski wrote: On 06/07/2022 18:00, Dmitry Baryshkov wrote: On 06/07/2022 18:50, Krzysztof Kozlowski wrote: On 06/07/2022 16:52, Dmitry Baryshkov wrote: The DT binding desribes using amd,imageon only for Imageon 2xx GPUs. We have been using amd,imageon with

Re: [Freedreno] [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-06 Thread Vinod Koul
On 05-07-22, 09:29, Kuogee Hsieh wrote: > 0) rebase on > https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree > 1) add regulator_set_load() to eDP phy > 2) add regulator_set_load() to DP phy > 3) remove vdda related function out of eDP/DP controller Applied, thanks -- ~Vinod

Re: [Freedreno] [PATCH 1/2] iommu: arm-smmu-impl: Add 8250 display compatible to the client list.

2022-07-06 Thread Will Deacon
On Tue, 14 Jun 2022 16:01:35 -0700, Emma Anholt wrote: > Required for turning on per-process page tables for the GPU. > > Applied to will (for-joerg/arm-smmu/updates), thanks! [1/2] iommu: arm-smmu-impl: Add 8250 display compatible to the client list.

Re: [Freedreno] [PATCH 2/4] dt-bindings: display/msm/gpu: document using the amd, imageon adreno too

2022-07-06 Thread Krzysztof Kozlowski
On 06/07/2022 18:00, Dmitry Baryshkov wrote: > On 06/07/2022 18:50, Krzysztof Kozlowski wrote: >> On 06/07/2022 16:52, Dmitry Baryshkov wrote: >>> The DT binding desribes using amd,imageon only for Imageon 2xx GPUs. We >>> have been using amd,imageon with newer (Adreno) GPUs to describe the >>>

[Freedreno] [PATCH v2] drm/msm/dp: make eDP panel as the first connected connector

2022-07-06 Thread Kuogee Hsieh
Some userspace presumes that the first connected connector is the main display, where it's supposed to display e.g. the login screen. For laptops, this should be the main panel. This patch call drm_helper_move_panel_connectors_to_head() after drm_bridge_connector_init() to make sure eDP stay at

Re: [Freedreno] [PATCH 2/4] dt-bindings: display/msm/gpu: document using the amd, imageon adreno too

2022-07-06 Thread Dmitry Baryshkov
On 06/07/2022 18:50, Krzysztof Kozlowski wrote: On 06/07/2022 16:52, Dmitry Baryshkov wrote: The DT binding desribes using amd,imageon only for Imageon 2xx GPUs. We have been using amd,imageon with newer (Adreno) GPUs to describe the headless setup, when the platform does not (yet) have the

Re: [Freedreno] [PATCH 4/4] dt-bindings: display/msm/mdp4: require 4 IOMMUs

2022-07-06 Thread Krzysztof Kozlowski
On 06/07/2022 16:52, Dmitry Baryshkov wrote: > APQ8064, the only supported mdp4 platform, uses 4 IOMMUs for the MDP4 > device. Update schema accordingly. When we have other MDP4 platforms, > this spec can be updated accordingly. > > Signed-off-by: Dmitry Baryshkov Acked-by: Krzysztof Kozlowski

Re: [Freedreno] [PATCH 3/4] dt-bindings: display/msm/gmu: account for different GMU variants

2022-07-06 Thread Krzysztof Kozlowski
On 06/07/2022 16:52, Dmitry Baryshkov wrote: > Make display/msm/gmu.yaml describe all existing GMU variants rather than > just the 630.2 (SDM845) version of it. > > Signed-off-by: Dmitry Baryshkov > --- > .../devicetree/bindings/display/msm/gmu.yaml | 166 +++--- > 1 file changed,

Re: [Freedreno] [PATCH 2/4] dt-bindings: display/msm/gpu: document using the amd, imageon adreno too

2022-07-06 Thread Krzysztof Kozlowski
On 06/07/2022 16:52, Dmitry Baryshkov wrote: > The DT binding desribes using amd,imageon only for Imageon 2xx GPUs. We > have been using amd,imageon with newer (Adreno) GPUs to describe the > headless setup, when the platform does not (yet) have the display DT Does not have "yet"? So later it

Re: [Freedreno] [PATCH 1/4] dt-bindings: display/msm/gpu: allow specifying several IOMMU nodes

2022-07-06 Thread Krzysztof Kozlowski
On 06/07/2022 16:52, Dmitry Baryshkov wrote: > Different platforms require different amounts of IOMMUs. The APQ8064 > uses 64 IOMMU instances for GPU, adjust the schema accordingly. > > Signed-off-by: Dmitry Baryshkov > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

[Freedreno] [PATCH 4/4] dt-bindings: display/msm/mdp4: require 4 IOMMUs

2022-07-06 Thread Dmitry Baryshkov
APQ8064, the only supported mdp4 platform, uses 4 IOMMUs for the MDP4 device. Update schema accordingly. When we have other MDP4 platforms, this spec can be updated accordingly. Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/display/msm/mdp4.yaml | 2 +- 1 file changed, 1

[Freedreno] [PATCH 3/4] dt-bindings: display/msm/gmu: account for different GMU variants

2022-07-06 Thread Dmitry Baryshkov
Make display/msm/gmu.yaml describe all existing GMU variants rather than just the 630.2 (SDM845) version of it. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm/gmu.yaml | 166 +++--- 1 file changed, 146 insertions(+), 20 deletions(-) diff --git

[Freedreno] [PATCH 2/4] dt-bindings: display/msm/gpu: document using the amd, imageon adreno too

2022-07-06 Thread Dmitry Baryshkov
The DT binding desribes using amd,imageon only for Imageon 2xx GPUs. We have been using amd,imageon with newer (Adreno) GPUs to describe the headless setup, when the platform does not (yet) have the display DT nodes (and no display support). Document this trick in the schema. Signed-off-by:

[Freedreno] [PATCH 0/4] dt-bindings: display/msm: schema fixes for gpu, gmu and mdp4

2022-07-06 Thread Dmitry Baryshkov
Fix several issues in MSM display schema. Dmitry Baryshkov (4): dt-bindings: display/msm/gpu: allow specifying several IOMMU nodes dt-bindings: display/msm/gpu: document using the amd,imageon adreno too dt-bindings: display/msm/gmu: account for different GMU variants dt-bindings:

[Freedreno] [PATCH 1/4] dt-bindings: display/msm/gpu: allow specifying several IOMMU nodes

2022-07-06 Thread Dmitry Baryshkov
Different platforms require different amounts of IOMMUs. The APQ8064 uses 64 IOMMU instances for GPU, adjust the schema accordingly. Signed-off-by: Dmitry Baryshkov --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Freedreno] [PATCH v2] drm/msm/adreno: Do not propagate void return values

2022-07-06 Thread Geert Uytterhoeven
With sparse ("make C=2"), lots of error: return expression in void function messages are seen. Fix this by removing the return statements to propagate void return values. Signed-off-by: Geert Uytterhoeven Reviewed-by: Guenter Roeck --- v2: - Add Reviewed-by. ---

Re: [Freedreno] [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML

2022-07-06 Thread Dmitry Baryshkov
On 30/06/2022 15:08, Bryan O'Donoghue wrote: Add in missing clock and clock-names declarations to the 28nm DSI PHY. When converting from .txt to .yaml we missed these. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Signed-off-by: Bryan O'Donoghue I checked