[Freedreno] [PATCH 5/7] drm/msm/dp: Implement hpd_notify()

2022-08-09 Thread Bjorn Andersson
The DisplayPort controller's hot-plug mechanism is based on pinmuxing a physical signal no a GPIO pin into the controller. This is not always possible, either because there aren't dedicated GPIOs available or because the hot-plug signal is a virtual notification, in cases such as USB Type-C. For t

[Freedreno] [PATCH 7/7] drm/msm/dp: HPD handling relates to next_bridge

2022-08-09 Thread Bjorn Andersson
The DisplayPort controller's internal HPD interrupt handling is used for cases where the HPD signal is connected to a GPIO which is pinmuxed into the DisplayPort controller. Most of the logic for enabling and disabling the HPD-related interrupts is conditioned on the presence of an EDP panel, but

[Freedreno] [PATCH 4/7] drm/msm/dp: Add SDM845 DisplayPort instance

2022-08-09 Thread Bjorn Andersson
The Qualcomm SDM845 platform has a single DisplayPort controller, with the same design as SC7180, so add support for this by reusing the SC7180 definition. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/m

[Freedreno] [PATCH 0/7] drm/msm/dp: Support for external displays

2022-08-09 Thread Bjorn Andersson
Introduce support for DisplayPort on SDM845 and SC8280XP, followed by introduction of drm_bridge based HPD handling. The version of these patches are restarted, as the previous drm_connector_oob_hotplug_event()-based approach was abandoned and this only barely resembles that effort. In this effor

[Freedreno] [PATCH 2/7] drm/msm/dp: Stop using DP id as index in desc

2022-08-09 Thread Bjorn Andersson
In the SC8280XP platform there are two identical MDSS instances, each with the same set of DisplayPort instances, at different addresses. By not relying on the index to define the instance id it's possible to describe them both in the same table and hence have a single compatible. While at it, fl

[Freedreno] [PATCH 3/7] drm/msm/dp: Add DP and EDP compatibles for SC8280XP

2022-08-09 Thread Bjorn Andersson
The SC8280XP platform has four DisplayPort controllers, per MDSS instance, all with widebus support. The first two are defined to be DisplayPort only, while the latter pair (of each instance) can be either DisplayPort or Embedded DisplayPort. The two sets are tied to the possible compatibels. Sig

[Freedreno] [PATCH 6/7] drm/msm/dp: Don't enable HPD interrupts for edp

2022-08-09 Thread Bjorn Andersson
Most instances where HPD interrupts are masked and unmasked are guareded by the presence of an EDP panel being connected, but not all. Extend this to cover the last few places, as HPD interrupt handling is not used for the EDP case. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_di

[Freedreno] [PATCH 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-08-09 Thread Bjorn Andersson
Add compatibles for the DisplayPort and Embedded DisplayPort blocks in Qualcomm SDM845 and SC8280XP platforms. Signed-off-by: Bjorn Andersson --- .../devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/binding

Re: [Freedreno] [PATCH] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-09 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-09 13:44:50) > dp_bridge_disable() is the first step toward tearing down main link. > Its major function is to start transmitting idle pattern to replace > video stream. This patch will check hpd_state to make sure main link > is enabled before commit changes of main l

Re: [Freedreno] [PATCH] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-09 Thread Abhinav Kumar
On 8/9/2022 1:44 PM, Kuogee Hsieh wrote: dp_bridge_disable() is the first step toward tearing down main link. Its major function is to start transmitting idle pattern to replace video stream. This patch will check hpd_state to make sure main link is enabled before commit changes of main link's

Re: [Freedreno] [RFC] drm/bridge: adv7533: remove dynamic lane switching from adv7533 bridge

2022-08-09 Thread Abhinav Kumar
Hi Laurent Thanks for the response. On 8/9/2022 12:40 PM, Laurent Pinchart wrote: Hi Abhinav, Thank you for the patch. On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote: adv7533 bridge tries to dynamically switch lanes based on the mode by detaching and attaching the mipi dsi dev

[Freedreno] [PATCH] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-09 Thread Kuogee Hsieh
dp_bridge_disable() is the first step toward tearing down main link. Its major function is to start transmitting idle pattern to replace video stream. This patch will check hpd_state to make sure main link is enabled before commit changes of main link's configuration to push idle pattern out to avo

Re: [Freedreno] [PATCH 0/5] clk/qcom: Support gdsc collapse polling using 'reset' inteface

2022-08-09 Thread Bjorn Andersson
On Sat 30 Jul 04:17 CDT 2022, Akhil P Oommen wrote: > > Some clients like adreno gpu driver would like to ensure that its gdsc > is collapsed at hardware during a gpu reset sequence. This is because it > has a votable gdsc which could be ON due to a vote from another subsystem > like tz, hyp etc

Re: [Freedreno] [RFC] drm/bridge: adv7533: remove dynamic lane switching from adv7533 bridge

2022-08-09 Thread Laurent Pinchart
Hi Abhinav, Thank you for the patch. On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote: > adv7533 bridge tries to dynamically switch lanes based on the > mode by detaching and attaching the mipi dsi device. > > This approach is incorrect because as per the DSI spec the > number of la