Re: [Freedreno] [PATCH 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-08-10 Thread Krzysztof Kozlowski
On 10/08/2022 22:20, Rob Herring wrote: > On Wed, Aug 10, 2022 at 05:47:52PM +0300, Krzysztof Kozlowski wrote: >> On 10/08/2022 06:50, Bjorn Andersson wrote: >>> Add compatibles for the DisplayPort and Embedded DisplayPort blocks in >>> Qualcomm SDM845 and SC8280XP platforms. >>> >>> Signed-off-by:

Re: [Freedreno] [PATCH 3/3] drm/msm/dpu: Introduce SC8280XP

2022-08-10 Thread Steev Klimaszewski
On Wed, Aug 10, 2022 at 11:28 PM Steev Klimaszewski wrote: > > Hi Bjorn, > > > On Wed, Aug 10, 2022 at 10:58 PM Bjorn Andersson > wrote: > > > > The Qualcomm SC8280XP platform contains DPU version 8.0.0, has 9 > > interfaces, 2 DSI controllers and 4 DisplayPort controllers. Extend the > > necessa

Re: [Freedreno] [PATCH 3/3] drm/msm/dpu: Introduce SC8280XP

2022-08-10 Thread Steev Klimaszewski
Hi Bjorn, On Wed, Aug 10, 2022 at 10:58 PM Bjorn Andersson wrote: > > The Qualcomm SC8280XP platform contains DPU version 8.0.0, has 9 > interfaces, 2 DSI controllers and 4 DisplayPort controllers. Extend the > necessary definitions and describe the DPU in the SC8280XP. > > Signed-off-by: Bjorn

[Freedreno] [PATCH 1/3] dt-bindings: display/msm: Add binding for SC8280XP MDSS

2022-08-10 Thread Bjorn Andersson
Add binding for the display subsystem and display processing unit in the Qualcomm SC8280XP platform. Signed-off-by: Bjorn Andersson --- .../bindings/display/msm/dpu-sc8280xp.yaml| 284 ++ 1 file changed, 284 insertions(+) create mode 100644 Documentation/devicetree/bindings

[Freedreno] [PATCH 2/3] drm/msm/dpu: add support for MDP_TOP blackhole

2022-08-10 Thread Bjorn Andersson
From: Dmitry Baryshkov On sm8450 a register block was removed from MDP TOP. Accessing it during snapshotting results in NoC errors / immediate reboot. Skip accessing these registers during snapshot. Signed-off-by: Dmitry Baryshkov Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/disp/dp

[Freedreno] [PATCH 3/3] drm/msm/dpu: Introduce SC8280XP

2022-08-10 Thread Bjorn Andersson
The Qualcomm SC8280XP platform contains DPU version 8.0.0, has 9 interfaces, 2 DSI controllers and 4 DisplayPort controllers. Extend the necessary definitions and describe the DPU in the SC8280XP. Signed-off-by: Bjorn Andersson --- Note that MSM_DP_CONTROLLER_3 is also defined in the DP series a

[Freedreno] [PATCH 0/3] drm/msm/dpu: Add support for SC8280XP

2022-08-10 Thread Bjorn Andersson
This adds support the MDSS and DPU found in the SC8280XP platform. Bjorn Andersson (2): dt-bindings: display/msm: Add binding for SC8280XP MDSS drm/msm/dpu: Introduce SC8280XP Dmitry Baryshkov (1): drm/msm/dpu: add support for MDP_TOP blackhole .../bindings/display/msm/dpu-sc8280xp.yaml

Re: [Freedreno] [PATCH v3] drm/msm: Make .remove and .shutdown HW shutdown consistent

2022-08-10 Thread Abhinav Kumar
Hi Javier Thank you for the patch. On 7/25/2022 12:43 AM, Javier Martinez Canillas wrote: Drivers' .remove and .shutdown callbacks are executed on different code paths. The former is called when a device is removed from the bus, while the latter is called at system shutdown time to quiesce the

Re: [Freedreno] [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Abhinav Kumar
Hi Stephen On 8/10/2022 5:09 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-10 16:57:51) On 8/10/2022 3:22 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-10 12:25:51) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index b36f8b6..678289a

Re: [Freedreno] [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-10 16:57:51) > > On 8/10/2022 3:22 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-08-10 12:25:51) > >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > >> b/drivers/gpu/drm/msm/dp/dp_display.c > >> index b36f8b6..678289a 100644 > >> --- a/drivers/gpu/drm/msm

Re: [Freedreno] [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Kuogee Hsieh
On 8/10/2022 3:22 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-08-10 12:25:51) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index b36f8b6..678289a 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -172

Re: [Freedreno] [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-08-10 12:25:51) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index b36f8b6..678289a 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1729,10 +1729,20 @@ void dp_bridge_dis

[Freedreno] [PATCH v3] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Kuogee Hsieh
dp_bridge_disable() is the first step toward tearing down main link. Its major function is to start transmitting idle pattern to replace video stream. This patch will check hpd_state to make sure main link is enabled before commit changes of main link's configuration to push idle pattern out to avo

Re: [Freedreno] [PATCH 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-08-10 Thread Rob Herring
On Wed, Aug 10, 2022 at 05:47:52PM +0300, Krzysztof Kozlowski wrote: > On 10/08/2022 06:50, Bjorn Andersson wrote: > > Add compatibles for the DisplayPort and Embedded DisplayPort blocks in > > Qualcomm SDM845 and SC8280XP platforms. > > > > Signed-off-by: Bjorn Andersson > > --- > > .../devicet

Re: [Freedreno] [PATCH v2] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Abhinav Kumar
On 8/10/2022 10:22 AM, Kuogee Hsieh wrote: dp_bridge_disable() is the first step toward tearing down main link. Its major function is to start transmitting idle pattern to replace video stream. This patch will check hpd_state to make sure main link is enabled before commit changes of main link

[Freedreno] [PATCH v2] drm/msm/dp: check hpd_state before push idle pattern at dp_bridge_disable()

2022-08-10 Thread Kuogee Hsieh
dp_bridge_disable() is the first step toward tearing down main link. Its major function is to start transmitting idle pattern to replace video stream. This patch will check hpd_state to make sure main link is enabled before commit changes of main link's configuration to push idle pattern out to avo

Re: [Freedreno] [PATCH 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-08-10 Thread Krzysztof Kozlowski
On 10/08/2022 06:50, Bjorn Andersson wrote: > Add compatibles for the DisplayPort and Embedded DisplayPort blocks in > Qualcomm SDM845 and SC8280XP platforms. > > Signed-off-by: Bjorn Andersson > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ > 1 file changed, 3 in

Re: [Freedreno] [PATCH 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-08-10 Thread Rob Herring
On Tue, 09 Aug 2022 20:50:07 -0700, Bjorn Andersson wrote: > Add compatibles for the DisplayPort and Embedded DisplayPort blocks in > Qualcomm SDM845 and SC8280XP platforms. > > Signed-off-by: Bjorn Andersson > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 3 +++ > 1 fil