[Freedreno] [RFC PATCH 1/3] drm/msm/dpu: add max external pixel clock for all targets

2022-08-29 Thread Abhinav Kumar
Add maximum external pixel clock for all targets based on the advertised limits for each of them. The pixel clock has been calculated from the timings mentioned in the CEA specification for CEA modes and according to the VESA CVT standard for the others. Signed-off-by: Abhinav Kumar ---

[Freedreno] [RFC PATCH 3/3] drm/msm: filter out modes for DP/eDP bridge having unsupported clock

2022-08-29 Thread Abhinav Kumar
Filter out DP/eDP modes having an unsupported pixel clock by replacing the current hard-coded limit with the per chipset advertised value. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 7 --- drivers/gpu/drm/msm/dp/dp_display.c | 16 +---

[Freedreno] [RFC PATCH 2/3] drm/msm: filter out modes for DSI bridge having unsupported clock

2022-08-29 Thread Abhinav Kumar
DSI interface used with a bridge chip connected to an external display is subject to the same pixel clock limits as one which is natively pluggable like DisplayPort. Hence filter out DSI modes having an unsupported pixel clock if its connected to a bridge which is pluggable. Ideally, this can be

[Freedreno] [RFC PATCH 0/3] Limit pluggable display modes

2022-08-29 Thread Abhinav Kumar
As reported on https://gitlab.freedesktop.org/drm/msm/-/issues/17, currently there is no mechanism to limit the display output to the pluggable displays and it lets users connect any monitor on any chipset based device. This can lead to undefined behavior because lets say the display advertises

Re: [Freedreno] [PATCH] arm64: dts: qcom: sc7280: Update gpu opp table

2022-08-29 Thread Bjorn Andersson
On Mon, 29 Aug 2022 01:10:55 +0530, Akhil P Oommen wrote: > On the lite sku where GPU Fmax is 550Mhz, voting for a slightly higher > bandwidth at the highest gpu opp helps to improve "Manhattan offscreen" > score by 10%. Update the gpu opp table such that this is applicable only > on SKUs which

Re: [Freedreno] [PATCH] arm64: dts: qcom: sm8250: move DSI opp table to the dsi0 node

2022-08-29 Thread Bjorn Andersson
On Mon, 22 Aug 2022 22:11:38 +0300, Dmitry Baryshkov wrote: > It makes no sense to have the OPP table for the DSI controllers in the > DSI1 PHY node. Move it to more logical dsi0 device node. > > Applied, thanks! [1/1] arm64: dts: qcom: sm8250: move DSI opp table to the dsi0 node commit:

Re: [Freedreno] [PATCH v5 0/6] clk/qcom: Support gdsc collapse polling using 'reset' interface

2022-08-29 Thread Stephen Boyd
+Philipp Quoting Akhil P Oommen (2022-08-28 12:21:13) > > Some clients like adreno gpu driver would like to ensure that its gdsc > is collapsed at hardware during a gpu reset sequence. This is because it > has a votable gdsc which could be ON due to a vote from another subsystem > like tz, hyp

Re: [Freedreno] [PATCH 3/5] dt-bindings: clock: drop minItems equal to maxItems

2022-08-29 Thread Rob Herring
On Thu, 25 Aug 2022 14:33:32 +0300, Krzysztof Kozlowski wrote: > minItems, if missing, are implicitly equal to maxItems, so drop > redundant piece to reduce size of code. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/clock/cirrus,cs2000-cp.yaml | 1 - >

Re: [Freedreno] [PATCH 5/5] dt-bindings: display: drop minItems equal to maxItems

2022-08-29 Thread Rob Herring
On Thu, 25 Aug 2022 14:33:34 +0300, Krzysztof Kozlowski wrote: > minItems, if missing, are implicitly equal to maxItems, so drop > redundant piece to reduce size of code. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml | 1 - >

Re: [Freedreno] [PATCH 4/5] dt-bindings: crypto: drop minItems equal to maxItems

2022-08-29 Thread Rob Herring
On Thu, 25 Aug 2022 14:33:33 +0300, Krzysztof Kozlowski wrote: > minItems, if missing, are implicitly equal to maxItems, so drop > redundant piece to reduce size of code. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 1 - > 1 file

Re: [Freedreno] [PATCH 2/5] dt-bindings: ata: drop minItems equal to maxItems

2022-08-29 Thread Rob Herring
On Thu, 25 Aug 2022 14:33:31 +0300, Krzysztof Kozlowski wrote: > minItems, if missing, are implicitly equal to maxItems, so drop > redundant piece to reduce size of code. > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml | 1 - >

Re: [Freedreno] [PATCH 1/5] dt-bindings: socionext, uniphier-system-cache: drop minItems equal to maxItems

2022-08-29 Thread Rob Herring
On Thu, 25 Aug 2022 14:33:30 +0300, Krzysztof Kozlowski wrote: > minItems, if missing, are implicitly equal to maxItems, so drop > redundant piece to reduce size of code. > > Signed-off-by: Krzysztof Kozlowski > --- > .../bindings/arm/socionext/socionext,uniphier-system-cache.yaml | 1 - > 1

Re: [Freedreno] [PATCH] dt-bindings: display: Add missing (unevaluated|additional)Properties on child nodes

2022-08-29 Thread Rob Herring
On Tue, 23 Aug 2022 09:56:42 -0500, Rob Herring wrote: > In order to ensure only documented properties are present, node schemas > must have unevaluatedProperties or additionalProperties set to false > (typically). > > Signed-off-by: Rob Herring > --- >

Re: [Freedreno] [RFC] drm/bridge: adv7533: remove dynamic lane switching from adv7533 bridge

2022-08-29 Thread Abhinav Kumar
Hi Laurent On 8/26/2022 4:55 AM, Laurent Pinchart wrote: Hello, On Fri, Aug 26, 2022 at 01:17:43PM +0300, Dmitry Baryshkov wrote: On 22/08/2022 19:31, Dmitry Baryshkov wrote: On 09/08/2022 22:40, Laurent Pinchart wrote: On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote: adv7533

[Freedreno] [PATCH] drm/bridge: adv7533: remove dynamic lane switching from adv7533 bridge

2022-08-29 Thread Abhinav Kumar
adv7533 bridge tries to dynamically switch lanes based on the mode by detaching and attaching the mipi dsi device. This approach is incorrect because this method of dynamic switch of detaching and attaching the mipi dsi device also results in removing and adding the component which is not

[Freedreno] [PATCH] drm/msm/dsi: Remove use of device_node in dsi_host_parse_dt()

2022-08-29 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/msm/dsi/dsi_host.c:1903:14: error: variable 'device_node' is uninitialized when used here [-Werror,-Wuninitialized] of_node_put(device_node); ^~~ drivers/gpu/drm/msm/dsi/dsi_host.c:1870:44: note: initialize the variable