Re: [Freedreno] [PATCH v1 3/4] drm/msm/mdp4: move resource allocation to the _probe function

2022-09-01 Thread Dmitry Baryshkov
On 2 September 2022 03:24:17 GMT+03:00, Abhinav Kumar wrote: > > >On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: >> To let the probe function bail early if any of the resources is >> unavailable, move resource allocattion from kms_init directly to the >> probe callback. While we are at it, repl

Re: [Freedreno] [PATCH v1 2/4] drm/msm/dpu: move resource allocation to the _probe function

2022-09-01 Thread Dmitry Baryshkov
On 2 September 2022 00:37:30 GMT+03:00, Abhinav Kumar wrote: > > >On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: >> To let the probe function bail early if any of the resources is >> unavailable, move resource allocattion from kms_init directly to the > allocation Ack >> probe callback. While

Re: [Freedreno] [PATCH v1 4/4] drm/msm/mdp5: move resource allocation to the _probe function

2022-09-01 Thread Abhinav Kumar
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: To let the probe function bail early if any of the resources is unavailable, move resource allocattion from kms_init directly to the probe callback. Seems to be the common typo in all the patches of this series allocattion -> allocation Apart f

Re: [Freedreno] [PATCH v1 3/4] drm/msm/mdp4: move resource allocation to the _probe function

2022-09-01 Thread Abhinav Kumar
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: To let the probe function bail early if any of the resources is unavailable, move resource allocattion from kms_init directly to the probe callback. While we are at it, replace irq_of_parse_and_map() with platform_get_irq(). Signed-off-by: Dmitry

Re: [Freedreno] [PATCH v1 2/4] drm/msm/dpu: move resource allocation to the _probe function

2022-09-01 Thread Abhinav Kumar
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote: To let the probe function bail early if any of the resources is unavailable, move resource allocattion from kms_init directly to the allocation probe callback. While we are at it, replace irq_of_parse_and_map() with platform_get_irq(). Any spec

[Freedreno] [PATCH 2/2] drm/msm/dpu: Add support for P010 format

2022-09-01 Thread Jessica Zhang
Add support for P010 color format. This adds support for both linear and compressed formats. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c| 17 - drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

[Freedreno] [PATCH 1/2] drm/msm/dpu: Add support for XR30 format

2022-09-01 Thread Jessica Zhang
Add support for XR30 color format. This supports both linear and compressed formats. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c| 7 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 1 + 3 files c

[Freedreno] [PATCH 0/2] Add support for HDR color formats

2022-09-01 Thread Jessica Zhang
Add support for HDR color formats. XR30 linear/compressed format has been validated with null_platform_test on SC7180, and P010 linear has been validated with plane_test (also on SC7180). Jessica Zhang (2): drm/msm/dpu: Add support for XR30 format drm/msm/dpu: Add support for P010 format dr

Re: [Freedreno] [PATCH v6 3/6] clk: qcom: gdsc: Add a reset op to poll gdsc collapse

2022-09-01 Thread Akhil P Oommen
On 9/1/2022 3:58 PM, Philipp Zabel wrote: On Wed, Aug 31, 2022 at 10:48:24AM +0530, Akhil P Oommen wrote: Add a reset op compatible function to poll for gdsc collapse. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov --- (no changes since v2) Changes in v2: - Minor update to func

Re: [Freedreno] [PATCH v6 2/6] clk: qcom: Allow custom reset ops

2022-09-01 Thread Akhil P Oommen
On 9/1/2022 3:47 PM, Philipp Zabel wrote: Hi Akhil, On Wed, Aug 31, 2022 at 10:48:23AM +0530, Akhil P Oommen wrote: Allow soc specific clk drivers to specify a custom reset operation. We will use this in an upcoming patch to allow gpucc driver to specify a differet reset operation for cx_gdsc.

Re: [Freedreno] [PATCH v6 4/6] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-09-01 Thread Akhil P Oommen
On 9/1/2022 4:16 PM, Dmitry Baryshkov wrote: On 01/09/2022 13:34, Philipp Zabel wrote: On Wed, Aug 31, 2022 at 10:48:25AM +0530, Akhil P Oommen wrote: Allow a consumer driver to poll for cx gdsc collapse through Reset framework. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov ---

Re: [Freedreno] [PATCH v6 4/6] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-09-01 Thread Dmitry Baryshkov
On 01/09/2022 13:34, Philipp Zabel wrote: On Wed, Aug 31, 2022 at 10:48:25AM +0530, Akhil P Oommen wrote: Allow a consumer driver to poll for cx gdsc collapse through Reset framework. Signed-off-by: Akhil P Oommen Reviewed-by: Dmitry Baryshkov --- (no changes since v3) Changes in v3: - Conv

Re: [Freedreno] [PATCH v6 4/6] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-09-01 Thread Philipp Zabel
On Wed, Aug 31, 2022 at 10:48:25AM +0530, Akhil P Oommen wrote: > Allow a consumer driver to poll for cx gdsc collapse through Reset > framework. > > Signed-off-by: Akhil P Oommen > Reviewed-by: Dmitry Baryshkov > --- > > (no changes since v3) > > Changes in v3: > - Convert 'struct qcom_reset_

Re: [Freedreno] [PATCH v6 3/6] clk: qcom: gdsc: Add a reset op to poll gdsc collapse

2022-09-01 Thread Philipp Zabel
On Wed, Aug 31, 2022 at 10:48:24AM +0530, Akhil P Oommen wrote: > Add a reset op compatible function to poll for gdsc collapse. > > Signed-off-by: Akhil P Oommen > Reviewed-by: Dmitry Baryshkov > --- > > (no changes since v2) > > Changes in v2: > - Minor update to function prototype > > driv

[Freedreno] [PATCH v6 10/12] dt-bindings: display/msm: split dpu-qcm2290 into DPU and MDSS parts

2022-09-01 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-qcm2290 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-qcm2290.yaml | 166 ++ .../bindings/display/msm/mdss-qcm2290.yaml|

[Freedreno] [PATCH v6 12/12] dt-bindings: display/msm: add support for the display on SM8250

2022-09-01 Thread Dmitry Baryshkov
Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm SM8250 platform. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sm8250.yaml | 96 .../bindings/display/msm/mdss-common.yaml | 4 +- .../bindings/display/msm/mdss-sm8250.yaml

[Freedreno] [PATCH v6 09/12] dt-bindings: display/msm: split dpu-msm8998 into DPU and MDSS parts

2022-09-01 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-msm8998 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-msm8998.yaml | 161 ++ .../bindings/display/msm/mdss-msm8998.yaml|

[Freedreno] [PATCH v6 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas

2022-09-01 Thread Dmitry Baryshkov
Add missing device nodes (DSI, PHYs, DP/eDP) to the existing MDSS schemas. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/mdss-msm8998.yaml| 12 + .../bindings/display/msm/mdss-qcm2290.yaml| 6 + .../bindings/display/msm/mdss-sc7180.yaml | 18 +

[Freedreno] [PATCH v6 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-01 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-sc7180 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sc7180.yaml | 185 ++ .../bindings/display/msm/mdss-sc7180.yaml |

[Freedreno] [PATCH v6 03/12] dt-bindings: display/msm: add interconnects property to qcom, mdss-smd845

2022-09-01 Thread Dmitry Baryshkov
Add interconnects required for the SDM845 MDSS device tree node. This change was made in the commit c8c61c09e38b ("arm64: dts: qcom: sdm845: Add interconnects property for display"), but was not reflected in the schema. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/display/msm/dpu-

[Freedreno] [PATCH v6 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-01 Thread Dmitry Baryshkov
Move properties common to all DPU DT nodes to the dpu-common.yaml. Note, this removes description of individual DPU port@ nodes. However such definitions add no additional value. The reg values do not correspond to hardware INTF indices. The driver discovers and binds these ports not paying any ca

[Freedreno] [PATCH v6 08/12] dt-bindings: display/msm: split dpu-sdm845 into DPU and MDSS parts

2022-09-01 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-sdm845 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sdm845.yaml | 170 ++ .../bindings/display/msm/mdss-sdm845.yaml |

[Freedreno] [PATCH v6 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-01 Thread Dmitry Baryshkov
Move properties common to all MDSS DT nodes to the mdss-common.yaml. This extends qcom,msm8998-mdss schema to allow interconnect nodes, which will be added later, once msm8998 gains interconnect support. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-msm8998.yaml | 42 ++--

[Freedreno] [PATCH v6 07/12] dt-bindings: display/msm: split dpu-sc7280 into DPU and MDSS parts

2022-09-01 Thread Dmitry Baryshkov
In order to make the schema more readable, split dpu-sc7280 into the DPU and MDSS parts, each one describing just a single device binding. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/dpu-sc7280.yaml | 194 ++ .../bindings/display/msm/mdss-sc7280.yaml |

[Freedreno] [PATCH v6 02/12] dt-bindings: display/msm: add gcc-bus clock to dpu-smd845

2022-09-01 Thread Dmitry Baryshkov
Add gcc-bus clock required for the SDM845 DPU device tree node. This change was made in the commit 111c52854102 ("arm64: dts: qcom: sdm845: move bus clock to mdp node for sdm845 target"), but was not reflected in the schema. Reviewed-by: Rob Herring Signed-off-by: Dmitry Baryshkov --- .../devic

[Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-01 Thread Dmitry Baryshkov
Split Mobile Display SubSystem (MDSS) root node bindings to the separate yaml file. Changes to the existing (txt) schema: - Added optional "vbif_nrt_phys" region used by msm8996 - Made "bus" and "vsync" clocks optional (they are not used by some platforms) - Added (optional) "core" clock adde

[Freedreno] [PATCH v6 00/12] dt-bindings: display/msm: rework MDSS and DPU bindings

2022-09-01 Thread Dmitry Baryshkov
Create separate YAML schema for MDSS devicesd$ (both for MDP5 and DPU devices). Cleanup DPU schema files, so that they do not contain schema for both MDSS and DPU nodes. Apply misc small fixes to the DPU schema afterwards. Add schema for the MDSS and DPU on sm8250 platform. Changes since v5: - Dr

Re: [Freedreno] [PATCH v6 2/6] clk: qcom: Allow custom reset ops

2022-09-01 Thread Philipp Zabel
Hi Akhil, On Wed, Aug 31, 2022 at 10:48:23AM +0530, Akhil P Oommen wrote: > Allow soc specific clk drivers to specify a custom reset operation. We > will use this in an upcoming patch to allow gpucc driver to specify a > differet reset operation for cx_gdsc. > > Signed-off-by: Akhil P Oommen > R

Re: [Freedreno] [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-01 Thread Johan Hovold
On Thu, Sep 01, 2022 at 12:21:36PM +0300, Dmitry Baryshkov wrote: > On 01/09/2022 12:20, Johan Hovold wrote: > > On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > >> Johan Hovold has reported that returning a probe deferral from the > >> msm_dp_modeset_init() can cause issues beca

Re: [Freedreno] [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-01 Thread Dmitry Baryshkov
On 01/09/2022 12:20, Johan Hovold wrote: On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: Johan Hovold has reported that returning a probe deferral from the msm_dp_modeset_init() can cause issues because the IRQ is not freed properly. This (compile-tested only) series tries to f

Re: [Freedreno] [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-01 Thread Johan Hovold
On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > Johan Hovold has reported that returning a probe deferral from the > msm_dp_modeset_init() can cause issues because the IRQ is not freed > properly. This (compile-tested only) series tries to fix the issue by > moving devm_request_

[Freedreno] [RFC PATCH 3/3] drm/msm/dp: move dp_request_irq() call to dp_display_probe()

2022-09-01 Thread Dmitry Baryshkov
As the MDSS registers the IRQ domain before populating child devices, there is little point in deferring the IRQ request up to the msm_dp_modeset_init(). Following the 'get resources as early as possible' paradigm, move dp_request_irq() call to dp_display_probe(). Signed-off-by: Dmitry Baryshkov

[Freedreno] [RFC PATCH 1/3] drm/msm/dp: fold disable_irq into devm_request_irq

2022-09-01 Thread Dmitry Baryshkov
Calling disable_irq() right after devm_request_irq() is a bad practice. it leaves a small window when the driver doesn't expect the IRQ, but the hardware still can trigger it. Use the IRQF_NO_AUTOEN flag to prevent the request_irq from enabling the IRQ line. Signed-off-by: Dmitry Baryshkov --- d

[Freedreno] [RFC PATCH 2/3] drm/msm/dp: switch to using platform_get_irq()

2022-09-01 Thread Dmitry Baryshkov
There is little point in using irq_of_parse_and_map(). Switch to plain and usual platform_get_irq() for parsing the DP IRQ line. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/

[Freedreno] [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-01 Thread Dmitry Baryshkov
Johan Hovold has reported that returning a probe deferral from the msm_dp_modeset_init() can cause issues because the IRQ is not freed properly. This (compile-tested only) series tries to fix the issue by moving devm_request_irq() to the probe callback. Dmitry Baryshkov (3): drm/msm/dp: fold dis

Re: [Freedreno] [PATCH] drm/msm/dsi: Set panel orientation when directly connected

2022-09-01 Thread Dmitry Baryshkov
On 06/07/2022 22:14, Stephen Boyd wrote: Set the panel orientation in drm when the panel is directly connected, i.e. we're not using an external bridge. The external bridge case is already handled by the panel bridge code, so we only update the path we take when the panel is directly connected/in