Re: [Freedreno] [PATCH v2 1/3] dma-buf: Add ioctl to query mmap coherency/cache info

2022-09-07 Thread Rob Clark
On Wed, Sep 7, 2022 at 9:55 AM Daniel Vetter wrote: > > On Thu, Aug 18, 2022 at 08:01:53AM -0700, Rob Clark wrote: > > On Thu, Aug 18, 2022 at 7:54 AM Christian König > > wrote: > > > > > > Am 18.08.22 um 16:25 schrieb Rob Clark: > > > > On Thu, Aug 18, 2022 at 4:21 AM Christian König > > > >

Re: [Freedreno] [RFC PATCH 3/3] drm/msm: filter out modes for DP/eDP bridge having unsupported clock

2022-09-07 Thread Stephen Boyd
Quoting Abhinav Kumar (2022-08-29 20:33:09) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index bfd0aeff3f0d..8b91d8adf921 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -117,6 +117,7 @@ struct

Re: [Freedreno] [RFC PATCH 2/3] drm/msm: filter out modes for DSI bridge having unsupported clock

2022-09-07 Thread Stephen Boyd
Quoting Abhinav Kumar (2022-08-29 20:33:08) > diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c > index 39bbabb5daf6..3a06a157d1b1 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi.c > +++ b/drivers/gpu/drm/msm/dsi/dsi.c > @@ -265,6 +265,11 @@ int msm_dsi_modeset_init(struct

Re: [Freedreno] [RFC PATCH 3/3] drm/msm/dp: move dp_request_irq() call to dp_display_probe()

2022-09-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-09-01 02:15:27) > As the MDSS registers the IRQ domain before populating child devices, > there is little point in deferring the IRQ request up to the > msm_dp_modeset_init(). Following the 'get resources as early as > possible' paradigm, move dp_request_irq() call

Re: [Freedreno] [RFC PATCH 2/3] drm/msm/dp: switch to using platform_get_irq()

2022-09-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-09-01 02:15:26) > There is little point in using irq_of_parse_and_map(). Switch to plain > and usual platform_get_irq() for parsing the DP IRQ line. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_display.c | 4 ++-- > 1 file changed, 2

Re: [Freedreno] [RFC PATCH 1/3] drm/msm/dp: fold disable_irq into devm_request_irq

2022-09-07 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-09-01 02:15:25) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index bfd0aeff3f0d..3173e6962a78 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1251,13 +1251,12 @@ int

Re: [Freedreno] [PATCH v2] drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training

2022-09-07 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-09-07 12:50:37) > DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an > upstream device disconnect. This patch will enforce this rule by always > cleared DOWNPREAD_CTRL register to 0 before start link training. At rare DOWNSPREAD_CTRL > case that DP

Re: [Freedreno] [PATCH v6 1/4] drm/msm: clean event_thread->worker in case of an error

2022-09-07 Thread Abhinav Kumar
On 6/17/2022 4:33 PM, Dmitry Baryshkov wrote: If worker creation fails, nullify the event_thread->worker, so that msm_drm_uninit() doesn't try accessing invalid memory location. While we are at it, remove duplicate assignment to the ret variable. Fixes: 1041dee2178f ("drm/msm: use

Re: [Freedreno] [PATCH v6 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-07 Thread Dmitry Baryshkov
On Wed, 7 Sept 2022 at 22:59, Rob Herring wrote: > > On Thu, Sep 01, 2022 at 01:23:04PM +0300, Dmitry Baryshkov wrote: > > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > > > Note, this removes description of individual DPU port@ nodes. However > > such definitions add no

Re: [Freedreno] [PATCH v6 12/12] dt-bindings: display/msm: add support for the display on SM8250

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:12PM +0300, Dmitry Baryshkov wrote: > Add DPU and MDSS schemas to describe MDSS and DPU blocks on the Qualcomm > SM8250 platform. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/dpu-sm8250.yaml | 96 >

Re: [Freedreno] [PATCH v6 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas

2022-09-07 Thread Rob Herring
On Thu, 01 Sep 2022 13:23:11 +0300, Dmitry Baryshkov wrote: > Add missing device nodes (DSI, PHYs, DP/eDP) to the existing MDSS > schemas. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/mdss-msm8998.yaml| 12 + > .../bindings/display/msm/mdss-qcm2290.yaml|

Re: [Freedreno] [PATCH v6 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:06PM +0300, Dmitry Baryshkov wrote: > In order to make the schema more readable, split dpu-sc7180 into the DPU > and MDSS parts, each one describing just a single device binding. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/display/msm/dpu-sc7180.yaml

Re: [Freedreno] [PATCH v6 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:05PM +0300, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. > > Signed-off-by:

Re: [Freedreno] [PATCH v6 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:04PM +0300, Dmitry Baryshkov wrote: > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > Note, this removes description of individual DPU port@ nodes. However > such definitions add no additional value. The reg values do not > correspond to

Re: [Freedreno] [PATCH v6 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:04PM +0300, Dmitry Baryshkov wrote: > Move properties common to all DPU DT nodes to the dpu-common.yaml. > > Note, this removes description of individual DPU port@ nodes. However > such definitions add no additional value. The reg values do not > correspond to

[Freedreno] [PATCH v2] drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training

2022-09-07 Thread Kuogee Hsieh
DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an upstream device disconnect. This patch will enforce this rule by always cleared DOWNPREAD_CTRL register to 0 before start link training. At rare case that DP MSA timing parameters may be mis-interpreted by the sink which

Re: [Freedreno] [PATCH v2 4/5] drm/msm/hdmi: don't take extra reference on PHY device

2022-09-07 Thread Abhinav Kumar
On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote: The of_find_device_by_node() already increments the device's usage count, so there is no need to increment it again using get_device(). Drop this extra get_device(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar ---

Re: [Freedreno] [PATCH v6 03/12] dt-bindings: display/msm: add interconnects property to qcom, mdss-smd845

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:03PM +0300, Dmitry Baryshkov wrote: > Add interconnects required for the SDM845 MDSS device tree node. This > change was made in the commit c8c61c09e38b ("arm64: dts: qcom: sdm845: > Add interconnects property for display"), but was not reflected in the > schema. > >

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-07 Thread Rob Herring
On Thu, Sep 01, 2022 at 01:23:01PM +0300, Dmitry Baryshkov wrote: > Split Mobile Display SubSystem (MDSS) root node bindings to the separate > yaml file. Changes to the existing (txt) schema: > - Added optional "vbif_nrt_phys" region used by msm8996 > - Made "bus" and "vsync" clocks optional

Re: [Freedreno] [PATCH v2 3/5] drm/msm/hdmi: move resource allocation to probe function

2022-09-07 Thread Abhinav Kumar
On 9/7/2022 12:09 PM, Abhinav Kumar wrote: On 9/7/2022 11:54 AM, Abhinav Kumar wrote: On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote: Rather than having all resource allocation happen in the _bind function (resulting in possible EPROBE_DEFER returns and component bind/unbind cycles)

Re: [Freedreno] [PATCH v2 3/5] drm/msm/hdmi: move resource allocation to probe function

2022-09-07 Thread Abhinav Kumar
On 9/7/2022 11:54 AM, Abhinav Kumar wrote: On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote: Rather than having all resource allocation happen in the _bind function (resulting in possible EPROBE_DEFER returns and component bind/unbind cycles) allocate and check all resources in _probe

Re: [Freedreno] [PATCH v2 5/5] drm/msm/hdmi: move msm_hdmi_get_phy() to msm_hdmi_dev_probe()

2022-09-07 Thread Abhinav Kumar
On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote: To continue the idea of failing the probe() rather than failing the bind(), move the call to msm_hdmi_get_phy() function to msm_hdmi_dev_probe(), so that the driver fails the probe if PHY is not yet available rather than succeeding the probe and

Re: [Freedreno] [PATCH v2 3/5] drm/msm/hdmi: move resource allocation to probe function

2022-09-07 Thread Abhinav Kumar
On 8/26/2022 2:39 AM, Dmitry Baryshkov wrote: Rather than having all resource allocation happen in the _bind function (resulting in possible EPROBE_DEFER returns and component bind/unbind cycles) allocate and check all resources in _probe function. While we are at it, use platform_get_irq()

Re: [Freedreno] [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-07 Thread Manivannan Sadhasivam
On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > Johan Hovold has reported that returning a probe deferral from the > msm_dp_modeset_init() can cause issues because the IRQ is not freed > properly. This (compile-tested only) series tries to fix the issue by > moving

Re: [Freedreno] [PATCH] drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training

2022-09-07 Thread Abhinav Kumar
On 9/7/2022 10:21 AM, Kuogee Hsieh wrote: DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an upstream device disconnect. This patch will enforce this rule by always cleared DOWNPREAD_CTRL register to 0 before start link training. At rare case that DP MSA timing parameters

[Freedreno] [PATCH] drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training

2022-09-07 Thread Kuogee Hsieh
DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an upstream device disconnect. This patch will enforce this rule by always cleared DOWNPREAD_CTRL register to 0 before start link training. At rare case that DP MSA timing parameters may be mis-interpreted by the sinker which

Re: [Freedreno] [PATCH v2 1/3] dma-buf: Add ioctl to query mmap coherency/cache info

2022-09-07 Thread Daniel Vetter
On Thu, Aug 18, 2022 at 08:01:53AM -0700, Rob Clark wrote: > On Thu, Aug 18, 2022 at 7:54 AM Christian König > wrote: > > > > Am 18.08.22 um 16:25 schrieb Rob Clark: > > > On Thu, Aug 18, 2022 at 4:21 AM Christian König > > > wrote: > > >> Am 17.08.22 um 15:44 schrieb Rob Clark: > > >>> On Wed,

Re: [Freedreno] [PATCH v2 1/3] dma-buf: Add ioctl to query mmap coherency/cache info

2022-09-07 Thread Daniel Vetter
On Tue, Aug 16, 2022 at 06:50:54PM +0200, Christian König wrote: > Am 16.08.22 um 16:26 schrieb Rob Clark: > > On Tue, Aug 16, 2022 at 1:27 AM Christian König > > wrote: > > > Am 15.08.22 um 23:15 schrieb Rob Clark: > > > > From: Rob Clark > > > > > > > > This is a fairly narrowly focused

[Freedreno] [v1] arm64: dts: qcom: sc7280: assign DSI clock source parents

2022-09-07 Thread Rajeev Nandan
Assign DSI clock source parents to DSI PHY clocks. Signed-off-by: Rajeev Nandan Cc: Dmitry Baryshkov --- This change is needed after the refactor done by the patch [2] (drm/msm/dsi: stop setting clock parents manually) of series [1], to fix the DSI pixel clock set rate error:

Re: [Freedreno] [Linaro-mm-sig] [PATCH v2 1/3] dma-buf: Add ioctl to query mmap info

2022-09-07 Thread Rob Clark
On Tue, Sep 6, 2022 at 12:46 PM Daniel Vetter wrote: > > On Mon, Aug 01, 2022 at 10:04:55AM -0700, Rob Clark wrote: > > From: Rob Clark > > > > This is a fairly narrowly focused interface, providing a way for a VMM > > in userspace to tell the guest kernel what pgprot settings to use when > >