Re: [Freedreno] [PATCH v4 2/2] drm/msm/dp: retry 3 times if set sink to D0 poweer state failed

2022-09-08 Thread Dmitry Baryshkov
On Fri, 9 Sept 2022 at 00:18, Kuogee Hsieh wrote: > > Bring sink out of D3 (power down) mode into D0 (normal operation) mode > by setting DP_SET_POWER_D0 bit to DP_SET_POWER dpcd register. This > patch will retry 3 times if written to DP_SET_POWER register failed. > > Changes in v4: > -- split

[Freedreno] [PATCH v4 2/2] drm/msm/dp: retry 3 times if set sink to D0 poweer state failed

2022-09-08 Thread Kuogee Hsieh
Bring sink out of D3 (power down) mode into D0 (normal operation) mode by setting DP_SET_POWER_D0 bit to DP_SET_POWER dpcd register. This patch will retry 3 times if written to DP_SET_POWER register failed. Changes in v4: -- split into two patches Signed-off-by: Kuogee Hsieh ---

[Freedreno] [PATCH v4 1/2] drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training

2022-09-08 Thread Kuogee Hsieh
DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an upstream device disconnect. This patch will enforce this rule by always cleared DOWNSPREAD_CTRL register to 0 before start link training. At rare case that DP MSA timing parameters may be mis-interpreted by the sink which

[Freedreno] [PATCH v4 0/2] cleared DP_DOWNSPREAD_CTRL register

2022-09-08 Thread Kuogee Hsieh
cleared DP_DOWNSPREAD_CTRL register before start link training Kuogee Hsieh (2): drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training drm/msm/dp: retry 3 times if set sink to D0 poweer state failed drivers/gpu/drm/msm/dp/dp_ctrl.c | 13 +

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-08 Thread Dmitry Baryshkov
On 08/09/2022 22:37, Rob Herring wrote: On Thu, Sep 08, 2022 at 03:37:38PM +0200, Krzysztof Kozlowski wrote: On 01/09/2022 12:23, Dmitry Baryshkov wrote: Split Mobile Display SubSystem (MDSS) root node bindings to the separate yaml file. Changes to the existing (txt) schema: - Added optional

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-08 Thread Rob Herring
On Thu, Sep 08, 2022 at 03:37:38PM +0200, Krzysztof Kozlowski wrote: > On 01/09/2022 12:23, Dmitry Baryshkov wrote: > > Split Mobile Display SubSystem (MDSS) root node bindings to the separate > > yaml file. Changes to the existing (txt) schema: > > - Added optional "vbif_nrt_phys" region used by

Re: [Freedreno] [RFC PATCH 2/3] drm/msm: filter out modes for DSI bridge having unsupported clock

2022-09-08 Thread Abhinav Kumar
Hi Dmitry On 9/8/2022 7:46 AM, Dmitry Baryshkov wrote: On 30/08/2022 06:33, Abhinav Kumar wrote: DSI interface used with a bridge chip connected to an external display is subject to the same pixel clock limits as one which is natively pluggable like DisplayPort. Hence filter out DSI modes

Re: [Freedreno] [RFC PATCH 3/3] drm/msm: filter out modes for DP/eDP bridge having unsupported clock

2022-09-08 Thread Abhinav Kumar
On 9/7/2022 6:12 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2022-08-29 20:33:09) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index bfd0aeff3f0d..8b91d8adf921 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++

Re: [Freedreno] [RFC PATCH 2/3] drm/msm: filter out modes for DSI bridge having unsupported clock

2022-09-08 Thread Abhinav Kumar
Hi Stephen On 9/7/2022 6:06 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2022-08-29 20:33:08) diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c index 39bbabb5daf6..3a06a157d1b1 100644 --- a/drivers/gpu/drm/msm/dsi/dsi.c +++ b/drivers/gpu/drm/msm/dsi/dsi.c @@ -265,6

Re: [Freedreno] [RFC PATCH 0/3] Limit pluggable display modes

2022-09-08 Thread Dmitry Baryshkov
On 30/08/2022 06:33, Abhinav Kumar wrote: As reported on https://gitlab.freedesktop.org/drm/msm/-/issues/17, currently there is no mechanism to limit the display output to the pluggable displays and it lets users connect any monitor on any chipset based device. This can lead to undefined

Re: [Freedreno] [PATCH v3] drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training

2022-09-08 Thread Dmitry Baryshkov
On Thu, 8 Sept 2022 at 18:38, Kuogee Hsieh wrote: > > DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an > upstream device disconnect. This patch will enforce this rule by always > cleared DOWNSPREAD_CTRL register to 0 before start link training. At rare > case that DP MSA

[Freedreno] [PATCH v3] drm/msm/dp: cleared DP_DOWNSPREAD_CTRL register before start link training

2022-09-08 Thread Kuogee Hsieh
DOWNSPREAD_CTRL (0x107) shall be cleared to 0 upon power-on reset or an upstream device disconnect. This patch will enforce this rule by always cleared DOWNSPREAD_CTRL register to 0 before start link training. At rare case that DP MSA timing parameters may be mis-interpreted by the sink which

Re: [Freedreno] [PATCH v6 1/4] drm/msm: clean event_thread->worker in case of an error

2022-09-08 Thread Dmitry Baryshkov
On 08/09/2022 03:08, Abhinav Kumar wrote: On 6/17/2022 4:33 PM, Dmitry Baryshkov wrote: If worker creation fails, nullify the event_thread->worker, so that msm_drm_uninit() doesn't try accessing invalid memory location. While we are at it, remove duplicate assignment to the ret variable.

Re: [Freedreno] [RFC PATCH 2/3] drm/msm: filter out modes for DSI bridge having unsupported clock

2022-09-08 Thread Dmitry Baryshkov
On 30/08/2022 06:33, Abhinav Kumar wrote: DSI interface used with a bridge chip connected to an external display is subject to the same pixel clock limits as one which is natively pluggable like DisplayPort. Hence filter out DSI modes having an unsupported pixel clock if its connected to a

Re: [Freedreno] [v4] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-09-08 Thread Dmitry Baryshkov
On 08/09/2022 10:26, Kalyan Thota wrote: Flush mechanism for DSPP blocks has changed in sc7280 family, it allows individual sub blocks to be flushed in coordination with master flush control. Representation: master_flush && (PCC_flush | IGC_flush .. etc ) This change adds necessary support for

Re: [Freedreno] [PATCH v6 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-08 Thread Krzysztof Kozlowski
On 08/09/2022 15:44, Krzysztof Kozlowski wrote: >> + interconnects: >> +maxItems: 1 >> + >> + interconnect-names: >> +maxItems: 1 >> + >> +patternProperties: >> + "^display-controller@[0-9a-f]+$": >> +type: object >> +properties: >> + compatible: >> +const:

Re: [Freedreno] [PATCH v6 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts

2022-09-08 Thread Krzysztof Kozlowski
On 01/09/2022 12:23, Dmitry Baryshkov wrote: > In order to make the schema more readable, split dpu-sc7180 into the DPU > and MDSS parts, each one describing just a single device binding. > > Signed-off-by: Dmitry Baryshkov Thank you for your patch. There is something to discuss/improve. > -

Re: [Freedreno] [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-08 Thread Krzysztof Kozlowski
On 01/09/2022 12:23, Dmitry Baryshkov wrote: > Split Mobile Display SubSystem (MDSS) root node bindings to the separate > yaml file. Changes to the existing (txt) schema: > - Added optional "vbif_nrt_phys" region used by msm8996 > - Made "bus" and "vsync" clocks optional (they are not used by

[Freedreno] [v4] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-09-08 Thread Kalyan Thota
Flush mechanism for DSPP blocks has changed in sc7280 family, it allows individual sub blocks to be flushed in coordination with master flush control. Representation: master_flush && (PCC_flush | IGC_flush .. etc ) This change adds necessary support for the above design. Changes in v1: - Few

[Freedreno] [v3] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-09-08 Thread Kalyan Thota
Flush mechanism for DSPP blocks has changed in sc7280 family, it allows individual sub blocks to be flushed in coordination with master flush control. Representation: master_flush && (PCC_flush | IGC_flush .. etc ) This change adds necessary support for the above design. Changes in v1: - Few