Re: [Freedreno] [PATCH v2 05/27] drm/msm/dpu: drop EAGAIN check from dpu_format_populate_layout

2023-01-27 Thread Abhinav Kumar
On 1/26/2023 10:05 PM, Dmitry Baryshkov wrote: On Fri, 27 Jan 2023 at 02:52, Abhinav Kumar wrote: On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: The pipe's layout is not cached, corresponding data structure is zeroed out each time in the dpu_plane_sspp_atomic_update(), right before the

Re: [Freedreno] [PATCH v2 03/27] drm/msm/dpu: move SSPP allocation to the RM

2023-01-27 Thread Abhinav Kumar
On 1/26/2023 9:56 PM, Dmitry Baryshkov wrote: On Fri, 27 Jan 2023 at 01:29, Abhinav Kumar wrote: On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: Follow the example of all other hw blocks and initialize SSPP blocks in Resource Manager. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/

Re: [Freedreno] [RFT PATCH 2/2] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset

2023-01-27 Thread Abhinav Kumar
On 1/27/2023 2:33 PM, Doug Anderson wrote: Hi, On Fri, Jan 27, 2023 at 10:54 AM Abhinav Kumar wrote: On 1/13/2023 3:56 PM, Douglas Anderson wrote: In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time"), we moved powering up DSI hosts to modeset time. This wasn't bec

Re: [Freedreno] [RFT PATCH 2/2] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset

2023-01-27 Thread Doug Anderson
Hi, On Fri, Jan 27, 2023 at 10:54 AM Abhinav Kumar wrote: > > On 1/13/2023 3:56 PM, Douglas Anderson wrote: > > In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > > time"), we moved powering up DSI hosts to modeset time. This wasn't > > because it was an elegant design, but

Re: [Freedreno] [RFT PATCH 2/2] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset

2023-01-27 Thread Abhinav Kumar
On 1/13/2023 3:56 PM, Douglas Anderson wrote: In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time"), we moved powering up DSI hosts to modeset time. This wasn't because it was an elegant design, but there were no better options. That commit actually ended up breaking p

Re: [Freedreno] [PATCH v3 01/10] drm/client: Test for connectors before sending hotplug event

2023-01-27 Thread Simon Ser
On Wednesday, January 25th, 2023 at 21:04, Thomas Zimmermann wrote: > Not having connectors indicates a driver bug. Is it? What if all connectors are of the DP-MST type, ie. they are created on-the-fly?

Re: [Freedreno] [PATCH v3 04/10] drm/fbdev-generic: Initialize fb-helper structure in generic setup

2023-01-27 Thread Sam Ravnborg
On Fri, Jan 27, 2023 at 03:21:30PM +0100, Thomas Zimmermann wrote: > Hi > > Am 25.01.23 um 22:03 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Wed, Jan 25, 2023 at 09:04:09PM +0100, Thomas Zimmermann wrote: > > > Initialize the fb-helper structure immediately after its allocation > > > in drm_f

Re: [Freedreno] [RFT PATCH 2/2] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset

2023-01-27 Thread Dmitry Baryshkov
On 27/01/2023 18:32, Doug Anderson wrote: Hi, On Thu, Jan 26, 2023 at 9:49 PM Dmitry Baryshkov wrote: Hi, On Sat, 14 Jan 2023 at 01:56, Douglas Anderson wrote: In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time"), we moved powering up DSI hosts to modeset time. Th

Re: [Freedreno] [PATCH v3 01/10] drm/client: Test for connectors before sending hotplug event

2023-01-27 Thread Sam Ravnborg
On Fri, Jan 27, 2023 at 03:13:50PM +0100, Thomas Zimmermann wrote: > Hi > > Am 25.01.23 um 21:52 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Wed, Jan 25, 2023 at 09:04:06PM +0100, Thomas Zimmermann wrote: > > > Test for connectors in the client code and remove a similar test > > > from the ge

Re: [Freedreno] [RFT PATCH 2/2] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset

2023-01-27 Thread Doug Anderson
Hi, On Thu, Jan 26, 2023 at 9:49 PM Dmitry Baryshkov wrote: > > Hi, > > On Sat, 14 Jan 2023 at 01:56, Douglas Anderson wrote: > > > > In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > > time"), we moved powering up DSI hosts to modeset time. This wasn't > > because it was

Re: [Freedreno] [PATCH Resend v11 05/15] drm/msm/dp: disable self_refresh_aware after entering psr

2023-01-27 Thread Vinod Polimera
> -Original Message- > From: Dmitry Baryshkov > Sent: Tuesday, January 24, 2023 10:15 PM > To: Vinod Polimera > Cc: Vinod Polimera (QUIC) ; dri- > de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; > freedreno@lists.freedesktop.org; devicet...@vger.kernel.org; Sankeerth > Billaka

Re: [Freedreno] [PATCH 13/14] drm/msm/a6xx: Add A619_holi speedbin support

2023-01-27 Thread Konrad Dybcio
On 27.01.2023 15:19, Dmitry Baryshkov wrote: > On 26/01/2023 17:16, Konrad Dybcio wrote: >> A619_holi is implemented on at least two SoCs: SM4350 (holi) and SM6375 >> (blair). This is what seems to be a first occurrence of this happening, >> but it's easy to overcome by guarding the SoC-specific

Re: [Freedreno] [PATCH v3 04/10] drm/fbdev-generic: Initialize fb-helper structure in generic setup

2023-01-27 Thread Thomas Zimmermann
Hi Am 25.01.23 um 22:03 schrieb Sam Ravnborg: Hi Thomas, On Wed, Jan 25, 2023 at 09:04:09PM +0100, Thomas Zimmermann wrote: Initialize the fb-helper structure immediately after its allocation in drm_fbdev_generic_setup(). That will make it easier to fill it with driver-specific values, such as

Re: [Freedreno] [PATCH 13/14] drm/msm/a6xx: Add A619_holi speedbin support

2023-01-27 Thread Konrad Dybcio
On 27.01.2023 15:19, Dmitry Baryshkov wrote: > On 26/01/2023 17:16, Konrad Dybcio wrote: >> A619_holi is implemented on at least two SoCs: SM4350 (holi) and SM6375 >> (blair). This is what seems to be a first occurrence of this happening, >> but it's easy to overcome by guarding the SoC-specific

Re: [Freedreno] [PATCH 13/14] drm/msm/a6xx: Add A619_holi speedbin support

2023-01-27 Thread Dmitry Baryshkov
On 26/01/2023 17:16, Konrad Dybcio wrote: A619_holi is implemented on at least two SoCs: SM4350 (holi) and SM6375 (blair). This is what seems to be a first occurrence of this happening, but it's easy to overcome by guarding the SoC-specific fuse values with of_machine_is_compatible(). Do just tha

Re: [Freedreno] [PATCH v3 02/10] drm/client: Add hotplug_failed flag

2023-01-27 Thread Thomas Zimmermann
Hi Am 25.01.23 um 21:57 schrieb Sam Ravnborg: Hi Thomas, On Wed, Jan 25, 2023 at 09:04:07PM +0100, Thomas Zimmermann wrote: Signal failed hotplugging with a flag in struct drm_client_dev. If set, the client helpers will not further try to set up the fbdev display. This used to be signalled wi

Re: [Freedreno] [PATCH v3 01/10] drm/client: Test for connectors before sending hotplug event

2023-01-27 Thread Thomas Zimmermann
Hi Am 25.01.23 um 21:52 schrieb Sam Ravnborg: Hi Thomas, On Wed, Jan 25, 2023 at 09:04:06PM +0100, Thomas Zimmermann wrote: Test for connectors in the client code and remove a similar test from the generic fbdev emulation. Do nothing if the test fails. Not having connectors indicates a driver

Re: [Freedreno] [PATCH 3/3] drm/msm/disp/dpu1: reserve the resources on topology change

2023-01-27 Thread Dmitry Baryshkov
On Fri, 27 Jan 2023 at 12:15, Kalyan Thota wrote: > > Some features like ctm can be enabled dynamically. Release and reserve > the dpu resources whenever a topology change occurs such that > required hw blocks are allocated appropriately. > > Signed-off-by: Kalyan Thota > --- > drivers/gpu/drm/m

Re: [Freedreno] [PATCH 2/3] drm/msm/disp/dpu1: add dspps into reservation if there is a ctm request

2023-01-27 Thread Dmitry Baryshkov
On Fri, 27 Jan 2023 at 12:15, Kalyan Thota wrote: > > Add dspp blocks into the topology for reservation, if there is a ctm > request for that composition. ... rather than just allocating them for DSI encoders. With this fixed (and one nit below): Reviewed-by: Dmitry Baryshkov > > Signed-off-b

Re: [Freedreno] [PATCH 1/3] drm/msm/disp/dpu1: clear dspp reservations in rm release

2023-01-27 Thread Dmitry Baryshkov
On Fri, 27 Jan 2023 at 12:15, Kalyan Thota wrote: > > Clear dspp reservations from the global state during > rm release > > Signed-off-by: Kalyan Thota Fixes: e47616df008b ("drm/msm/dpu: add support for color processing blocks in dpu driver") Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/

[Freedreno] [PATCH 3/3] drm/msm/disp/dpu1: reserve the resources on topology change

2023-01-27 Thread Kalyan Thota
Some features like ctm can be enabled dynamically. Release and reserve the dpu resources whenever a topology change occurs such that required hw blocks are allocated appropriately. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h| 1 + drivers/gpu/drm/msm/disp/dpu1/d

[Freedreno] [PATCH 1/3] drm/msm/disp/dpu1: clear dspp reservations in rm release

2023-01-27 Thread Kalyan Thota
Clear dspp reservations from the global state during rm release Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c index 73b3442..718ea0a 100

[Freedreno] [PATCH 2/3] drm/msm/disp/dpu1: add dspps into reservation if there is a ctm request

2023-01-27 Thread Kalyan Thota
Add dspp blocks into the topology for reservation, if there is a ctm request for that composition. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encod

[Freedreno] [PATCH 0/3] Reserve dspps based on user request

2023-01-27 Thread Kalyan Thota
This series will enable color features on sc7280 target which has primary panel as eDP The series removes dspp allocation based on encoder type and allows the dspp reservation based on user request via ctm. The series will release/reserve the dpu resources when ever there is a topology change

[Freedreno] [v12] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2023-01-27 Thread Kalyan Thota
Flush mechanism for DSPP blocks has changed in sc7280 family, it allows individual sub blocks to be flushed in coordination with master flush control. Representation: master_flush && (PCC_flush | IGC_flush .. etc ) This change adds necessary support for the above design. Changes in v1: - Few nit