Re: [Freedreno] [RFT PATCH v2 3/3] drm/msm/dsi: More properly handle errors in regards to dsi_mgr_bridge_power_on()

2023-02-02 Thread Doug Anderson
Hi, On Thu, Feb 2, 2023 at 2:37 PM Abhinav Kumar wrote: > > Hi Doug > > On 1/31/2023 2:18 PM, Douglas Anderson wrote: > > In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > > time") the error handling with regards to dsi_mgr_bridge_power_on() > > got a bit worse.

Re: [Freedreno] [RFT PATCH v2 3/3] drm/msm/dsi: More properly handle errors in regards to dsi_mgr_bridge_power_on()

2023-02-02 Thread Abhinav Kumar
Hi Doug On 1/31/2023 2:18 PM, Douglas Anderson wrote: In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time") the error handling with regards to dsi_mgr_bridge_power_on() got a bit worse. Specifically if we failed to power the bridge on then nothing would really notice.

Re: [Freedreno] [PATCH v2 12/27] drm/msm/dpu: remove dpu_hw_fmt_layout from struct dpu_hw_pipe_cfg

2023-02-02 Thread Abhinav Kumar
On 2/2/2023 12:10 PM, Dmitry Baryshkov wrote: On 02/02/2023 21:54, Abhinav Kumar wrote: On 2/2/2023 11:45 AM, Dmitry Baryshkov wrote: On Thu, 2 Feb 2023 at 21:38, Abhinav Kumar wrote: On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: Remove dpu_hw_fmt_layout instance from struct

Re: [Freedreno] [PATCH v2 12/27] drm/msm/dpu: remove dpu_hw_fmt_layout from struct dpu_hw_pipe_cfg

2023-02-02 Thread Dmitry Baryshkov
On 02/02/2023 21:54, Abhinav Kumar wrote: On 2/2/2023 11:45 AM, Dmitry Baryshkov wrote: On Thu, 2 Feb 2023 at 21:38, Abhinav Kumar wrote: On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: Remove dpu_hw_fmt_layout instance from struct dpu_hw_pipe_cfg, leaving only src_rect and dst_rect.

Re: [Freedreno] [RFT PATCH v2 2/3] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset

2023-02-02 Thread Abhinav Kumar
On 2/1/2023 6:33 AM, Doug Anderson wrote: Hi, On Tue, Jan 31, 2023 at 3:32 PM Abhinav Kumar wrote: On 1/31/2023 2:18 PM, Douglas Anderson wrote: In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset time"), we moved powering up DSI hosts to modeset time. This wasn't

Re: [Freedreno] [PATCH v2 12/27] drm/msm/dpu: remove dpu_hw_fmt_layout from struct dpu_hw_pipe_cfg

2023-02-02 Thread Abhinav Kumar
On 2/2/2023 11:45 AM, Dmitry Baryshkov wrote: On Thu, 2 Feb 2023 at 21:38, Abhinav Kumar wrote: On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: Remove dpu_hw_fmt_layout instance from struct dpu_hw_pipe_cfg, leaving only src_rect and dst_rect. This way right and left pipes will have

Re: [Freedreno] [PATCH v2 12/27] drm/msm/dpu: remove dpu_hw_fmt_layout from struct dpu_hw_pipe_cfg

2023-02-02 Thread Dmitry Baryshkov
On Thu, 2 Feb 2023 at 21:38, Abhinav Kumar wrote: > > > > On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: > > Remove dpu_hw_fmt_layout instance from struct dpu_hw_pipe_cfg, leaving > > only src_rect and dst_rect. This way right and left pipes will have > > separate dpu_hw_pipe_cfg isntances,

Re: [Freedreno] [PATCH v2 12/27] drm/msm/dpu: remove dpu_hw_fmt_layout from struct dpu_hw_pipe_cfg

2023-02-02 Thread Abhinav Kumar
On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: Remove dpu_hw_fmt_layout instance from struct dpu_hw_pipe_cfg, leaving only src_rect and dst_rect. This way right and left pipes will have separate dpu_hw_pipe_cfg isntances, while the layout is common to both of them. Sorry for not

Re: [Freedreno] [PATCH v2 11/27] drm/msm/dpu: move stride programming to dpu_hw_sspp_setup_sourceaddress

2023-02-02 Thread Abhinav Kumar
On 2/2/2023 10:55 AM, Dmitry Baryshkov wrote: Hi Abhinav, On Thu, 2 Feb 2023 at 20:41, Abhinav Kumar wrote: On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: Move stride programming to dpu_hw_sspp_setup_sourceaddress(), so that dpu_hw_sspp_setup_rects() programs only source and

Re: [Freedreno] [PATCH v2 11/27] drm/msm/dpu: move stride programming to dpu_hw_sspp_setup_sourceaddress

2023-02-02 Thread Dmitry Baryshkov
Hi Abhinav, On Thu, 2 Feb 2023 at 20:41, Abhinav Kumar wrote: > > > > On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: > > Move stride programming to dpu_hw_sspp_setup_sourceaddress(), so that > > dpu_hw_sspp_setup_rects() programs only source and destination > > rectangles. > > > >

[Freedreno] [PATCH] drm/msm/a6xx: Make GPU destroy a bit safer

2023-02-02 Thread Douglas Anderson
If, for whatever reason, we're trying process adreno_runtime_resume() at the same time that a6xx_destroy() is running then things can go boom. Specifically adreno_runtime_resume() will eventually call a6xx_pm_resume() and that may try to resume the gmu. Let's grab the GMU lock as we're destroying

Re: [Freedreno] [PATCH v2 11/27] drm/msm/dpu: move stride programming to dpu_hw_sspp_setup_sourceaddress

2023-02-02 Thread Abhinav Kumar
On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: Move stride programming to dpu_hw_sspp_setup_sourceaddress(), so that dpu_hw_sspp_setup_rects() programs only source and destination rectangles. Signed-off-by: Dmitry Baryshkov Sorry but once again, I dont see a response to my comment

Re: [Freedreno] [v1 3/3] drm/msm/disp/dpu1: reserve the resources on topology change

2023-02-02 Thread kernel test robot
-randconfig-r034-20230129 (https://download.01.org/0day-ci/archive/20230202/202302022254.37xyfgnr-...@intel.com/config) compiler: aarch64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross

Re: [Freedreno] [RFC PATCH v3 0/3] Support for Solid Fill Planes

2023-02-02 Thread Pekka Paalanen
On Wed, 1 Feb 2023 18:06:41 -0800 Jessica Zhang wrote: > On 1/31/2023 4:49 AM, Pekka Paalanen wrote: > > On Tue, 31 Jan 2023 11:21:18 + > > Simon Ser wrote: > > > >> On Tuesday, January 31st, 2023 at 12:13, Pekka Paalanen > >> wrote: > >> > >>> On Tue, 31 Jan 2023 10:06:39 + >