Re: [Freedreno] [PATCH v3 0/4] Reserve DSPPs based on user request

2023-02-08 Thread Doug Anderson
Hi, On Wed, Feb 8, 2023 at 8:16 PM Kalyan Thota wrote: > > Hi Doug, > > Have you picked the core change to program dspp's (below) ? the current > series will go on top of it. > https://patchwork.kernel.org/project/linux-arm-msm/patch/1671542719-12655-1-git-send-email-quic_kaly...@quicinc.com/

Re: [Freedreno] [PATCH] firmware: qcom_scm: Move qcom_scm.h to include/linux/firmware/qcom/

2023-02-08 Thread Bjorn Andersson
On Fri, 3 Feb 2023 13:09:52 -0800, Elliot Berman wrote: > Move include/linux/qcom_scm.h to include/linux/firmware/qcom/qcom_scm.h. > This removes 1 of a few remaining Qualcomm-specific headers into a more > approciate subdirectory under include/. > > Applied, thanks! [1/1] firmware: qcom_scm:

Re: [Freedreno] (subset) [PATCH v2 0/8] arm64: dts: qcom: sm8350: enable GPU on the HDK board

2023-02-08 Thread Bjorn Andersson
On Mon, 6 Feb 2023 16:56:59 +0200, Dmitry Baryshkov wrote: > Add A660 device to the Qualcomm SM8350 platform and enable it for the > sm8350-hdk board. Unfortunately while adding the GPU & related devices I > noticed that DT nodes on SM8350 are greatly out of the preagreed order, > so patches 4-6

Re: [Freedreno] (subset) [PATCH 0/6] drm/msm/hdmi: integrate msm8960 HDMI PHY with DT clocks infrastructure

2023-02-08 Thread Bjorn Andersson
On Thu, 19 Jan 2023 15:22:13 +0200, Dmitry Baryshkov wrote: > Make msm8960's HDMI PHY accept clocks from DT and also register it as a > DT clock provider. > > Dmitry Baryshkov (6): > dt-bindings: phy: qcom,hdmi-phy-other: use pxo clock > dt-bindings: phy: qcom,hdmi-phy-other: mark it as clock

Re: [Freedreno] [PATCH v3 0/4] Reserve DSPPs based on user request

2023-02-08 Thread Kalyan Thota
Hi Doug, Have you picked the core change to program dspp's (below) ? the current series will go on top of it. https://patchwork.kernel.org/project/linux-arm-msm/patch/1671542719-12655-1-git-send-email-quic_kaly...@quicinc.com/ Thanks, Kalyan >-Original Message- >From: Doug Anderson

Re: [Freedreno] [PATCH v2 4/8] arm64: dts: qcom: sm8350: reorder device nodes

2023-02-08 Thread Bjorn Andersson
On Mon, Feb 06, 2023 at 04:57:03PM +0200, Dmitry Baryshkov wrote: > Start ordering DT nodes according to agreed order. Move apps SMMU, GIC, > timer, apps RSC, cpufreq ADSP and cDSP nodes to the end to the proper > position at the end of /soc/. > I think "according to agreed order" means "sorted

Re: [Freedreno] [PATCH v3 27/27] drm/msm/dpu: add support for wide planes

2023-02-08 Thread Abhinav Kumar
On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Typically SSPP can support rectangle with width up to 2560. However it's Not always 2560. Depends on the chipset. possible to use multirect feature and split source to use the SSPP to output two consecutive rectangles. This commit brings in

Re: [Freedreno] [PATCH v3 25/27] drm/msm/dpu: rework static color fill code

2023-02-08 Thread Dmitry Baryshkov
On 09/02/2023 00:34, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Rework static color fill code to separate the pipe / pipe_cfg handling. This is a preparation for the r_pipe support. Signed-off-by: Dmitry Baryshkov ---   drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 70

Re: [Freedreno] [PATCH v3 22/27] drm/msm/dpu: rework dpu_plane_sspp_atomic_update()

2023-02-08 Thread Dmitry Baryshkov
On 07/02/2023 02:22, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_sspp_atomic_update() into the sspp-dependent? No, this is really pipe-dependent. It takes dpu_sw_pipe and dpu_sw_pipe_cfg arguments. separate function

Re: [Freedreno] [PATCH v3 22/27] drm/msm/dpu: rework dpu_plane_sspp_atomic_update()

2023-02-08 Thread Dmitry Baryshkov
On 07/02/2023 02:22, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_sspp_atomic_update() into the sspp-dependent? separate function dpu_plane_sspp_update_pipe(). This is one of preparational steps to add r_pipe support.

Re: [Freedreno] [PATCH v3 18/27] drm/msm/dpu: populate SmartDMA features in hw catalog

2023-02-08 Thread Dmitry Baryshkov
On 05/02/2023 02:36, Abhinav Kumar wrote: On 2/4/2023 4:29 PM, Dmitry Baryshkov wrote: On Sun, 5 Feb 2023 at 01:20, Abhinav Kumar wrote: On 2/4/2023 1:08 PM, Dmitry Baryshkov wrote: On 04/02/2023 20:35, Abhinav Kumar wrote: On 2/4/2023 2:43 AM, Dmitry Baryshkov wrote: On 04/02/2023

Re: [Freedreno] [PATCH v3 26/27] drm/msm/dpu: split pipe handling from _dpu_crtc_blend_setup_mixer

2023-02-08 Thread Dmitry Baryshkov
On 09/02/2023 01:44, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Rework _dpu_crtc_blend_setup_mixer() to split away pipe handling to a separate functon. This is a preparation for the r_pipe support. Signed-off-by: Dmitry Baryshkov ---  

Re: [Freedreno] [PATCH v3 26/27] drm/msm/dpu: split pipe handling from _dpu_crtc_blend_setup_mixer

2023-02-08 Thread Abhinav Kumar
On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Rework _dpu_crtc_blend_setup_mixer() to split away pipe handling to a separate functon. This is a preparation for the r_pipe support. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 86 ---

Re: [Freedreno] [RFC PATCH] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-02-08 Thread Dmitry Baryshkov
On 09/02/2023 01:24, Jessica Zhang wrote: On 2/8/2023 2:18 PM, Dmitry Baryshkov wrote: On 08/02/2023 23:37, Jessica Zhang wrote: Currently, DPU will enable TE during prepare_commit(). However, this will cause issues when trying to read/write to register in get_autorefresh_config(), because

Re: [Freedreno] [RFC PATCH] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-02-08 Thread Jessica Zhang
On 2/8/2023 2:18 PM, Dmitry Baryshkov wrote: On 08/02/2023 23:37, Jessica Zhang wrote: Currently, DPU will enable TE during prepare_commit(). However, this will cause issues when trying to read/write to register in get_autorefresh_config(), because the core clock rates aren't set at that

Re: [Freedreno] [PATCH v3 17/27] drm/msm/dpu: rewrite plane's QoS-related functions to take dpu_sw_pipe and dpu_format

2023-02-08 Thread Abhinav Kumar
On 2/3/2023 3:20 PM, Dmitry Baryshkov wrote: On 04/02/2023 01:07, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Rewrite dpu_plane's QoS related functions to take struct dpu_sw_pipe and struct dpu_format as arguments rather than fetching them from the pstate or

Re: [Freedreno] [PATCH v3 25/27] drm/msm/dpu: rework static color fill code

2023-02-08 Thread Abhinav Kumar
On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Rework static color fill code to separate the pipe / pipe_cfg handling. This is a preparation for the r_pipe support. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 70 +-- 1 file changed,

Re: [Freedreno] [RFC PATCH] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-02-08 Thread Dmitry Baryshkov
On 08/02/2023 23:37, Jessica Zhang wrote: Currently, DPU will enable TE during prepare_commit(). However, this will cause issues when trying to read/write to register in get_autorefresh_config(), because the core clock rates aren't set at that time. This used to work because phys_enc->hw_pp is

Re: [Freedreno] [PATCH v12 13/14] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver

2023-02-08 Thread Dmitry Baryshkov
On 07/02/2023 17:25, Dmitry Baryshkov wrote: On 07/02/2023 16:26, Vinod Polimera wrote: -Original Message- From: Dmitry Baryshkov Sent: Tuesday, January 31, 2023 6:29 PM To: Vinod Polimera (QUIC) ; dri- de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org;

[Freedreno] [RFC PATCH] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-02-08 Thread Jessica Zhang
Currently, DPU will enable TE during prepare_commit(). However, this will cause issues when trying to read/write to register in get_autorefresh_config(), because the core clock rates aren't set at that time. This used to work because phys_enc->hw_pp is only initialized in mode set [1], so the

Re: [Freedreno] [PATCH 09/14] drm/msm/a6xx: Fix some A619 tunables

2023-02-08 Thread Jordan Crouse
On Thu, Jan 26, 2023 at 04:16:13PM +0100, Konrad Dybcio wrote: > Adreno 619 expects some tunables to be set differently. Make up for it. > > Fixes: b7616b5c69e6 ("drm/msm/adreno: Add A619 support") > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +- > 1 file

Re: [Freedreno] [PATCH v3 0/4] Reserve DSPPs based on user request

2023-02-08 Thread Doug Anderson
Hi, On Wed, Feb 8, 2023 at 5:42 AM Kalyan Thota wrote: > > This series will enable color features on sc7280 target which has > primary panel as eDP > > The series removes DSPP allocation based on encoder type and allows > the DSPP reservation based on user request via CTM. > > The series will

Re: [Freedreno] [PATCH v2 8/8] arm64: dts: qcom: sm8350-hdk: enable GPU

2023-02-08 Thread Konrad Dybcio
On 6.02.2023 15:57, Dmitry Baryshkov wrote: > Enable the GPU on the SM8350-HDK device. The ZAP shader is required for > the GPU to function properly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 8 > 1 file

Re: [Freedreno] [PATCH v3 4/4] drm/msm/dpu: reserve the resources on topology change

2023-02-08 Thread Dmitry Baryshkov
On 08/02/2023 15:42, Kalyan Thota wrote: Some features like CTM can be enabled dynamically. Release and reserve the DPU resources whenever a topology change occurs such that required hw blocks are allocated appropriately. Signed-off-by: Kalyan Thota --- Changes in v1: - Avoid mode_set call

[Freedreno] [PATCH v3 2/4] drm/msm/dpu: add DSPPs into reservation upon a CTM request

2023-02-08 Thread Kalyan Thota
Add DSPP blocks into the topology for reservation, if there is a CTM request for that composition. Signed-off-by: Kalyan Thota Reviewed-by: Dmitry Baryshkov --- Changes in v1: - Minor nits (Dmitry) Changes in v2: - Populate DSPPs into the reservation only if CTM is requested (Dmitry) ---

[Freedreno] [PATCH v3 1/4] drm/msm/dpu: clear DSPP reservations in rm release

2023-02-08 Thread Kalyan Thota
Clear DSPP reservations from the global state during rm release Fixes: e47616df008b ("drm/msm/dpu: add support for color processing blocks in dpu driver") Signed-off-by: Kalyan Thota Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 2 ++

[Freedreno] [PATCH v3 0/4] Reserve DSPPs based on user request

2023-02-08 Thread Kalyan Thota
This series will enable color features on sc7280 target which has primary panel as eDP The series removes DSPP allocation based on encoder type and allows the DSPP reservation based on user request via CTM. The series will release/reserve the dpu resources when ever there is a topology change

[Freedreno] [PATCH v3 3/4] drm/msm/dpu: avoid unnecessary check in DPU reservations

2023-02-08 Thread Kalyan Thota
Return immediately on failure, this will make dpu reservations part look cleaner. Signed-off-by: Kalyan Thota Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git

[Freedreno] [PATCH v3 4/4] drm/msm/dpu: reserve the resources on topology change

2023-02-08 Thread Kalyan Thota
Some features like CTM can be enabled dynamically. Release and reserve the DPU resources whenever a topology change occurs such that required hw blocks are allocated appropriately. Signed-off-by: Kalyan Thota --- Changes in v1: - Avoid mode_set call directly (Dmitry) Changes in v2: - Minor nits

Re: [Freedreno] [PATCH v2 4/8] arm64: dts: qcom: sm8350: reorder device nodes

2023-02-08 Thread Konrad Dybcio
On 6.02.2023 15:57, Dmitry Baryshkov wrote: > Start ordering DT nodes according to agreed order. Move apps SMMU, GIC, > timer, apps RSC, cpufreq ADSP and cDSP nodes to the end to the proper > position at the end of /soc/. > > Signed-off-by: Dmitry Baryshkov > --- Moving adjacent nodes is

Re: [Freedreno] [PATCH 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-02-08 Thread Konrad Dybcio
On 8.02.2023 04:40, Bjorn Andersson wrote: > From: Bjorn Andersson > > Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the > SC8280XP. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 171