Re: [Freedreno] [PATCH v4 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-03-01 Thread Dmitry Baryshkov
On 01/03/2023 19:08, Marijn Suijten wrote: On 2023-03-01 08:23:28, Abhinav Kumar wrote: On 3/1/2023 2:03 AM, Marijn Suijten wrote: On 2023-02-21 10:42:53, Jessica Zhang wrote: Then, for some patch hygiene, starting here: Depends on: "Implement tearcheck support on INTF block" [3] Changes

Re: [Freedreno] [PATCH v4 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-03-01 Thread Abhinav Kumar
On 3/1/2023 9:08 AM, Marijn Suijten wrote: On 2023-03-01 08:23:28, Abhinav Kumar wrote: On 3/1/2023 2:03 AM, Marijn Suijten wrote: On 2023-02-21 10:42:53, Jessica Zhang wrote: Currently, DPU will enable TE during prepare_commit(). However, this will cause a crash and reboot to sahara when

Re: [Freedreno] [PATCH v3] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-03-01 Thread Dmitry Baryshkov
On 01/03/2023 18:57, Kuogee Hsieh wrote: On 2/28/2023 6:16 PM, Dmitry Baryshkov wrote: On Wed, 1 Mar 2023 at 02:17, Kuogee Hsieh wrote: There is a reboot/suspend test case where system suspend is forced during system booting up. Since dp_display_host_init() of external DP is executed at hpd

Re: [Freedreno] [PATCH v13 00/13] Add PSR support for eDP

2023-03-01 Thread Dmitry Baryshkov
On 01/03/2023 21:06, Doug Anderson wrote: Hi, On Sun, Feb 12, 2023 at 8:29 AM Vinod Polimera wrote: Changes in v2: - Use dp bridge to set psr entry/exit instead of dpu_enocder. - Don't modify whitespaces. - Set self refresh aware from atomic_check. - Set self refresh aware only

Re: [Freedreno] [PATCH v13 00/13] Add PSR support for eDP

2023-03-01 Thread Doug Anderson
Hi, On Wed, Mar 1, 2023 at 11:06 AM Doug Anderson wrote: > > Hi, > > On Sun, Feb 12, 2023 at 8:29 AM Vinod Polimera > wrote: > > > > Changes in v2: > > - Use dp bridge to set psr entry/exit instead of dpu_enocder. > > - Don't modify whitespaces. > > - Set self refresh aware from

Re: [Freedreno] [PATCH v13 00/13] Add PSR support for eDP

2023-03-01 Thread Doug Anderson
Hi, On Sun, Feb 12, 2023 at 8:29 AM Vinod Polimera wrote: > > Changes in v2: > - Use dp bridge to set psr entry/exit instead of dpu_enocder. > - Don't modify whitespaces. > - Set self refresh aware from atomic_check. > - Set self refresh aware only if psr is supported. > - Provide a

Re: [Freedreno] [PATCH v4 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-03-01 Thread Marijn Suijten
On 2023-03-01 08:23:28, Abhinav Kumar wrote: > > On 3/1/2023 2:03 AM, Marijn Suijten wrote: > > On 2023-02-21 10:42:53, Jessica Zhang wrote: > >> Currently, DPU will enable TE during prepare_commit(). However, this > >> will cause a crash and reboot to sahara when trying to read/write to > >>

Re: [Freedreno] [PATCH v3] drm/msm/dp: check core_initialized flag at both host_init() and host_deinit()

2023-03-01 Thread Kuogee Hsieh
On 2/28/2023 6:16 PM, Dmitry Baryshkov wrote: On Wed, 1 Mar 2023 at 02:17, Kuogee Hsieh wrote: There is a reboot/suspend test case where system suspend is forced during system booting up. Since dp_display_host_init() of external DP is executed at hpd thread context, this test case may

Re: [Freedreno] [PATCH v4 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-03-01 Thread Abhinav Kumar
On 3/1/2023 2:03 AM, Marijn Suijten wrote: On 2023-02-21 10:42:53, Jessica Zhang wrote: Currently, DPU will enable TE during prepare_commit(). However, this will cause a crash and reboot to sahara when trying to read/write to register in get_autorefresh_config(), because the core clock rates

Re: [Freedreno] [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-03-01 Thread Rob Clark
On Wed, Mar 1, 2023 at 7:31 AM Sebastian Wick wrote: > > On Tue, Feb 28, 2023 at 11:52 PM Rob Clark wrote: > > > > On Tue, Feb 28, 2023 at 6:30 AM Sebastian Wick > > wrote: > > > > > > On Tue, Feb 28, 2023 at 12:48 AM Rob Clark wrote: > > > > > > > > On Mon, Feb 27, 2023 at 2:44 PM Sebastian

Re: [Freedreno] [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-03-01 Thread Rodrigo Vivi
On Mon, Feb 27, 2023 at 02:20:04PM -0800, Rob Clark wrote: > On Mon, Feb 27, 2023 at 1:36 PM Rodrigo Vivi wrote: > > > > On Fri, Feb 24, 2023 at 09:59:57AM -0800, Rob Clark wrote: > > > On Fri, Feb 24, 2023 at 7:27 AM Luben Tuikov wrote: > > > > > > > > On 2023-02-24 06:37, Tvrtko Ursulin wrote:

Re: [Freedreno] [PATCH v4 06/14] dma-buf/sync_file: Support (E)POLLPRI

2023-03-01 Thread Sebastian Wick
On Tue, Feb 28, 2023 at 11:52 PM Rob Clark wrote: > > On Tue, Feb 28, 2023 at 6:30 AM Sebastian Wick > wrote: > > > > On Tue, Feb 28, 2023 at 12:48 AM Rob Clark wrote: > > > > > > On Mon, Feb 27, 2023 at 2:44 PM Sebastian Wick > > > wrote: > > > > > > > > On Mon, Feb 27, 2023 at 11:20 PM Rob

Re: [Freedreno] [PATCH AUTOSEL 6.2 18/60] drm/msm/dp: Remove INIT_SETUP delay

2023-03-01 Thread Sasha Levin
On Mon, Feb 27, 2023 at 10:12:20AM +0100, Johan Hovold wrote: On Sun, Feb 26, 2023 at 09:00:03PM -0500, Sasha Levin wrote: From: Bjorn Andersson [ Upstream commit e17af1c9d861dc177e5b56009bd4f71ace688d97 ] During initalization of the DisplayPort controller an EV_HPD_INIT_SETUP event is

Re: [Freedreno] [PATCH] drm/msm: Initialize mode_config earlier

2023-03-01 Thread Johan Hovold
On Tue, Jan 24, 2023 at 09:09:02AM +0100, Johan Hovold wrote: > On Mon, Jan 23, 2023 at 09:17:49AM -0800, Bjorn Andersson wrote: > > On Mon, Jan 23, 2023 at 05:01:45PM +0100, Johan Hovold wrote: > > > On Tue, Jan 17, 2023 at 09:04:39AM +0100, Johan Hovold wrote: > > > > On Mon, Jan 16, 2023 at

Re: [Freedreno] [RFC PATCH 1/2] drm/msm/dp: enumerate edp panel during driver probe

2023-03-01 Thread Dmitry Baryshkov
On 01/03/2023 10:13, Sankeerth Billakanti (QUIC) wrote: The eDP panel is identified and enumerated during probe of the panel-edp driver. The current DP driver triggers this panel-edp driver probe while getting the panel-bridge associated with the eDP panel from the platform driver bind. If the

Re: [Freedreno] [PATCH v4 3/4] drm/msm/dpu: Remove empty prepare_commit() function

2023-03-01 Thread Marijn Suijten
On 2023-03-01 11:08:16, Marijn Suijten wrote: > On 2023-02-21 10:42:55, Jessica Zhang wrote: > > Now that the TE setup has been moved to prepare_for_kickoff(), we have > > not prepare_commit() callbacks left. This makes dpu_encoder_prepare_commit() > > s/not/no > > > do nothing. Remove

Re: [Freedreno] [PATCH v4 3/4] drm/msm/dpu: Remove empty prepare_commit() function

2023-03-01 Thread Marijn Suijten
On 2023-02-21 10:42:55, Jessica Zhang wrote: > Now that the TE setup has been moved to prepare_for_kickoff(), we have > not prepare_commit() callbacks left. This makes dpu_encoder_prepare_commit() s/not/no > do nothing. Remove prepare_commit() from DPU driver. And again, this: > Changes in

Re: [Freedreno] [PATCH v4 4/4] drm/msm/mdp4: Remove empty prepare_commit() function

2023-03-01 Thread Marijn Suijten
On 2023-02-21 10:42:56, Jessica Zhang wrote: > Remove empty prepare_commit() function from MDP4 driver. > > Signed-off-by: Jessica Zhang > Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten > --- > drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 5 - > 1 file changed, 5 deletions(-) >

Re: [Freedreno] [PATCH v4 2/4] drm/msm: Check for NULL before calling prepare_commit()

2023-03-01 Thread Marijn Suijten
On 2023-02-21 10:42:54, Jessica Zhang wrote: > Add a NULL check before calling prepare_commit() in > msm_atomic_commit_tail() > > Signed-off-by: Jessica Zhang > Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten > --- > drivers/gpu/drm/msm/msm_atomic.c | 3 ++- > 1 file changed, 2

Re: [Freedreno] [PATCH v4 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-03-01 Thread Marijn Suijten
On 2023-02-21 10:42:53, Jessica Zhang wrote: > Currently, DPU will enable TE during prepare_commit(). However, this > will cause a crash and reboot to sahara when trying to read/write to > register in get_autorefresh_config(), because the core clock rates > aren't set at that time. Haven't seeen

Re: [Freedreno] [PATCH v8 08/16] dma-buf/sw_sync: Add fence deadline support

2023-03-01 Thread Pekka Paalanen
On Tue, 28 Feb 2023 14:58:12 -0800 Rob Clark wrote: > From: Rob Clark > > This consists of simply storing the most recent deadline, and adding an > ioctl to retrieve the deadline. This can be used in conjunction with > the SET_DEADLINE ioctl on a fence fd for testing. Ie. create various >

Re: [Freedreno] [PATCH v8 05/16] dma-buf/sync_file: Surface sync-file uABI

2023-03-01 Thread Pekka Paalanen
On Tue, 28 Feb 2023 14:58:09 -0800 Rob Clark wrote: > From: Rob Clark > > We had all of the internal driver APIs, but not the all important > userspace uABI, in the dma-buf doc. Fix that. And re-arrange the > comments slightly as otherwise the comments for the ioctl nr defines > would not

Re: [Freedreno] [PATCH v8 01/16] dma-buf/dma-fence: Add deadline awareness

2023-03-01 Thread Bagas Sanjaya
On 3/1/23 05:58, Rob Clark wrote: > From: Rob Clark > > Add a way to hint to the fence signaler of an upcoming deadline, such as > vblank, which the fence waiter would prefer not to miss. This is to aid > the fence signaler in making power management decisions, like boosting > frequency as the

Re: [Freedreno] [PATCH v4 3/4] drm/msm/dpu: avoid unnecessary check in DPU reservations

2023-03-01 Thread Marijn Suijten
On 2023-02-13 03:11:43, Kalyan Thota wrote: > Return immediately on failure, this will make dpu reservations > part look cleaner. > > Signed-off-by: Kalyan Thota > Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 23

Re: [Freedreno] [PATCH v4 2/4] drm/msm/dpu: add DSPPs into reservation upon a CTM request

2023-03-01 Thread Marijn Suijten
On 2023-02-13 03:11:42, Kalyan Thota wrote: > Add DSPP blocks into the topology for reservation, if there > is a CTM request for that composition. > > Signed-off-by: Kalyan Thota > Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten > --- > Changes in v1: > - Minor nits (Dmitry) > >

Re: [Freedreno] [RFC PATCH 2/2] drm/msm/dp: enable pm_runtime support for dp driver

2023-03-01 Thread Sankeerth Billakanti (QUIC)
>> diff --git a/drivers/gpu/drm/msm/dp/dp_aux.c >> b/drivers/gpu/drm/msm/dp/dp_aux.c >[..] >> +static int dp_runtime_resume(struct device *dev) { >> +struct platform_device *pdev = to_platform_device(dev); >> +struct msm_dp *dp_display = platform_get_drvdata(pdev); >> +struct

Re: [Freedreno] [RFC PATCH 0/2] drm/msm/dp: refactor the msm dp driver resources

2023-03-01 Thread Sankeerth Billakanti (QUIC)
>> The DP driver resources are currently enabled and disabled directly based >on code flow. >> As mentioned in bug 230631602, we want to do the following: > >private bug tracker > Will remove the reference for this. >> >> 1) Refactor the dp/edp parsing code to move it to probe (it is currently

Re: [Freedreno] [RFC PATCH 1/2] drm/msm/dp: enumerate edp panel during driver probe

2023-03-01 Thread Sankeerth Billakanti (QUIC)
>> >> The eDP panel is identified and enumerated during probe of the >> panel-edp driver. The current DP driver triggers this panel-edp driver >> probe while getting the panel-bridge associated with the eDP panel >> from the platform driver bind. If the panel-edp probe is deferred, >> then the