Re: [Freedreno] [PATCH v3 11/12] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-22 Thread Thomas Zimmermann
Hi Am 22.05.23 um 15:20 schrieb Dmitry Baryshkov: On Mon, 22 May 2023 at 15:22, Thomas Zimmermann wrote: Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Fbdev-generic was the only caller of the DRM helpers, so remove them from the helper module. v2:

Re: [Freedreno] [PATCH v3 5/5] drm/msm/dsi: Remove incorrect references to slice_count

2023-05-22 Thread Jessica Zhang
On 5/20/2023 5:32 PM, Dmitry Baryshkov wrote: On 20/05/2023 00:17, Jessica Zhang wrote: Currently, slice_count is being used to calculate word count and pkt_per_line. In downstream, these values are calculated using slice per packet, which is not the same as slice_count. I'd say the

Re: [Freedreno] [PATCH v3 1/5] msm/drm/dsi: Round up DSC hdisplay calculation

2023-05-22 Thread Jessica Zhang
On 5/20/2023 1:07 AM, Marijn Suijten wrote: On 2023-05-19 14:17:26, Jessica Zhang wrote: Currently, when compression is enabled, hdisplay is reduced via integer division. This causes issues for modes where the original hdisplay is not a multiple of 3. To fix this, use DIV_ROUND_UP to divide

Re: [Freedreno] [PATCH v3 3/5] drm/msm/dpu: Add DPU_INTF_DATA_COMPRESS feature flag

2023-05-22 Thread Jessica Zhang
On 5/19/2023 2:34 PM, Marijn Suijten wrote: On 2023-05-19 14:17:28, Jessica Zhang wrote: Add DATA_COMPRESS feature flag to DPU INTF block. In DPU 7.x and later, DSC/DCE enablement registers have been moved from PINGPONG to INTF. Reviewed-by: Marijn Suijten Signed-off-by: Jessica Zhang

Re: [Freedreno] [PATCH 3/6] drm/msm/dpu: split interrupt address arrays

2023-05-22 Thread Dmitry Baryshkov
On 22/05/2023 17:36, Neil Armstrong wrote: Hi, On 22/05/2023 02:42, Dmitry Baryshkov wrote: There is no point in having a single enum (and a single array) for both DPU < 7.0 and DPU >= 7.0 interrupt registers. Instead define a single enum and two IRQ address arrays. Signed-off-by: Dmitry

Re: [Freedreno] [PATCH 6/6] drm/msm/dpu: drop compatibility INTR defines

2023-05-22 Thread Neil Armstrong
On 22/05/2023 02:42, Dmitry Baryshkov wrote: While reworking interrupts masks, it was easier to keep old MDP_INTFn_7xxx_INTR and MDP_INTFn_7xxx_TEAR_INTR symbols. Now it is time to drop them and use unified symbol names. Signed-off-by: Dmitry Baryshkov ---

Re: [Freedreno] [PATCH 5/6] drm/msm/dpu: drop now-unused mdss_irqs field from hw catalog

2023-05-22 Thread Neil Armstrong
On 22/05/2023 02:42, Dmitry Baryshkov wrote: Now as the list of the interrupts is constructed from the catalog data, drop the mdss_irqs field from catalog. Signed-off-by: Dmitry Baryshkov --- .../drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h| 8

Re: [Freedreno] [PATCH 3/6] drm/msm/dpu: split interrupt address arrays

2023-05-22 Thread Neil Armstrong
Hi, On 22/05/2023 02:42, Dmitry Baryshkov wrote: There is no point in having a single enum (and a single array) for both DPU < 7.0 and DPU >= 7.0 interrupt registers. Instead define a single enum and two IRQ address arrays. Signed-off-by: Dmitry Baryshkov ---

Re: [Freedreno] [PATCH 2/6] drm/msm/dpu: inline __intr_offset

2023-05-22 Thread Neil Armstrong
On 22/05/2023 02:42, Dmitry Baryshkov wrote: Inline __intr_offset(), there is no point in having a separate oneline function for setting base block address. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 8 +--- 1 file changed, 1 insertion(+), 7

Re: [Freedreno] [PATCH 1/6] drm/msm/dpu: don't set DPU_INTF_TE globally

2023-05-22 Thread Neil Armstrong
On 22/05/2023 02:42, Dmitry Baryshkov wrote: Using BIT(DPU_INTF_TE) in INTF_SC7180_MASK (and by extension in INTF_SC7280_MASK) results in this bit (and corrsponding operations) being enabled for all interfaces, even the ones which do not have TE block. Move this bit setting to INTF_DSI_TE(), so

Re: [Freedreno] [PATCH v2 3/3] drm/bridge: display-connector: handle hdmi-pwr supply

2023-05-22 Thread Neil Armstrong
On 19/05/2023 20:40, Dmitry Baryshkov wrote: On some devices the +5V Power pin of the HDMI connector and/or the ESD protection logic is powered on by a separate regulator. Instead of declaring this regulator as always-on, make hdmi-connector support the additional hdmi-pwr supply.

Re: [Freedreno] [PATCH v3 11/12] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-22 Thread Dmitry Baryshkov
On Mon, 22 May 2023 at 15:22, Thomas Zimmermann wrote: > > Implement dedicated fbdev helpers for framebuffer I/O instead > of using DRM's helpers. Fbdev-generic was the only caller of the > DRM helpers, so remove them from the helper module. > > v2: > * use FB_SYS_HELPERS_DEFERRED option

Re: [Freedreno] [PATCH v10 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2023-05-22 Thread Rodrigo Vivi
On Sat, May 20, 2023 at 02:07:51AM +0300, Dmitry Baryshkov wrote: > On 20/05/2023 00:16, Rodrigo Vivi wrote: > > On Fri, May 19, 2023 at 07:55:47PM +0300, Dmitry Baryshkov wrote: > > > On 19/04/2023 18:43, Mark Yacoub wrote: > > > > Hi all, > > > > This is v10 of the HDCP patches. The patches are

[Freedreno] [PATCH v3 11/12] drm/fbdev-generic: Implement dedicated fbdev I/O helpers

2023-05-22 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. Fbdev-generic was the only caller of the DRM helpers, so remove them from the helper module. v2: * use FB_SYS_HELPERS_DEFERRED option Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig

[Freedreno] [PATCH v3 12/12] drm/i915: Implement dedicated fbdev I/O helpers

2023-05-22 Thread Thomas Zimmermann
Implement dedicated fbdev helpers for framebuffer I/O instead of using DRM's helpers. i915 was the only caller of the DRM helpers, so remove them from the helper module. v2: * use FB_IO_HELPERS options Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo

[Freedreno] [PATCH v3 10/12] drm/fb-helper: Export helpers for marking damage areas

2023-05-22 Thread Thomas Zimmermann
Export drm_fb_helper_damage() and drm_fb_helper_damage_range(), which handle damage areas for fbdev emulation. This is a temporary export that allows to move the DRM I/O helpers for fbdev into drivers. Only fbdev-generic and i915 need them. Both will be updated to implement damage handling by

[Freedreno] [PATCH v3 09/12] drm/tegra: Use regular fbdev I/O helpers

2023-05-22 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Tegra does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

[Freedreno] [PATCH v3 02/12] drm/armada: Use regular fbdev I/O helpers

2023-05-22 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Armada does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

[Freedreno] [PATCH v3 07/12] drm/msm: Use regular fbdev I/O helpers

2023-05-22 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Msm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirely.

[Freedreno] [PATCH v3 06/12] drm/fbdev-dma: Use regular fbdev I/O helpers

2023-05-22 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Fbdev-dma does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

[Freedreno] [PATCH v3 05/12] drm/radeon: Use regular fbdev I/O helpers

2023-05-22 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Radeon does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

[Freedreno] [PATCH v3 08/12] drm/omapdrm: Use regular fbdev I/O helpers

2023-05-22 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Omapdrm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

[Freedreno] [PATCH v3 04/12] drm/gma500: Use regular fbdev I/O helpers

2023-05-22 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Gma500 does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

[Freedreno] [PATCH v3 01/12] fbdev: Add Kconfig options to select different fb_ops helpers

2023-05-22 Thread Thomas Zimmermann
Many fbdev drivers use the same set of fb_ops helpers. Add Kconfig options to select them at once. This will help with making DRM's fbdev emulation code more modular, but can also be used to simplify fbdev's driver configs. v3: * fix select statement (Jingfeng) Signed-off-by: Thomas

[Freedreno] [PATCH v3 00/12] drm/fbdev: Remove DRM's helpers for fbdev I/O

2023-05-22 Thread Thomas Zimmermann
DRM provides a number of wrappers around fbdev cfb_() sys_(), fb_io_() and fb_sys_() helpers. The DRM functions don't provide any additional functionality for most DRM drivers. So remove them and call the fbdev I/O helpers directly. The DRM fbdev I/O wrappers were originally added because does

[Freedreno] [PATCH v3 03/12] drm/exynos: Use regular fbdev I/O helpers

2023-05-22 Thread Thomas Zimmermann
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Exynos does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions

Re: [Freedreno] [PATCH v12 1/9] drm/display/dsc: Add flatness and initial scale value calculations

2023-05-22 Thread Jani Nikula
On Wed, 17 May 2023, Jessica Zhang wrote: > Add helpers to calculate det_thresh_flatness and initial_scale_value as > these calculations are defined within the DSC spec. > > Reviewed-by: Marijn Suijten > Signed-off-by: Jessica Zhang > --- > include/drm/display/drm_dsc_helper.h | 10 ++

Re: [Freedreno] [PATCH v12 3/9] drm/display/dsc: Add drm_dsc_get_bpp_int helper

2023-05-22 Thread Jani Nikula
On Wed, 17 May 2023, Jessica Zhang wrote: > Add helper to get the integer value of drm_dsc_config.bits_per_pixel > > Reviewed-by: Marijn Suijten > Signed-off-by: Jessica Zhang > --- > include/drm/display/drm_dsc_helper.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [Freedreno] [PATCH 02/11] drm/msm/dpu: use the actual lm maximum width instead of a hardcoded value

2023-05-22 Thread Arnaud Vrac
Le sam. 20 mai 2023 à 22:49, Dmitry Baryshkov a écrit : > > On 20/04/2023 20:47, Jeykumar Sankaran wrote: > > > > > > On 4/19/2023 3:23 PM, Dmitry Baryshkov wrote: > >> On 19/04/2023 17:41, Arnaud Vrac wrote: > >>> This avoids using two LMs instead of one when the display width is lower > >>>

<    1   2