Re: [Freedreno] [PATCH v5 00/12] SM63(50|75) DPU support

2023-05-31 Thread Dmitry Baryshkov
On 23/05/2023 10:46, Konrad Dybcio wrote: [skipped the changelog] --- Konrad Dybcio (12): dt-bindings: display/msm: dsi-controller-main: Add SM6350 dt-bindings: display/msm: dsi-controller-main: Add SM6375 dt-bindings: display/msm: sc7180-dpu: Describe SM6350 and SM6375

Re: [Freedreno] [PATCH v5 04/12] dt-bindings: display/msm: Add SM6350 MDSS

2023-05-31 Thread Dmitry Baryshkov
On 23/05/2023 11:34, Rob Herring wrote: On Tue, 23 May 2023 09:46:15 +0200, Konrad Dybcio wrote: Document the SM6350 MDSS. Signed-off-by: Konrad Dybcio --- .../bindings/display/msm/qcom,sm6350-mdss.yaml | 214 + 1 file changed, 214 insertions(+) My bot found erro

Re: [Freedreno] [PATCH v3 1/3] drm/msm/adreno: Add Adreno A690 support

2023-05-31 Thread Konrad Dybcio
On 31.05.2023 05:09, Bjorn Andersson wrote: > From: Bjorn Andersson > > Introduce support for the Adreno A690, found in Qualcomm SC8280XP. > > Tested-by: Steev Klimaszewski > Reviewed-by: Konrad Dybcio > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- Couple of addit

Re: [Freedreno] [PATCH v3 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-05-31 Thread Konrad Dybcio
On 31.05.2023 05:09, Bjorn Andersson wrote: > From: Bjorn Andersson > > Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the > SC8280XP. > > Tested-by: Steev Klimaszewski > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Konrad Dybcio Konrad

Re: [Freedreno] [PATCH v3 3/3] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-05-31 Thread Konrad Dybcio
On 31.05.2023 05:09, Bjorn Andersson wrote: > From: Bjorn Andersson > > Add memory reservation for the zap-shader and enable the Adreno SMMU, > GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the > Lenovo ThinkPad X13s. > > Tested-by: Steev Klimaszewski > Signed-off-by:

Re: [Freedreno] [PATCH] drm/msm/dpu: re-introduce dpu core revision to the catalog

2023-05-31 Thread Abhinav Kumar
On 5/31/2023 3:07 AM, Dmitry Baryshkov wrote: On 31/05/2023 06:05, Abhinav Kumar wrote: On 5/30/2023 7:53 PM, Dmitry Baryshkov wrote: On Wed, 31 May 2023 at 03:54, Abhinav Kumar wrote: With [1] dpu core revision was dropped in favor of using the compatible string from the device tree to

[Freedreno] [PATCH v2 1/2] dt-bindings: display: panel: Add Visionox R66451 AMOLED DSI panel

2023-05-31 Thread Jessica Zhang
Document the 1080x2340 Visionox R66451 AMOLED DSI panel bindings Reviewed-by: Krzysztof Kozlowski Signed-off-by: Jessica Zhang --- .../bindings/display/panel/visionox,r66451.yaml| 59 ++ 1 file changed, 59 insertions(+) diff --git a/Documentation/devicetree/bindings/di

[Freedreno] [PATCH v2 0/2] Add support for Visionox R66451 AMOLED DSI panel

2023-05-31 Thread Jessica Zhang
Add support for the 1080x2340 Visionox R66451 AMOLED DSI panel that comes with the Qualcomm HDK8350 display expansion pack. The driver will come with display compression (DSC v1.2) enabled by default. Signed-off-by: Jessica Zhang --- Changes in v2: - Reworded panel bindings commit message for br

[Freedreno] [PATCH v2 2/2] drm/panel: Add driver for Visionox r66451 panel

2023-05-31 Thread Jessica Zhang
Add support for the 1080x2340 Visionox R66451 AMOLED DSI panel that comes with the Qualcomm HDK8350 display expansion pack. The panel enables display compression (DSC v1.2) by default. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-05-31 Thread Dmitry Baryshkov
On Wed, 31 May 2023 at 20:29, Kuogee Hsieh wrote: > > > On 5/31/2023 10:12 AM, Dmitry Baryshkov wrote: > > On Wed, 31 May 2023 at 18:41, Kuogee Hsieh wrote: > >> > >> > +if (dpu_enc->disp_info.intf_type == DRM_MODE_ENCODER_DSI) { > >>> INTF_DSI > >>> > +struct drm_bridge

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-05-31 Thread Kuogee Hsieh
On 5/31/2023 10:12 AM, Dmitry Baryshkov wrote: On Wed, 31 May 2023 at 18:41, Kuogee Hsieh wrote: +if (dpu_enc->disp_info.intf_type == DRM_MODE_ENCODER_DSI) { INTF_DSI +struct drm_bridge *bridge; + +if (!dpu_enc->dsc) { This condition is not correct. We should be

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-05-31 Thread Dmitry Baryshkov
On Wed, 31 May 2023 at 18:41, Kuogee Hsieh wrote: > > > > >> +if (dpu_enc->disp_info.intf_type == DRM_MODE_ENCODER_DSI) { > > > > INTF_DSI > > > >> +struct drm_bridge *bridge; > >> + > >> +if (!dpu_enc->dsc) { > > > > This condition is not correct. We should be updating the D

Re: [Freedreno] [PATCH v3 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-05-31 Thread Bjorn Andersson
On Wed, May 31, 2023 at 09:28:35AM +0200, Johan Hovold wrote: > On Tue, May 30, 2023 at 08:09:44PM -0700, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the > > SC8280XP. > > > > Tested-by: Steev Klimaszewski > > Signed-off-

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-05-31 Thread Kuogee Hsieh
  +    if (dpu_enc->disp_info.intf_type == DRM_MODE_ENCODER_DSI) { INTF_DSI +    struct drm_bridge *bridge; + +    if (!dpu_enc->dsc) { This condition is not correct. We should be updating the DSC even if there is one. +    bridge = drm_bridge_chain_get_first_bridge(d

Re: [Freedreno] [PATCH] drm/msm/a6xx: fix uninitialised lock in init error path

2023-05-31 Thread Doug Anderson
Hi, On Wed, May 31, 2023 at 1:00 AM Johan Hovold wrote: > > A recent commit started taking the GMU lock in the GPU destroy path, > which on GPU initialisation failure is called before the GMU and its > lock have been initialised. > > Make sure that the GMU has been initialised before taking the l

Re: [Freedreno] [PATCH v8 00/18] GMU-less A6xx support (A610, A619_holi)

2023-05-31 Thread Konrad Dybcio
On 29.05.2023 15:52, Konrad Dybcio wrote: > v7 -> v8: > - Fix up resume/suspend (icc now correctly parks to 0, don't abuse > OPP & genpd throughout system-wide suspend) > - Don't handle ebi1_clk separately, the bulk ops handle it just fine > - Rebase on next-20230525 (no meaningful changes) Kr

Re: [Freedreno] [PATCH] drm/msm/dpu: re-introduce dpu core revision to the catalog

2023-05-31 Thread Dmitry Baryshkov
On 31/05/2023 06:05, Abhinav Kumar wrote: On 5/30/2023 7:53 PM, Dmitry Baryshkov wrote: On Wed, 31 May 2023 at 03:54, Abhinav Kumar wrote: With [1] dpu core revision was dropped in favor of using the compatible string from the device tree to select the dpu catalog being used in the device.

Re: [Freedreno] [PATCH v3 0/3] drm/bridge: display-connector: add external supply support

2023-05-31 Thread Neil Armstrong
Hi, On Wed, 31 May 2023 03:02:56 +0300, Dmitry Baryshkov wrote: > On some devices the 5V pin of the HDMI connector and/or the ESD > protection logic is powered on by a separate regulator. The dp-connector > for such usecases provides dp-pwr supply support. Follow this example > and make hdmi-conne

Re: [Freedreno] [PATCH v5 08/13] drm/omapdrm: Use regular fbdev I/O helpers

2023-05-31 Thread Tomi Valkeinen
On 30/05/2023 18:02, Thomas Zimmermann wrote: Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Omapdrm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-31 Thread AngeloGioacchino Del Regno
Il 30/05/23 17:44, Neil Armstrong ha scritto: On 30/05/2023 14:36, Dmitry Baryshkov wrote: On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: Hi Marijn, Dmitry, Caleb, Jessica, On 29/05/

[Freedreno] [PATCH] drm/msm/a6xx: fix uninitialised lock in init error path

2023-05-31 Thread Johan Hovold
A recent commit started taking the GMU lock in the GPU destroy path, which on GPU initialisation failure is called before the GMU and its lock have been initialised. Make sure that the GMU has been initialised before taking the lock in a6xx_destroy() and drop the now redundant check from a6xx_gmu_

Re: [Freedreno] [PATCH v3 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-05-31 Thread Johan Hovold
On Tue, May 30, 2023 at 08:09:42PM -0700, Bjorn Andersson wrote: > This series introduces support for A690 in the DRM/MSM driver and > enables it for the two SC8280XP laptops. > > Bjorn Andersson (3): > drm/msm/adreno: Add Adreno A690 support > arm64: dts: qcom: sc8280xp: Add GPU related nodes

Re: [Freedreno] [PATCH v3 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-05-31 Thread Johan Hovold
On Tue, May 30, 2023 at 08:09:44PM -0700, Bjorn Andersson wrote: > From: Bjorn Andersson > > Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the > SC8280XP. > > Tested-by: Steev Klimaszewski > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > > Changes sinc