[Freedreno] [PATCH v2 1/2] drm/msm/dpu: use PINGPONG_NONE to unbind INTF from PP

2023-06-03 Thread Dmitry Baryshkov
Currently the driver passes the PINGPONG index to dpu_hw_intf_ops::bind_pingpong_blk() callback and uses separate boolean flag to tell whether INTF should be bound or unbound. Simplify this by passing PINGPONG_NONE in case of unbinding and drop the flag completely. Signed-off-by: Dmitry Baryshkov

[Freedreno] [PATCH v2 2/2] drm/msm/dpu: use PINGPONG_NONE to unbind WB from PP

2023-06-03 Thread Dmitry Baryshkov
Currently the driver passes the PINGPONG index to dpu_hw_wb_ops::bind_pingpong_blk() callback and uses separate boolean flag to tell whether WB should be bound or unbound. Simplify this by passing PINGPONG_NONE in case of unbinding and drop the flag completely. Suggested-by: Marijn Suijten Signed

Re: [Freedreno] [PATCH] drm/msm: Use struct fb_info.screen_buffer

2023-06-03 Thread Dmitry Baryshkov
On Mon, 22 May 2023 21:17:01 +0200, Thomas Zimmermann wrote: > The fbdev framebuffer is in system memory. Store the address in > the field 'screen_buffer'. Fixes the following sparse warning. > > ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: warning: incorrect type in > assignment (different addre

Re: [Freedreno] [PATCH v3 0/7] drm/msm/dpu: simplify DPU encoder init

2023-06-03 Thread Dmitry Baryshkov
On Thu, 01 Jun 2023 20:22:29 +0300, Dmitry Baryshkov wrote: > Rework dpu_encoder initialization code, simplifying calling sequences > and separating common init parts. > > Changes since v2: > - Rebased on top of msm-next-lumag branch > > Changes since v1: > - Withdrawn two pathes for a later co

Re: [Freedreno] [PATCH v14 00/10] add DSC 1.2 dpu supports

2023-06-03 Thread Dmitry Baryshkov
On Thu, 25 May 2023 10:40:48 -0700, Kuogee Hsieh wrote: > This series adds the DPU side changes to support DSC 1.2 encoder. This > was validated with both DSI DSC 1.2 panel and DP DSC 1.2 monitor. > The DSI and DP parts will be pushed later on top of this change. > This seriel is rebase on [1], [

Re: [Freedreno] [PATCH v2 0/3] arm64: dts: qcom: add DP Controller to SM8550 DTS

2023-06-03 Thread Dmitry Baryshkov
On Thu, 01 Jun 2023 12:09:46 +0200, Neil Armstrong wrote: > The DP output is shared with the USB3 SuperSpeed lanes and is > usually connected to an USB-C port which Altmode is controlled > by the PMIC Glink infrastructure. > > DT changes tying the DP controller to the USB-C port on the QRD > boa

Re: [Freedreno] [PATCH v3 0/9] drm/msm/dpu: simplify QoS/CDP programming

2023-06-03 Thread Dmitry Baryshkov
On Fri, 19 May 2023 01:22:29 +0300, Dmitry Baryshkov wrote: > Merge SSPP and WB code programming QoS and CDP. This allows us to drop > intermediate structures and duplicate code. > > Changes since v2: > - Moved SSPP_VIG_CSC_10_OP_MODE close to other CSC10 defines (Jeykumar) > > Changes since v1

Re: [Freedreno] [PATCH 1/3] drm/msm/dp: Drop now unused dp_hpd module

2023-06-03 Thread Dmitry Baryshkov
On Sun, 14 May 2023 20:02:54 -0700, Bjorn Andersson wrote: > The dp_hpd module is a remnant from the downstream design and is now > completely unused. Drop it and all references to it. > > Applied, thanks! [2/3] drm/msm/dp: Clean up logs dp_power module https://gitlab.freedesktop.org/lu

Re: [Freedreno] [PATCH] drm/msm: Remove unnecessary (void*) conversions

2023-06-03 Thread Dmitry Baryshkov
On Mon, 22 May 2023 09:32:13 +0800, Su Hui wrote: > Pointer variables of (void*) type do not require type cast. > > Applied, thanks! [1/1] drm/msm: Remove unnecessary (void*) conversions https://gitlab.freedesktop.org/lumag/msm/-/commit/eea9cf72b718 Best regards, -- Dmitry Baryshkov

Re: [Freedreno] [PATCH v3 0/7] Display support for MSM8226

2023-06-03 Thread Dmitry Baryshkov
On Thu, 01 Jun 2023 19:00:07 +0200, Luca Weiss wrote: > This series adds the required configs for MDP5 and DSI blocks that are > needed for MDSS on MSM8226. Finally we can add the new nodes into the > dts. > > Tested on apq8026-lg-lenok and msm8926-htc-memul. > > > [...] Applied, thanks! [1/

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dsi: remove extra call to dsi_get_pclk_rate()

2023-06-03 Thread Dmitry Baryshkov
On Sat, 20 May 2023 23:01:02 +0300, Dmitry Baryshkov wrote: > In dsi_calc_clk_rate_v2() there is no need to call dsi_get_pclk_rate(). > This function has just been called (from dsi_calc_pclk()) and its > result is stored at msm_host->pixel_clk_rate. Use this variable > directly. > > Applied, t

Re: [Freedreno] [PATCH v2 1/3] drm/msm/dpu: drop dpu_encoder_phys_ops::late_register()

2023-06-03 Thread Dmitry Baryshkov
On Sun, 21 May 2023 22:22:28 +0300, Dmitry Baryshkov wrote: > This callback has been unused since the driver being added. Drop it now. > > Applied, thanks! [1/3] drm/msm/dpu: drop dpu_encoder_phys_ops::late_register() https://gitlab.freedesktop.org/lumag/msm/-/commit/95666ca7431c [2/3]

Re: [Freedreno] [PATCH v2] drm/msm/dp: remove most of usbpd-related remains

2023-06-03 Thread Dmitry Baryshkov
On Sat, 20 May 2023 21:20:50 +0300, Dmitry Baryshkov wrote: > Remove most of remains of downstream usbpd code. Mainline kernel uses > different approach for managing Type-C / USB-PD, so this remains unused. > > Applied, thanks! [1/1] drm/msm/dp: remove most of usbpd-related remains http

Re: [Freedreno] [PATCH v2] drm/msm/dpu: clean up dpu_kms_get_clk_rate() returns

2023-06-03 Thread Dmitry Baryshkov
On Fri, 26 May 2023 14:51:59 +0300, Dan Carpenter wrote: > Static analysis tools complain about the -EINVAL error code being > stored in an unsigned variable. Let's change this to match > the clk_get_rate() function which is type unsigned long and returns > zero on error. > > Applied, thanks!

Re: [Freedreno] [PATCH v3 6/7] drm/msm/dsi: Add phy configuration for MSM8226

2023-06-03 Thread Dmitry Baryshkov
On 01/06/2023 20:00, Luca Weiss wrote: MSM8226 uses a modified PLL lock sequence compared to MSM8974, which is based on the function dsi_pll_enable_seq_m in the msm-3.10 kernel. Worth noting that the msm-3.10 downstream kernel also will try other sequences in case this one doesn't work, but duri

Re: [Freedreno] [PATCH] drm/msm/dpu: re-introduce dpu core revision to the catalog

2023-06-03 Thread Dmitry Baryshkov
On 31/05/2023 21:25, Abhinav Kumar wrote: On 5/31/2023 3:07 AM, Dmitry Baryshkov wrote: On 31/05/2023 06:05, Abhinav Kumar wrote: On 5/30/2023 7:53 PM, Dmitry Baryshkov wrote: On Wed, 31 May 2023 at 03:54, Abhinav Kumar wrote: With [1] dpu core revision was dropped in favor of using the

Re: [Freedreno] [PATCH v14 02/10] drm/msm/dpu: add DSC blocks to the catalog of MSM8998 and SC8180X

2023-06-03 Thread Dmitry Baryshkov
On 25/05/2023 20:40, Kuogee Hsieh wrote: From: Abhinav Kumar Some platforms have DSC blocks which have not been declared in the catalog. Complete DSC 1.1 support for all platforms by adding the missing blocks to MSM8998 and SC8180X. Changes in v9: -- add MSM8998 and SC8180x to commit title Ch

Re: [Freedreno] [PATCH] drm/msm: Use struct fb_info.screen_buffer

2023-06-03 Thread Dmitry Baryshkov
On 22/05/2023 22:17, Thomas Zimmermann wrote: The fbdev framebuffer is in system memory. Store the address in the field 'screen_buffer'. Fixes the following sparse warning. ../drivers/gpu/drm/msm/msm_fbdev.c:124:26: warning: incorrect type in assignment (different address spaces) ../drivers/gpu

Re: [Freedreno] [PATCH 3/3] drm/msm/dp: Clean up pdev/dev duplication in dp_power

2023-06-03 Thread Dmitry Baryshkov
On 21/05/2023 06:53, Bjorn Andersson wrote: On Sat, May 20, 2023 at 04:26:59AM +0300, Dmitry Baryshkov wrote: On 15/05/2023 06:02, Bjorn Andersson wrote: The dp_power module keeps track of both the DP controller's struct platform_device and struct device - with the prior pulled out of the dp_pa