[Freedreno] [PATCH v2] drm/msm/dpu: tidy up some error checking

2023-06-08 Thread Dan Carpenter
The "vsync_hz" variable is unsigned int so it can't be less than zero. The dpu_kms_get_clk_rate() function used to return a u64 but I previously changed it to return an unsigned long and zero on error so it matches clk_get_rate(). Change the "vsync_hz" type to unsigned long as well and change the

Re: [Freedreno] [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-08 Thread Dan Carpenter
On Thu, Jun 08, 2023 at 02:26:14AM +0300, Dmitry Baryshkov wrote: > On 07/06/2023 17:42, Dan Carpenter wrote: > > On Tue, Jun 06, 2023 at 10:23:46PM +0200, Marijn Suijten wrote: > > > > @@ -359,8 +359,8 @@ static void dpu_encoder_phys_cmd_tearcheck_config( > > > > * frequency divided by th

Re: [Freedreno] [PATCH v2 2/2] drm/panel: Add driver for Visionox r66451 panel

2023-06-08 Thread Neil Armstrong
Hi Jessica, On 31/05/2023 20:12, Jessica Zhang wrote: Add support for the 1080x2340 Visionox R66451 AMOLED DSI panel that comes with the Qualcomm HDK8350 display expansion pack. The panel enables display compression (DSC v1.2) by default. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/pan

Re: [Freedreno] Adreno devfreq lockdep splat with 6.3-rc2

2023-06-08 Thread Johan Hovold
Hi Rob, Have you had a chance to look at this regression yet? It prevents us from using lockdep on the X13s as it is disabled as soon as we start the GPU. On Wed, Mar 15, 2023 at 10:19:21AM +0100, Johan Hovold wrote: > > Since 6.3-rc2 (or possibly -rc1), I'm now seeing the below > devfreq-relate

Re: [Freedreno] [PATCH v2 0/2] Add support for Visionox R66451 AMOLED DSI panel

2023-06-08 Thread Neil Armstrong
Hi, On 31/05/2023 20:12, Jessica Zhang wrote: Add support for the 1080x2340 Visionox R66451 AMOLED DSI panel that comes with the Qualcomm HDK8350 display expansion pack. The driver will come with display compression (DSC v1.2) enabled by default. Signed-off-by: Jessica Zhang --- Changes in v2

Re: [Freedreno] [RFC PATCH v2 12/13] drm/msm/dpu: add support for virtual planes

2023-06-08 Thread Abhinav Kumar
On 6/7/2023 2:56 PM, Dmitry Baryshkov wrote: On 08/06/2023 00:05, Abhinav Kumar wrote: On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: Only several SSPP blocks support such features as YUV output or scaling, thus different DRM planes have different features.  Properly utilizing all planes re

Re: [Freedreno] [PATCH v5 2/5] drm/msm/dsi: Adjust pclk rate for compression

2023-06-08 Thread Marijn Suijten
Same title suggestion as earlier: s/adjust/reduce On 2023-05-22 18:08:56, Jessica Zhang wrote: > Adjust the pclk rate to divide hdisplay by the compression ratio when DSC > is enabled. > > Signed-off-by: Jessica Zhang > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 21 ++--- > 1 fi

Re: [Freedreno] [PATCH v8 01/18] dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx

2023-06-08 Thread Rob Herring
On Tue, May 30, 2023 at 03:35:09PM +0200, Konrad Dybcio wrote: > > > On 30.05.2023 14:26, Krzysztof Kozlowski wrote: > > On Mon, 29 May 2023 15:52:20 +0200, Konrad Dybcio wrote: > >> The "GMU Wrapper" is Qualcomm's name for "let's treat the GPU blocks > >> we'd normally assign to the GMU as if th

Re: [Freedreno] [PATCH v8 01/18] dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx

2023-06-08 Thread Rob Herring
On Mon, 29 May 2023 15:52:20 +0200, Konrad Dybcio wrote: > The "GMU Wrapper" is Qualcomm's name for "let's treat the GPU blocks > we'd normally assign to the GMU as if they were a part of the GMU, even > though they are not". It's a (good) software representation of the GMU_CX > and GMU_GX regist

Re: [Freedreno] [PATCH v6 10/12] iommu/arm-smmu-qcom: Sort the compatible list alphabetically

2023-06-08 Thread Will Deacon
On Tue, Jun 06, 2023 at 02:44:01PM +0200, Konrad Dybcio wrote: > It got broken at some point, fix it up. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Konrad Dybcio > --- > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --gi

Re: [Freedreno] [PATCH v6 11/12] iommu/arm-smmu-qcom: Add SM6375 DPU compatible

2023-06-08 Thread Will Deacon
On Tue, Jun 06, 2023 at 02:44:02PM +0200, Konrad Dybcio wrote: > Add the SM6375 DPU compatible to clients compatible list, as it also > needs the workarounds. > > Acked-by: Dmitry Baryshkov > Signed-off-by: Konrad Dybcio > --- > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + > 1 file changed

Re: [Freedreno] [PATCH v6 12/12] iommu/arm-smmu-qcom: Add SM6350 DPU compatible

2023-06-08 Thread Will Deacon
On Tue, Jun 06, 2023 at 02:44:03PM +0200, Konrad Dybcio wrote: > From: Konrad Dybcio > > Add the SM6350 DPU compatible to clients compatible list, as it also > needs the workarounds. > > Signed-off-by: Konrad Dybcio > Acked-by: Dmitry Baryshkov > Signed-off-by: Konrad Dybcio > --- > drivers/

Re: [Freedreno] Adreno devfreq lockdep splat with 6.3-rc2

2023-06-08 Thread Rob Clark
On Thu, Jun 8, 2023 at 7:12 AM Johan Hovold wrote: > > Hi Rob, > > Have you had a chance to look at this regression yet? It prevents us > from using lockdep on the X13s as it is disabled as soon as we start > the GPU. Hmm, curious what is different between x13s and sc7180/sc7280 things? Or did lo

Re: [Freedreno] [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-06-08 Thread Doug Anderson
Hi, On Thu, Jun 8, 2023 at 10:19 AM Tomi Valkeinen wrote: > > On 08/06/2023 19:26, Laurent Pinchart wrote: > > Hi Doug, > > > > On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: > >> On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König wrote: > >>> On Sun, May 07, 2023 at 06:25:23PM +0200

Re: [Freedreno] [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-06-08 Thread Doug Anderson
Hi, On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König wrote: > > Hello, > > On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-König wrote: > > this patch series adapts the platform drivers below drivers/gpu/drm > > to use the .remove_new() callback. Compared to the traditional .remove() > > call

Re: [Freedreno] [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-06-08 Thread Laurent Pinchart
Hi Doug, On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: > On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König wrote: > > On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-König wrote: > > > this patch series adapts the platform drivers below drivers/gpu/drm > > > to use the .remove_

Re: [Freedreno] [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-06-08 Thread Doug Anderson
Hi, On Thu, Jun 8, 2023 at 9:26 AM Laurent Pinchart wrote: > > > The following ones appeared to apply to the top of drm-misc-next, but > > I didn't apply them since get_maintainer didn't say they were part of > > drm-misc-next: > > > > drm/tiny: Convert to platform remove callback returning void

Re: [Freedreno] [PATCH 00/53] drm: Convert to platform remove callback returning void

2023-06-08 Thread Tomi Valkeinen
On 08/06/2023 19:26, Laurent Pinchart wrote: Hi Doug, On Thu, Jun 08, 2023 at 09:08:15AM -0700, Doug Anderson wrote: On Thu, Jun 1, 2023 at 8:40 AM Uwe Kleine-König wrote: On Sun, May 07, 2023 at 06:25:23PM +0200, Uwe Kleine-König wrote: this patch series adapts the platform drivers below dri

Re: [Freedreno] [PATCH v5 2/5] drm/msm/dsi: Adjust pclk rate for compression

2023-06-08 Thread Jessica Zhang
On 6/8/2023 1:36 PM, Marijn Suijten wrote: Same title suggestion as earlier: s/adjust/reduce Hi Marijn, Acked. On 2023-05-22 18:08:56, Jessica Zhang wrote: Adjust the pclk rate to divide hdisplay by the compression ratio when DSC is enabled. Signed-off-by: Jessica Zhang --- drivers/

Re: [Freedreno] [PATCH v5 2/5] drm/msm/dsi: Adjust pclk rate for compression

2023-06-08 Thread Abhinav Kumar
On 6/8/2023 5:56 PM, Jessica Zhang wrote: On 6/8/2023 1:36 PM, Marijn Suijten wrote: Same title suggestion as earlier: s/adjust/reduce Hi Marijn, Acked. On 2023-05-22 18:08:56, Jessica Zhang wrote: Adjust the pclk rate to divide hdisplay by the compression ratio when DSC is enabled.

[Freedreno] [pull] drm/msm: drm-msm-fixes-2023-06-08 for v6.4-rc6 [resend]

2023-06-08 Thread Rob Clark
Hi Dave, (retry of previous PR with missing s-o-b corrected but otherwise identical) A few late fixes for v6.4.. meant to send this out last week but got distracted setting my new x13s. The following changes since commit 5c054db54c43a5fcb5cc81012361f5e3fac37637: drm/msm: Be more shouty if per

Re: [Freedreno] Adreno devfreq lockdep splat with 6.3-rc2

2023-06-08 Thread Johan Hovold
On Thu, Jun 08, 2023 at 02:17:45PM -0700, Rob Clark wrote: > On Thu, Jun 8, 2023 at 7:12 AM Johan Hovold wrote: > > Have you had a chance to look at this regression yet? It prevents us > > from using lockdep on the X13s as it is disabled as soon as we start > > the GPU. > > Hmm, curious what is