Re: [Freedreno] [PATCH v2 0/4] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-09-19 Thread Bjorn Andersson
On Thu, 17 Aug 2023 17:59:36 +0300, Dmitry Baryshkov wrote: > Implement DisplayPort support for the Qualcomm RB5 platform. > > Note: while testing this, I had link training issues with several > dongles with DP connectors. Other DisplayPort-USB-C dongles (with HDMI > or VGA connectors) work perf

Re: [Freedreno] (subset) [PATCH 0/5] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-09-19 Thread Bjorn Andersson
On Sun, 09 Jul 2023 07:19:21 +0300, Dmitry Baryshkov wrote: > Implement DisplayPort support for the Qualcomm RB5 platform. > > Note: while testing this, I had link training issues with several > dongles with DP connectors. Other DisplayPort-USB-C dongles (with HDMI > or VGA connectors) work perf

Re: [Freedreno] [PATCH v2 1/4] arm64: dts: qcom: sm8250: Add DisplayPort device node

2023-09-19 Thread Bjorn Andersson
On Thu, Aug 17, 2023 at 05:59:37PM +0300, Dmitry Baryshkov wrote: > Declare the displayport controller present on the Qualcomm SM8250 SoC. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 89 > 1 file changed, 89 insertions(+) > > d

[Freedreno] [PATCH v6 4/6] drm/drm_file: Add DRM obj's RSS reporting function for fdinfo

2023-09-19 Thread Adrián Larumbe
Some BO's might be mapped onto physical memory chunkwise and on demand, like Panfrost's tiler heap. In this case, even though the drm_gem_shmem_object page array might already be allocated, only a very small fraction of the BO is currently backed by system memory, but drm_show_memory_stats will the

[Freedreno] [PATCH v6 5/6] drm/panfrost: Implement generic DRM object RSS reporting function

2023-09-19 Thread Adrián Larumbe
BO's RSS is updated every time new pages are allocated on demand and mapped for the object at GPU page fault's IRQ handler, but only for heap buffers. The reason this is unnecessary for non-heap buffers is that they are mapped onto the GPU's VA space and backed by physical memory in their entirety

[Freedreno] [PATCH v6 0/6] Add fdinfo support to Panfrost

2023-09-19 Thread Adrián Larumbe
This patch series adds fdinfo support to the Panfrost DRM driver. It will display a series of key:value pairs under /proc/pid/fdinfo/fd for render processes that open the Panfrost DRM file. The pairs contain basic drm gpu engine and memory region information that can either be cat by a privileged

[Freedreno] [PATCH v6 2/6] drm/panfrost: Add fdinfo support GPU load metrics

2023-09-19 Thread Adrián Larumbe
The drm-stats fdinfo tags made available to user space are drm-engine, drm-cycles, drm-max-freq and drm-curfreq, one per job slot. This deviates from standard practice in other DRM drivers, where a single set of key:value pairs is provided for the whole render engine. However, Panfrost has separat

[Freedreno] [PATCH v6 6/6] drm/drm-file: Show finer-grained BO sizes in drm_show_memory_stats

2023-09-19 Thread Adrián Larumbe
The current implementation will try to pick the highest available size display unit as soon as the BO size exceeds that of the previous multiplier. That can lead to loss of precision in contexts of low memory usage. The new selection criteria try to preserve precision, whilst also increasing the d

[Freedreno] [PATCH v6 3/6] drm/panfrost: Add fdinfo support for memory stats

2023-09-19 Thread Adrián Larumbe
A new DRM GEM object function is added so that drm_show_memory_stats can provide more accurate memory usage numbers. Ideally, in panfrost_gem_status, the BO's purgeable flag would be checked after locking the driver's shrinker mutex, but drm_show_memory_stats takes over the drm file's object handl

[Freedreno] [PATCH v6 1/6] drm/panfrost: Add cycle count GPU register definitions

2023-09-19 Thread Adrián Larumbe
These GPU registers will be used when programming the cycle counter, which we need for providing accurate fdinfo drm-cycles values to user space. Signed-off-by: Adrián Larumbe Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_regs.h | 5 + 1 file

Re: [Freedreno] (subset) [PATCH v4 00/17] drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel

2023-09-19 Thread Bjorn Andersson
On Sun, 23 Jul 2023 18:08:38 +0200, Marijn Suijten wrote: > Bring up the SM6125 DPU now that all preliminary series (such as INTF > TE) have been merged (for me to test the hardware properly), and most > other conflicting work (barring ongoing catalog *improvements*) has made > its way in as well

Re: [Freedreno] [PATCH] drm: remove drm_bridge_hpd_disable() from drm_bridge_connector_destroy()

2023-09-19 Thread Abhinav Kumar
Hi Laurent On 9/19/2023 11:12 AM, Laurent Pinchart wrote: Hi Abhinav, Thank you for the patch. On Tue, Sep 19, 2023 at 10:48:12AM -0700, Abhinav Kumar wrote: drm_bridge_hpd_enable()/drm_bridge_hpd_disable() callbacks call into the respective driver's hpd_enable()/hpd_disable() ops. These ops

Re: [Freedreno] [PATCH] drm: remove drm_bridge_hpd_disable() from drm_bridge_connector_destroy()

2023-09-19 Thread Laurent Pinchart
Hi Abhinav, Thank you for the patch. On Tue, Sep 19, 2023 at 10:48:12AM -0700, Abhinav Kumar wrote: > drm_bridge_hpd_enable()/drm_bridge_hpd_disable() callbacks call into > the respective driver's hpd_enable()/hpd_disable() ops. These ops control > the HPD enable/disable logic which in some cases

[Freedreno] [PATCH] drm: remove drm_bridge_hpd_disable() from drm_bridge_connector_destroy()

2023-09-19 Thread Abhinav Kumar
drm_bridge_hpd_enable()/drm_bridge_hpd_disable() callbacks call into the respective driver's hpd_enable()/hpd_disable() ops. These ops control the HPD enable/disable logic which in some cases like MSM can be a dedicate hardware block to control the HPD. During probe_defer cases, a connector can be

Re: [Freedreno] [PATCH v3 6/7] drm/msm/dp: add pm_runtime_force_suspend()/resume()

2023-09-19 Thread Dmitry Baryshkov
On Mon, 18 Sept 2023 at 20:48, Kuogee Hsieh wrote: > > > On 9/15/2023 6:21 PM, Dmitry Baryshkov wrote: > > On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: > >> Add pm_runtime_force_suspend()/resume() to complete incorporating pm > >> runtime framework into DP driver. Both dp_pm_prepare() and d

Re: [Freedreno] [PATCH v3 3/7] drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes

2023-09-19 Thread Dmitry Baryshkov
On Mon, 18 Sept 2023 at 23:16, Kuogee Hsieh wrote: > > > On 9/15/2023 5:41 PM, Dmitry Baryshkov wrote: > > On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: > >> Currently DP driver use drm_helper_hpd_irq_event(), bypassing drm bridge > >> framework, to report HPD status changes to user space fr

Re: [Freedreno] [PATCH v3 2/7] drm/msm/dp: replace is_connected with link_ready

2023-09-19 Thread Dmitry Baryshkov
On Mon, 18 Sept 2023 at 20:09, Kuogee Hsieh wrote: > > > On 9/15/2023 6:51 PM, Dmitry Baryshkov wrote: > > On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: > >> The is_connected flag is set to true after DP mainlink successfully > >> finish link training. Replace the is_connected flag with link

Re: [Freedreno] [PATCH v3 1/7] drm/msm/dp: tie dp_display_irq_handler() with dp driver

2023-09-19 Thread Dmitry Baryshkov
On Mon, 18 Sept 2023 at 20:03, Kuogee Hsieh wrote: > > > On 9/15/2023 5:29 PM, Dmitry Baryshkov wrote: > > On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote: > >> Currently the dp_display_irq_handler() is executed at msm_dp_modeset_init() > >> which ties irq registration to the DPU device's life