Re: [Freedreno] [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Michael Walle
I'm facing similar issues with the tc358775 bridge. This bridge needs to release its reset while both clock and data lanes are in LP-11 mode. But then it needs to be configured (via I2C) while the clock lane is in enabled (HS mode), but the data lanes are still in LP-11 mode. This is quite an

Re: [Freedreno] [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Michael Walle
>> >> > DSI device lifetime has three different stages: >> >> > 1. before the DSI link being powered up and clocking, >> >> > 2. when the DSI link is in LP state (for the purpose of this question, >> >> > this is the time between the DSI link being powered up and the video >> >> > stream start)

Re: [Freedreno] [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Dmitry Baryshkov
On Wed, 29 Nov 2023 at 00:20, Michael Walle wrote: > > [sorry I fat fingered my former reply and converted all CCs to BCCs..] > > >> >> >> > DSI device lifetime has three different stages: > >> >> >> > 1. before the DSI link being powered up and clocking, > >> >> >> > 2. when the DSI link is in

Re: [Freedreno] [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Michael Walle
[sorry I fat fingered my former reply and converted all CCs to BCCs..] >> >> > DSI device lifetime has three different stages: >> >> > 1. before the DSI link being powered up and clocking, >> >> > 2. when the DSI link is in LP state (for the purpose of this question, >> >> > this is the time

Re: [Freedreno] [PATCH] drm/msm/dpu: Capture dpu snapshot when frame_done_timer timeouts

2023-11-28 Thread Dmitry Baryshkov
On Tue, 28 Nov 2023 at 19:43, Paloma Arellano wrote: > > > On 11/27/2023 5:48 PM, Dmitry Baryshkov wrote: > > On Tue, 28 Nov 2023 at 03:12, Paloma Arellano > > wrote: > >> Trigger a devcoredump to dump dpu registers and capture the drm atomic > >> state when the frame_done_timer timeouts. > >>

Re: [Freedreno] [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Dmitry Baryshkov
On Tue, 28 Nov 2023 at 21:50, Michael Walle wrote: > > >> >> > DSI device lifetime has three different stages: > >> >> > 1. before the DSI link being powered up and clocking, > >> >> > 2. when the DSI link is in LP state (for the purpose of this question, > >> >> > this is the time between the

Re: [Freedreno] [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Michael Walle
>> >> > DSI device lifetime has three different stages: >> >> > 1. before the DSI link being powered up and clocking, >> >> > 2. when the DSI link is in LP state (for the purpose of this question, >> >> > this is the time between the DSI link being powered up and the video >> >> > stream start) >>

[Freedreno] [PATCH] drm/msm/gpu: Fix null-pointer dereference in zap_shader_load_mdt

2023-11-28 Thread Kunwu Chan
kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Ensure the allocation was successful by checking the pointer validity. Fixes: a9e2559c931d ("drm/msm/gpu: Move zap shader loading to adreno") Signed-off-by: Kunwu Chan ---

Re: [Freedreno] [PATCH] drm/msm/dpu: Capture dpu snapshot when frame_done_timer timeouts

2023-11-28 Thread Paloma Arellano
On 11/27/2023 5:48 PM, Dmitry Baryshkov wrote: On Tue, 28 Nov 2023 at 03:12, Paloma Arellano wrote: Trigger a devcoredump to dump dpu registers and capture the drm atomic state when the frame_done_timer timeouts. Signed-off-by: Paloma Arellano ---

Re: [Freedreno] [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Dmitry Baryshkov
On Tue, 28 Nov 2023 at 18:56, Michael Walle wrote: > > >> > DSI device lifetime has three different stages: > >> > 1. before the DSI link being powered up and clocking, > >> > 2. when the DSI link is in LP state (for the purpose of this question, > >> > this is the time between the DSI link being

Re: [Freedreno] [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Michael Walle
> DSI device lifetime has three different stages: > 1. before the DSI link being powered up and clocking, > 2. when the DSI link is in LP state (for the purpose of this question, > this is the time between the DSI link being powered up and the video > stream start) > 3. when the DSI link is in HS

Re: [Freedreno] [RFC PATCH 03/10] drm/mipi-dsi: add API for manual control over the DSI link power state

2023-11-28 Thread Dmitry Baryshkov
On Mon, 27 Nov 2023 at 18:07, Michael Walle wrote: > > Hi, > > > DSI device lifetime has three different stages: > > 1. before the DSI link being powered up and clocking, > > 2. when the DSI link is in LP state (for the purpose of this question, > > this is the time between the DSI link being

Re: [Freedreno] [PATCH v2 05/12] iommu/arm-smmu-qcom: Add QCM2290 DPU compatible

2023-11-28 Thread Dmitry Baryshkov
On 27/11/2023 17:28, Konrad Dybcio wrote: Add the QCM2290 DPU compatible to clients compatible list, as it also needs the workarounds. Nit: MDSS, not DPU compatible With that fixed: Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio ---

Re: [Freedreno] [PATCH v2 08/12] arm64: dts: qcom: qcm2290: Add display nodes

2023-11-28 Thread Dmitry Baryshkov
On 27/11/2023 17:28, Konrad Dybcio wrote: Add the required nodes to support display on QCM2290. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qcm2290.dtsi | 214 ++ 1 file changed, 214 insertions(+) Reviewed-by: Dmitry Baryshkov -- With best

Re: [Freedreno] [PATCH v2 09/12] arm64: dts: qcom: qcm2290: Hook up interconnects

2023-11-28 Thread Dmitry Baryshkov
On 27/11/2023 17:28, Konrad Dybcio wrote: Add interconnect provider nodes and hook up interconnects to consumer devices, including bwmon. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qcm2290.dtsi | 248 ++ 1 file changed, 248 insertions(+)

Re: [Freedreno] [PATCH v2 10/12] arm64: dts: qcom: qrb2210-rb1: Set up HDMI

2023-11-28 Thread Dmitry Baryshkov
On 27/11/2023 17:28, Konrad Dybcio wrote: Add the required nodes to support display output via the HDMI port. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 86 1 file changed, 86 insertions(+) Reviewed-by: Dmitry Baryshkov

Re: [Freedreno] [PATCH v2 12/12] arm64: dts: qcom: qrb2210-rb1: add wifi variant property

2023-11-28 Thread Dmitry Baryshkov
On 27/11/2023 17:28, Konrad Dybcio wrote: From: Dmitry Baryshkov The RB1 platform doesn't have board-specific board-id programmed, it uses generic 0xff. Thus add the property with the 'variant' of the calibration data. Note: the driver will check for the calibration data for the following

Re: [Freedreno] [PATCH v2 02/12] dt-bindings: display: msm: Add reg bus and rotator interconnects

2023-11-28 Thread Krzysztof Kozlowski
On 27/11/2023 16:28, Konrad Dybcio wrote: > Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there are > other connection paths: > - a path that connects rotator block to the DDR. > - a path that needs to be handled to ensure MDSS register access > functions properly, namely the "reg

Re: [Freedreno] [PATCH v2 01/12] dt-bindings: display: msm: qcm2290-mdss: Use the non-deprecated DSI compat

2023-11-28 Thread Krzysztof Kozlowski
On 27/11/2023 16:28, Konrad Dybcio wrote: > The "qcom,dsi-ctrl-6g-qcm2290" has been deprecated in commit 0c0f65c6dd44 > ("dt-bindings: msm: dsi-controller-main: Add compatible strings for every > current SoC"), but the example hasn't been updated to reflect that. > > Fix that. Reviewed-by: