Re: [Freedreno] [PATCH v3 2/2] drm/msm/dpu: Add mutex lock in control vblank irq

2023-12-03 Thread Bjorn Andersson
On Fri, Dec 01, 2023 at 11:43:36AM -0800, Abhinav Kumar wrote: > > > On 12/1/2023 8:22 AM, Bjorn Andersson wrote: > > On Fri, Dec 01, 2023 at 10:34:50AM +0200, Dmitry Baryshkov wrote: > > > On Fri, 1 Dec 2023 at 05:47, Bjorn Andersson > > > wrote: > > > > On Thu, Nov 30, 2023 at 05:40:55PM -080

Re: [Freedreno] [PATCH] drm: improve the documentation of connector hpd ops

2023-12-03 Thread Dmitry Baryshkov
On Sun, 3 Dec 2023 at 16:24, Laurent Pinchart wrote: > > Hi Abhinav, > > Thank you for the patch (and thank to Dmitry for pinging me on IRC, this > patch got burried in my inbox). > > On Wed, Sep 20, 2023 at 01:13:58PM -0700, Abhinav Kumar wrote: > > While making the changes in [1], it was noted t

Re: [Freedreno] (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes

2023-12-03 Thread Dmitry Baryshkov
On Sun, 3 Dec 2023 at 14:15, Simon Ser wrote: > > On Saturday, December 2nd, 2023 at 22:41, Dmitry Baryshkov > wrote: > > > On Fri, 27 Oct 2023 15:32:50 -0700, Jessica Zhang wrote: > > > > > Some drivers support hardware that have optimizations for solid fill > > > planes. This series aims to ex

Re: [Freedreno] [PATCH] drm: improve the documentation of connector hpd ops

2023-12-03 Thread Laurent Pinchart
Hi Abhinav, Thank you for the patch (and thank to Dmitry for pinging me on IRC, this patch got burried in my inbox). On Wed, Sep 20, 2023 at 01:13:58PM -0700, Abhinav Kumar wrote: > While making the changes in [1], it was noted that the documentation > of the enable_hpd() and disable_hpd() does n

Re: [Freedreno] (subset) [PATCH RFC v7 00/10] Support for Solid Fill Planes

2023-12-03 Thread Simon Ser
On Saturday, December 2nd, 2023 at 22:41, Dmitry Baryshkov wrote: > On Fri, 27 Oct 2023 15:32:50 -0700, Jessica Zhang wrote: > > > Some drivers support hardware that have optimizations for solid fill > > planes. This series aims to expose these capabilities to userspace as > > some compositors

[Freedreno] [PATCH RESEND v2 0/3] drm: introduce per-encoder debugfs directory

2023-12-03 Thread Dmitry Baryshkov
Resending, patch 1 needs review from DRM core maintainers, but it got no attention since October. Each of connectors and CRTCs used by the DRM device provides debugfs directory, which is used by several standard debugfs files and can further be extended by the driver. Add such generic debugfs dire

[Freedreno] [PATCH RESEND v2 2/3] drm/bridge: migrate bridge_chains to per-encoder file

2023-12-03 Thread Dmitry Baryshkov
Instead of having a single file with all bridge chains, list bridges under a corresponding per-encoder debugfs directory. While we are at it, also slightly improve the formatting of the bridge data: split a single line entry into multiple lines, include the symbol name of the bridge funcs and add

[Freedreno] [PATCH RESEND v2 3/3] drm/msm/dpu: move encoder status to standard encoder debugfs dir

2023-12-03 Thread Dmitry Baryshkov
Now as we have standard per-encoder debugfs directory, move DPU encoder status file to that directory. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 45 +++-- 1 file changed, 6 insertions(+), 39 deletions(-) diff --git a/drivers/gpu/drm/msm/di

[Freedreno] [PATCH RESEND v2 1/3] drm/encoder: register per-encoder debugfs dir

2023-12-03 Thread Dmitry Baryshkov
Each of connectors and CRTCs used by the DRM device provides debugfs directory, which is used by several standard debugfs files and can further be extended by the driver. Add such generic debugfs directories for encoder. Reviewed-by: Neil Armstrong Signed-off-by: Dmitry Baryshkov --- drivers/gp

[Freedreno] [PATCH RESEND 4/6] drm/bridge: implement generic DP HPD bridge

2023-12-03 Thread Dmitry Baryshkov
Several USB-C controllers implement a pretty simple DRM bridge which implements just the HPD notification operations. Add special helper for creating such simple bridges. Acked-by: Neil Armstrong Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/Kconfig | 8 ++ drivers/gpu/d

[Freedreno] [PATCH RESEND 3/6] usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE

2023-12-03 Thread Dmitry Baryshkov
Switch to using the new DRM_AUX_BRIDGE helper to create the transparent DRM bridge device instead of handcoding corresponding functionality. Reviewed-by: Heikki Krogerus Acked-by: Greg Kroah-Hartman Signed-off-by: Dmitry Baryshkov --- drivers/usb/typec/mux/Kconfig | 2 +- drivers/usb/typ

[Freedreno] [PATCH RESEND 2/6] phy: qcom: qmp-combo: switch to DRM_AUX_BRIDGE

2023-12-03 Thread Dmitry Baryshkov
Switch to using the new DRM_AUX_BRIDGE helper to create the transparent DRM bridge device instead of handcoding corresponding functionality. Acked-by: Vinod Koul Signed-off-by: Dmitry Baryshkov --- drivers/phy/qualcomm/Kconfig | 2 +- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 44

[Freedreno] [PATCH RESEND 5/6] soc: qcom: pmic-glink: switch to DRM_AUX_HPD_BRIDGE

2023-12-03 Thread Dmitry Baryshkov
Use the freshly defined DRM_AUX_HPD_BRIDGE instead of open-coding the same functionality for the DRM bridge chain termination. Reviewed-by: Bjorn Andersson Acked-by: Bjorn Andersson Signed-off-by: Dmitry Baryshkov --- drivers/soc/qcom/Kconfig | 1 + drivers/soc/qcom/pmic_glink_al

[Freedreno] [PATCH RESEND 0/6] drm: simplify support for transparent DRM bridges

2023-12-03 Thread Dmitry Baryshkov
Greg, could you please ack the last patch to be merged through the drm-misc tree? You have acked patch 3, but since that time I've added patches 4-6. Supporting DP/USB-C can result in a chain of several transparent bridges (PHY, redrivers, mux, etc). All attempts to implement DP support in a diffe

[Freedreno] [PATCH RESEND 6/6] usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE

2023-12-03 Thread Dmitry Baryshkov
Use the freshly defined DRM_AUX_HPD_BRIDGE instead of open-coding the same functionality for the DRM bridge chain termination. Acked-by: Bryan O'Donoghue Signed-off-by: Dmitry Baryshkov --- drivers/usb/typec/tcpm/Kconfig| 1 + drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 41

[Freedreno] [PATCH RESEND 1/6] drm/bridge: add transparent bridge helper

2023-12-03 Thread Dmitry Baryshkov
Define a helper for creating simple transparent bridges which serve the only purpose of linking devices into the bridge chain up to the last bridge representing the connector. This is especially useful for DP/USB-C bridge chains, which can span across several devices, but do not require any additio

Re: [Freedreno] [PATCH v2 4/7] drm/msm/gem: Split out submit_unpin_objects() helper

2023-12-03 Thread Dmitry Baryshkov
On 21/11/2023 02:38, Rob Clark wrote: From: Rob Clark Untangle unpinning from unlock/unref loop. The unpin only happens in error paths so it is easier to decouple from the normal unlock path. Since we never have an intermediate state where a subset of buffers are pinned (ie. we never bail out

Re: [Freedreno] [PATCH v2 5/7] drm/msm/gem: Cleanup submit_cleanup_bo()

2023-12-03 Thread Dmitry Baryshkov
On 21/11/2023 02:38, Rob Clark wrote: From: Rob Clark Now that it only handles unlock duty, drop the superfluous arg and rename it. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_gem_submit.c | 15 +-- 1 file changed, 5 insertions(+), 10

Re: [Freedreno] [PATCH v2 1/7] drm/msm/gem: Remove "valid" tracking

2023-12-03 Thread Dmitry Baryshkov
On 21/11/2023 02:38, Rob Clark wrote: From: Rob Clark This was a small optimization for pre-soft-pin userspace. But mesa switched to soft-pin nearly 5yrs ago. So lets drop the optimization and simplify the code. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.h| 2 -- d

Re: [Freedreno] [PATCH v3] drm/msm/dpu: Capture dpu snapshot when frame_done_timer timeouts

2023-12-03 Thread Dmitry Baryshkov
On Thu, 30 Nov 2023 14:47:37 -0800, Paloma Arellano wrote: > Trigger a devcoredump to dump dpu registers and capture the drm atomic > state when the frame_done_timer timeouts. > > v2: Optimize the format in which frame_done_timeout_cnt is incremented > v3: Describe parameter frame_done_timeout_c

Re: [Freedreno] [PATCH] drm/msm/dpu: enable smartdma on sm8350

2023-12-03 Thread Dmitry Baryshkov
On Fri, 08 Sep 2023 12:33:13 -0700, Abhinav Kumar wrote: > To support high resolutions on sm8350, enable smartdma > in its catalog. > > Applied, thanks! [1/1] drm/msm/dpu: enable smartdma on sm8350 https://gitlab.freedesktop.org/lumag/msm/-/commit/921e32bf6c0c Best regards, -- Dmitry

Re: [Freedreno] [PATCH] drm/msm/dpu: Correct UBWC settings for sc8280xp

2023-12-03 Thread Dmitry Baryshkov
On Thu, 30 Nov 2023 11:21:18 -0800, Rob Clark wrote: > The UBWC settings need to match between the display and GPU. When we > updated the GPU settings, we forgot to make the corresponding update on > the display side. > > Applied, thanks! [1/1] drm/msm/dpu: Correct UBWC settings for sc8280xp

Re: [Freedreno] [PATCH] dt-bindings: display/msm: qcom, sm8250-mdss: add DisplayPort controller node

2023-12-03 Thread Dmitry Baryshkov
On Tue, 07 Nov 2023 11:36:00 +0100, Krzysztof Kozlowski wrote: > Document the DisplayPort controller node in MDSS binding, already used > in DTS: > > sm8250-xiaomi-elish-boe.dtb: display-subsystem@ae0: Unevaluated > properties are not allowed ('displayport-controller@ae9' was unexpect

Re: [Freedreno] [PATCH v9 0/7] incorporate pm runtime framework and eDP clean up

2023-12-03 Thread Dmitry Baryshkov
On Fri, 01 Dec 2023 15:19:42 -0800, Kuogee Hsieh wrote: > The purpose of this patch series is to incorporate pm runtime framework > into MSM eDP/DP driver so that eDP panel can be detected by DRM eDP panel > driver during system probe time. During incorporating procedure, original > customized pm

Re: [Freedreno] [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8180x catalog

2023-12-03 Thread Dmitry Baryshkov
On Thu, 30 Nov 2023 16:35:01 -0800, Bjorn Andersson wrote: > Similar to SC8280XP, the misconfigured SAFE logic causes rather > significant delays in __arm_smmu_tlb_sync(), resulting in poor > performance for things such as USB. > > Introduce appropriate SAFE values for SC8180X to correct this. >

Re: [Freedreno] [PATCH v3 00/12] RB1/QCM2290 features

2023-12-03 Thread Dmitry Baryshkov
On Wed, 29 Nov 2023 15:43:57 +0100, Konrad Dybcio wrote: > This series brings: > - interconnect plumbing > - display setup > > for QCM2290/QRB2210 and > > - CAN bus controller > - HDMI display > - wifi fw variant name > > [...] Applied, thanks! [01/12] dt-bindings: display: msm: qcm2290-mdss

Re: [Freedreno] [PATCH v2 0/2] DSIPHY RPM

2023-12-03 Thread Dmitry Baryshkov
On Tue, 20 Jun 2023 13:43:19 +0200, Konrad Dybcio wrote: > Some recent SoCs use power rails that we model as GENPDs to power the > DSIPHY. This series attempts to make such configurations suspendable. > > Tested on SM6375. > > Applied, thanks! [1/2] drm/msm/dsi: Use pm_runtime_resume_and_get

Re: [Freedreno] [PATCH] drm/msm/mdp4: flush vblank event on disable

2023-12-03 Thread Dmitry Baryshkov
On Tue, 28 Nov 2023 00:54:01 +0300, Dmitry Baryshkov wrote: > Flush queued events when disabling the crtc. This avoids timeouts when > we come back and wait for dependencies (like the previous frame's > flip_done). > > Applied, thanks! [1/1] drm/msm/mdp4: flush vblank event on disable h

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dpu: fail dpu_plane_atomic_check() based on mdp clk limits

2023-12-03 Thread Dmitry Baryshkov
On Mon, 11 Sep 2023 15:16:26 -0700, Abhinav Kumar wrote: > Currently, dpu_plane_atomic_check() does not check whether the > plane can process the image without exceeding the per chipset > limits for MDP clock. This leads to underflow issues because the > SSPP is not able to complete the processin

Re: [Freedreno] [PATCH 00/17] drm/msm/mdp[45]: use managed memory allocations

2023-12-03 Thread Dmitry Baryshkov
On Sat, 08 Jul 2023 04:03:50 +0300, Dmitry Baryshkov wrote: > Follow the DPU patchset ([1]) and use devm_ and drmm_ functions to > allocate long-living data structures in mdp4 and mdp5 drivers. > > [1] https://patchwork.freedesktop.org/series/120366/ > > Dmitry Baryshkov (17): > drm/msm: add

Re: [Freedreno] [PATCH] dt-bindings: display/msm: qcom, sm8150-mdss: correct DSI PHY compatible

2023-12-03 Thread Dmitry Baryshkov
On Sat, 11 Nov 2023 15:20:17 +0100, Krzysztof Kozlowski wrote: > Qualcomm SM8150 MDSS comes with a bit different 7nm DSI PHY with its own > compatible. DTS already use it: > > sa8155p-adp.dtb: display-subsystem@ae0: phy@ae94400:compatible:0: > 'qcom,dsi-phy-7nm' was expected > > Appli

Re: [Freedreno] [PATCH] drm/msm/dp: cleanup debugfs handling

2023-12-03 Thread Dmitry Baryshkov
On Thu, 19 Oct 2023 13:44:19 +0300, Dmitry Baryshkov wrote: > Currently there are two subdirs for DP debugfs files, e.g. DP-1, created > by the drm core for the connector, and the msm_dp-DP-1, created by the > DP driver itself. Merge those two, so that there are no extraneous > connector-related

Re: [Freedreno] [PATCH] drm/msm/dpu: enable SmartDMA on SM8450

2023-12-03 Thread Dmitry Baryshkov
On Mon, 09 Oct 2023 19:56:27 +0300, Dmitry Baryshkov wrote: > Enable the SmartDMA / multirect support on the SM8450 platform to > support higher resoltion modes. > > Applied, thanks! [1/1] drm/msm/dpu: enable SmartDMA on SM8450 https://gitlab.freedesktop.org/lumag/msm/-/commit/a9bd555de

Re: [Freedreno] [PATCH] drm/msm/a6xx: add QMP dependency

2023-12-03 Thread Dmitry Baryshkov
On Mon, 16 Oct 2023 22:04:03 +0200, Arnd Bergmann wrote: > When QMP is in a loadable module, the A6xx GPU driver fails to link > as built-in: > > x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function > `a6xx_gmu_resume': > a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send