Re: [PATCH v3 6/7] arm64: dts: qcom: sm8650: add GPU nodes

2024-03-11 Thread Konrad Dybcio
On 2/16/24 12:03, Neil Armstrong wrote: Add GPU nodes for the SM8650 platform. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 166 +++ 1 file changed, 166 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm

Re: [10/13] drm/fbdev-generic: Fix locking with drm_client_buffer_vmap_local()

2024-03-11 Thread Sui Jingfeng
Hi, On 2024/2/27 18:14, Thomas Zimmermann wrote: Temporarily lock the fbdev buffer object during updates to prevent memory managers from evicting/moving the buffer. Moving a buffer object while update its content results in undefined behaviour. Fbdev-generic updates its buffer object from a sh

Re: [09/13] drm/gem: Acquire reservation lock in drm_gem_{pin/unpin}()

2024-03-11 Thread Sui Jingfeng
Hi, On 2024/2/27 18:14, Thomas Zimmermann wrote: Acquire the buffer object's reservation lock in drm_gem_pin() and remove locking the drivers' GEM callbacks where necessary. Same for unpin(). DRM drivers and memory managers modified by this patch will now have correct dma-buf locking semantics

Re: [PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-11 Thread Kuogee Hsieh
On 3/8/2024 1:45 PM, Abhinav Kumar wrote: There are cases where the userspace might still send another frame after the HPD disconnect causing a modeset cycle after a disconnect. This messes the internal state machine of MSM DP driver and can lead to a crash as there can be an imbalance between

Re: [PATCH RFC v2 5/5] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2024-03-11 Thread Dmitry Baryshkov
On Mon, 11 Mar 2024 at 19:06, Maxime Ripard wrote: > > On Mon, Mar 11, 2024 at 05:55:36PM +0200, Dmitry Baryshkov wrote: > > On Mon, 11 Mar 2024 at 17:46, Maxime Ripard wrote: > > > > > > Hi, > > > > > > On Sat, Mar 09, 2024 at 12:31:32PM +0200, Dmitry Baryshkov wrote: > > > > Setup the HDMI conn

Re: [PATCH RFC v2 5/5] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2024-03-11 Thread Maxime Ripard
On Mon, Mar 11, 2024 at 05:55:36PM +0200, Dmitry Baryshkov wrote: > On Mon, 11 Mar 2024 at 17:46, Maxime Ripard wrote: > > > > Hi, > > > > On Sat, Mar 09, 2024 at 12:31:32PM +0200, Dmitry Baryshkov wrote: > > > Setup the HDMI connector on the MSM HDMI outputs. Make use of > > > atomic_check hook a

Re: drm/msm: DisplayPort hard-reset on hotplug regression in 6.8-rc1

2024-03-11 Thread Abhinav Kumar
On 3/11/2024 6:43 AM, Johan Hovold wrote: On Sat, Mar 09, 2024 at 05:30:17PM +0100, Johan Hovold wrote: On Fri, Mar 08, 2024 at 09:50:17AM -0800, Abhinav Kumar wrote: On 3/8/2024 4:43 AM, Johan Hovold wrote: For this last remaining reset with the stacktrace you have mentioned below, I do

Re: [RFC PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-11 Thread Kuogee Hsieh
On 3/6/2024 11:50 AM, Abhinav Kumar wrote: There are cases where the userspace might still send another frame after the HPD disconnect causing a modeset cycle after a disconnect. This messes the internal state machine of MSM DP driver and can lead to a crash as there can be an imbalance between

Re: [PATCH RFC v2 5/5] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2024-03-11 Thread Dmitry Baryshkov
On Mon, 11 Mar 2024 at 17:46, Maxime Ripard wrote: > > Hi, > > On Sat, Mar 09, 2024 at 12:31:32PM +0200, Dmitry Baryshkov wrote: > > Setup the HDMI connector on the MSM HDMI outputs. Make use of > > atomic_check hook and of the provided Infoframe infrastructure. > > > > Note: for now only AVI Info

Re: [PATCH RFC v2 5/5] drm/msm/hdmi: make use of the drm_connector_hdmi framework

2024-03-11 Thread Maxime Ripard
Hi, On Sat, Mar 09, 2024 at 12:31:32PM +0200, Dmitry Baryshkov wrote: > Setup the HDMI connector on the MSM HDMI outputs. Make use of > atomic_check hook and of the provided Infoframe infrastructure. > > Note: for now only AVI Infoframes are enabled. Audio Infoframes are > currenly handled separa

Re: [PATCH RFC v2 0/5] drm/msm: make use of the HDMI connector infrastructure

2024-03-11 Thread Maxime Ripard
Hi, On Sat, Mar 09, 2024 at 12:31:27PM +0200, Dmitry Baryshkov wrote: > This patchset sits on top Maxime's HDMI connector patchset ([1]). > > Currently this is an RFC exploring the interface between HDMI bridges > and HDMI connector code. This has been lightly verified on the Qualcomm > DB820c, w

Re: [PATCH RFC v2 2/5] drm/connector: hdmi: add drm_connector_hdmi_init

2024-03-11 Thread Maxime Ripard
Hi, On Sat, Mar 09, 2024 at 12:31:29PM +0200, Dmitry Baryshkov wrote: > To support connectors which do all the management on their own (like > drm_bridge_connector), add drm_connector_hdmi_init() in addition to > drmm_connector_hdmi_init(). > > Signed-off-by: Dmitry Baryshkov That's only slight

Re: drm/msm: DisplayPort hard-reset on hotplug regression in 6.8-rc1

2024-03-11 Thread Johan Hovold
On Mon, Mar 11, 2024 at 02:43:24PM +0100, Johan Hovold wrote: > So, while it may still be theoretically possible to hit the resets after > the revert, the HPD notify revert effectively "fixed" the regression in > 6.8-rc1 by removing the preconditions that now made us hit it (i.e. the > half-initia

Re: drm/msm: DisplayPort hard-reset on hotplug regression in 6.8-rc1

2024-03-11 Thread Johan Hovold
On Sat, Mar 09, 2024 at 05:30:17PM +0100, Johan Hovold wrote: > On Fri, Mar 08, 2024 at 09:50:17AM -0800, Abhinav Kumar wrote: > > On 3/8/2024 4:43 AM, Johan Hovold wrote: > > > For this last remaining reset with the stacktrace you have mentioned > > below, I do not think this was introduced due