On Wed, 27 Mar 2024 at 01:49, Abhinav Kumar wrote:
>
>
>
> On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
> > Generate DRM/MSM headers on the fly during kernel build. This removes a
> > need to push register changes to Mesa with the following manual
> > synchronization step. Existing headers will
On Wed, 27 Mar 2024 at 00:34, Abhinav Kumar wrote:
>
>
>
> On 3/26/2024 3:25 PM, Dmitry Baryshkov wrote:
> > On Wed, 27 Mar 2024 at 00:19, Abhinav Kumar
> > wrote:
> >>
> >>
> >>
> >> On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
> >>> Import the gen_headers.py script from Mesa, commit FIXME.
On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
Generate DRM/MSM headers on the fly during kernel build. This removes a
need to push register changes to Mesa with the following manual
synchronization step. Existing headers will be removed in the following
commits (split away to ease reviews).
On 3/26/2024 3:25 PM, Dmitry Baryshkov wrote:
On Wed, 27 Mar 2024 at 00:19, Abhinav Kumar wrote:
On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
Import the gen_headers.py script from Mesa, commit FIXME. This script
will be used to generate MSM register files on the fly during
compilation.
On Wed, 27 Mar 2024 at 00:19, Abhinav Kumar wrote:
>
>
>
> On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
> > Import the gen_headers.py script from Mesa, commit FIXME. This script
> > will be used to generate MSM register files on the fly during
> > compilation.
> >
> > Signed-off-by: Dmitry
On 3/26/2024 2:52 PM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 23:39, Abhinav Kumar wrote:
On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote:
In order to stop patching the mdp5 headers, import definitions for the
writeback blocks. This part is extracted from the old Rob's patch.
On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
Import the gen_headers.py script from Mesa, commit FIXME. This script
will be used to generate MSM register files on the fly during
compilation.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/registers/gen_header.py | 957
On Tue, 26 Mar 2024 at 23:39, Abhinav Kumar wrote:
>
>
>
> On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote:
> > In order to stop patching the mdp5 headers, import definitions for the
> > writeback blocks. This part is extracted from the old Rob's patch.
> >
> > Co-developed-by: Rob Clark
> >
On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote:
The mmss_cc.xml.h file describes bits of the MMSS clock controller on
APQ8064 / MSM8960 platforms. They are not used by the driver and do not
belong to the DRM MSM driver. Drop the file.
Signed-off-by: Dmitry Baryshkov
---
On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote:
The qfprom.xml.h contains definitions for the nvmem code. They are not
used in the existing code. Also if we were to use them later, we should
have used nvmem cell API instead of using these defs. Drop the file.
Signed-off-by: Dmitry Baryshkov
On 3/22/2024 3:56 PM, Dmitry Baryshkov wrote:
In order to stop patching the mdp5 headers, import definitions for the
writeback blocks. This part is extracted from the old Rob's patch.
Co-developed-by: Rob Clark
Signed-off-by: Rob Clark
Signed-off-by: Dmitry Baryshkov
---
On Tue, Mar 26, 2024 at 8:56 PM Abhinav Kumar wrote:
>
> Alright, in that case, Miguel can you please repost this with the Fixes
> tags and in a patch form.
Done at https://lore.kernel.org/lkml/20240326212324.185832-1-oj...@kernel.org/
Thanks all!
Cheers,
Miguel
Clang 14 in an (essentially) defconfig arm64 build for next-20240326
reports [1]:
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error:
variable 'out' set but not used [-Werror,-Wunused-but-set-variable]
The variable `out` in these functions is meant to compute the `target
On 26.03.2024 9:02 PM, Dmitry Baryshkov wrote:
> The number of interrupt cells for the mdss interrupt controller is 1,
> meaning there should only be one cell for the interrupt number, not two.
> Drop the second cell containing (unused) irq flags.
>
> Fixes: 494dec9b6f54 ("arm64: dts: qcom:
On 26.03.2024 9:02 PM, Dmitry Baryshkov wrote:
> The property #stream-id-cells is legacy, it is not documented as valid
> for the GPU. Drop it now.
>
> Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes")
> Signed-off-by: Dmitry Baryshkov
> ---
Reviewed-by: Konrad Dybcio
Split shared schema into per-gen and group adrenos by clocks used.
Signed-off-by: Adam Skladowski
---
.../devicetree/bindings/display/msm/gpu.yaml | 317 ++
.../bindings/display/msm/qcom,adreno-306.yaml | 115 +++
.../bindings/display/msm/qcom,adreno-330.yaml | 111 ++
Following recommendation from Dmitry Baryshkov this series split schema
into separate schemas per gpu family, as i don't really understand much
of yamls and dt-schema i decided to send this as RFC and if there
are any changes suggested i will be glad if these can be explained
to me in ELI5 format.
The number of interrupt cells for the mdss interrupt controller is 1,
meaning there should only be one cell for the interrupt number, not two.
Drop the second cell containing (unused) irq flags.
Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes")
Signed-off-by: Dmitry
DisplayPort nodes must declare the dp_p1 register space in addition to
dp_p0. Add corresponding resource to DisplayPort DT nodes.
Signed-off-by: Dmitry Baryshkov
---
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
As Qualcomm SM8150 got support for the DisplayPort, add displayport@
node as a valid child to the MDSS node.
Signed-off-by: Dmitry Baryshkov
---
.../devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git
The property #stream-id-cells is legacy, it is not documented as valid
for the GPU. Drop it now.
Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes")
Signed-off-by: Dmitry Baryshkov
---
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 1 -
1 file changed, 1 deletion(-)
diff
: 13ee4a7161b6fd938aef6688ff43b163f6d83e37
change-id: 20240326-fd-fix-schema-b91f94a95135
Best regards,
--
Dmitry Baryshkov
On 3/26/2024 12:47 PM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 21:32, Abhinav Kumar wrote:
On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar wrote:
On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:05, Miguel
On Tue, Mar 26, 2024 at 7:47 PM Dmitry Baryshkov
wrote:
>
> On Tue, 26 Mar 2024 at 21:32, Abhinav Kumar wrote:
> >
> >
> >
> > On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote:
> > > On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar
> > > wrote:
> > >>
> > >>
> > >>
> > >> On 3/26/2024 11:19 AM, Dmitry
On Tue, 26 Mar 2024 at 21:32, Abhinav Kumar wrote:
>
>
>
> On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote:
> > On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar
> > wrote:
> >>
> >>
> >>
> >> On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
> >>> On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda
> >>> wrote:
On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar wrote:
On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda
wrote:
Hi,
In today's next, I got:
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6:
Hi all.
> + error: arch/sparc/kernel/process_32.o: relocation truncated to fit:
> R_SPARC_WDISP22 against `.text': => (.fixup+0xc), (.fixup+0x4)
> + error: arch/sparc/kernel/signal_32.o: relocation truncated to fit:
> R_SPARC_WDISP22 against `.text': => (.fixup+0x18), (.fixup+0x8),
>
On Sun, Mar 24, 2024 at 08:56:52PM +0200, Abel Vesa wrote:
> Add the X1E80100 DP descs and compatible. This platform will be using
> a single compatible for both eDP and DP mode. The actual mode will
> be set based on the presence of the panel node in DT.
>
> Reviewed-by: Dmitry Baryshkov
>
On Sun, Mar 24, 2024 at 08:56:51PM +0200, Abel Vesa wrote:
> Instead of relying on different compatibles for eDP and DP, lookup
> the panel node in devicetree to figure out the connector type and
> then pass on that information to the PHY. External DP doesn't have
> a panel described in DT,
On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar wrote:
>
>
>
> On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
> > On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda
> > wrote:
> >>
> >> Hi,
> >>
> >> In today's next, I got:
> >>
> >> drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable
>
On Tue, Mar 26, 2024 at 7:31 PM Abhinav Kumar wrote:
>
> This should be fixed with https://patchwork.freedesktop.org/patch/581853/.
Ah, so in that case the `CRASHDUMP_READ` target should really be
constant, unlike in other cases in that file?
> We can pickup that one with a Fixes tag applied.
On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote:
On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda
wrote:
Hi,
In today's next, I got:
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable
'out' set but not used [-Werror,-Wunused-but-set-variable]
`out` seems to be there since
On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda
wrote:
>
> Hi,
>
> In today's next, I got:
>
> drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable
> 'out' set but not used [-Werror,-Wunused-but-set-variable]
>
> `out` seems to be there since commit 64d6255650d4 ("drm/msm: More
>
Hi,
In today's next, I got:
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable
'out' set but not used [-Werror,-Wunused-but-set-variable]
`out` seems to be there since commit 64d6255650d4 ("drm/msm: More
fully implement devcoredump for a7xx").
Untested diff below assuming
On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson wrote:
>
> From: Bjorn Andersson
>
> The dp_audio read and write operations uses members in struct dp_catalog
> for passing arguments and return values. This adds unnecessary
> complexity to the implementation, as it turns out after detangling the
>
On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson wrote:
>
> From: Bjorn Andersson
>
> dp_catalog_panel_timing_cfg() takes 4 arguments, which are passed from
> the calling function through members of struct dp_catalog.
>
> No state is maintained other than across this call, so switch to
> function
On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson wrote:
>
> From: Bjorn Andersson
>
> The dp_aux write operations takes the data to be operated on through a
> member of struct dp_catalog, rather than as an argument to the function.
>
> No state is maintained other than across the calling of the
On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson wrote:
>
> From: Bjorn Andersson
>
> The "desc" member of struct dp_panel is zero-initialized during
> allocation and never assigned, resulting in dp_ctrl_use_fixed_nvid()
> never returning true. This returned boolean value is passed around but
>
On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson wrote:
>
> From: Bjorn Andersson
>
> The members of struct dp_debug are no longer used, so the only purpose
> of this struct is as a type of the return value of dp_debug_get(), to
> signal success/error.
>
> Drop the struct in favor of signalling the
On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson wrote:
>
> From: Bjorn Andersson
>
> Throughout the Qualcomm Displayport driver a number of defines and
> struct members has become unused, but lingers in the code. Remove these.
>
> Signed-off-by: Bjorn Andersson
> ---
>
From: Bjorn Andersson
The dp_audio read and write operations uses members in struct dp_catalog
for passing arguments and return values. This adds unnecessary
complexity to the implementation, as it turns out after detangling the
logic that no state is actually held in these variables.
Clean
From: Bjorn Andersson
dp_catalog_panel_timing_cfg() takes 4 arguments, which are passed from
the calling function through members of struct dp_catalog.
No state is maintained other than across this call, so switch to
function arguments to clean up the code.
Signed-off-by: Bjorn Andersson
---
From: Bjorn Andersson
The dp_aux write operations takes the data to be operated on through a
member of struct dp_catalog, rather than as an argument to the function.
No state is maintained other than across the calling of the functions,
so replace this member with a function argument.
From: Bjorn Andersson
Throughout the Qualcomm Displayport driver a number of defines and
struct members has become unused, but lingers in the code. Remove these.
Signed-off-by: Bjorn Andersson
---
drivers/gpu/drm/msm/dp/dp_audio.c | 5 -
drivers/gpu/drm/msm/dp/dp_catalog.c | 1 -
Spring is in the air, clean out some dust that has accumulated in the
Qualcomm DP driver.
Signed-off-by: Bjorn Andersson
---
Bjorn Andersson (6):
drm/msm/dp: Drop unused dp_debug struct
drm/msm/dp: Removed fixed nvid "support"
drm/msm/dp: Remove unused defines and members
From: Bjorn Andersson
The "desc" member of struct dp_panel is zero-initialized during
allocation and never assigned, resulting in dp_ctrl_use_fixed_nvid()
never returning true. This returned boolean value is passed around but
never acted upon.
Perform constant propagation and remove the traces
From: Bjorn Andersson
The members of struct dp_debug are no longer used, so the only purpose
of this struct is as a type of the return value of dp_debug_get(), to
signal success/error.
Drop the struct in favor of signalling the result of initialization
using an int.
Signed-off-by: Bjorn
On Mon, 25 Mar 2024, Geert Uytterhoeven wrote:
Below is the list of build error/warning regressions/improvements in
v6.9-rc1[1] compared to v6.8[2].
Summarized:
- build errors: +8/-8
+ /kisskb/src/crypto/scompress.c: error: unused variable 'dst_page'
[-Werror=unused-variable]: => 174:38
48 matches
Mail list logo
