Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Abhinav Kumar
On 3/28/2024 8:23 PM, Dmitry Baryshkov wrote: On Fri, 29 Mar 2024 at 04:16, Abhinav Kumar wrote: On 3/28/2024 5:10 PM, Dmitry Baryshkov wrote: On Fri, 29 Mar 2024 at 01:42, Abhinav Kumar wrote: On 3/28/2024 3:50 PM, Dmitry Baryshkov wrote: On Thu, 28 Mar 2024 at 23:21, Abhinav

Re: [PATCH] drm/msm/dp: Remove now unused connector_type from desc

2024-03-28 Thread Dmitry Baryshkov
On Fri, 29 Mar 2024 at 06:02, Bjorn Andersson wrote: > > Now that the connector_type is dynamically determined, the > connector_type of the struct msm_dp_desc is unused. Clean it up. > > Signed-off-by: Bjorn Andersson > --- > This cleans up after, and hence depends on, >

[PATCH] drm/msm/dp: Remove now unused connector_type from desc

2024-03-28 Thread Bjorn Andersson
: 8780048e8c13990129e67c097ef580c3ae456650 change-id: 20240328-dp-connector-type-cleanup-af6501e374b3 Best regards, -- Bjorn Andersson

Re: [PATCH 1/3] drm/msm/dpu: fix DSC for DSI video mode

2024-03-28 Thread Dmitry Baryshkov
On Fri, 29 Mar 2024 at 04:47, Jun Nie wrote: > > Dmitry Baryshkov 于2024年3月28日周四 23:05写道: > > > > On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > > > > > Fix DSC timing and control configurations in DPU for DSI video mode. > > > Only compression ratio 3:1 is handled and tested. > > > > > > This

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Dmitry Baryshkov
On Fri, 29 Mar 2024 at 04:16, Abhinav Kumar wrote: > > > > On 3/28/2024 5:10 PM, Dmitry Baryshkov wrote: > > On Fri, 29 Mar 2024 at 01:42, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/28/2024 3:50 PM, Dmitry Baryshkov wrote: > >>> On Thu, 28 Mar 2024 at 23:21, Abhinav Kumar > >>> wrote:

Re: [PATCH 1/3] drm/msm/dpu: fix DSC for DSI video mode

2024-03-28 Thread Jun Nie
Dmitry Baryshkov 于2024年3月28日周四 23:05写道: > > On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > > > Fix DSC timing and control configurations in DPU for DSI video mode. > > Only compression ratio 3:1 is handled and tested. > > > > This patch is modified from patchs of Jonathan Marek. > > > >

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Abhinav Kumar
On 3/28/2024 6:46 PM, Bjorn Andersson wrote: On Thu, Mar 28, 2024 at 02:21:14PM -0700, Abhinav Kumar wrote: On 3/28/2024 1:58 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2024-03-28 13:24:34) + Johan and Bjorn for FYI On 3/28/2024 1:04 PM, Kuogee Hsieh wrote: For internal HPD case,

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Abhinav Kumar
On 3/28/2024 5:10 PM, Dmitry Baryshkov wrote: On Fri, 29 Mar 2024 at 01:42, Abhinav Kumar wrote: On 3/28/2024 3:50 PM, Dmitry Baryshkov wrote: On Thu, 28 Mar 2024 at 23:21, Abhinav Kumar wrote: On 3/28/2024 1:58 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2024-03-28 13:24:34)

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Bjorn Andersson
On Thu, Mar 28, 2024 at 02:21:14PM -0700, Abhinav Kumar wrote: > > > On 3/28/2024 1:58 PM, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2024-03-28 13:24:34) > > > + Johan and Bjorn for FYI > > > > > > On 3/28/2024 1:04 PM, Kuogee Hsieh wrote: > > > > For internal HPD case, hpd_event_thread is

Re: [PATCH v1] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-03-28 Thread Stephen Boyd
Quoting Kuogee Hsieh (2024-03-28 14:07:15) > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > index 36632fa..884973a 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > @@ -2754,6

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Dmitry Baryshkov
On Fri, 29 Mar 2024 at 01:42, Abhinav Kumar wrote: > > > > On 3/28/2024 3:50 PM, Dmitry Baryshkov wrote: > > On Thu, 28 Mar 2024 at 23:21, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/28/2024 1:58 PM, Stephen Boyd wrote: > >>> Quoting Abhinav Kumar (2024-03-28 13:24:34) > + Johan and

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Abhinav Kumar
On 3/28/2024 3:50 PM, Dmitry Baryshkov wrote: On Thu, 28 Mar 2024 at 23:21, Abhinav Kumar wrote: On 3/28/2024 1:58 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2024-03-28 13:24:34) + Johan and Bjorn for FYI On 3/28/2024 1:04 PM, Kuogee Hsieh wrote: For internal HPD case,

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 23:21, Abhinav Kumar wrote: > > > > On 3/28/2024 1:58 PM, Stephen Boyd wrote: > > Quoting Abhinav Kumar (2024-03-28 13:24:34) > >> + Johan and Bjorn for FYI > >> > >> On 3/28/2024 1:04 PM, Kuogee Hsieh wrote: > >>> For internal HPD case, hpd_event_thread is created to

Re: [PATCH v1] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 23:36, Abhinav Kumar wrote: > > > > On 3/28/2024 2:07 PM, Kuogee Hsieh wrote: > > Currently qmp_combo_dp_power_on() always return 0 in regardless of > > return value of cfg->configure_dp_phy(). This patch propagate > > return value of cfg->configure_dp_phy() all the way

Re: [PATCH v1] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-03-28 Thread Abhinav Kumar
On 3/28/2024 2:07 PM, Kuogee Hsieh wrote: Currently qmp_combo_dp_power_on() always return 0 in regardless of return value of cfg->configure_dp_phy(). This patch propagate return value of cfg->configure_dp_phy() all the way back to caller. This is good. But I am also thinking if we should

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Abhinav Kumar
On 3/28/2024 1:58 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2024-03-28 13:24:34) + Johan and Bjorn for FYI On 3/28/2024 1:04 PM, Kuogee Hsieh wrote: For internal HPD case, hpd_event_thread is created to handle HPD interrupts generated by HPD block of DP controller. It converts HPD

[PATCH v1] phy/qcom-qmp-combo: propagate correct return value at phy_power_on()

2024-03-28 Thread Kuogee Hsieh
Currently qmp_combo_dp_power_on() always return 0 in regardless of return value of cfg->configure_dp_phy(). This patch propagate return value of cfg->configure_dp_phy() all the way back to caller. Signed-off-by: Kuogee Hsieh --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 5 +++-- 1 file

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-03-28 13:24:34) > + Johan and Bjorn for FYI > > On 3/28/2024 1:04 PM, Kuogee Hsieh wrote: > > For internal HPD case, hpd_event_thread is created to handle HPD > > interrupts generated by HPD block of DP controller. It converts > > HPD interrupts into events and executed

Re: [PATCH 2/3] dt-bindings: display: msm: sm6350-mdss: document DP controller subnode

2024-03-28 Thread Rob Herring
On Thu, Mar 28, 2024 at 10:42:45AM +0100, Luca Weiss wrote: > Document the displayport controller subnode of the SM6350 MDSS. > > Signed-off-by: Luca Weiss > --- > .../devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml | 10 > ++ > 1 file changed, 10 insertions(+) > > diff

Re: [PATCH 1/3] dt-bindings: display: msm: dp-controller: document SM8250 compatible

2024-03-28 Thread Rob Herring
On Thu, 28 Mar 2024 10:42:44 +0100, Luca Weiss wrote: > Add the compatible string for the DisplayPort controller on SM6350 which > is compatible with the one on SM8350. > > Signed-off-by: Luca Weiss > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + > 1 file

Re: [PATCH v1] drm/msm/dp: assign correct DP controller ID to interface table

2024-03-28 Thread Abel Vesa
On 24-03-28 13:04:05, Kuogee Hsieh wrote: > At current x1e80100 interface table, interface #3 is wrongly > connected to DP controller #0 and interface #4 wrongly connected > to DP controller #2. Fix this problem by connect Interface #3 to > DP controller #0 and interface #4 connect to DP

Re: [PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Abhinav Kumar
+ Johan and Bjorn for FYI On 3/28/2024 1:04 PM, Kuogee Hsieh wrote: For internal HPD case, hpd_event_thread is created to handle HPD interrupts generated by HPD block of DP controller. It converts HPD interrupts into events and executed them under hpd_event_thread context. For external HPD

Re: [PATCH v1] drm/msm/dp: assign correct DP controller ID to interface table

2024-03-28 Thread Abhinav Kumar
On 3/28/2024 1:04 PM, Kuogee Hsieh wrote: At current x1e80100 interface table, interface #3 is wrongly connected to DP controller #0 and interface #4 wrongly connected to DP controller #2. Fix this problem by connect Interface #3 to DP controller #0 and interface #4 connect to DP controller

[PATCH v1] drm/msm/dp: use dp_hpd_plug_handle() and dp_hpd_unplug_handle() directly

2024-03-28 Thread Kuogee Hsieh
For internal HPD case, hpd_event_thread is created to handle HPD interrupts generated by HPD block of DP controller. It converts HPD interrupts into events and executed them under hpd_event_thread context. For external HPD case, HPD events is delivered by way of dp_bridge_hpd_notify() under thread

[PATCH v1] drm/msm/dp: assign correct DP controller ID to interface table

2024-03-28 Thread Kuogee Hsieh
At current x1e80100 interface table, interface #3 is wrongly connected to DP controller #0 and interface #4 wrongly connected to DP controller #2. Fix this problem by connect Interface #3 to DP controller #0 and interface #4 connect to DP controller #1. Also add interface #6, #7 and #8 connections

Re: [PATCH 3/3] arm64: dts: qcom: sm6350: Add DisplayPort controller

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 11:43, Luca Weiss wrote: > > Add the node for the DisplayPort controller found on the SM6350 SoC. > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/sm6350.dtsi | 88 > > 1 file changed, 88 insertions(+) > Reviewed-by:

Re: [PATCH 3/3] drm/panel: Enable DSC for Visionox VTDR6130 panel

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > Enable display compression (DSC v1.2) for 1080x2400 Visionox > VTDR6130 AMOLED DSI panel. DTS property is needed to enable DSC. > Default configuration is video mode + non-DSC for any back > compatibility. The changelog talks about the DSC only,

Re: [PATCH 2/3] dt-bindings: display: panel: visionox,vtdr6130: Add mode property

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > Add DSI mode property and compression mode property > > Signed-off-by: Jun Nie > --- > .../bindings/display/panel/visionox,vtdr6130.yaml | 8 > 1 file changed, 8 insertions(+) > > diff --git >

Re: [PATCH 1/3] drm/msm/dpu: fix DSC for DSI video mode

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > Fix DSC timing and control configurations in DPU for DSI video mode. > Only compression ratio 3:1 is handled and tested. > > This patch is modified from patchs of Jonathan Marek. > > Signed-off-by: Jun Nie This almost looks like a joke, except it

Re: [PATCH v2 1/6] drm/msm/dp: Drop unused dp_debug struct

2024-03-28 Thread Dmitry Baryshkov
On Thu, 28 Mar 2024 at 16:35, Bjorn Andersson wrote: > > From: Bjorn Andersson > > The members of struct dp_debug are no longer used, so the only purpose > of this struct is as a type of the return value of dp_debug_get(), to > signal success/error. > > Drop the struct in favor of signalling the

[PATCH v2 5/6] drm/msm/dp: Use function arguments for timing configuration

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson dp_catalog_panel_timing_cfg() takes 4 arguments, which are passed from the calling function through members of struct dp_catalog. No state is maintained other than across this call, so switch to function arguments to clean up the code. Reviewed-by: Dmitry Baryshkov

[PATCH v2 6/6] drm/msm/dp: Use function arguments for audio operations

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The dp_audio read and write operations uses members in struct dp_catalog for passing arguments and return values. This adds unnecessary complexity to the implementation, as it turns out after detangling the logic that no state is actually held in these variables. Clean

[PATCH v2 3/6] drm/msm/dp: Remove unused defines and members

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson Throughout the Qualcomm Displayport driver a number of defines and struct members has become unused, but lingers in the code. Remove these. Reviewed-by: Dmitry Baryshkov Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_audio.c | 5 -

[PATCH v2 4/6] drm/msm/dp: Use function arguments for aux writes

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The dp_aux write operations takes the data to be operated on through a member of struct dp_catalog, rather than as an argument to the function. No state is maintained other than across the calling of the functions, so replace this member with a function argument.

[PATCH v2 2/6] drm/msm/dp: Removed fixed nvid "support"

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The "desc" member of struct dp_panel is zero-initialized during allocation and never assigned, resulting in dp_ctrl_use_fixed_nvid() never returning true. This returned boolean value is passed around but never acted upon. Perform constant propagation and remove the traces

[PATCH v2 1/6] drm/msm/dp: Drop unused dp_debug struct

2024-03-28 Thread Bjorn Andersson
From: Bjorn Andersson The members of struct dp_debug are no longer used, so the only purpose of this struct is as a type of the return value of dp_debug_get(), to signal success/error. Drop the struct in favor of signalling the result of initialization using an int, then merge dp_debug_get()

[PATCH v2 0/6] drm/msm/dp: Spring cleaning

2024-03-28 Thread Bjorn Andersson
Spring is in the air, clean out some dust that has accumulated in the Qualcomm DP driver. Signed-off-by: Bjorn Andersson --- Changes in v2: - Merge dp_debug_get() and dp_debug_init() - Link to v1: https://lore.kernel.org/r/20240326-msm-dp-cleanup-v1-0-e775556ec...@quicinc.com --- Bjorn

[PATCH 3/3] drm/panel: Enable DSC for Visionox VTDR6130 panel

2024-03-28 Thread Jun Nie
Enable display compression (DSC v1.2) for 1080x2400 Visionox VTDR6130 AMOLED DSI panel. DTS property is needed to enable DSC. Default configuration is video mode + non-DSC for any back compatibility. Below modes works on SM8650. While cmd mode does not work yet. - video mode + DSC - video mode -

[PATCH 2/3] dt-bindings: display: panel: visionox, vtdr6130: Add mode property

2024-03-28 Thread Jun Nie
Add DSI mode property and compression mode property Signed-off-by: Jun Nie --- .../bindings/display/panel/visionox,vtdr6130.yaml | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml

[PATCH 1/3] drm/msm/dpu: fix DSC for DSI video mode

2024-03-28 Thread Jun Nie
Fix DSC timing and control configurations in DPU for DSI video mode. Only compression ratio 3:1 is handled and tested. This patch is modified from patchs of Jonathan Marek. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-

Re: [PATCH 1/3] dt-bindings: display: msm: dp-controller: document SM8250 compatible

2024-03-28 Thread Luca Weiss
Stupid typo in subject, should of course be SM6350, not SM8250. On Thu Mar 28, 2024 at 10:42 AM CET, Luca Weiss wrote: > Add the compatible string for the DisplayPort controller on SM6350 which > is compatible with the one on SM8350. > > Signed-off-by: Luca Weiss > --- >

[PATCH 3/3] arm64: dts: qcom: sm6350: Add DisplayPort controller

2024-03-28 Thread Luca Weiss
Add the node for the DisplayPort controller found on the SM6350 SoC. Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/qcom/sm6350.dtsi | 88 1 file changed, 88 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi

[PATCH 2/3] dt-bindings: display: msm: sm6350-mdss: document DP controller subnode

2024-03-28 Thread Luca Weiss
Document the displayport controller subnode of the SM6350 MDSS. Signed-off-by: Luca Weiss --- .../devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml

[PATCH 0/3] DisplayPort support for SM6350/SM7225

2024-03-28 Thread Luca Weiss
+ .../bindings/display/msm/qcom,sm6350-mdss.yaml | 10 +++ arch/arm64/boot/dts/qcom/sm6350.dtsi | 88 ++ 3 files changed, 99 insertions(+) --- base-commit: 871760455183dc66b3e185f8d3ed2184cc9fac25 change-id: 20240328-sm6350-dp-41238153b448 Best regards, -- Luca Weiss

[PATCH 1/3] dt-bindings: display: msm: dp-controller: document SM8250 compatible

2024-03-28 Thread Luca Weiss
Add the compatible string for the DisplayPort controller on SM6350 which is compatible with the one on SM8350. Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] drm/msm/adreno: Set highest_bank_bit for A619

2024-03-28 Thread Luca Weiss
be 14 but causes corruption at e.g. 1920x1200 on DP */ + gpu->ubwc_config.highest_bank_bit = 13; + if (adreno_is_a619_holi(gpu)) gpu->ubwc_config.highest_bank_bit = 13; --- base-commit: d5a436a7b5958caa6fc0dcda6c842f9d951be73b change-id: 20240328-a6