Re: [PATCH] drm/msm/dpu: make error messages at dpu_core_irq_register_callback() more sensible

2024-03-30 Thread Marijn Suijten
rq_idx)) { > - DPU_ERROR("invalid IRQ=[%d, %d]\n", > - DPU_IRQ_REG(irq_idx), DPU_IRQ_BIT(irq_idx)); > + DPU_ERROR("invalid IRQ=[%d, %d] irq_cb:%ps\n", > + DPU_IRQ_REG(irq_idx), DPU_IRQ_BIT(irq_idx), irq_cb);

Re: [PATCH v2 2/3] dt-bindings: display: msm: sm6350-mdss: document DP controller subnode

2024-03-30 Thread Krzysztof Kozlowski
On 29/03/2024 08:45, Luca Weiss wrote: > Document the displayport controller subnode of the SM6350 MDSS. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-03-30 Thread Krzysztof Kozlowski
On 27/03/2024 11:11, Krzysztof Kozlowski wrote: > On 26/03/2024 21:02, Dmitry Baryshkov wrote: >> As Qualcomm SM8150 got support for the DisplayPort, add displayport@ >> node as a valid child to the MDSS node. >> >> Signed-off-by: Dmitry Baryshkov >> --- > > Reviewed-by: Krzysztof Kozlowski If

Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-03-30 Thread Marijn Suijten
On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: > In case of CMD DSI panels, the vblank IRQ can be used outside of > irq_enable/irq_disable pair. This results in the following kind of Can you clarify when exactly that is? Is it via ops.control_vblank_irq in dpu_encoder_toggle_vblank_for_crtc()?

Re: [PATCH] drm/msm/dpu: make error messages at dpu_core_irq_register_callback() more sensible

2024-03-30 Thread Abhinav Kumar
On 3/29/2024 8:53 PM, Dmitry Baryshkov wrote: There is little point in using %ps to print a value known to be NULL. On the other hand it makes sense to print the callback symbol in the 'invalid IRQ' message. Correct those two error messages to make more sense. Fixes: 6893199183f8 ("drm/msm/dp

Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-03-30 Thread Abhinav Kumar
On 3/30/2024 9:49 AM, Marijn Suijten wrote: On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: In case of CMD DSI panels, the vblank IRQ can be used outside of irq_enable/irq_disable pair. This results in the following kind of Can you clarify when exactly that is? Is it via ops.control_vblank

Re: [PATCH] drm/msm/dpu: make error messages at dpu_core_irq_register_callback() more sensible

2024-03-30 Thread Marijn Suijten
> > - DPU_ERROR("invalid IRQ=[%d, %d]\n", > > - DPU_IRQ_REG(irq_idx), DPU_IRQ_BIT(irq_idx)); > > + DPU_ERROR("invalid IRQ=[%d, %d] irq_cb:%ps\n", > > + DPU_IRQ_REG(irq_idx), DPU_IRQ_BIT(irq_idx), irq_cb); > > return -EINVAL; > > } > > > > > > --- > > base-commit: 13ee4a7161b6fd938aef6688ff43b163f6d83e37 > > change-id: 20240330-dpu-irq-messages-5cf13fd7568c > > > > Best regards, > > -- > > Dmitry Baryshkov > >