Re: [PATCH v2 6/6] drm/msm/dp: Use function arguments for audio operations

2024-04-09 Thread Bjorn Andersson
On Mon, Apr 08, 2024 at 02:31:45PM -0700, Abhinav Kumar wrote: > On 3/28/2024 7:40 AM, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > The dp_audio read and write operations uses members in struct dp_catalog > > for passing arguments and return values. This adds unnecessary > > complexit

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-09 Thread Dmitry Baryshkov
On Tue, 9 Apr 2024 at 21:27, Konrad Dybcio wrote: > > > > On 4/9/24 20:15, Dmitry Baryshkov wrote: > > On Tue, Apr 09, 2024 at 08:07:56PM +0200, Konrad Dybcio wrote: > >> > >> > >> On 4/9/24 20:04, Dmitry Baryshkov wrote: > >>> On Tue, Apr 09, 2024 at 10:12:00AM -0700, Rob Clark wrote: > On T

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-09 Thread Konrad Dybcio
On 4/9/24 20:15, Dmitry Baryshkov wrote: On Tue, Apr 09, 2024 at 08:07:56PM +0200, Konrad Dybcio wrote: On 4/9/24 20:04, Dmitry Baryshkov wrote: On Tue, Apr 09, 2024 at 10:12:00AM -0700, Rob Clark wrote: On Tue, Apr 9, 2024 at 8:23 AM Dmitry Baryshkov wrote: On Tue, Apr 09, 2024 at 05:

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-09 Thread Dmitry Baryshkov
On Tue, Apr 09, 2024 at 08:07:56PM +0200, Konrad Dybcio wrote: > > > On 4/9/24 20:04, Dmitry Baryshkov wrote: > > On Tue, Apr 09, 2024 at 10:12:00AM -0700, Rob Clark wrote: > > > On Tue, Apr 9, 2024 at 8:23 AM Dmitry Baryshkov > > > wrote: > > > > > > > > On Tue, Apr 09, 2024 at 05:12:46PM +020

Re: [PATCH 5/6] drm/msm/adreno: Add speedbin data for SM8550 / A740

2024-04-09 Thread Konrad Dybcio
On 4/9/24 17:24, Dmitry Baryshkov wrote: On Tue, Apr 09, 2024 at 05:13:15PM +0200, Konrad Dybcio wrote: On 4/6/24 05:25, Dmitry Baryshkov wrote: On Fri, Apr 05, 2024 at 10:41:33AM +0200, Konrad Dybcio wrote: Add speebin data for A740, as found on SM8550 and derivative SoCs. Signed-off-by

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-09 Thread Konrad Dybcio
On 4/9/24 20:04, Dmitry Baryshkov wrote: On Tue, Apr 09, 2024 at 10:12:00AM -0700, Rob Clark wrote: On Tue, Apr 9, 2024 at 8:23 AM Dmitry Baryshkov wrote: On Tue, Apr 09, 2024 at 05:12:46PM +0200, Konrad Dybcio wrote: On 4/6/24 04:56, Dmitry Baryshkov wrote: On Fri, Apr 05, 2024 at 10:

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-09 Thread Dmitry Baryshkov
On Tue, Apr 09, 2024 at 10:12:00AM -0700, Rob Clark wrote: > On Tue, Apr 9, 2024 at 8:23 AM Dmitry Baryshkov > wrote: > > > > On Tue, Apr 09, 2024 at 05:12:46PM +0200, Konrad Dybcio wrote: > > > > > > > > > On 4/6/24 04:56, Dmitry Baryshkov wrote: > > > > On Fri, Apr 05, 2024 at 10:41:31AM +0200,

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-09 Thread Rob Clark
On Tue, Apr 9, 2024 at 8:23 AM Dmitry Baryshkov wrote: > > On Tue, Apr 09, 2024 at 05:12:46PM +0200, Konrad Dybcio wrote: > > > > > > On 4/6/24 04:56, Dmitry Baryshkov wrote: > > > On Fri, Apr 05, 2024 at 10:41:31AM +0200, Konrad Dybcio wrote: > > > > From: Neil Armstrong > > > > > > > > Usually,

Re: [PATCH 5/6] drm/msm/adreno: Add speedbin data for SM8550 / A740

2024-04-09 Thread Dmitry Baryshkov
On Tue, Apr 09, 2024 at 05:13:15PM +0200, Konrad Dybcio wrote: > > > On 4/6/24 05:25, Dmitry Baryshkov wrote: > > On Fri, Apr 05, 2024 at 10:41:33AM +0200, Konrad Dybcio wrote: > > > Add speebin data for A740, as found on SM8550 and derivative SoCs. > > > > > > Signed-off-by: Konrad Dybcio > >

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-09 Thread Dmitry Baryshkov
On Tue, Apr 09, 2024 at 05:12:46PM +0200, Konrad Dybcio wrote: > > > On 4/6/24 04:56, Dmitry Baryshkov wrote: > > On Fri, Apr 05, 2024 at 10:41:31AM +0200, Konrad Dybcio wrote: > > > From: Neil Armstrong > > > > > > Usually, speedbin 0 is the "super SKU", a.k.a the one which can clock > > > the

Re: [PATCH 2/6] soc: qcom: smem: Add pcode/fcode getters

2024-04-09 Thread Bjorn Andersson
On Fri, Apr 05, 2024 at 10:41:30AM +0200, Konrad Dybcio wrote: > Introduce getters for SoC product and feature codes and export them. > Thought I commented on this already, but I don't see my reply... Can you please elaborate on what this stuff is, such that we have a track record in the history

Re: [PATCH 5/6] drm/msm/adreno: Add speedbin data for SM8550 / A740

2024-04-09 Thread Konrad Dybcio
On 4/6/24 05:25, Dmitry Baryshkov wrote: On Fri, Apr 05, 2024 at 10:41:33AM +0200, Konrad Dybcio wrote: Add speebin data for A740, as found on SM8550 and derivative SoCs. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/adreno_device.c | 14 ++ 1 file changed, 14 i

Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value

2024-04-09 Thread Konrad Dybcio
On 4/6/24 04:56, Dmitry Baryshkov wrote: On Fri, Apr 05, 2024 at 10:41:31AM +0200, Konrad Dybcio wrote: From: Neil Armstrong Usually, speedbin 0 is the "super SKU", a.k.a the one which can clock the highest. Falling back to it when things go wrong is largely suboptimal, as more often than n

Re: [PATCH 2/6] soc: qcom: smem: Add pcode/fcode getters

2024-04-09 Thread Konrad Dybcio
On 4/6/24 04:21, Dmitry Baryshkov wrote: On Fri, Apr 05, 2024 at 10:41:30AM +0200, Konrad Dybcio wrote: Introduce getters for SoC product and feature codes and export them. Signed-off-by: Konrad Dybcio --- [...] + /* Ensure the value makes sense */ + if (raw_code >= SOCINFO

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-09 Thread Dmitry Baryshkov
On Mon, Apr 08, 2024 at 09:33:01PM -0500, Bjorn Andersson wrote: > On Tue, Apr 09, 2024 at 01:07:57AM +0300, Dmitry Baryshkov wrote: > > On Tue, 9 Apr 2024 at 00:23, Abhinav Kumar > > wrote: > > > On 4/8/2024 2:12 PM, Dmitry Baryshkov wrote: > > > > On Mon, 8 Apr 2024 at 22:43, Abhinav Kumar >

[PATCH] drm/msm/gen_header: allow skipping the validation

2024-04-09 Thread Dmitry Baryshkov
'--validate', action=argparse.BooleanOptionalAction) subparsers = parser.add_subparsers(required=True) --- base-commit: ab556156cafa24ec7de9e89bc18fa15637c21a59 change-id: 20240409-fd-fix-lxml-eecc6949f64e Best regards, -- Dmitry Baryshkov

[PATCH] drm/msm/adreno: fix CP cycles stat retrieval on a7xx

2024-04-09 Thread zan
From: Zan Dobersek a7xx_submit() should use the a7xx variant of the RBBM_PERFCTR_CP register for retrieving the CP cycles value before and after the submitted command stream execution. Signed-off-by: Zan Dobersek Fixes: af66706accdf ("drm/msm/a6xx: Add skeleton A7xx support") --- drivers/gpu/d

Re: [PATCH] drm/msm/adreno: fix CP cycles stat retrieval on a7xx

2024-04-09 Thread Konrad Dybcio
On 4/9/24 14:57, z...@falconsigh.net wrote: From: Zan Dobersek a7xx_submit() should use the a7xx variant of the RBBM_PERFCTR_CP register for retrieving the CP cycles value before and after the submitted command stream execution. Signed-off-by: Zan Dobersek Fixes: af66706accdf ("drm/msm/a6x