Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-05-03 Thread Luca Weiss
On Sun Apr 7, 2024 at 5:15 AM CEST, Dmitry Baryshkov wrote: > On Sat, 30 Mar 2024 at 18:49, Marijn Suijten > wrote: > > > > On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: > > > In case of CMD DSI panels, the vblank IRQ can be used outside of > > > irq_enable/irq_disable pair. This results in the

[PATCH 0/5] drm/msm: Support devcoredump on a750

2024-05-03 Thread Connor Abbott
This mostly involves importing the list of registers to dump from kgsl and plumbing them through. We also need to update registers from Mesa to pull in some AQE-related registers for dumping the AQE equivalents of the SQE_STAT, UCODE_DBG_INFO, and ROQ indexed registers. I tested this with msm_reco

[PATCH 1/5] drm/msm: Import a750 snapshot registers from kgsl

2024-05-03 Thread Connor Abbott
Import from kgsl commit 809ee24fe560. Signed-off-by: Connor Abbott --- .../gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h | 1426 1 file changed, 1426 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h b/drivers/gpu/drm/msm/adreno/adreno_gen7_

[PATCH 2/5] drm/msm: Fix imported a750 snapshot header for upstream

2024-05-03 Thread Connor Abbott
Add A7XX prefixes necessary because we use the same code for dumping a6xx and a7xx, fix register name prefixes for upstream, and use the upstream header. --- .../gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h | 888 +++-- 1 file changed, 454 insertions(+), 434 deletions(-) diff --

[PATCH 3/5] drm/msm: Update a6xx registers XML

2024-05-03 Thread Connor Abbott
Update to Mesa commit e82d70d472cc ("freedreno/a7xx: Add A7XX_HLSQ_DP_STR location from kgsl"). Signed-off-by: Connor Abbott --- drivers/gpu/drm/msm/registers/adreno/a6xx.xml | 47 +-- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/regi

[PATCH 5/5] drm/msm: Add devcoredump support for a750

2024-05-03 Thread Connor Abbott
Add an a750 case to the various places where we choose a list of registers. --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 64 + 1 file changed, 46 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/msm/adreno/

[PATCH 4/5] drm/msm: Adjust a7xx GBIF debugbus dumping

2024-05-03 Thread Connor Abbott
Use the kgsl-style list of indices, because this is about to change for a750 and we want to reuse the downstream header directly. --- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff -

Re: [PATCH] drm/msm/gen_header: allow skipping the validation

2024-05-03 Thread Nathan Chancellor
Hi Dmitry, On Tue, Apr 09, 2024 at 05:22:54PM +0300, Dmitry Baryshkov wrote: > We don't need to run the validation of the XML files if we are just > compiling the kernel. Skip the validation unless the user enables > corresponding Kconfig option. This removes a warning from gen_header.py > about l

[PATCH v2 0/2] drm/msm/gen_header: allow skipping the validation

2024-05-03 Thread Dmitry Baryshkov
In order to remove pointless messages regarding missing lxml, skip validation of MSM register files against the schema. Only the driver developers really care and/or can fix the files. Keep the validation enabled during one of DRM CI stages, so that we still catch errors, introduced by mistake. T

[PATCH v2 1/2] drm/msm/gen_header: allow skipping the validation

2024-05-03 Thread Dmitry Baryshkov
We don't need to run the validation of the XML files if we are just compiling the kernel. Skip the validation unless the user enables corresponding Kconfig option. This removes a warning from gen_header.py about lxml being not installed. Reported-by: Stephen Rothwell Closes: https://lore.kernel.o

[PATCH v2 2/2] drm/ci: validate drm/msm XML register files against schema

2024-05-03 Thread Dmitry Baryshkov
In order to validate drm/msm register definition files against schema, reuse the nodebugfs build step. The validation entry is guarded by the EXPERT Kconfig option and we don't want to enable that option for all the builds. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/ci/build.sh | 3 +++

Re: [PATCH v2 1/2] drm/msm/gen_header: allow skipping the validation

2024-05-03 Thread Abhinav Kumar
On 5/3/2024 11:15 AM, Dmitry Baryshkov wrote: We don't need to run the validation of the XML files if we are just compiling the kernel. Skip the validation unless the user enables corresponding Kconfig option. This removes a warning from gen_header.py about lxml being not installed. Reported-

Re: [PATCH v2 2/2] drm/ci: validate drm/msm XML register files against schema

2024-05-03 Thread Abhinav Kumar
On 5/3/2024 11:15 AM, Dmitry Baryshkov wrote: In order to validate drm/msm register definition files against schema, reuse the nodebugfs build step. The validation entry is guarded by the EXPERT Kconfig option and we don't want to enable that option for all the builds. Signed-off-by: Dmitry B

Re: [PATCH v2 2/2] drm/ci: validate drm/msm XML register files against schema

2024-05-03 Thread Dmitry Baryshkov
On Fri, 3 May 2024 at 22:42, Abhinav Kumar wrote: > > > > On 5/3/2024 11:15 AM, Dmitry Baryshkov wrote: > > In order to validate drm/msm register definition files against schema, > > reuse the nodebugfs build step. The validation entry is guarded by > > the EXPERT Kconfig option and we don't want

Re: [PATCH v2 0/2] drm/msm/gen_header: allow skipping the validation

2024-05-03 Thread Dmitry Baryshkov
On Fri, 3 May 2024 at 21:15, Dmitry Baryshkov wrote: > > In order to remove pointless messages regarding missing lxml, skip > validation of MSM register files against the schema. Only the driver > developers really care and/or can fix the files. > > Keep the validation enabled during one of DRM CI

Re: [PATCH] drm/msm/gen_header: allow skipping the validation

2024-05-03 Thread Dmitry Baryshkov
On Fri, May 03, 2024 at 09:48:12AM -0700, Nathan Chancellor wrote: > Hi Dmitry, > > On Tue, Apr 09, 2024 at 05:22:54PM +0300, Dmitry Baryshkov wrote: > > We don't need to run the validation of the XML files if we are just > > compiling the kernel. Skip the validation unless the user enables > > co

Re: [PATCH] drm/msm/dpu: fix vblank IRQ handling for command panels

2024-05-03 Thread Dmitry Baryshkov
On Fri, May 03, 2024 at 11:18:52AM +0200, Luca Weiss wrote: > On Sun Apr 7, 2024 at 5:15 AM CEST, Dmitry Baryshkov wrote: > > On Sat, 30 Mar 2024 at 18:49, Marijn Suijten > > wrote: > > > > > > On 2024-03-30 05:52:29, Dmitry Baryshkov wrote: > > > > In case of CMD DSI panels, the vblank IRQ can be

Re: [PATCH v2 2/2] drm/ci: validate drm/msm XML register files against schema

2024-05-03 Thread Abhinav Kumar
On 5/3/2024 1:20 PM, Dmitry Baryshkov wrote: On Fri, 3 May 2024 at 22:42, Abhinav Kumar wrote: On 5/3/2024 11:15 AM, Dmitry Baryshkov wrote: In order to validate drm/msm register definition files against schema, reuse the nodebugfs build step. The validation entry is guarded by the EXPER

Re: [PATCH v2 2/2] drm/ci: validate drm/msm XML register files against schema

2024-05-03 Thread Dmitry Baryshkov
On Sat, 4 May 2024 at 01:38, Abhinav Kumar wrote: > > > > On 5/3/2024 1:20 PM, Dmitry Baryshkov wrote: > > On Fri, 3 May 2024 at 22:42, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 5/3/2024 11:15 AM, Dmitry Baryshkov wrote: > >>> In order to validate drm/msm register definition files against

Re: [PATCH v2 2/2] drm/ci: validate drm/msm XML register files against schema

2024-05-03 Thread Abhinav Kumar
On 5/3/2024 5:02 PM, Dmitry Baryshkov wrote: On Sat, 4 May 2024 at 01:38, Abhinav Kumar wrote: On 5/3/2024 1:20 PM, Dmitry Baryshkov wrote: On Fri, 3 May 2024 at 22:42, Abhinav Kumar wrote: On 5/3/2024 11:15 AM, Dmitry Baryshkov wrote: In order to validate drm/msm register definiti