Re: [PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied

2024-06-25 Thread Krzysztof Kozlowski
On 26/06/2024 06:31, Dmitry Baryshkov wrote: > On Tue, Jun 25, 2024 at 04:51:27PM GMT, Rob Herring wrote: >> On Sun, Jun 23, 2024 at 02:59:30PM +0200, Krzysztof Kozlowski wrote: >>> dtschema v2024.4, v2024.5 and maybe earlier do not select device nodes for >> >> That should be just since db9c05a087

Re: [PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied

2024-06-25 Thread Dmitry Baryshkov
On Tue, Jun 25, 2024 at 04:51:27PM GMT, Rob Herring wrote: > On Sun, Jun 23, 2024 at 02:59:30PM +0200, Krzysztof Kozlowski wrote: > > dtschema v2024.4, v2024.5 and maybe earlier do not select device nodes for > > That should be just since db9c05a08709 ("validator: Rework selecting > schemas for v

Re: [PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied

2024-06-25 Thread Rob Herring
On Sun, Jun 23, 2024 at 02:59:30PM +0200, Krzysztof Kozlowski wrote: > dtschema v2024.4, v2024.5 and maybe earlier do not select device nodes for That should be just since db9c05a08709 ("validator: Rework selecting schemas for validation") AKA the 6x speed up in v2024.04. > given binding validat

Re: [PATCH v2 2/2] Revert "drm/msm/a6xx: Poll for GBIF unhalt status in hw_init"

2024-06-25 Thread Rob Clark
On Tue, Jun 25, 2024 at 1:18 PM Dmitry Baryshkov wrote: > > On Tue, 25 Jun 2024 at 21:54, Konrad Dybcio wrote: > > > > Commit c9707bcbd0f3 ("drm/msm/adreno: De-spaghettify the use of memory > > ID is not present in next it ofc wouldn't be, because it was the previous patch in this series ;-) I'

Re: [PATCH] drm/msm/a6xx: request memory region

2024-06-25 Thread Rob Clark
On Tue, Jun 25, 2024 at 1:23 PM Akhil P Oommen wrote: > > On Tue, Jun 25, 2024 at 11:03:42AM -0700, Rob Clark wrote: > On Tue, Jun 25, > 2024 at 10:59 AM Akhil P Oommen wrote: > > > > > > On Fri, Jun 21, 2024 at 02:09:58PM -0700, Rob Clark wrote: > > > > On Sat, Jun 8, 2024 at 8:44 AM Kiarash Ha

Re: [PATCH RFC v3] drm/msm/dpu: Configure DP INTF/PHY selector

2024-06-25 Thread Abhinav Kumar
On 6/25/2024 1:24 PM, Dmitry Baryshkov wrote: From: Bjorn Andersson Some platforms provides a mechanism for configuring the mapping between (one or two) DisplayPort intfs and their PHYs. In particular SC8180X requires this to be configured, since on this platform there are fewer controllers

Re: [PATCH v2 0/2] Clean up barriers

2024-06-25 Thread Akhil P Oommen
eno/a6xx_gpu.c | 14 ++ > 2 files changed, 7 insertions(+), 11 deletions(-) > --- > base-commit: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed > change-id: 20240625-adreno_barriers-29f356742418 for the whole series: Reviewed-by: Akhil P Oommen -Akhil > > Best regards, > -- > Konrad Dybcio >

[PATCH RFC v3] drm/msm/dpu: Configure DP INTF/PHY selector

2024-06-25 Thread Dmitry Baryshkov
From: Bjorn Andersson Some platforms provides a mechanism for configuring the mapping between (one or two) DisplayPort intfs and their PHYs. In particular SC8180X requires this to be configured, since on this platform there are fewer controllers than PHYs. The change implements the logic for op

Re: [PATCH] drm/msm/a6xx: request memory region

2024-06-25 Thread Akhil P Oommen
On Tue, Jun 25, 2024 at 11:03:42AM -0700, Rob Clark wrote: > On Tue, Jun 25, 2024 at 10:59 AM Akhil P Oommen wrote: > > > > On Fri, Jun 21, 2024 at 02:09:58PM -0700, Rob Clark wrote: > > > On Sat, Jun 8, 2024 at 8:44 AM Kiarash Hajian > > > wrote: > > > > > > > > The driver's memory regions are

Re: [PATCH RFC v2] drm/msm/dpu: Configure DP INTF/PHY selector

2024-06-25 Thread Abhinav Kumar
On 6/25/2024 1:20 PM, Dmitry Baryshkov wrote: On Tue, 25 Jun 2024 at 22:28, Abhinav Kumar wrote: On 6/25/2024 12:26 PM, Abhinav Kumar wrote: On 6/24/2024 6:39 PM, Abhinav Kumar wrote: On 6/13/2024 4:17 AM, Dmitry Baryshkov wrote: From: Bjorn Andersson Some platforms provides a me

Re: [PATCH RFC v2] drm/msm/dpu: Configure DP INTF/PHY selector

2024-06-25 Thread Dmitry Baryshkov
On Tue, 25 Jun 2024 at 22:28, Abhinav Kumar wrote: > > > > On 6/25/2024 12:26 PM, Abhinav Kumar wrote: > > > > > > On 6/24/2024 6:39 PM, Abhinav Kumar wrote: > >> > >> > >> On 6/13/2024 4:17 AM, Dmitry Baryshkov wrote: > >>> From: Bjorn Andersson > >>> > >>> Some platforms provides a mechanism fo

Re: [PATCH v2 2/2] Revert "drm/msm/a6xx: Poll for GBIF unhalt status in hw_init"

2024-06-25 Thread Dmitry Baryshkov
On Tue, 25 Jun 2024 at 21:54, Konrad Dybcio wrote: > > Commit c9707bcbd0f3 ("drm/msm/adreno: De-spaghettify the use of memory ID is not present in next > barriers") made some fixups relating to write arrival, ensuring that > the GPU's memory interface has *really really really* been told to come

Re: [PATCH RFC v2] drm/msm/dpu: Configure DP INTF/PHY selector

2024-06-25 Thread Abhinav Kumar
On 6/25/2024 12:26 PM, Abhinav Kumar wrote: On 6/24/2024 6:39 PM, Abhinav Kumar wrote: On 6/13/2024 4:17 AM, Dmitry Baryshkov wrote: From: Bjorn Andersson Some platforms provides a mechanism for configuring the mapping between (one or two) DisplayPort intfs and their PHYs. In particul

Re: [PATCH RFC v2] drm/msm/dpu: Configure DP INTF/PHY selector

2024-06-25 Thread Abhinav Kumar
On 6/24/2024 6:39 PM, Abhinav Kumar wrote: On 6/13/2024 4:17 AM, Dmitry Baryshkov wrote: From: Bjorn Andersson Some platforms provides a mechanism for configuring the mapping between (one or two) DisplayPort intfs and their PHYs. In particular SC8180X provides this functionality, without

[PATCH v2 2/2] Revert "drm/msm/a6xx: Poll for GBIF unhalt status in hw_init"

2024-06-25 Thread Konrad Dybcio
Commit c9707bcbd0f3 ("drm/msm/adreno: De-spaghettify the use of memory barriers") made some fixups relating to write arrival, ensuring that the GPU's memory interface has *really really really* been told to come out of reset. That in turn rendered the hacky commit being reverted no longer necessary

[PATCH v2 1/2] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-25 Thread Konrad Dybcio
Memory barriers help ensure instruction ordering, NOT time and order of actual write arrival at other observers (e.g. memory-mapped IP). On architectures employing weak memory ordering, the latter can be a giant pain point, and it has been as part of this driver. Moreover, the gpu_/gmu_ accessors

[PATCH v2 0/2] Clean up barriers

2024-06-25 Thread Konrad Dybcio
l for GBIF unhalt status in hw_init" drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 4 +--- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 14 ++ 2 files changed, 7 insertions(+), 11 deletions(-) --- base-commit: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed change-id: 20240625-adreno_barriers-29f

[PATCH v4 5/5] arm64: dts: qcom: sm8550: Wire up GPU speed bin & more OPPs

2024-06-25 Thread Konrad Dybcio
Add the speedbin masks to ensure only the desired OPPs are available on chips of a given bin. Using this, add the binned 719 MHz OPP and the non-binned 124.8 MHz. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 21 - 1 f

[PATCH v4 4/5] drm/msm/adreno: Redo the speedbin assignment

2024-06-25 Thread Konrad Dybcio
There is no need to reinvent the wheel for simple read-match-set logic. Make speedbin discovery and assignment generation independent. This implicitly removes the bogus 0x80 / BIT(7) speed bin on A5xx, which has no representation in hardware whatshowever. Signed-off-by: Konrad Dybcio --- drive

[PATCH v4 3/5] drm/msm/adreno: Define A530 speed bins explicitly

2024-06-25 Thread Konrad Dybcio
In preparation for commonizing the speedbin handling code. Reviewed-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a5xx_catalog.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a5xx_catalog.c b/drivers/gpu/drm/msm/adreno/a

[PATCH v4 2/5] drm/msm/adreno: Add speedbin data for SM8550 / A740

2024-06-25 Thread Konrad Dybcio
Add speebin data for A740, as found on SM8550 and derivative SoCs. For non-development SoCs it seems that "everything except FC_AC, FC_AF should be speedbin 1", but what the values are for said "everything" are not known, so that's an exercise left to the user.. Reviewed-by: Dmitry Baryshkov Sig

[PATCH v4 1/5] drm/msm/adreno: Implement SMEM-based speed bin

2024-06-25 Thread Konrad Dybcio
On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is abstracted through SMEM, instead of being directly available in a fuse. Add support for SMEM-based speed binning, which includes getting "feature code" and "product code" from said source and parsing them to form something that le

[PATCH v4 0/5] Add SMEM-based speedbin matching

2024-06-25 Thread Konrad Dybcio
for 8550 - Fix some checkpatch fluff (code style) - Rebase on next-20240625 Changes in v3: - Wrap the argument usage in new preprocessor macros in braces (Bjorn) - Make the SOCINFO_FC_INT_MAX define inclusive, adjust .h and .c (Bjorn) - Pick up rbs - Rebase on next-20240605 - Drop the already-applied

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-25 Thread Akhil P Oommen
On Tue, Jun 18, 2024 at 10:08:23PM +0530, Akhil P Oommen wrote: > On Tue, Jun 04, 2024 at 07:35:04PM +0200, Konrad Dybcio wrote: > > > > > > On 5/14/24 20:38, Akhil P Oommen wrote: > > > On Wed, May 08, 2024 at 07:46:31PM +0200, Konrad Dybcio wrote: > > > > Memory barriers help ensure instruction

Re: [PATCH] drm/msm/a6xx: request memory region

2024-06-25 Thread Rob Clark
On Tue, Jun 25, 2024 at 10:59 AM Akhil P Oommen wrote: > > On Fri, Jun 21, 2024 at 02:09:58PM -0700, Rob Clark wrote: > > On Sat, Jun 8, 2024 at 8:44 AM Kiarash Hajian > > wrote: > > > > > > The driver's memory regions are currently just ioremap()ed, but not > > > reserved through a request. That

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-25 Thread Akhil P Oommen
On Thu, Jun 20, 2024 at 02:04:01PM +0100, Will Deacon wrote: > On Tue, Jun 18, 2024 at 09:41:58PM +0530, Akhil P Oommen wrote: > > On Tue, Jun 04, 2024 at 03:40:56PM +0100, Will Deacon wrote: > > > On Thu, May 16, 2024 at 01:55:26PM -0500, Andrew Halaney wrote: > > > > On Thu, May 16, 2024 at 08:20

Re: [PATCH] drm/msm/a6xx: request memory region

2024-06-25 Thread Akhil P Oommen
On Fri, Jun 21, 2024 at 02:09:58PM -0700, Rob Clark wrote: > On Sat, Jun 8, 2024 at 8:44 AM Kiarash Hajian > wrote: > > > > The driver's memory regions are currently just ioremap()ed, but not > > reserved through a request. That's not a bug, but having the request is > > a little more robust. > >

Re: [PATCH v2 4/7] drm/msm/adreno: Add speedbin data for SM8550 / A740

2024-06-25 Thread Konrad Dybcio
On 25.06.2024 7:21 PM, Rob Clark wrote: > On Wed, Jun 5, 2024 at 1:10 PM Konrad Dybcio wrote: >> >> Add speebin data for A740, as found on SM8550 and derivative SoCs. >> >> Reviewed-by: Dmitry Baryshkov >> Signed-off-by: Konrad Dybcio >> --- >> drivers/gpu/drm/msm/adreno/adreno_device.c | 4 +++

Re: [PATCH v2 3/7] drm/msm/adreno: Implement SMEM-based speed bin

2024-06-25 Thread Konrad Dybcio
On 25.06.2024 7:20 PM, Rob Clark wrote: > On Wed, Jun 5, 2024 at 1:10 PM Konrad Dybcio wrote: >> [...] >> struct adreno_speedbin { >> - uint16_t fuse; >> + /* <= 16-bit for NVMEM fuses, 32b for SOCID values */ >> + uint32_t fuse; >> +/* As of SM8650, PCODE on production SoCs i

Re: [PATCH v2 4/7] drm/msm/adreno: Add speedbin data for SM8550 / A740

2024-06-25 Thread Rob Clark
On Wed, Jun 5, 2024 at 1:10 PM Konrad Dybcio wrote: > > Add speebin data for A740, as found on SM8550 and derivative SoCs. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm/adreno/adreno_device.c | 4 > 1 file changed, 4 insertions(+) > > diff --g

Re: [PATCH v2 3/7] drm/msm/adreno: Implement SMEM-based speed bin

2024-06-25 Thread Rob Clark
On Wed, Jun 5, 2024 at 1:10 PM Konrad Dybcio wrote: > > On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is > abstracted through SMEM, instead of being directly available in a fuse. > > Add support for SMEM-based speed binning, which includes getting > "feature code" and "product c

Re: [PATCH v2 0/4] dt-bindings: display/msm/gpu: few cleanups

2024-06-25 Thread Dmitry Baryshkov
On Sun, 23 Jun 2024 22:02:59 +0200, Krzysztof Kozlowski wrote: > Changes since v1: > 1. Add tags > 2. New patches #3 and #4 > 3. Drop previous patch "dt-bindings: display/msm/gpu: constrain >reg/reg-names per variant", because I need to investigate more. > > v1: dt-bindings: display/msm/gpu:

Re: [PATCH v2 1/2] drm/bridge-connector: reset the HDMI connector state

2024-06-25 Thread Dmitry Baryshkov
On Tue, Jun 25, 2024 at 05:49:54PM GMT, Maxime Ripard wrote: > On Tue, Jun 25, 2024 at 06:05:33PM GMT, Dmitry Baryshkov wrote: > > On Tue, 25 Jun 2024 at 18:02, Maxime Ripard wrote: > > > > > > Hi, > > > > > > On Sun, Jun 23, 2024 at 08:40:12AM GMT, Dmitry Baryshkov wrote: > > > > On HDMI connecto

Re: [PATCH v2 1/2] drm/bridge-connector: reset the HDMI connector state

2024-06-25 Thread Maxime Ripard
On Tue, Jun 25, 2024 at 06:05:33PM GMT, Dmitry Baryshkov wrote: > On Tue, 25 Jun 2024 at 18:02, Maxime Ripard wrote: > > > > Hi, > > > > On Sun, Jun 23, 2024 at 08:40:12AM GMT, Dmitry Baryshkov wrote: > > > On HDMI connectors which use drm_bridge_connector and DRM_BRIDGE_OP_HDMI > > > IGT chokes o

Re: [PATCH v4 1/2] iommu/io-pgtable-arm: Add way to debug pgtable walk

2024-06-25 Thread Rob Clark
On Tue, Jun 25, 2024 at 4:27 AM Will Deacon wrote: > > On Mon, Jun 24, 2024 at 08:37:26AM -0700, Rob Clark wrote: > > On Mon, Jun 24, 2024 at 8:14 AM Will Deacon wrote: > > > > > > On Thu, May 23, 2024 at 10:52:21AM -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > Add an io-pgtabl

Re: [PATCH v2 1/2] drm/bridge-connector: reset the HDMI connector state

2024-06-25 Thread Dmitry Baryshkov
On Tue, 25 Jun 2024 at 18:02, Maxime Ripard wrote: > > Hi, > > On Sun, Jun 23, 2024 at 08:40:12AM GMT, Dmitry Baryshkov wrote: > > On HDMI connectors which use drm_bridge_connector and DRM_BRIDGE_OP_HDMI > > IGT chokes on the max_bpc property in several kms_properties tests due > > to the the drm_

Re: [PATCH v2 1/2] drm/bridge-connector: reset the HDMI connector state

2024-06-25 Thread Maxime Ripard
Hi, On Sun, Jun 23, 2024 at 08:40:12AM GMT, Dmitry Baryshkov wrote: > On HDMI connectors which use drm_bridge_connector and DRM_BRIDGE_OP_HDMI > IGT chokes on the max_bpc property in several kms_properties tests due > to the the drm_bridge_connector failing to reset HDMI-related > properties. > >

Re: [PATCH v2 0/4] MSM8937 MDP/DSI PHY enablement

2024-06-25 Thread Dmitry Baryshkov
On Sun, 23 Jun 2024 22:30:35 +0200, Barnabás Czémán wrote: > This patch series adds support for the MDP and DSI PHY as found on the > MSM8937 platform. > > Applied, thanks! [1/4] dt-bindings: display/msm: qcom, mdp5: Add msm8937 compatible https://gitlab.freedesktop.org/lumag/msm/-/comm

Re: [PATCH v3] drm/msm/dpu: remove CRTC frame event callback registration

2024-06-25 Thread Dmitry Baryshkov
On Tue, 25 Jun 2024 01:38:25 +0300, Dmitry Baryshkov wrote: > The frame event callback is always set to dpu_crtc_frame_event_cb() (or > to NULL) and the data is always either the CRTC itself or NULL > (correpondingly). Thus drop the event callback registration, call the > dpu_crtc_frame_event_cb(

Re: [PATCH] drm/msm/mdp5: Remove MDP_CAP_SRC_SPLIT from msm8x53_config

2024-06-25 Thread Dmitry Baryshkov
On Mon, 24 Jun 2024 00:26:01 +0200, Barnabás Czémán wrote: > Remove MDP_CAP_SRC_SPLIT from msm8x53_config because > it is not referenced in downstream. > > Applied, thanks! [1/1] drm/msm/mdp5: Remove MDP_CAP_SRC_SPLIT from msm8x53_config https://gitlab.freedesktop.org/lumag/msm/-/commit

Re: [PATCH] drm/msm: log iommu init failure

2024-06-25 Thread Brian Masney
On Fri, Jun 21, 2024 at 2:48 AM Luca Weiss wrote: > On Fri Jun 21, 2024 at 12:47 AM CEST, Konrad Dybcio wrote: > > On 6/20/24 20:24, Dmitry Baryshkov wrote: > > > Does that mean that we will lose GPU support on MSM8974? > > > > Yeah, that was brought up on #freedreno some time ago > > Also on MSM

Re: [PATCH v2 2/2] drm/connector: automatically set immutable flag for max_bpc property

2024-06-25 Thread Dmitry Baryshkov
On Tue, Jun 25, 2024 at 03:58:25PM GMT, Maxime Ripard wrote: > On Tue, Jun 25, 2024 at 10:23:14AM GMT, Dmitry Baryshkov wrote: > > On Tue, 25 Jun 2024 at 10:19, Maxime Ripard wrote: > > > > > > Hi, > > > > > > On Tue, Jun 25, 2024 at 09:21:27AM GMT, Dmitry Baryshkov wrote: > > > > On Tue, 25 Jun 2

Re: [PATCH v2 2/2] drm/connector: automatically set immutable flag for max_bpc property

2024-06-25 Thread Maxime Ripard
On Tue, Jun 25, 2024 at 10:23:14AM GMT, Dmitry Baryshkov wrote: > On Tue, 25 Jun 2024 at 10:19, Maxime Ripard wrote: > > > > Hi, > > > > On Tue, Jun 25, 2024 at 09:21:27AM GMT, Dmitry Baryshkov wrote: > > > On Tue, 25 Jun 2024 at 01:56, Abhinav Kumar > > > wrote: > > > > > > > > > > > > > > > >

Re: [PATCH v4 1/2] iommu/io-pgtable-arm: Add way to debug pgtable walk

2024-06-25 Thread Will Deacon
On Mon, Jun 24, 2024 at 08:37:26AM -0700, Rob Clark wrote: > On Mon, Jun 24, 2024 at 8:14 AM Will Deacon wrote: > > > > On Thu, May 23, 2024 at 10:52:21AM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Add an io-pgtable method to walk the pgtable returning the raw PTEs that > > > would

Re: [PATCH v2 2/2] drm/connector: automatically set immutable flag for max_bpc property

2024-06-25 Thread Dmitry Baryshkov
On Tue, 25 Jun 2024 at 10:19, Maxime Ripard wrote: > > Hi, > > On Tue, Jun 25, 2024 at 09:21:27AM GMT, Dmitry Baryshkov wrote: > > On Tue, 25 Jun 2024 at 01:56, Abhinav Kumar > > wrote: > > > > > > > > > > > > On 6/24/2024 3:46 PM, Dmitry Baryshkov wrote: > > > > On Tue, 25 Jun 2024 at 01:39, Ab

Re: [PATCH v2 2/2] drm/connector: automatically set immutable flag for max_bpc property

2024-06-25 Thread Maxime Ripard
Hi, On Tue, Jun 25, 2024 at 09:21:27AM GMT, Dmitry Baryshkov wrote: > On Tue, 25 Jun 2024 at 01:56, Abhinav Kumar wrote: > > > > > > > > On 6/24/2024 3:46 PM, Dmitry Baryshkov wrote: > > > On Tue, 25 Jun 2024 at 01:39, Abhinav Kumar > > > wrote: > > >> > > >> + IGT dev > > >> > > >> On 6/22/202