Re: [Freedreno] [PATCH v3] drm/msm: Add syncobj support.

2020-02-06 Thread Bas Nieuwenhuizen
Hi, I'd appreciate if you could take a look at this patch. I believe I have accommodated the earlier review comments. Thank you, Bas On Fri, Jan 24, 2020 at 12:58 AM Bas Nieuwenhuizen wrote: > > This > > 1) Enables core DRM syncobj support. > 2) Adds options to the submissio

[Freedreno] [PATCH v3] drm/msm: Add syncobj support.

2020-01-23 Thread Bas Nieuwenhuizen
a cleanup issue in a failure case - Moved to a copy_from_user per syncobj v3: - Fixed a missing declaration introduced in v2 - Reworked to use ERR_PTR/PTR_ERR - Simplified failure gotos. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/msm/msm_drv.c| 6 +- drivers/gpu/drm/msm

Re: [Freedreno] [PATCH v2] drm/msm: Add syncobj support.

2020-01-23 Thread Bas Nieuwenhuizen
On Mon, Jan 20, 2020 at 5:06 PM Jordan Crouse wrote: > > On Fri, Jan 17, 2020 at 07:32:27PM +0100, Bas Nieuwenhuizen wrote: > > On Fri, Jan 17, 2020 at 7:17 PM Jordan Crouse > > wrote: > > > > > > On Fri, Jan 17, 2020 at 12:04:17AM +0100, Bas Nieuwenhuizen w

Re: [Freedreno] [PATCH v2] drm/msm: Add syncobj support.

2020-01-17 Thread Bas Nieuwenhuizen
On Fri, Jan 17, 2020 at 7:17 PM Jordan Crouse wrote: > > On Fri, Jan 17, 2020 at 12:04:17AM +0100, Bas Nieuwenhuizen wrote: > > This > > > > 1) Enables core DRM syncobj support. > > 2) Adds options to the submission ioctl to wait/signal syncobjs. > > > &

[Freedreno] [PATCH v2] drm/msm: Add syncobj support.

2020-01-16 Thread Bas Nieuwenhuizen
a cleanup issue in a failure case - Moved to a copy_from_user per syncobj Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/msm/msm_drv.c| 6 +- drivers/gpu/drm/msm/msm_gem_submit.c | 236 ++- include/uapi/drm/msm_drm.h | 24 ++- 3 files changed

Re: [Freedreno] [PATCH] drm/msm: Add syncobj support.

2020-01-13 Thread Bas Nieuwenhuizen
On Tue, Jan 14, 2020 at 12:41 AM Jordan Crouse wrote: > > On Mon, Jan 13, 2020 at 09:25:57PM +0100, Bas Nieuwenhuizen wrote: > > This > > > > 1) Enables core DRM syncobj support. > > 2) Adds options to the submission ioctl to wait/signal syncobjs. > > > &

[Freedreno] [PATCH] drm/msm: Add syncobj support.

2020-01-13 Thread Bas Nieuwenhuizen
and the interface is ready for it, but I'm not enabling it yet until there is some code for turnip to use it. The reset is mostly in there because in the presence of waiting and signalling the same semaphores, resetting them after signalling can become very annoying. Signed-off-by: Bas Nieuwenhuizen

Re: [Freedreno] [Mesa-dev] [RFC 1/4] nir: Add a new intrinsic 'load_image_stride'

2019-01-28 Thread Bas Nieuwenhuizen
On Mon, Jan 28, 2019 at 9:38 AM Eduardo Lima Mitev wrote: > > On 1/26/19 5:34 PM, Jason Ekstrand wrote: > > Mind suffixing it with _ir3 or something since it's a back-end-specific > > intrinsic? Incidentally, this looks a lot like load_image_param_intel. > > > > Yes, I felt inclined to add the