Re: [Freedreno] (subset) [PATCH v2 0/9] dt-bindings: msm/dp: cleanup Qualcomm DP and eDP bidndings

2022-07-16 Thread Bjorn Andersson
/9] arm64: dts: qcom: sc7280: drop address/size-cells from eDP node commit: 97e5c82d4e170b815fe31fb91d6639be0f1b11aa [6/9] arm64: dts: qcom: sc7280: drop unused clocks from eDP node commit: f32894b8d8b4300693f1c3549cad544799ffeb3b Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH v2 00/11] dt-bindings: display/msm: rework MDSS and DPU bindings

2022-07-16 Thread Bjorn Andersson
1d52eb6cc827d0f166c728a7577609de75b6b8b1 [02/11] arm64: dts: qcom: sc7180: rename DPU device node commit: 37e3558b79392ab864fe887b4593c5f737e063a5 [03/11] arm64: dts: qcom: sm8250: rename DPU device node commit: ce5cf986cdab1973df0042ac5b743d5df008c338 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH v2 3/9] arm64: dts: qcom: sc7280: split register block for DP controller

2022-07-16 Thread Bjorn Andersson
; Reviewed-by: Bjorn Andersson > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > b/arch/arm64/boot/dts/qcom/sc7280.dtsi >

Re: [Freedreno] [PATCH v2 1/9] arm64: dts: qcom: sc7180: split register block for DP controller

2022-07-16 Thread Bjorn Andersson
; Reviewed-by: Bjorn Andersson > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi >

[Freedreno] [PATCH] drm/msm/gpu: Drop qos request if devm_devfreq_add_device() fails

2022-07-08 Thread Bjorn Andersson
he requests in the error path. Fixes: 7c0ffcd40b16 ("drm/msm/gpu: Respect PM QoS constraints") Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/ms

Re: [Freedreno] (subset) [PATCH] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp

2022-07-06 Thread Bjorn Andersson
commit: 154fd146a446c0fffa81d72c78611b0ce26b2718 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH 5/5] arm64: dts: qcom: add mdp_clk clock to the MDSS device

2022-07-04 Thread Bjorn Andersson
SS device commit: 2e4ae611ab73d8e35d6059fc30cb4da4cd568d4c Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH] arm64: dts: qcom: msm8996: add second DSI interface

2022-07-04 Thread Bjorn Andersson
996: add second DSI interface commit: 2752bb7d9b58accbaa15bcfc50de0e41e84990d5 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH v3 14/14] arm64: dts: qcom: msm8996: drop phy-names from HDMI device node

2022-07-04 Thread Bjorn Andersson
from existing DTs. > > Applied, thanks! [14/14] arm64: dts: qcom: msm8996: drop phy-names from HDMI device node commit: 917a6de1b0a0d55c67533c5d3827ddd4388b14a5 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH v3 00/14] drm/msm/hdmi: YAML-ify schema and cleanup some platform properties

2022-07-04 Thread Bjorn Andersson
vice node commit: fe5651cc8e33b5fcdc351e36cd0cd4bff2f6192f Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH 2/2] arm64: dts: qcom: sm8250: Enable per-process page tables.

2022-07-04 Thread Bjorn Andersson
er-process page tables. commit: 213d7368723709cf4567488e63dd667802378202 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH v2 1/2] drm/msm/a6xx: Add support for a new 7c3 sku

2022-06-28 Thread Bjorn Andersson
On Tue 10 May 02:53 CDT 2022, Akhil P Oommen wrote: > Add a new sku to the fuse map of 7c3 gpu. > > Signed-off-by: Akhil P Oommen Is this series still needed/wanted? I've been waiting for patch 1 to be merged in the driver so that I can pick up the dts change. Regards, Bjorn > --- > > (no ch

Re: [Freedreno] (subset) [PATCH v7 0/5] Update mdp clk to max supported value to support higher refresh rates

2022-06-27 Thread Bjorn Andersson
641d9b9b6052b469df3c10 [4/5] arm64: dts: qcom: sdm845: remove assigned-clock-rate property for mdp clk commit: 0b24829fd74cf954b3a02e9e4c4da3c098c69fbc [5/5] arm64: dts: qcom: sm8250: remove assigned-clock-rate property for mdp clk commit: 6edb323837909462d493f22c07a38a23ef44f944 Best regards, -- Bjorn Andersson

Re: [Freedreno] (subset) [PATCH] arm64: dts: qcom: sdm845: use dispcc AHB clock for mdss node

2022-06-27 Thread Bjorn Andersson
ISP_AHB_CLK> to > <&dispcc DISP_CC_MDSS_AHB_CLK> fixes the issue. > > Applied, thanks! [1/1] arm64: dts: qcom: sdm845: use dispcc AHB clock for mdss node commit: 3ba500dee327e0261e728edec8a4f2f563d2760c Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH] drm/msm: Fix double pm_runtime_disable() call

2022-06-06 Thread Bjorn Andersson
to fix. Therefore, instead check > whether runtime PM is still enabled, and only disable it in that case. > > Fixes: 17e822f7591f ("drm/msm: fix unbalanced pm_runtime_enable in > adreno_gpu_{init, cleanup}") Tested-by: Bjorn Andersson > Signed-off-by: Maximilian Luz > --

Re: [Freedreno] [PATCH v13 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-06-06 Thread Bjorn Andersson
On Wed 25 May 14:02 PDT 2022, Kuogee Hsieh wrote: > This patch add regulator_set_load() before enable regulator at > eDP phy driver. > > Signed-off-by: Kuogee Hsieh > Reviewed-by: Douglas Anderson Reviewed-by: Bjorn Andersson > --- > drivers/phy/qualcom

Re: [Freedreno] [PATCH v8 1/3] phy: qcom-edp: add regulator_set_load to edp phy

2022-05-20 Thread Bjorn Andersson
On Fri 20 May 09:26 PDT 2022, Kuogee Hsieh wrote: > This patch add regulator_set_load() before enable regulator at > eDP phy driver. > > Signed-off-by: Kuogee Hsieh > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/phy/qualcomm/

Re: [Freedreno] [PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-02 Thread Bjorn Andersson
On Mon 02 May 15:49 PDT 2022, Kuogee Hsieh wrote: > > On 5/2/2022 3:29 PM, Bjorn Andersson wrote: > > On Mon 02 May 13:59 PDT 2022, Kuogee Hsieh wrote: > > > > > On 5/2/2022 9:53 AM, Bjorn Andersson wrote: > > > > The Qualcomm DisplayPort driver contains t

Re: [Freedreno] [PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-02 Thread Bjorn Andersson
On Mon 02 May 15:29 PDT 2022, Bjorn Andersson wrote: > On Mon 02 May 13:59 PDT 2022, Kuogee Hsieh wrote: > > > > > On 5/2/2022 9:53 AM, Bjorn Andersson wrote: > > > The Qualcomm DisplayPort driver contains traces of the necessary > > > plumbing to hook u

Re: [Freedreno] [PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-02 Thread Bjorn Andersson
On Mon 02 May 13:59 PDT 2022, Kuogee Hsieh wrote: > > On 5/2/2022 9:53 AM, Bjorn Andersson wrote: > > The Qualcomm DisplayPort driver contains traces of the necessary > > plumbing to hook up USB HPD, in the form of the dp_hpd module and the > > dp_usbpd_cb struc

[Freedreno] [PATCH v4 5/5] drm/msm/dp: Implement hpd_notify()

2022-05-02 Thread Bjorn Andersson
de in dp_drm_connector_init(). Signed-off-by: Bjorn Andersson --- Changes since v3: - Implements hpd_notify instead of oob_hotplug_event - Rebased on new cleanup patch from Dmitry - Set hpd_state to ST_MAINLINK_READY when dp_display_usbpd_configure() succeeds drivers/gpu/drm/msm/dp/dp_display.c

[Freedreno] [PATCH v4 4/5] drm/msm/dp: remove most of usbpd-related remains

2022-05-02 Thread Bjorn Andersson
rewritten into . Signed-off-by: Dmitry Baryshkov [bjorn: Cleaned up dp_display_usbpd_attention() prototype as well] Signed-off-by: Bjorn Andersson --- Changes since v3: - New patch drivers/gpu/drm/msm/Makefile| 1 - drivers/gpu/drm/msm/dp/dp_ctrl.h| 1 - drivers/gpu/drm/msm/dp

[Freedreno] [PATCH v4 3/5] drm/bridge_connector: implement oob_hotplug_event

2022-05-02 Thread Bjorn Andersson
From: Dmitry Baryshkov Implement the oob_hotplug_event() callback. Translate it to the HPD notification sent to the HPD bridge in the chain. Signed-off-by: Dmitry Baryshkov Signed-off-by: Bjorn Andersson --- Changes since v3: - New patch drivers/gpu/drm/drm_bridge_connector.c | 12

[Freedreno] [PATCH v4 2/5] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-05-02 Thread Bjorn Andersson
test for unchanged state in the displayport altmode driver into the i915 driver, to allow other drivers to act upon each update. Signed-off-by: Bjorn Andersson --- Changes since v3: - Transition to drm_connector_status instead of custom hpd_state drivers/gpu/drm/drm_connector.c

[Freedreno] [PATCH v4 0/5] drm/msm/dp: implement HPD notifications handling

2022-05-02 Thread Bjorn Andersson
liver altmode messages to the MSM DP driver. Note, I left the original 'bool connected' field to be used by the notifiers. However I think that it should be replaced in favour of using the dp->hpd_state properly. Bjorn Andersson (2): drm: Add HPD state to drm_connector_oob_hotplug_ev

[Freedreno] [PATCH v4 1/5] drm/bridge_connector: stop filtering events in drm_bridge_connector_hpd_cb()

2022-05-02 Thread Bjorn Andersson
() and let drivers decide whether they would like to receive the event or not. Signed-off-by: Dmitry Baryshkov Signed-off-by: Bjorn Andersson --- Changes since v3: - New patch, needed due to the move to drm_bridge_connector drivers/gpu/drm/drm_bridge_connector.c | 5 - 1 file changed, 5

Re: [Freedreno] [PATCH v3 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-04-22 Thread Bjorn Andersson
On Fri 22 Apr 16:07 PDT 2022, Dmitry Baryshkov wrote: > On 23/04/2022 01:32, Bjorn Andersson wrote: [..] > > diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c > > b/drivers/gpu/drm/msm/dp/dp_drm.c > > index 80f59cf99089..76904b1601b1 100644 > > --- a/drivers/gpu/drm/msm/dp

[Freedreno] [PATCH v3 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-04-22 Thread Bjorn Andersson
de in dp_drm_connector_init(). Signed-off-by: Bjorn Andersson --- Changes since v2: - Rebased patch drivers/gpu/drm/msm/dp/dp_display.c | 9 + drivers/gpu/drm/msm/dp/dp_display.h | 3 +++ drivers/gpu/drm/msm/dp/dp_drm.c | 11 +++ drivers/gpu/drm/msm/dp/dp_hpd.c

[Freedreno] [PATCH v3 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-04-22 Thread Bjorn Andersson
test for unchanged state in the displayport altmode driver into the i915 driver, to allow other drivers to act upon each update. Signed-off-by: Bjorn Andersson --- Changs since v2: - The i915 cached hpd_state is tracked per encoder. drivers/gpu/drm/drm_connector.c | 6 -- driver

[Freedreno] [PATCH v4 2/2] drm/msm/dpu: Issue MDSS reset during initialization

2022-04-20 Thread Bjorn Andersson
running OS will be a considerable effort, start by simply resetting the entire MDSS to its power-on state, to avoid the partial configuration. Signed-off-by: Bjorn Andersson --- Changes since v3: - Rebased upon the mdss dpu/mdp restructuring (https://patchwork.freedesktop.org/series/98525/) drive

[Freedreno] [PATCH v4 1/2] dt-bindings: display: msm: Add optional resets

2022-04-20 Thread Bjorn Andersson
Add an optional reference to the MDSS_CORE reset, which when specified can be used by the implementation to reset the hardware blocks. Reviewed-by: Dmitry Baryshkov Acked-by: Krzysztof Kozlowski Signed-off-by: Bjorn Andersson --- Changes since v3: - None .../devicetree/bindings/display/msm

Re: [Freedreno] [PATCH v5 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2022-04-19 Thread Bjorn Andersson
On Mon 11 Apr 13:47 PDT 2022, Sean Paul wrote: > From: Sean Paul > > This patch adds the register ranges required for HDCP key injection and > HDCP TrustZone interaction as described in the dt-bindings for the > sc7180 dp controller. Can you please mention why this is only done for trogdor and

Re: [Freedreno] [PATCH] clk: qcom: clk-rcg2: fix gfx3d frequency calculation

2022-04-19 Thread Bjorn Andersson
On Tue 19 Apr 18:54 CDT 2022, Dmitry Baryshkov wrote: > Since the commit 948fb0969eae ("clk: Always clamp the rounded rate"), > the clk_core_determine_round_nolock() would clamp the requested rate > between min and max rates from the rate request. Normally these fields > would be filled by clk_cor

Re: [Freedreno] [PATCH] clk: qcom: clk-rcg2: fix gfx3d frequency calculation

2022-04-19 Thread Bjorn Andersson
s being requested > from the hardware. > > Fix this by filling min_rate and max_rate to the values valid for the > respective PLLs (0 and ULONG_MAX). > > Fixes: 948fb0969eae ("clk: Always clamp the rounded rate") > Signed-off-by: Dmitry Baryshkov Reviewed-by: Bj

[Freedreno] [PATCH v3 2/2] drm/msm/dpu: Issue MDSS reset during initialization

2022-04-08 Thread Bjorn Andersson
running OS will be a considerable effort, start by simply resetting the entire MDSS to its power-on state, to avoid the partial configuration. Signed-off-by: Bjorn Andersson --- Changes since v2: - Move the reset before the probing of the children, to avoid issues if child drivers touched hardwar

[Freedreno] [PATCH v3 1/2] dt-bindings: display: msm: Add optional resets

2022-04-08 Thread Bjorn Andersson
Add an optional reference to the MDSS_CORE reset, which when specified can be used by the implementation to reset the hardware blocks. Signed-off-by: Bjorn Andersson --- Resending these two patches again as I put "v2" in the subject, even though I meant v3. Sorry about that. Change

[Freedreno] [PATCH v2 2/2] drm/msm/dpu: Issue MDSS reset during initialization

2022-04-08 Thread Bjorn Andersson
running OS will be a considerable effort, start by simply resetting the entire MDSS to its power-on state, to avoid the partial configuration. Signed-off-by: Bjorn Andersson --- Changes since v2: - Move the reset before the probing of the children, to avoid issues if child drivers touched hardwar

[Freedreno] [PATCH v2 1/2] dt-bindings: display: msm: Add optional resets

2022-04-08 Thread Bjorn Andersson
Add an optional reference to the MDSS_CORE reset, which when specified can be used by the implementation to reset the hardware blocks. Signed-off-by: Bjorn Andersson --- Changes since v2: - None .../devicetree/bindings/display/msm/dpu-qcm2290.yaml | 4 Documentation/devicetree

Re: [Freedreno] [PATCH v5 1/5] arm64/dts/qcom/sc7280: remove assigned-clock-rate property for mdp clk

2022-03-12 Thread Bjorn Andersson
On Tue 08 Mar 10:54 CST 2022, Vinod Polimera wrote: Please run: git log --oneline --no-decorate -- arch/arm64/boot/dts/qcom/sc7280.dtsi and make sure your $subject is prefixed according to all other sc7280-specific changes. > Kernel clock driver assumes that initial rate is the > max rate for

[Freedreno] [PATCH v2 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-03-03 Thread Bjorn Andersson
test for unchanged state in the displayport altmode driver into the i915 driver, to allow other drivers to act upon each update. Changes in v2: - Replace bool with drm_connector_hpd_state enum to represent "state" better - Track old hpd state per encoder in i915 Signed-off-by:

[Freedreno] [PATCH v2 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-03-03 Thread Bjorn Andersson
de in dp_drm_connector_init(). Changes in v2: - Adopt enum drm_connector_hpd_state Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 9 + drivers/gpu/drm/msm/dp/dp_display.h | 3 +++ drivers/gpu/drm/msm/dp/dp_drm.c | 11 +++ drivers/gpu/drm/msm/dp/dp_

Re: [Freedreno] [PATCH v3 0/6] drm/msm/dpu: simplify IRQ helpers

2022-03-03 Thread Bjorn Andersson
On Thu 03 Mar 13:22 PST 2022, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2022-02-16 20:31:42) > > This is the second part of > > https://patchwork.freedesktop.org/series/91631/ reworked and cleaned up. > > > > Changes since v1: > > v2? > > > - Fix warning ins dpu_trace.h related to > >

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dpu: Issue MDSS reset during initialization

2022-03-01 Thread Bjorn Andersson
On Tue 01 Mar 17:47 PST 2022, Dmitry Baryshkov wrote: > On Wed, 2 Mar 2022 at 04:27, Bjorn Andersson > wrote: > > > > It's typical for the bootloader to bring up the display for showing a > > boot splash or efi framebuffer. But in some cases the kernel driv

[Freedreno] [PATCH v2 2/2] drm/msm/dpu: Issue MDSS reset during initialization

2022-03-01 Thread Bjorn Andersson
running OS will be a considerable effort, start by simply resetting the entire MDSS to its power-on state, to avoid the partial configuration. Signed-off-by: Bjorn Andersson --- Changes since v1: - Rather than trying to deconfigure individual pieces of the DPU, reset the entire block. drivers/g

[Freedreno] [PATCH v2 1/2] dt-bindings: display: msm: Add optional resets

2022-03-01 Thread Bjorn Andersson
Add an optional reference to the MDSS_CORE reset, which when specified can be used by the implementation to reset the hardware blocks. Signed-off-by: Bjorn Andersson --- Changes since v1: - New approach/patch .../devicetree/bindings/display/msm/dpu-qcm2290.yaml | 4

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dp: Add basic PSR support for eDP

2022-02-22 Thread Bjorn Andersson
On Mon 21 Feb 06:51 PST 2022, Vinod Polimera wrote: > Add support for basic panel self refresh (PSR) feature for eDP. > Add a new interface to set PSR state in the sink from DPU. > Program the eDP controller to issue PSR enter and exit SDP to > the sink. > > Signed-off-by: Sankeerth Billakanti >

Re: [Freedreno] [PATCH v4 2/5] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-02-17 Thread Bjorn Andersson
On Thu 17 Feb 17:03 PST 2022, Doug Anderson wrote: > Hi, > > On Thu, Feb 10, 2022 at 3:58 AM Sankeerth Billakanti > wrote: > > > > + backlight_3v3_regulator: backlight-3v3-regulator { > > + compatible = "regulator-fixed"; > > + regulator-name = "backlight_3v3_re

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-17 Thread Bjorn Andersson
On Thu 17 Feb 19:10 CST 2022, Dmitry Baryshkov wrote: > On 16/02/2022 05:16, Abhinav Kumar wrote: > > > > > > On 2/15/2022 6:03 PM, Bjorn Andersson wrote: > > > On Tue 15 Feb 19:34 CST 2022, Abhinav Kumar wrote: > > > > > > > > >

[Freedreno] [PATCH v3 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-16 Thread Bjorn Andersson
the widebus bit set, so this is flagged appropriately to ensure widebus is disabled - for now. Signed-off-by: Rob Clark [bjorn: Reworked intf and irq definitions] Signed-off-by: Bjorn Andersson --- Changes since v2: - Dropped the extra element in danger_lut_tbl .../gpu/drm/msm/disp/dpu1

[Freedreno] [PATCH v3 1/2] drm/msm/dpu: Add INTF_5 interrupts

2022-02-16 Thread Bjorn Andersson
SC8180x has the eDP controller wired up to INTF_5, so add the interrupt register block for this interface to the list. Signed-off-by: Bjorn Andersson --- Changes since v2: - None drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 6 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Bjorn Andersson
On Tue 15 Feb 20:38 CST 2022, Abhinav Kumar wrote: > > > On 2/15/2022 6:14 PM, Bjorn Andersson wrote: > > On Tue 15 Feb 11:42 CST 2022, Abhinav Kumar wrote: > > > > > > > > > > > On 2/15/2022 9:28 AM, Bjorn Andersson wrote: > >

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Bjorn Andersson
On Tue 15 Feb 11:42 CST 2022, Abhinav Kumar wrote: > > > On 2/15/2022 9:28 AM, Bjorn Andersson wrote: > > On Tue 15 Feb 11:14 CST 2022, Abhinav Kumar wrote: > > > > > > > > > > > On 2/14/2022 8:33 PM, Bjorn Andersson wrote: > > &g

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Bjorn Andersson
22 at 20:42, Abhinav Kumar > > > > wrote: > > > > > On 2/15/2022 9:28 AM, Bjorn Andersson wrote: > > > > > > On Tue 15 Feb 11:14 CST 2022, Abhinav Kumar wrote: > > > > > > > On 2/14/2022 8:33 PM, Bjorn Andersson wrote: > > > > &

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Bjorn Andersson
On Tue 15 Feb 11:14 CST 2022, Abhinav Kumar wrote: > > > On 2/14/2022 8:33 PM, Bjorn Andersson wrote: > > From: Rob Clark > > > > Add SC8180x to the hardware catalog, for initial support for the > > platform. Due to limitations in the DP driver only one of t

Re: [Freedreno] [PATCH v2 8/8] drm/msm/dpu: simplify intf allocation code

2022-02-15 Thread Bjorn Andersson
der; > > memset(&info, 0, sizeof(info)); > - info.intf_type = encoder->encoder_type; > + info.intf_type = INTF_DSI; > > rc = msm_dsi_modeset_init(priv->dsi[i], dev, encoder); > if (rc) { > @@

Re: [Freedreno] [PATCH v2 5/8] drm/msm/dpu: encoder: drop unused mode_fixup callback

2022-02-15 Thread Bjorn Andersson
On Tue 15 Feb 08:16 CST 2022, Dmitry Baryshkov wrote: > Both cmd and vid backends provide useless mode_fixup() callback. Drop > it. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 4 >

Re: [Freedreno] [PATCH v2 4/8] drm/msm/dpu: drop bus_scaling_client field

2022-02-15 Thread Bjorn Andersson
On Tue 15 Feb 08:16 CST 2022, Dmitry Baryshkov wrote: > We do not use MSM bus client, so drop bus_scaling_client field from > dpu_encoder_virt. > > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov Reviewed-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/di

Re: [Freedreno] [PATCH v2 3/8] drm/msm/dpu: remove msm_dp cached in dpu_encoder_virt

2022-02-15 Thread Bjorn Andersson
> Signed-off-by: Dmitry Baryshkov Reviewed-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > in

Re: [Freedreno] [PATCH v2 1/8] drm/msm/dpu: fix dp audio condition

2022-02-15 Thread Bjorn Andersson
22 ("drm/msm/dp: add audio support for Display Port on MSM") > Signed-off-by: Dmitry Baryshkov Reviewed-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/m

Re: [Freedreno] [PATCH] drm/msm/dpu: drop unused access macros

2022-02-15 Thread Bjorn Andersson
On Tue 15 Feb 08:53 CST 2022, Dmitry Baryshkov wrote: > The access macros BLK_foo are not used by the code, drop them. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 16 >

Re: [Freedreno] [PATCH] drm/msm/dpu: Disable boot loader configured data paths

2022-02-15 Thread Bjorn Andersson
On Tue 15 Feb 08:44 CST 2022, Dmitry Baryshkov wrote: > On 15/02/2022 07:37, Bjorn Andersson wrote: > > It's typical for the bootloader to configure CTL_0 for the boot splash > > or EFIFB, but for non-DSI use cases the DPU driver tend to pick another > > CTL and the sy

[Freedreno] [PATCH] drm/msm/dpu: Disable boot loader configured data paths

2022-02-14 Thread Bjorn Andersson
ort will affect clocks, regulators, power-domains etc, and will take time to implement. So in the meantime this patch simply disables all the data paths, on platforms that has CTL_FETCH_ACTIVE, to avoid the graphical artifacts. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/disp/dpu1/dp

[Freedreno] [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-14 Thread Bjorn Andersson
the widebus bit set, so this is flagged appropriately to ensure widebus is disabled - for now. Signed-off-by: Rob Clark [bjorn: Reworked intf and irq definitions] Signed-off-by: Bjorn Andersson --- Changes since v1: - Dropped widebus flag .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 129

[Freedreno] [PATCH v2 1/2] drm/msm/dpu: Add INTF_5 interrupts

2022-02-14 Thread Bjorn Andersson
SC8180x has the eDP controller wired up to INTF_5, so add the interrupt register block for this interface to the list. Signed-off-by: Bjorn Andersson --- Changes since v1: - None drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 6 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h

Re: [Freedreno] [PATCH v4 2/2] drm/msm/dp: enable widebus feature for display port

2022-02-14 Thread Bjorn Andersson
timing configuration by struct msm_dp > > Changes in v3: > -- split patch into 3 patches > -- enable widebus feature base on chip hardware revision > > Signed-off-by: Kuogee Hsieh Tested-by: Bjorn Andersson > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

Re: [Freedreno] [PATCH v4 1/2] drm/msm/dp: revise timing engine programming to support widebus feature

2022-02-14 Thread Bjorn Andersson
der leaves widebus enabled in the eDP controller, and the two patches takes care of this problem for me. I also checked the DP still works. Tested-by: Bjorn Andersson Thanks, Bjorn > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c|

Re: [Freedreno] [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-14 Thread Bjorn Andersson
On Mon 14 Feb 09:59 PST 2022, Imre Deak wrote: > On Mon, Feb 07, 2022 at 08:43:27PM -0800, Bjorn Andersson wrote: > > In some implementations, such as the Qualcomm platforms, the display > > driver has no way to query the current HPD state and as such it's > > impossi

Re: [Freedreno] [PATCH v4 3/5] arm64: dts: qcom: sc7280: rename edp_out label to mdss_edp_out

2022-02-10 Thread Bjorn Andersson
On Thu 10 Feb 05:57 CST 2022, Sankeerth Billakanti wrote: > Rename the edp_out label in the sc7280 platform to mdss_edp_out. Next week, or in the next product, it might not be obvious why we did this change. So please continue this sentence with something like "so that the nodes are grouped toget

Re: [Freedreno] [PATCH v4 2/5] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-02-10 Thread Bjorn Andersson
On Thu 10 Feb 05:57 CST 2022, Sankeerth Billakanti wrote: > Enable the eDP display panel support without HPD on sc7280 platform. > > Signed-off-by: Sankeerth Billakanti > --- > > Changes in v4: > - Create new patch for name changes > - Remove output-low > > Changes in v3: > - Sort the no

Re: [Freedreno] [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-10 Thread Bjorn Andersson
On Thu 10 Feb 13:12 PST 2022, Dmitry Baryshkov wrote: > On Thu, 10 Feb 2022 at 23:54, Bjorn Andersson > wrote: > > > > On Tue 08 Feb 02:39 PST 2022, Greg Kroah-Hartman wrote: > > > > > On Mon, Feb 07, 2022 at 08:43:27PM -0800, Bjorn Andersson wrote: > > &

Re: [Freedreno] [PATCH 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-02-10 Thread Bjorn Andersson
On Mon 07 Feb 23:40 PST 2022, Greg Kroah-Hartman wrote: > On Mon, Feb 07, 2022 at 08:43:28PM -0800, Bjorn Andersson wrote: > > The Qualcomm DisplayPort driver contains traces of the necessary > > plumbing to hook up USB HPD, in the form of the dp_hpd module and the > > dp

Re: [Freedreno] [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-10 Thread Bjorn Andersson
On Tue 08 Feb 02:39 PST 2022, Greg Kroah-Hartman wrote: > On Mon, Feb 07, 2022 at 08:43:27PM -0800, Bjorn Andersson wrote: > > In some implementations, such as the Qualcomm platforms, the display > > driver has no way to query the current HPD state and as such it's > >

Re: [Freedreno] [PATCH v2 2/4] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD

2022-02-08 Thread Bjorn Andersson
On Tue 08 Feb 07:18 PST 2022, Sankeerth Billakanti wrote: > Enable the eDP display panel support without HPD on sc7280 platform. > > Signed-off-by: Sankeerth Billakanti > --- > > Changes in v2: > - sort node references alphabetically > - improve readability > - move the pwm pinctrl to pwm

Re: [Freedreno] [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350

2022-02-08 Thread Bjorn Andersson
On Wed 19 Jan 15:14 PST 2022, Dmitry Baryshkov wrote: > On 28/12/2021 07:59, Bjorn Andersson wrote: > > The Qualcomm SM8350 platform comes with a single DisplayPort controller, > > add support for this in the DisplayPort driver. > > > > Signed-off-by: Bjorn Andersso

[Freedreno] [PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-07 Thread Bjorn Andersson
test for unchanged state in the displayport altmode driver into the i915 driver, to allow other drivers to act upon each update. Signed-off-by: Bjorn Andersson --- Note that the Intel driver has only been compile tested with this patch. drivers/gpu/drm/drm_connector.c | 6 -- dr

[Freedreno] [PATCH 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-02-07 Thread Bjorn Andersson
de in dp_drm_connector_init(). Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/dp/dp_display.c | 8 drivers/gpu/drm/msm/dp/dp_display.h | 2 ++ drivers/gpu/drm/msm/dp/dp_drm.c | 10 ++ drivers/gpu/drm/msm/dp/dp_hpd.c | 19 +++ drivers/gpu/drm/msm/dp/dp_

Re: [Freedreno] [PATCH] drm/msm/dp: add wide bus support

2022-01-31 Thread Bjorn Andersson
On Fri 28 Jan 09:29 PST 2022, Kuogee Hsieh wrote: > Normally, mdp will push one pixel of data per pixel clock to > interface to display. Wide bus feature will increase bus > width from 32 bits to 64 bits so that it can push two > pixel of data per pixel clock to interface to display. > This featur

Re: [Freedreno] [PATCH v2 4/4] drm/msm/adreno: Update the name of 7c3 gpu

2022-01-31 Thread Bjorn Andersson
On Wed 19 Jan 09:21 CST 2022, Akhil P Oommen wrote: > Update the name in the gpulist for 7c3 gpu as per the latest > recommendation. > I was skeptical when this was introduced and you proved my point. Give it a name based on the Adreno revision or possibly the part number and leave it at that.

Re: [Freedreno] [PATCH v2 2/4] arm64: dts: qcom: sc7280: Support gpu speedbin

2022-01-31 Thread Bjorn Andersson
On Wed 19 Jan 09:21 CST 2022, Akhil P Oommen wrote: > Add the speedbin fuse and the required opps to support gpu sku. > > Signed-off-by: Akhil P Oommen > --- > > (no changes since v1) > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 46 > > 1 file changed, 46 i

Re: [Freedreno] [PATCH v2 1/4] drm/msm/adreno: Add support for Adreno 8c Gen 3

2022-01-31 Thread Bjorn Andersson
On Wed 19 Jan 09:21 CST 2022, Akhil P Oommen wrote: > Add support for "Adreno 8c Gen 3" gpu along with the necessary speedbin > support. > > Signed-off-by: Akhil P Oommen > --- > > Changes in v2: > - Fix a bug in adreno_cmp_rev() > > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 21 +++

Re: [Freedreno] [PATCH v5 0/4] arm: dts: qcom: sc7280: Add display DT nodes for sc7280

2022-01-31 Thread Bjorn Andersson
splay dt nodes commit: 25940788d170251373d8975d359706350818fa0f [4/4] arm64: dts: qcom: sc7280: Add Display Port node commit: fc6b1225d20de0298a7b0e52eb3843d71e1992e8 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH v4 4/4] arm64: dts: qcom: sc7280: Add Display Port node

2022-01-31 Thread Bjorn Andersson
On Mon, 22 Nov 2021 16:59:15 +0530, Sankeerth Billakanti wrote: > From: Kuogee Hsieh > > Applied, thanks! [4/4] arm64: dts: qcom: sc7280: Add Display Port node commit: fc6b1225d20de0298a7b0e52eb3843d71e1992e8 Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH v4 1/4] arm64: dts: qcom: sc7280: add display dt nodes

2022-01-31 Thread Bjorn Andersson
s: qcom: sc7280: Add DSI display nodes commit: 43137272f0bc5e05e4c4c6f7bfce017bfb9e16b5 [3/4] arm64: dts: qcom: sc7280: add edp display dt nodes commit: 25940788d170251373d8975d359706350818fa0f Best regards, -- Bjorn Andersson

Re: [Freedreno] [PATCH 1/2] drm/msm/gpu: Wait for idle before suspending

2022-01-06 Thread Bjorn Andersson
or the GPU to become > idle. > > Alternatively we could just return -EBUSY in this case, but that has the > disadvantage of causing system suspend to fail. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/adreno_d

Re: [Freedreno] [PATCH v4] drm/msm/dp: populate connector of struct dp_panel

2022-01-06 Thread Bjorn Andersson
; Interesting, thanks for adding this! Reviewed-by: Bjorn Andersson Regards, Bjorn > The problem is struct dp_panel::connector never be assigned, instead the > connector is stored in struct msm_dp::connector. When we run compliance > testing test case 4.2.2.6 dp_panel_handle_sink_requ

Re: [Freedreno] [PATCH v3] drm/msm/dp: populate connector of struct dp_panel

2022-01-06 Thread Bjorn Andersson
On Thu 06 Jan 09:15 PST 2022, Kuogee Hsieh wrote: > We never assign struct dp_panel::connector, instead the connector is > stored in struct msm_dp::connector. When we run compliance testing test > case 4.2.2.6 dp_panel_handle_sink_request() won't have a valid edid set I unfortunately have no idea

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dp: rewrite dss_module_power to use bulk clock functions

2021-12-28 Thread Bjorn Andersson
On Thu 25 Nov 20:35 CST 2021, Dmitry Baryshkov wrote: > In order to simplify DP code, drop hand-coded loops over clock arrays, > replacing them with clk_bulk_* functions. > I've yet to debug this, but applying the two patches and attaching an HDMI cable to my USB dongle results in the follwing s

Re: [Freedreno] [PATCH] drm/msm/dp: add support of tps4 (training pattern 4) for HBR3

2021-12-28 Thread Bjorn Andersson
On Tue 28 Dec 10:51 PST 2021, Kuogee Hsieh wrote: > From: Kuogee Hsieh > > Some DP sinkers prefer to use tps4 instead of tps3 during training #2. > This patch will use tps4 to perform link training #2 if sinker's DPCD > supports it. > > Signed-off-by: Kuogee Hsieh > --- > drivers/gpu/drm/msm/

Re: [Freedreno] [PATCH] drm/msm/dp: populate connector of struct dp_panel

2021-12-28 Thread Bjorn Andersson
On Tue 28 Dec 09:51 PST 2021, Kuogee Hsieh wrote: > There is kernel crashed happen due to unable to handle kernel NULL It would be wonderful, for my understanding today, as well as people in the coming months to be able to search for the callstack etc on the mailing list, if you could provide som

[Freedreno] [PATCH] drm/msm/dp: Add DisplayPort controller for SM8350

2021-12-27 Thread Bjorn Andersson
The Qualcomm SM8350 platform comes with a single DisplayPort controller, add support for this in the DisplayPort driver. Signed-off-by: Bjorn Andersson --- .../devicetree/bindings/display/msm/dp-controller.yaml| 1 + drivers/gpu/drm/msm/dp/dp_display.c | 8 2

Re: [Freedreno] [PATCH v2] drm/msm/dp: Only create debugfs for PRIMARY minor

2021-12-20 Thread Bjorn Andersson
On Mon 20 Dec 15:53 PST 2021, Dmitry Baryshkov wrote: > On Fri, 17 Dec 2021 at 03:19, Bjorn Andersson > wrote: > > > > dpu_kms_debugfs_init() is invoked for each minor being registered. Most > > of the files created are unrelated to the minor, so there's no reason

Re: [Freedreno] [PATCH v9] phy: qcom-qmp: add display port v4 voltage and pre-emphasis swing tables

2021-12-20 Thread Bjorn Andersson
t; and a pre-emphasis table for both hbr2 and hbr3. > > In addition, write 0x0a to TX_TX_POL_INV is added to complete the sequence > of configure dp phy base on the hardware documentation. > > Fixes: aff188feb5e1 ("phy: qcom-qmp: add support for sm8250-usb3-dp phy") > Sig

[Freedreno] [PATCH v6] drm/msm/dp: Add sc8180x DP controllers

2021-12-16 Thread Bjorn Andersson
The sc8180x has 2 DP and 1 eDP controllers, add support for these to the DP driver. Signed-off-by: Bjorn Andersson --- Changes since v5: - Dropped DPU hw catalog change from the patch - Rebased the patch drivers/gpu/drm/msm/dp/dp_display.c | 11 +++ 1 file changed, 11 insertions

[Freedreno] [PATCH v2] drm/msm/dp: Only create debugfs for PRIMARY minor

2021-12-16 Thread Bjorn Andersson
les() and the dp_debug_private object does outlive the debugfs entries in either case, so there doesn't seem to be any adverse effects of this, but per the code the current behavior is unexpected, so change it to only create debugfs files for the PRIMARY minor. Signed-off-by: Bjorn Andersson --- Changes

Re: [Freedreno] [PATCH v7] phy: qcom-qmp: add display port v4 voltage and pre-emphasis swing tables

2021-12-13 Thread Bjorn Andersson
rdware documentation". Thanks, Bjorn > > Fixes: aff188feb5e1 ("phy: qcom-qmp: add support for sm8250-usb3-dp phy") > Signed-off-by: Kuogee Hsieh > Reviewed-by: Stephen Boyd > Reviewed-by: Bjorn Andersson > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 112 > ++

Re: [Freedreno] [PATCH v6] phy: qcom-qmp: add display port v4 voltage and pre-emphasis swing tables

2021-12-08 Thread Bjorn Andersson
- re wording commit text The changelog still don't belong in the commit message, perhaps Vinod can drop that as he applies the patch. Reviewed-by: Bjorn Andersson Regards, Bjorn > > Fixes: aff188feb5e1 ("phy: qcom-qmp: add support for sm8250-usb3-dp phy") > Signed-off-by:

Re: [Freedreno] [PATCH v5] phy: qcom-qmp: add support for display port voltage and pre-emphasis swing

2021-12-08 Thread Bjorn Andersson
On Wed 08 Dec 10:50 PST 2021, Kuogee Hsieh wrote: > From: Kuogee Hsieh > > Both voltage and pre-emphasis swing level are set during link training > negotiation between host and sink. There are totally four tables added. > A voltage swing table for both hbr and hbr1, a voltage table for both > hb

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-12-07 Thread Bjorn Andersson
On Tue 07 Dec 08:56 PST 2021, Hans de Goede wrote: > Hi all, > > On 12/7/21 13:26, Heikki Krogerus wrote: > > +Hans and Imre > > > > On Mon, Dec 06, 2021 at 02:31:40PM -0800, Bjorn Andersson wrote: > >> On Thu 07 Oct 03:17 PDT 2021, Heikki Krogerus wrote:

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-12-06 Thread Bjorn Andersson
On Thu 07 Oct 03:17 PDT 2021, Heikki Krogerus wrote: > On Wed, Oct 06, 2021 at 01:26:35PM -0700, Prashant Malani wrote: > > (CC+ Heikki) [..] > > On Wed, Oct 6, 2021 at 8:19 AM Doug Anderson wrote: [..] > void drm_connector_oob_hotplug_event(struct fwnode_handle > *connector_fwnode); > >

Re: [Freedreno] [PATCH v4] phy: qcom-qmp: add support for display port voltage and pre-emphasis swing

2021-12-02 Thread Bjorn Andersson
On Tue 14 Sep 09:45 PDT 2021, Kuogee Hsieh wrote: $suject says "add support", but afaict the code already configures voltage and pre-emphasis swing. If I understand your change you're not adding support for the swing, but rather you make it possible to have different tables for different versions

<    1   2   3   4   5   6   7   8   >