The contents of struct encoder_kickoff_params are never used. Remove the
structure and all remnants of it from function calls.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 7 ++-
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 7
fc
> fc fc
> [ 10.660571] ^
> [ 10.665774] ffc0d9f06300: fc fc fc fc fc fc fc fc fc fc fc fc fc fc
> fc fc
> [ 10.673210] ffc0d9f06380: fc fc fc fc fc fc fc fc fc fc fc fc fc fc
> fc fc
> [ 10.680639]
>
ded null checks.
>
> Signed-off-by: Jordan Crouse
Reviewed-by: Bruce Wang
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 30 ++-
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 9 +---
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 17 ---
> driv
on't error check these */
> - debugfs_create_file("status", 0600,
> - dpu_enc->debugfs_root, dpu_enc, &debugfs_status_fops);
> + debugfs_create_file("status", 0600, dpu_enc->debugfs_r
On 10/18/2018 03:58 PM, Jordan Crouse wrote:
The functions in dpu_dbg.c aren't used. The two main dump functions
fail after a lookup from dpu_dbg_base.reg_base_list which turns out
to never be populated and once those are removed the rest of the
file doesn't make any sense.
Signed-off-by: Jord
On Thu, Oct 18, 2018 at 3:59 PM Jordan Crouse wrote:
>
> Do some cleanup in the static inline functions defined in
> dpu_media_info.h by cleaning up gotos and unneeded local
> variables.
>
> Signed-off-by: Jordan Crouse
Reviewed-by: Bruce Wang
> ---
> .
/msm/disp/dpu1/dpu_kms.c
> index 7e3ba128cbaf..2a91881048c8 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -706,10 +706,30 @@ static void _dpu_kms_set_encoder_mode(struct msm_kms
> *kms,
> enco
On Thu, Oct 18, 2018 at 3:58 PM Jordan Crouse wrote:
>
> Allow the KMS operation 'irq_postinstall' to be optional
> so that the target display drivers don't need to define
> a dummy function if they don't need one.
>
> Signed-off-by: Jordan Crouse
Reviewed
own.
>
> Signed-off-by: Jordan Crouse
Reviewed-by: Bruce Wang
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 17 ++---
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 9 -
> 2 files changed, 6 insertions(+), 20 deletions(-)
>
> dif
On Thu, Oct 18, 2018 at 3:59 PM Jordan Crouse wrote:
>
> dpu_crtc_get_mixer_height() is only used once and the value it
> returns can be easily derived from the calling function.
>
> Signed-off-by: Jordan Crouse
Reviewed-by: Bruce Wang
> ---
> drivers/gpu/drm/msm/disp
On Thu, Oct 18, 2018 at 3:58 PM Jordan Crouse wrote:
>
> Use the standard DEFINE_SHOW_ATTRIBUTE macro for seq_file based
> debugfs files instead of custom macros and hand-coded functions.
>
> Signed-off-by: Jordan Crouse
Sorry! Suppressed CCs by accident
Reviewed
-off-by: Bruce Wang
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 123
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 15 ---
2 files changed, 138 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
moved all calls
to dpu_kms_is_suspend_state, we can remove that function and the
suspend_state field of dpu_kms as well.
v2: added patch to patchset
v3: reworded commit body and moved deletion of dpu_kms_is_suspend_state and
suspend_state to this patch
Signed-off-by: Bruce Wang
---
drivers/g
.
v2: reorganized patch order
v3: made error checks less severe
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/msm_drv.c | 27 ---
drivers/gpu/drm/msm/msm_kms.h | 3 ---
2 files changed, 12 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gp
Since we removed all suspend logic from the crtc code (see patch 3/4),
dpu_crtc_reset does the same things as drm_atomic_helper_crtc_reset, so let's
just replace it with a call to the atomic helper.
v3: added patch to patchset
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp
ordering, added removal of suspend state reliance
v3: Condesed suspend state reliance patches into one patch (patch 3),
added removal of dpu_crtc_reset
Bruce Wang (4):
drm/msm/dpu: Remove dpu_kms_pm_suspend/resume
drm/msm: Cut dpu_kms hooks from msm_pm_suspend/resume
drm/msm/dpu: Remove suspend
state from inside the crtc.
This patch removes the suspend logic from the crtc, and removes the relevant
tracing from dpu_trace.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 61 ++-
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 2 -
drivers/gpu/dr
Patches 1-2: Changes msm_pm_resume implementation to use atomic helpers and
removes the previously used dpu_kms_pm_suspend/resume functions.
Patches 3-4: Removes reliance on knowledge about suspend state from crtc
Bruce Wang (4):
drm/msm/dpu: Remove dpu_kms_pm_suspend/resume
drm/msm: Cut
The suspend_state field is no longer used and can be removed along with
dpu_kms_is_suspend_state.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h
b/drivers/gpu/drm
d-off-by: Bruce Wang
---
drivers/gpu/drm/msm/msm_drv.c | 28 ++--
drivers/gpu/drm/msm/msm_kms.h | 3 ---
2 files changed, 10 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 4904d0d41409..f987df7f10df 100644
PM resume was crashing during dpu_kms_pm_resume. This patch removes
dpu_kms_pm_suspend/resume so that msm_pm_suspend/resume uses the atomic
helpers instead (see next patch). This patch also removes
dpu_kms_is_suspend_blocked since it is never called.
Signed-off-by: Bruce Wang
---
drivers/gpu
t;
> This patch moves the NULL assignment to setup_display where it will be
> re-assigned later in the function.
>
> Signed-off-by: Sean Paul
Tested-by: Bruce Wang
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
poll_disable call is likely not needed as
of right now as the DRM_CONNECTOR_POLL_CONNECT flag is never set.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 --
drivers/gpu/drm/msm/msm_drv.c | 28 +
drivers/gpu/drm/msm/msm_kms.h | 3
Removes the now uncalled pm_suspend/resume code. Also removes
dpu_kms_is_suspend_blocked which is never called, and changes
dpu_kms_is_suspend_state to work with the new msm_pm_suspend/resume
implementations.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 121
On Fri, Sep 28, 2018 at 3:42 AM Sean Paul wrote:
>
> On Mon, Sep 24, 2018 at 12:22:21PM -0400, Bruce Wang wrote:
> > Removes uneeded checks and unused variables. Changes some
> > function that do not need return values to void.
> >
> > Bruce Wang (7):
> > dr
: Removed both _dpu_crtc_power_enable and _dpu_crtc_power_disable
and called pm_runtime_get_sync and pm_runtime_put_sync from all
call points
Signed-off-by: Bruce Wang
Reviewed-by: Jordan Crouse
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 41 ++--
1 file changed, 2 insertions
Remove unneeded checks from _dpu_plane_get_aspace.
v3: change _dpu_plane_get_aspace to return a struct
*msm_gem_address_space instead passing in a pointer of the same
type to edit. Remove uneeded arguments.
Signed-off-by: Bruce Wang
Reviewed-by: Jordan Crouse
---
drivers/gpu/drm/msm/disp/dpu1
On Mon, Sep 24, 2018 at 2:01 PM Jeykumar Sankaran wrote:
>
> On 2018-09-24 10:45, Bruce Wang wrote:
> > Remove unneeded checks from _dpu_plane_get_aspace. The function
> > no longer needs to return anything so it is changed to void.
> >
> Are the subject and text stil
Remove unneeded checks from _dpu_plane_get_aspace. The function
no longer needs to return anything so it is changed to void.
v3: change _dpu_plane_get_aspace to return a struct
*msm_gem_address_space instead passing in a pointer of the same
type to edit.
Signed-off-by: Bruce Wang
---
drivers
On Mon, Sep 24, 2018 at 12:47 PM Jordan Crouse wrote:
>
> On Mon, Sep 24, 2018 at 12:22:28PM -0400, Bruce Wang wrote:
> > Remove unneeded checks from _dpu_plane_get_aspace. The function
> > no longer needs to return anything so it is changed to void.
> >
> > v3:
Remove unneeded checks from _dpu_plane_get_aspace. The function
no longer needs to return anything so it is changed to void.
v3: Made return value of function struct msm_gem_address_space* instead
of passing one in to reflect the purpose of the function.
Signed-off-by: Bruce Wang
---
drivers
Removed all impossible checks from the function, which eliminates
the need for a return value. This function is also never used
outside of dpu_plane.c, so the function is made static.
v3: Using helper function _dpu_plane_get_kms() instead of doing
it locally.
Signed-off-by: Bruce Wang
Reviewed
Removes redundant tests for _dpu_crtc_vblank_enable_no_lock.
Function return type is now void and all function calls have
been changed accordingly.
Signed-off-by: Bruce Wang
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 42
1 file changed, 7
.
Signed-off-by: Bruce Wang
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 204 ++
1 file changed, 16 insertions(+), 188 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
index 1ce76460d710
Removes impossible checks in dpu_crtc.c.
Variable assignments are moved up to be initializations where
possible. Some variables are no longer used, these are removed.
v3: reverted back to original patch
Signed-off-by: Bruce Wang
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1
Removes uneeded checks and unused variables. Changes some
function that do not need return values to void.
Bruce Wang (7):
drm/msm/dpu: Remove unneeded checks in dpu_plane.c
drm/msm/dpu: Clean up plane atomic disable/update
drm/msm/dpu: Remove unneeded checks in dpu_crtc.c
drm/msm/dpu
arity.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 44 ++--
1 file changed, 11 insertions(+), 33 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index e31e70f5dbac..cb71e2a2e02e 100644
Removes unnecessary checks from dpu_plane_atomic_disable, old_state
argument for both dpu_plane_atomic_disable and
dpu_plane_sspp_atomic_update is removed as it is no longer used.
Signed-off-by: Bruce Wang
Reviewed-by: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 31
On Fri, Sep 21, 2018 at 11:51 AM, Sean Paul wrote:
>
> On Thu, Sep 20, 2018 at 11:36:34AM -0600, Jordan Crouse wrote:
> > On Thu, Sep 20, 2018 at 12:49:21PM -0400, Bruce Wang wrote:
> > > All checks for _dpu_crtc_power_enable are not true, so the function
> > > can n
Removed all impossible checks from the function, which eliminates
the need for a return value. This function is also never used
outside of dpu_plane.c, so the function is made static.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 27 +--
1 file
Remove unneeded checks from _dpu_plane_get_aspace. The function
no longer needs to return anything so it is changed to void.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 25 ---
1 file changed, 4 insertions(+), 21 deletions(-)
diff --git a
Removes redundant tests for _dpu_crtc_vblank_enable_no_lock.
Function return type is now void and all function calls have
been changed accordingly.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 42
1 file changed, 7 insertions(+), 35 deletions
Removes impossible checks in dpu_crtc.c.
Variable assignments are moved up to be initializations where
possible. Some variables are no longer used, these are removed.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 170 +++
1 file changed, 23
All checks for _dpu_crtc_power_enable are not true, so the function
can never return an error code. All calls of the function have also
been changed so that they don't expect a return value.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 35 --
Removes unnecessary checks from dpu_plane_atomic_disable, old_state
argument for both dpu_plane_atomic_disable and
dpu_plane_sspp_atomic_update is removed as it is no longer used.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 31 +--
1 file
Removes some checks from dpu_plane.c that will never result in an error.
Subsequent variable assignments become part of the initialization wherever
possible. Unused variables are removed.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 190 ++
1
Removes uneeded checks and unused variables. Changes some
function that do not need return values to void.
Bruce Wang (7):
drm/msm/dpu: Remove unneeded checks in dpu_plane.c
drm/msm/dpu: Clean up plane atomic disable/update
drm/msm/dpu: Remove unneeded checks in dpu_crtc.c
drm/msm/dpu
Removes some checks from dpu_plane.c that will never result in an error.
Subsequent variable assignments become part of the initialization wherever
possible.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 53 +++
1 file changed, 6 insertions(+), 47
Removes unnecessary checks from dpu_plane_atomic_disable, old_state
argument for both dpu_plane_atomic_disable and
dpu_plane_sspp_atomic_update is removed as it is no longer used.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 31 +--
1 file
All checks for _dpu_crtc_power_enable are not true, so the function
can never return an error code. All calls of the function have also
been changed so that they don't expect a return value.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 35 --
Removes unneeded checks and unused variables. Changes some
functions that do not need return values to void.
Bruce Wang (5):
[patch 1/5] drm/msm/dpu: Remove unneeded checks from dpu_plane
[patch 2/5] drm/msm/dpu: Clean up plane atomic disable/update
[patch 3/5] drm/msm/dpu: Remove
Removes redundant tests for _dpu_crtc_vblank_enable_no_lock.
Function return type is now void and all function calls have
been changed accordingly.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 42
1 file changed, 7 insertions(+), 35 deletions
Removes additional impossible checks in dpu_plane.c and dpu_crtc.c.
Variable assignments are moved up to be initializations where
possible. Some variables are no longer used, these are removed.
Signed-off-by: Bruce Wang
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 121
53 matches
Mail list logo
