Re: [Freedreno] [PATCH][next] drm: Replace zero-length array with flexible-array member

2020-02-25 Thread Chris Wilson
Quoting Gustavo A. R. Silva (2020-02-25 14:03:47) > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: I remember

Re: [Freedreno] [PATCH v2 2/3] drm: plumb attaching dev thru to prime_pin/unpin

2019-07-16 Thread Chris Wilson
Quoting Rob Clark (2019-07-16 18:43:22) > From: Rob Clark > > Needed in the following patch for cache operations. What's the base for this patch? (I'm missing the ancestor for drm_gem.c) -Chris ___ Freedreno mailing list

Re: [Freedreno] [PATCH v1] drm/msm: Move fence put to where failure occurs

2018-11-01 Thread Chris Wilson
Quoting Robert Foss (2018-11-01 16:12:28) > If dma_fence_wait fails to wait for a supplied in-fence in > msm_ioctl_gem_submit, make sure we release that in-fence. > > Also remove this dma_fence_put() from the 'out' label. > > Signed-off-by: Robert Foss > --- >

Re: [Freedreno] [PATCH 08/13] drm/msm/gpu: Rearrange the code that collects the task during a hang

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:25) > Do a bit of cleanup to prepare for upcoming changes to pass the > hanging task comm and cmdline to the crash dump function. > > Signed-off-by: Jordan Crouse > --- > drivers/gpu/drm/msm/msm_gpu.c | 18 ++ > 1 file changed, 10

Re: [Freedreno] [PATCH 07/13] drm/msm/gpu: Convert the GPU show function to use the GPU state

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:24) > Convert the existing GPU show function to use the GPU state to > dump the information rather than reading it directly from the hardware. > This will require an additional step to capture the state before > dumping it for the existing nodes but it will

Re: [Freedreno] [PATCH 05/13] drm: Add put callback for the coredump printer

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:22) > Add a put function for the coredump printer to bypass printf() > for constant strings for a speed boost. > > v2: Add EXPORT_SYMBOL for _drm_puts_coredump > Signed-off-by: Jordan Crouse > --- > drivers/gpu/drm/drm_print.c | 43

Re: [Freedreno] [PATCH 02/13] drm: drm_printer: Add printer for devcoredump

2018-07-12 Thread Chris Wilson
Quoting Jordan Crouse (2018-07-12 19:59:19) > Add a drm printer suitable for use with the read callback for > devcoredump or other suitable buffer based output format that > isn't otherwise covered by seq_file. > > Signed-off-by: Jordan Crouse > --- > drivers/gpu/drm/drm_print.c | 74

Re: [Freedreno] [PATCH 01/13] include: Move ascii85 functions from i915 to linux/ascii85.h

2018-07-12 Thread Chris Wilson
r_puts -> err_puts pointed out by the 01.org bot > v2: Update API to be cleaner for the caller as suggested by Chris Wilson > > Signed-off-by: Jordan Crouse > --- > +static inline long > +ascii85_encode_len(long len) > +{ > + return DIV_ROUND_UP(len, 4); > +} &g

Re: [Freedreno] [PATCH 04/10] drm/msm/gpu: Convert the GPU show function to use the GPU state

2018-04-06 Thread Chris Wilson
Quoting Jordan Crouse (2018-04-05 23:00:50) > diff --git a/drivers/gpu/drm/msm/msm_debugfs.c > b/drivers/gpu/drm/msm/msm_debugfs.c > index ba74cb4f94df..fd535dab3d5b 100644 > --- a/drivers/gpu/drm/msm/msm_debugfs.c > +++ b/drivers/gpu/drm/msm/msm_debugfs.c > @@ -25,13 +25,22 @@ static int

Re: [Freedreno] [PATCH 02/10] drm: drm_printer: Add printer for devcoredump

2018-04-06 Thread Chris Wilson
Quoting Chris Wilson (2018-04-06 11:42:25) > Quoting Jordan Crouse (2018-04-05 23:00:48) > > +struct drm_print_iterator { > > + void *data; > > + > > + ssize_t start; > > + ssize_t offset; > > + ssize_t remain; > > +}; > &g

Re: [Freedreno] [Intel-gfx] [PATCH 01/10] include: Move ascii85 functions from i915 to linux/ascii85.h

2018-04-06 Thread Chris Wilson
Quoting Jordan Crouse (2018-04-05 23:06:53) > On Thu, Apr 05, 2018 at 04:00:47PM -0600, Jordan Crouse wrote: > > The i915 DRM driver very cleverly used ascii85 encoding for their > > GPU state file. Move the encode functions to a general header file to > > support other drivers that might be

Re: [Freedreno] [PATCH] include: Move ascii85 functions from i915 to linux/ascii85.h

2018-01-26 Thread Chris Wilson
Quoting Jordan Crouse (2018-01-26 20:59:22) > The i915 DRM driver very cleverly used ascii85 encoding for their All gfx drivers must eventually become PostScript. > GPU state file. Move the encode functions to a general header file to > support other drivers that might be interested in the same

Re: [Freedreno] [RFC 0/4] drm/msm: GPU crash state

2018-01-05 Thread Chris Wilson
Quoting Jordan Crouse (2018-01-05 18:00:17) > This is a request for comment on code to store and dump a GPU state > a hang with inspiration from the very good i915 GPU error state and > the binary GPU snapshot in the downstream kernel. > > The goal is to store and provide enough information to

Re: [Freedreno] [PATCH] drm/msm/mdp5: Fix compilation warnings

2017-07-19 Thread Chris Wilson
Quoting Viresh Kumar (2017-06-29 10:19:59) > Following compilation warnings were observed for these files: > > CC [M] drivers/gpu/drm/msm/mdp/mdp5/mdp5_mdss.o > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c: In function 'blend_setup': > drivers/gpu/drm/msm/mdp/mdp5/mdp5_crtc.c:223:7: warning:

Re: [Freedreno] [PATCH] drm/msm: return fence_fd = -1 if gem_submit fails

2016-12-12 Thread Chris Wilson
error paths you do not modify user inputs. In particular, consider EINTR where the usual pattern (e.g. drmIoctl) is do { err = ioctl(fd, SUBMIT, arg); } while (err == -EINTR); If you modify the in fence before you consume it, you can't recreate it after handling the signal.