Re: [PATCH v6 3/6] drm/msm/hdmi: add "qcom,hdmi-tx-8998" compatible

2024-07-15 Thread Conor Dooley
On Mon, Jul 15, 2024 at 04:26:12PM +0100, Conor Dooley wrote: > On Mon, Jul 15, 2024 at 02:21:16PM +0200, Marc Gonzalez wrote: > > Current driver already supports the msm8998 HDMI TX. > > We just need to add the compatible string. > > Why is this required when the driver chan

Re: [PATCH v6 3/6] drm/msm/hdmi: add "qcom,hdmi-tx-8998" compatible

2024-07-15 Thread Conor Dooley
On Mon, Jul 15, 2024 at 02:21:16PM +0200, Marc Gonzalez wrote: > Current driver already supports the msm8998 HDMI TX. > We just need to add the compatible string. Why is this required when the driver change suggests that this device is compatible with the existing 8974? > > Signed-off-by: Marc G

Re: [PATCH v2 0/4] dt-bindings: display/msm/gpu: few cleanups

2024-06-24 Thread Conor Dooley
On Sun, Jun 23, 2024 at 10:02:59PM +0200, Krzysztof Kozlowski wrote: > Changes since v1: > 1. Add tags > 2. New patches #3 and #4 > 3. Drop previous patch "dt-bindings: display/msm/gpu: constrain >reg/reg-names per variant", because I need to investigate more. Acked-

Re: [PATCH 1/3] dt-bindings: display/msm/gpu: constrain clocks in top-level

2024-06-23 Thread Conor Dooley
ot; block for given > variant. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Conor Dooley signature.asc Description: PGP signature

Re: [PATCH 2/3] dt-bindings: display/msm/gpu: define reg-names in top-level

2024-06-23 Thread Conor Dooley
Kozlowski Acked-by: Conor Dooley signature.asc Description: PGP signature

Re: [PATCH 3/3] dt-bindings: display/msm/gpu: constrain reg/reg-names per variant

2024-06-23 Thread Conor Dooley
On Sun, Jun 23, 2024 at 02:00:26PM +0200, Krzysztof Kozlowski wrote: > MMIO address space is known per each variant of Adreno GPU, so we can > constrain the reg/reg-names entries for each variant. There is no DTS > for A619, so that part is not accurate but could be corrected later. > > Signed-of

Re: [PATCH v3 2/4] dt-bindings: display/msm: hdmi: add qcom,hdmi-tx-8998

2024-06-06 Thread Conor Dooley
On Thu, Jun 06, 2024 at 06:07:48PM +0200, Marc Gonzalez wrote: > HDMI TX block embedded in the APQ8098. > > Signed-off-by: Marc Gonzalez Reviewed-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [PATCH v2 1/6] dt-bindings: display/msm/gmu: Document Adreno 750 GMU

2024-02-15 Thread Conor Dooley
On Thu, Feb 15, 2024 at 10:20:23AM +0100, Neil Armstrong wrote: > Document the Adreno 750 GMU found on the SM8650 platform. > > Reviewed-by: Konrad Dybcio > Signed-off-by: Neil Armstrong Acked-by: Conor Dooley Cheers, Conor. > --- > Documentation/devicetree/bindings/di

Re: [Freedreno] [PATCH] dt-bindings: display/msm: qcom, sm8150-mdss: correct DSI PHY compatible

2023-11-11 Thread Conor Dooley
hy-7nm' was expected > > Signed-off-by: Krzysztof Kozlowski Acked-by: Conor Dooley Thanks, Conor. > --- > .../devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git > a/Documentation/devicetre

Re: [Freedreno] [PATCH] dt-bindings: display/msm: qcom, sm8250-mdss: add DisplayPort controller node

2023-11-08 Thread Conor Dooley
troller@ae9' was unexpected) > > Signed-off-by: Krzysztof Kozlowski Acked-by: Conor Dooley Cheers, Conor. > --- > .../bindings/display/msm/qcom,sm8250-mdss.yaml | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git > a/Documentation/devi

Re: [Freedreno] [PATCH 2/2] dt-bindings: display: msm: Make "additionalProperties: true" explicit

2023-09-26 Thread Conor Dooley
I cross-checked only a handful of these... Acked-by: Conor Dooley Thanks, Conor. > --- > .../bindings/display/msm/qcom,msm8998-mdss.yaml| 6 ++ > .../bindings/display/msm/qcom,qcm2290-mdss.yaml| 6 ++ > .../bindings/display/msm/qcom,sc7180-mdss.yaml |

Re: [Freedreno] [PATCH 1/2] dt-bindings: display: msm: Add missing unevaluatedProperties on child node schemas

2023-09-26 Thread Conor Dooley
for any node. > > Signed-off-by: Rob Herring Acked-by: Conor Dooley Thanks, Conor. > --- > Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.y

Re: [Freedreno] [PATCH] dt-bindings: cleanup DTS example whitespaces

2023-07-03 Thread Conor Dooley
On Sun, Jul 02, 2023 at 08:23:08PM +0200, Krzysztof Kozlowski wrote: > The DTS code coding style expects spaces around '=' sign. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Conor Dooley Cheers, Conor. signature.asc Description: PGP signature

Re: [Freedreno] [PATCH 1/7] dt-bindings: msm: dsi-phy-28nm: Document msm8226 compatible

2023-05-29 Thread Conor Dooley
t; + - qcom,dsi-phy-28nm-8226 How come the order is different in both places? Acked-by: Conor Dooley Thanks, Conor. >- qcom,dsi-phy-28nm-8960 > >reg: > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml > b/Documentation/devicetree/bindi

Re: [Freedreno] [PATCH 3/7] dt-bindings: display/msm: qcom, mdp5: Add msm8226 compatible

2023-05-29 Thread Conor Dooley
On Mon, May 29, 2023 at 11:44:00AM +0200, Luca Weiss wrote: > Add the compatible for the MDP5 found on MSM8226. > > Signed-off-by: Luca Weiss Acked-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [Freedreno] [PATCH 2/7] dt-bindings: display/msm: dsi-controller-main: Add msm8226 compatible

2023-05-29 Thread Conor Dooley
On Mon, May 29, 2023 at 11:43:59AM +0200, Luca Weiss wrote: > Add the compatible for the DSI found on MSM8226. > > Signed-off-by: Luca Weiss Acked-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [Freedreno] [PATCH] dt-bindings: yamllint: Require a space after a comment '#'

2023-03-03 Thread Conor Dooley
> '#'. A couple of cases with comments which were not intended to be > comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and > brcm,bcmgenet.yaml. > > Signed-off-by: Rob Herring > --- > Cc: Conor Dooley > diff --git a/Documentation/devicetree/bi