[PATCH 14/14] drm/msm/dp: move interrupt handling to dp_ctrl

2024-11-07 Thread Dmitry Baryshkov
It makes it easier to keep all interrupts-related code in dp_ctrl submodule. Move all functions to dp_ctrl.c. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_aux.c | 9 +-- drivers/gpu/drm/msm/dp/dp_aux.h | 2 +- drivers/gpu/drm/msm/dp/dp_catalog.c | 95

[PATCH 08/14] drm/msm/dp: move/inline panel related functions

2024-11-07 Thread Dmitry Baryshkov
Move panel-related functions to dp_panel.c, following up the cleanup done by the rest of the submodules. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_catalog.c | 114 drivers/gpu/drm/msm/dp/dp_catalog.h | 6 -- drivers/gpu/drm/msm/dp

[PATCH 10/14] drm/msm/dp: drop obsolete audio headers access through catalog

2024-11-07 Thread Dmitry Baryshkov
Drop obsolete functions to access audio packet headers. The dp_audio.c now writes them using msm_dp_write_link() directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_audio.c | 2 - drivers/gpu/drm/msm/dp/dp_catalog.c | 76 - drivers/gpu

[PATCH 13/14] drm/msm/dp: drop struct msm_dp_panel_in

2024-11-07 Thread Dmitry Baryshkov
All other submodules pass arguments directly. Drop struct msm_dp_panel_in that is used to wrap dp_panel's submodule args and pass all data to msm_dp_panel_get() directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 9 + drivers/gpu/drm/msm/dp/dp_pa

[PATCH 12/14] drm/msm/dp: move more AUX functions to dp_aux.c

2024-11-07 Thread Dmitry Baryshkov
Move several misnamed functions accessing AUX bus to dp_aux.c, further cleaning up dp_catalog submodule. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_aux.c | 88 - drivers/gpu/drm/msm/dp/dp_aux.h | 7 +++ drivers/gpu/drm/msm/dp

[PATCH 11/14] drm/msm/dp: move/inline audio related functions

2024-11-07 Thread Dmitry Baryshkov
Move audio-related functions to dp_audio.c, following up the cleanup done by the rest of the submodules. Inline functions with simple register access patterns. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_audio.c | 72 + drivers/gpu/drm/msm/dp

[PATCH 09/14] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets

2024-11-07 Thread Dmitry Baryshkov
Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly to program audio packet data. Use 0 as Packet ID, as it was not programmed earlier. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_audio.c | 288 +- 1 file changed, 66

[PATCH 01/14] drm/msm/dp: fix msm_dp_utils_pack_sdp_header interface

2024-11-07 Thread Dmitry Baryshkov
which nobody actually checks. Fix the function interface to accept u32[2] and return void, skipping all the checks. Fixes: 55fb8ffc1802 ("drm/msm/dp: add VSC SDP support for YUV420 over DP") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_utils.c | 10 +- drivers/gpu/

[PATCH 07/14] drm/msm/dp: move/inline ctrl register functions

2024-11-07 Thread Dmitry Baryshkov
Move CTRL-related functions to dp_ctrl.c, inlining one line wrappers during this process. The enable/disable functions have been split to the enable/disable or enter/exit pairs. The IRQ and HPD related functions are left in dp_catalog.c, pending later cleanup. Signed-off-by: Dmitry Baryshkov

[PATCH 06/14] drm/msm/dp: move/inline AUX register functions

2024-11-07 Thread Dmitry Baryshkov
Move all register-level functions to dp_aux.c, inlining one line wrappers during this process. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_aux.c | 98 +++-- drivers/gpu/drm/msm/dp/dp_catalog.c | 96

[PATCH 05/14] drm/msm/dp: move I/O functions to global header

2024-11-07 Thread Dmitry Baryshkov
Move msm_dp_read()/msm_write_foo() functions to the dp_catalog.h, allowing other modules to access the data directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_catalog.c | 65 drivers/gpu/drm/msm/dp/dp_catalog.h | 66

[PATCH 04/14] drm/msm/dp: pull I/O data out of msm_dp_catalog_private()

2024-11-07 Thread Dmitry Baryshkov
Having I/O regions inside a msm_dp_catalog_private() results in extra layers of one-line wrappers for accessing the data. Move I/O region base and size to the globally visible struct msm_dp_catalog. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_catalog.c | 453

[PATCH 03/14] drm/msm/dp: drop msm_dp_panel_tpg_config()

2024-11-07 Thread Dmitry Baryshkov
Drop even more dead code. The msm_dp_panel_tpg_config() has never been called. Drop it and the implementation inside dp_catalog.c Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_catalog.c | 78 - drivers/gpu/drm/msm/dp/dp_catalog.h | 3

[PATCH 02/14] drm/msm/dp: drop msm_dp_panel_dump_regs() and msm_dp_catalog_dump_regs()

2024-11-07 Thread Dmitry Baryshkov
The msm_dp_panel_dump_regs() and msm_dp_catalog_dump_regs() are not called anywhere. If there is a necessity to dump registers, the snapshotting should be used instead. Drop these two functions. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_catalog.c | 37

[PATCH 00/14] drm/msm/dp: perform misc cleanups

2024-11-07 Thread Dmitry Baryshkov
- Fix register programming in the dp_audio module - Rework most of the register programming functions to be local to the calling module rather than accessing everything through huge dp_catalog monster. Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (14): drm/msm/dp: fix

[PATCH] drm/msm/dpu: rework documentation comments

2024-11-02 Thread Dmitry Baryshkov
se comments and report an error. Signed-off-by: Dmitry Baryshkov --- The documentation can further be improved, but let's move the comments now, close to the end of the development window, reducing the risk of the possible conflicts. --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 46 ---

Re: [PATCH v6 0/9] drm/msm/dpu: support virtual wide planes

2024-11-01 Thread Dmitry Baryshkov
On Fri, 25 Oct 2024 03:20:07 +0300, Dmitry Baryshkov wrote: > As promised in the basic wide planes support ([1]) here comes a series > supporting 2*max_linewidth for all the planes. > > Note: Unlike v1 and v2 this series finally includes support for > additional planes - having m

Re: [PATCH 0/4] drm/msm/mdss: rework UBWC registers programming

2024-11-01 Thread Dmitry Baryshkov
On Sat, 21 Sep 2024 11:17:28 +0300, Dmitry Baryshkov wrote: > Current way of programming of the UBWC-related registers has been > inherited from vendor's drivers. The ubwc_static was supposed to contain > raw data to be programmed to the hardware, but was later repurposed to > d

Re: [PATCH] drm/msm/hdmi: mark interlace_allowed as true

2024-11-01 Thread Dmitry Baryshkov
On Fri, Nov 01, 2024 at 05:40:46PM -0700, Abhinav Kumar wrote: > > > On 11/1/2024 3:26 PM, Dmitry Baryshkov wrote: > > On Fri, 1 Nov 2024 at 23:41, Abhinav Kumar > > wrote: > > > > > > > > > > > > On 10/18/2024 2:10 PM, Dmitry Baryshk

Re: [PATCH] drm/msm/hdmi: mark interlace_allowed as true

2024-11-01 Thread Dmitry Baryshkov
On Fri, 1 Nov 2024 at 23:41, Abhinav Kumar wrote: > > > > On 10/18/2024 2:10 PM, Dmitry Baryshkov wrote: > > The MSM HDMI driver supports interlaced modes. Set the corresponding > > flag to allow interlaced modes on the corresponding connectors. > > >

Re: [PATCH v6 7/9] drm/msm/dpu: add support for virtual planes

2024-11-01 Thread Dmitry Baryshkov
On Fri, Nov 01, 2024 at 01:37:03PM -0700, Abhinav Kumar wrote: > > > On 10/31/2024 2:03 PM, Dmitry Baryshkov wrote: > > On Thu, Oct 31, 2024 at 01:06:34PM -0700, Abhinav Kumar wrote: > > > > > > > > > On 10/31/2024 8:11 AM, Dmitry Baryshkov wrote: &

Re: [PATCH RFC 1/4] drm/dp: Add helper to set LTTPRs in transparent mode

2024-11-01 Thread Dmitry Baryshkov
On Fri, Nov 01, 2024 at 03:43:40PM +0200, Imre Deak wrote: > On Fri, Nov 01, 2024 at 11:22:13AM +0200, Jani Nikula wrote: > > On Thu, 31 Oct 2024, Imre Deak wrote: > > > On Thu, Oct 31, 2024 at 05:12:45PM +0200, Abel Vesa wrote: > > >> According to the DisplayPort standard, LTTPRs have two operati

Re: [PATCH v2] drm/msm/dpu: cast crtc_clk calculation to u64 in _dpu_core_perf_calc_clk()

2024-10-31 Thread Dmitry Baryshkov
ied, thanks! [1/1] drm/msm/dpu: cast crtc_clk calculation to u64 in _dpu_core_perf_calc_clk() https://gitlab.freedesktop.org/lumag/msm/-/commit/20c7b42d9dbd Best regards, -- Dmitry Baryshkov

Re: [PATCH v2 0/3] drm/msm/dp: mass-rename symbols

2024-10-31 Thread Dmitry Baryshkov
On Tue, 29 Oct 2024 22:28:23 +0200, Dmitry Baryshkov wrote: > The LKP reported [1] a symbol clash between the drm/msm/dp and the HIMBC > driver being sumbitted, because both of them use a generic dp_ prefix > for a lot of symbols. It's a hight time we made msm/dp driver use &g

Re: [PATCH 0/3] drm/msm: minor msm_drv.h cleanup

2024-10-31 Thread Dmitry Baryshkov
On Thu, 31 Oct 2024 23:44:05 +0200, Dmitry Baryshkov wrote: > As I stumbled upon msm_display_topology define, perform minor cleanup of > msm_drv.h incldue file. > > Applied, thanks! [1/3] drm/msm: move msm_display_topology to the DPU driver https://gitlab.freedesktop.o

[PATCH 2/3] drm/msm: move MAX_H_TILES_PER_DISPLAY to the DPU driver

2024-10-31 Thread Dmitry Baryshkov
The MAX_H_TILES_PER_DISPLAY const is only used by the DPU driver, move it to the corresponding header. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h | 2 ++ drivers/gpu/drm/msm/msm_drv.h | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH v3 03/23] drm/msm/dpu: get rid of struct dpu_rm_requirements

2024-10-31 Thread Dmitry Baryshkov
On Wed, Oct 16, 2024 at 06:21:09PM -0700, Jessica Zhang wrote: > From: Dmitry Baryshkov > > The struct dpu_rm_requirements was used to wrap display topology and > hw resources, which meant INTF indices. As of commit ef58e0ad3436 > ("drm/msm/dpu: get INTF blocks directly ra

[PATCH 1/3] drm/msm: move msm_display_topology to the DPU driver

2024-10-31 Thread Dmitry Baryshkov
The struct msm_display_topology is only used by the DPU driver. Remove it from the global header and move it to DPU-specific header. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 16 drivers/gpu/drm/msm/msm_drv.h | 16 2

[PATCH 3/3] drm/msm: drop MAX_BRIDGES define

2024-10-31 Thread Dmitry Baryshkov
The const MAX_BRIDGES is unused after the commit 4d1a1e4686bd ("drm/msm: remove msm_drm_private::bridges field"), drop it now. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_drv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/g

[PATCH 0/3] drm/msm: minor msm_drv.h cleanup

2024-10-31 Thread Dmitry Baryshkov
As I stumbled upon msm_display_topology define, perform minor cleanup of msm_drv.h incldue file. Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (3): drm/msm: move msm_display_topology to the DPU driver drm/msm: move MAX_H_TILES_PER_DISPLAY to the DPU driver drm/msm: drop

Re: [PATCH v6 7/9] drm/msm/dpu: add support for virtual planes

2024-10-31 Thread Dmitry Baryshkov
On Thu, Oct 31, 2024 at 01:06:34PM -0700, Abhinav Kumar wrote: > > > On 10/31/2024 8:11 AM, Dmitry Baryshkov wrote: > > Hi Abhinav, > > > > On Wed, 30 Oct 2024 at 21:26, Abhinav Kumar > > wrote: > > > > > > > > > > > >

Re: [PATCH v3 05/23] drm/msm/dpu: move resource allocation to CRTC

2024-10-31 Thread Dmitry Baryshkov
On Wed, Oct 16, 2024 at 06:21:11PM -0700, Jessica Zhang wrote: > From: Dmitry Baryshkov > > All resource allocation is centered around the LMs. Then other blocks > (except DSCs) are allocated basing on the LMs that was selected, and LM > powers up the CRTC rather than the encoder

Re: [RFC PATCH] i2c: skip of_i2c_register_device() for invalid child nodes

2024-10-31 Thread Dmitry Baryshkov
On Thu, Oct 31, 2024 at 11:45:53AM -0700, Abhinav Kumar wrote: > > > On 10/31/2024 11:23 AM, Dmitry Baryshkov wrote: > > On Wed, 30 Oct 2024 at 03:07, Abhinav Kumar > > wrote: > > > > > > of_i2c_register_devices() adds all child nodes of a given i2c bu

Re: [PATCH v3 05/23] drm/msm/dpu: move resource allocation to CRTC

2024-10-31 Thread Dmitry Baryshkov
On Thu, Oct 31, 2024 at 12:37:03PM -0700, Abhinav Kumar wrote: > > > On 10/16/2024 6:21 PM, Jessica Zhang wrote: > > From: Dmitry Baryshkov > > > > All resource allocation is centered around the LMs. Then other blocks > > (except DSCs) are allocated basing on

Re: [RFC PATCH] i2c: skip of_i2c_register_device() for invalid child nodes

2024-10-31 Thread Dmitry Baryshkov
On Wed, 30 Oct 2024 at 03:07, Abhinav Kumar wrote: > > of_i2c_register_devices() adds all child nodes of a given i2c bus > however in certain device trees of_alias_from_compatible() and > of_property_read_u32() can fail as the child nodes of the device > might not be valid i2c client devices. One

Re: [PATCH RFC 2/4] drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode

2024-10-31 Thread Dmitry Baryshkov
On Thu, Oct 31, 2024 at 05:12:46PM +0200, Abel Vesa wrote: > LTTPRs operating modes are defined by the DisplayPort standard and the > generic framework now provides a helper to switch between them. > So use the drm generic helper instead as it makes the code a bit cleaner. > > Signed-off-by: Abel

Re: [PATCH RFC 4/4] drm/msm/dp: Add support for LTTPR handling

2024-10-31 Thread Dmitry Baryshkov
On Thu, Oct 31, 2024 at 05:12:48PM +0200, Abel Vesa wrote: > Link Training Tunable PHY Repeaters (LTTPRs) are defined in DisplayPort > 1.4a specification. As the name suggests, these PHY repeaters are > capable of adjusting their output for link training purposes. > > The msm DP driver is currentl

Re: [PATCH v6 7/9] drm/msm/dpu: add support for virtual planes

2024-10-31 Thread Dmitry Baryshkov
On Thu, 31 Oct 2024 at 17:11, Dmitry Baryshkov wrote: > > Hi Abhinav, > > On Wed, 30 Oct 2024 at 21:26, Abhinav Kumar wrote: > > On 10/30/2024 3:48 AM, Dmitry Baryshkov wrote: > > > On Tue, Oct 29, 2024 at 02:30:12PM -0700, Abhinav Kumar wrote: > > >>

Re: [PATCH v6 7/9] drm/msm/dpu: add support for virtual planes

2024-10-31 Thread Dmitry Baryshkov
Hi Abhinav, On Wed, 30 Oct 2024 at 21:26, Abhinav Kumar wrote: > > > > On 10/30/2024 3:48 AM, Dmitry Baryshkov wrote: > > On Tue, Oct 29, 2024 at 02:30:12PM -0700, Abhinav Kumar wrote: > >> > >> > >> On 10/24/2024 5:20 PM, Dmitry Baryshkov wrote

Re: [PATCH v6 7/9] drm/msm/dpu: add support for virtual planes

2024-10-30 Thread Dmitry Baryshkov
On Tue, Oct 29, 2024 at 02:30:12PM -0700, Abhinav Kumar wrote: > > > On 10/24/2024 5:20 PM, Dmitry Baryshkov wrote: > > Only several SSPP blocks support such features as YUV output or scaling, > > thus different DRM planes have different features. Properly utilizing > &

Re: [PATCH v6 8/9] drm/msm/dpu: allow using two SSPP blocks for a single plane

2024-10-30 Thread Dmitry Baryshkov
On Tue, Oct 29, 2024 at 03:07:30PM -0700, Abhinav Kumar wrote: > > > On 10/24/2024 5:20 PM, Dmitry Baryshkov wrote: > > Virtual wide planes give high amount of flexibility, but it is not > > always enough: > > > > In parallel multirect case only the half of the

[PATCH v2 0/3] drm/msm/dp: mass-rename symbols

2024-10-29 Thread Dmitry Baryshkov
d-all/202410250305.uhkdhtxy-...@intel.com/ Signed-off-by: Dmitry Baryshkov --- Changes in v2: - Switched eDP symbols from msm_dp_foo_edp to msm_edp_foo (Abhinav) - Link to v1: https://lore.kernel.org/r/20241028-msm-dp-rename-v1-0-a2564e945...@linaro.org --- Dmitry Baryshkov (3): drm/msm/dp: prefi

[PATCH v2 2/3] drm/msm/dp: rename edp_ bridge functions and struct

2024-10-29 Thread Dmitry Baryshkov
Follow the estalished prefix and rename eDP bridge symbols to use msm_edp_ prefix, moving the edp to the end of the symbol name. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_drm.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff

[PATCH v2 3/3] drm/msm/dp: tidy up platform data names

2024-10-29 Thread Dmitry Baryshkov
Follow the established symbol name pattern and rename platform data structures. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 38 ++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers

Re: [PATCH 2/3] drm/msm/dp: rename edp_ bridge functions and struct

2024-10-29 Thread Dmitry Baryshkov
On Tue, 29 Oct 2024 at 20:08, Abhinav Kumar wrote: > > > > On 10/28/2024 4:49 AM, Dmitry Baryshkov wrote: > > Follow the estalished prefix and rename eDP bridge symbols to use > > msm_dp_ prefix, moving the edp to the end of the symbol name. > > >

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
Please no empty lines between tags. > Signed-off-by: Akhil P Oommen After all the discussions: Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 1 + > drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 34 ++ > 2 files chan

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, Oct 28, 2024 at 12:31:50PM +0100, Konrad Dybcio wrote: > On 28.10.2024 11:52 AM, Dmitry Baryshkov wrote: > > On Mon, Oct 28, 2024 at 11:36:15AM +0100, Konrad Dybcio wrote: > >> On 28.10.2024 11:27 AM, Dmitry Baryshkov wrote: > >>> On Mon, 28 Oct 2024 at 12:08

[PATCH 3/3] drm/msm/dp: tidy up platform data names

2024-10-28 Thread Dmitry Baryshkov
Follow the established symbol name pattern and rename platform data structures. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 38 ++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c

[PATCH 2/3] drm/msm/dp: rename edp_ bridge functions and struct

2024-10-28 Thread Dmitry Baryshkov
Follow the estalished prefix and rename eDP bridge symbols to use msm_dp_ prefix, moving the edp to the end of the symbol name. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_drm.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff

[PATCH 0/3] drm/msm/dp: mass-rename symbols

2024-10-28 Thread Dmitry Baryshkov
d-all/202410250305.uhkdhtxy-...@intel.com/ Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (3): drm/msm/dp: prefix all symbols with msm_dp_ drm/msm/dp: rename edp_ bridge functions and struct drm/msm/dp: tidy up platform data names drivers/gpu/drm/msm/dp/dp_audio.c

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, Oct 28, 2024 at 11:36:15AM +0100, Konrad Dybcio wrote: > On 28.10.2024 11:27 AM, Dmitry Baryshkov wrote: > > On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen > > wrote: > >> > >> On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: > >>> On Sun, Oct

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, Oct 28, 2024 at 11:39:16AM +0100, Konrad Dybcio wrote: > On 28.10.2024 10:52 AM, Akhil P Oommen wrote: > > On 10/28/2024 12:13 AM, Arnd Bergmann wrote: > >> On Sun, Oct 27, 2024, at 18:05, Akhil P Oommen wrote: > >>> Clang-19 and above sometimes end up with multiple copies of the large > >>

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Mon, 28 Oct 2024 at 12:08, Akhil P Oommen wrote: > > On 10/28/2024 1:56 PM, Dmitry Baryshkov wrote: > > On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: > >> Clang-19 and above sometimes end up with multiple copies of the large > >> a6xx_hfi_msg_b

Re: [PATCH v6 2/9] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check

2024-10-28 Thread Dmitry Baryshkov
On Fri, Oct 25, 2024 at 12:00:20PM -0700, Abhinav Kumar wrote: > > > On 10/24/2024 5:20 PM, Dmitry Baryshkov wrote: > > In preparation for virtualized planes support, move pstate->pipe > > initialization from dpu_plane_reset() to dpu_plane_atomic_check(). In > &

Re: [PATCH] drm/msm/a6xx: Fix excessive stack usage

2024-10-28 Thread Dmitry Baryshkov
On Sun, Oct 27, 2024 at 11:35:47PM +0530, Akhil P Oommen wrote: > Clang-19 and above sometimes end up with multiple copies of the large > a6xx_hfi_msg_bw_table structure on the stack. The problem is that > a6xx_hfi_send_bw_table() calls a number of device specific functions to > fill the structure,

Re: [PATCH 1/3] drm/msm: Avoid NULL dereference in msm_disp_state_print_regs()

2024-10-26 Thread Dmitry Baryshkov
dump_addr = *reg; > > [...] Applied, thanks! [3/3] drm/msm: Simplify NULL checking in msm_disp_state_dump_regs() https://gitlab.freedesktop.org/lumag/msm/-/commit/74c374648ed0 Best regards, -- Dmitry Baryshkov

[PATCH v2 1/2] arm64: dts: qcom: sm8550: correct MDSS interconnects

2024-10-26 Thread Dmitry Baryshkov
-LLCC and LLCC-EBI paths. Fixes: d7da51db5b81 ("arm64: dts: qcom: sm8550: add display hardware devices") Cc: sta...@kernel.org Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boo

[PATCH v2 2/2] arm64: dts: qcom: sm8650: correct MDSS interconnects

2024-10-26 Thread Dmitry Baryshkov
-LLCC and LLCC-EBI paths. Fixes: 10e024671295 ("arm64: dts: qcom: sm8650: add interconnect dependent device nodes") Cc: sta...@kernel.org Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/

[PATCH v2 0/2] arm64: dts: qcom: sm8[56]50: correct MDSS interconnects

2024-10-26 Thread Dmitry Baryshkov
paths (and LLCC-EBI should not be a part of such division). Drop mdp1-mem paths and use MDP-EBI path directly. Signed-off-by: Dmitry Baryshkov --- Changes in v2: - Fixed type in 'degrading' in the commit messages (Konrad) - Link to v1: https://lore.kernel.org/r/20241008-fix-sm8

Re: [PATCH] drm/msm/gpu: Fix missing error check for dev_pm_qos_add_request()

2024-10-26 Thread Dmitry Baryshkov
On Sat, Oct 26, 2024 at 05:37:38PM +0800, Jinjie Ruan wrote: > dev_pm_qos_add_request() can fail, and it returns -EINVAL in case of > wrong parameters, return -ENOMEM if there's not enough memory to allocate > for data structures, and return -ENODEV if the device has just been > removed from the sy

Re: [PATCH 0/2] drm: Treewide plane/crtc legacy state sweeping

2024-10-25 Thread Dmitry Baryshkov
On Fri, 25 Oct 2024 at 10:46, Ville Syrjälä wrote: > > On Wed, Oct 02, 2024 at 09:21:58PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > An attempt to hide the drm_plane/crtc legacy state better. > > > > This also highlights the fact that a lot of supposedly > > atomic drivers are po

[PATCH v6 5/9] drm/msm/dpu: split dpu_plane_atomic_check()

2024-10-25 Thread Dmitry Baryshkov
Split dpu_plane_atomic_check() function into two pieces: dpu_plane_atomic_check_nosspp() performing generic checks on the pstate, without touching the associated SSPP blocks, and dpu_plane_atomic_check_sspp(), which takes into account used SSPPs. Signed-off-by: Dmitry Baryshkov --- drivers

Re: [PATCH v2 2/3] dt-bindings: opp: Add v2-qcom-adreno vendor bindings

2024-10-24 Thread Dmitry Baryshkov
On Thu, Oct 24, 2024 at 12:56:58AM +0530, Akhil P Oommen wrote: > On 10/22/2024 11:19 AM, Krzysztof Kozlowski wrote: > > On Mon, Oct 21, 2024 at 05:23:43PM +0530, Akhil P Oommen wrote: > >> Add a new schema which extends opp-v2 to support a new vendor specific > >> property required for Adreno GPUs

[PATCH v6 7/9] drm/msm/dpu: add support for virtual planes

2024-10-24 Thread Dmitry Baryshkov
resolution. Note #2: By default support for virtual planes is turned off and the driver still uses old code path with preallocated SSPP block for each plane. To enable virtual planes, pass 'msm.dpu_use_virtual_planes=1' kernel parameter. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/dr

Re: [PATCH v2 4/4] arm64: dts: qcom: sa8775p-ride: Enable Adreno 663 GPU

2024-10-24 Thread Dmitry Baryshkov
/dts/qcom/sa8775p-ride.dtsi | 8 > 1 file changed, 8 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

Re: [PATCH v2 3/4] arm64: dts: qcom: sa8775p: Add gpu and gmu nodes

2024-10-24 Thread Dmitry Baryshkov
aswi > Signed-off-by: Akhil P Oommen > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 94 > +++ > 1 file changed, 94 insertions(+) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

[PATCH v6 8/9] drm/msm/dpu: allow using two SSPP blocks for a single plane

2024-10-24 Thread Dmitry Baryshkov
cases and allows all planes to go up to 2*max_linewidth (at the cost of making some of the planes unavailable to the user). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 163 ++ 1 file changed, 119 insertions(+), 44 deletions(-) diff

[PATCH v6 3/9] drm/msm/dpu: drop virt_formats from SSPP subblock configuration

2024-10-24 Thread Dmitry Baryshkov
-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 12 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 4 2 files changed, 16 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c index

[PATCH v6 9/9] drm/msm/dpu: include SSPP allocation state into the dumped state

2024-10-24 Thread Dmitry Baryshkov
Make dpu_rm_print_state() also output the SSPP allocation state. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp

[PATCH v6 2/9] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check

2024-10-24 Thread Dmitry Baryshkov
In preparation for virtualized planes support, move pstate->pipe initialization from dpu_plane_reset() to dpu_plane_atomic_check(). In case of virtual planes the plane's pipe will not be known up to the point of atomic_check() callback. Signed-off-by: Dmitry Baryshkov --- drivers/gpu

[PATCH v6 6/9] drm/msm/dpu: move rot90 checking to dpu_plane_atomic_check_sspp()

2024-10-24 Thread Dmitry Baryshkov
Move a call to dpu_plane_check_inline_rotation() to the dpu_plane_atomic_check_sspp() function, so that the rot90 constraints are checked for both SSPP blocks. Also move rotation field from struct dpu_plane_state to struct dpu_sw_pipe_cfg. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm

[PATCH v6 4/9] drm/msm/dpu: move scaling limitations out of the hw_catalog

2024-10-24 Thread Dmitry Baryshkov
, this will have to be handled separately, after the plane refactoring. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 16 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 4 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 16

[PATCH v6 1/9] drm/msm/dpu: use drm_rect_fp_to_int()

2024-10-24 Thread Dmitry Baryshkov
Use the drm_rect_fp_to_int() helper instead of using the hand-written code. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1

[PATCH v6 0/9] drm/msm/dpu: support virtual wide planes

2024-10-24 Thread Dmitry Baryshkov
one of fixups, it was left uncommitted. - Implementated proper handling of wide plane rotation & reflection. --- Dmitry Baryshkov (9): drm/msm/dpu: use drm_rect_fp_to_int() drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check drm/msm/dpu: drop virt_format

Re: [PATCH 0/6] drm/bridge: add ycbcr_420_allowed support

2024-10-24 Thread Dmitry Baryshkov
On Sat, 19 Oct 2024 00:49:11 +0300, Dmitry Baryshkov wrote: > One of the features that drm_bridge_connector can't handle currently is > setting of the ycbcr_420_allowed flag on the connector. Add the flag to > the drm_bridge struct and propagate it to the drm_connector as AND of >

Re: [PATCH 0/6] drm/bridge: add ycbcr_420_allowed support

2024-10-21 Thread Dmitry Baryshkov
On Mon, 21 Oct 2024 at 15:32, Neil Armstrong wrote: > > Hi, > > On 18/10/2024 23:49, Dmitry Baryshkov wrote: > > One of the features that drm_bridge_connector can't handle currently is > > setting of the ycbcr_420_allowed flag on the connector. Add the flag to

Re: [PATCH v5 0/5] Add support for DisplayPort on SA8775P platform

2024-10-21 Thread Dmitry Baryshkov
https://gitlab.freedesktop.org/lumag/msm/-/commit/c51ff89a8139 [5/5] drm/msm/dp: Add DisplayPort controller for SA8775P https://gitlab.freedesktop.org/lumag/msm/-/commit/dcb380d19e58 Best regards, -- Dmitry Baryshkov

Re: [PATCH -next v2] drm/msm: Remove unneeded semicolon

2024-10-21 Thread Dmitry Baryshkov
unnecessary and can lead to confusion in the code structure. > > > [...] Applied, thanks! [1/1] drm/msm: Remove unneeded semicolon https://gitlab.freedesktop.org/lumag/msm/-/commit/00adf52efec3 Best regards, -- Dmitry Baryshkov

Re: [PATCH v6 00/15] drm/msm/dpu: be more friendly to X.org

2024-10-21 Thread Dmitry Baryshkov
On Tue, 03 Sep 2024 06:22:43 +0300, Dmitry Baryshkov wrote: > Unlike other compositors X.org allocates a single framebuffer covering > the whole screen space. This is not an issue with the single screens, > but with the multi-monitor setup 5120x4096 becomes a limiting factor. &g

Re: [PATCH v5 0/5] Display enablement changes for Qualcomm SA8775P platform

2024-10-21 Thread Dmitry Baryshkov
ag/msm/-/commit/546f8d6c3ed1 [3/5] drm/msm: mdss: Add SA8775P support https://gitlab.freedesktop.org/lumag/msm/-/commit/4d1cd4c3faec [4/5] drm/msm/dpu: Add SA8775P support https://gitlab.freedesktop.org/lumag/msm/-/commit/b139c80d181c Best regards, -- Dmitry Baryshkov

Re: [PATCH 0/5] dt-bindings: display/msm: dpu: merge bindings

2024-10-21 Thread Dmitry Baryshkov
into SC7280 https://gitlab.freedesktop.org/lumag/msm/-/commit/342d48210577 Best regards, -- Dmitry Baryshkov

Re: [PATCH][next] drm/msm8998: make const arrays ratio_list and band_list static

2024-10-21 Thread Dmitry Baryshkov
tatic https://gitlab.freedesktop.org/lumag/msm/-/commit/71f40d32fa4b Best regards, -- Dmitry Baryshkov

Re: [PATCH 0/3] drm/msm/dpu: catalog fixes for SDM845 / MSM8998

2024-10-21 Thread Dmitry Baryshkov
On Thu, 05 Sep 2024 06:26:12 +0300, Dmitry Baryshkov wrote: > Drop two extra blocks that sneaked into SDM845 and MSM8998 catalog > declarations. > > Applied, thanks! [1/3] drm/msm/dpu: on SDM845 move DSPP_3 to LM_5 block https://gitlab.freedesktop.org/lumag/msm/-/commit/768

Re: [PATCH v2 0/4] Add MSM8996/MSM8953/MSM8937/MSM8917 dpu catalog

2024-10-21 Thread Dmitry Baryshkov
t for MSM8953 https://gitlab.freedesktop.org/lumag/msm/-/commit/7a6109ce1c2c [3/4] drm/msm/dpu: Add support for MSM8937 https://gitlab.freedesktop.org/lumag/msm/-/commit/c079680bb0fa [4/4] drm/msm/dpu: Add support for MSM8917 https://gitlab.freedesktop.org/lumag/msm/-/commit/62af6e1cb596 Best regards, -- Dmitry Baryshkov

Re: [PATCH 3/6] drm/bridge: display-connector: allow YCbCr 420 for HDMI and DP

2024-10-21 Thread Dmitry Baryshkov
On Mon, 21 Oct 2024 at 10:29, Neil Armstrong wrote: > > On 18/10/2024 23:49, Dmitry Baryshkov wrote: > > Allow YCbCr 420 output for HDMI and DisplayPort connectors. Other > > bridges in the chain still might limit YCbCr 420 support on the > > corresponding connector. >

Re: [PATCH v4 0/5] Display enablement changes for Qualcomm SA8775P platform

2024-10-19 Thread Dmitry Baryshkov
On Sat, Oct 19, 2024 at 09:13:23PM +0530, Mahadevan P wrote: > I apologize for the inconvenience caused by uploading the incorrect patch > (v4). Kindly disregard it. One thing makes me wonder. You are using b4 tool. It should handle versioning, changelogs, etc for you. However despite all of that

Re: [PATCH] drm: a6xx: avoid excessive stack usage

2024-10-19 Thread Dmitry Baryshkov
On Sat, Oct 19, 2024 at 03:01:46PM +0530, Akhil P Oommen wrote: > On Fri, Oct 18, 2024 at 03:11:38PM +, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > Clang-19 and above sometimes end up with multiple copies of the large > > a6xx_hfi_msg_bw_table structure on the stack. The problem is t

[PATCH] drm/msm/hdmi: mark interlace_allowed as true

2024-10-18 Thread Dmitry Baryshkov
The MSM HDMI driver supports interlaced modes. Set the corresponding flag to allow interlaced modes on the corresponding connectors. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/hdmi

[PATCH 5/6] drm/msm/dp: migrate the ycbcr_420_allowed to drm_bridge

2024-10-18 Thread Dmitry Baryshkov
Instead of forcing the ycbcr_420_allowed flag to be set on the created drm_connector, set it on the drm_bridge instance and allow drm_bridge_connecgtor to propagate it to the drm_connector. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 4 ++-- drivers/gpu/drm/msm/dp

[PATCH 3/6] drm/bridge: display-connector: allow YCbCr 420 for HDMI and DP

2024-10-18 Thread Dmitry Baryshkov
Allow YCbCr 420 output for HDMI and DisplayPort connectors. Other bridges in the chain still might limit YCbCr 420 support on the corresponding connector. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/display-connector.c | 4 1 file changed, 4 insertions(+) diff --git a

[PATCH 4/6] drm/bridge: aux: allow interlaced and YCbCr 420 output

2024-10-18 Thread Dmitry Baryshkov
As both aux bridges are merely passthrough bridges, mark them as supporting interlaced and YCbCr 420 data. Other bridges in the chain still might limit interlaced and YCbCr 420 data support on the corresponding connector. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/aux-bridge.c

[PATCH 6/6] drm/bridge: dw-hdmi: set bridge's ycbcr_420_allowed flag

2024-10-18 Thread Dmitry Baryshkov
Set the drm_bridge's ycbcr_420_allowed flag if the YCbCr 420 output is supported by the hardware. Cc: Alexander Stein Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-h

[PATCH 0/6] drm/bridge: add ycbcr_420_allowed support

2024-10-18 Thread Dmitry Baryshkov
ag on the DW HDMI bridge, MSM DP bridge, display connector drivers (for DisplayPort and HDMI outputs) and AUX bridges. Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (6): drm/display: bridge_connector: handle ycbcr_420_allowed drm/atomic: add interlaced and ycbcr_420 fla

[PATCH 2/6] drm/atomic: add interlaced and ycbcr_420 flags to connector's state dump

2024-10-18 Thread Dmitry Baryshkov
Although the interlace_allowed and ycbcr_420_allowed flags are a part of the struct drm_connector rather than struct drm_connector_state, still include them into state dump in order to ease debugging of the setup issues. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_atomic.c | 2 ++ 1

[PATCH 1/6] drm/display: bridge_connector: handle ycbcr_420_allowed

2024-10-18 Thread Dmitry Baryshkov
Follow the interlace_allowed example and calculate drm_connector's ycbcr_420_allowed flag as AND of all drm_bridge's ycbcr_420_allowed flags in a chain. This is one of the gaps between several bridge-specific connector implementations and drm_bridge_connector. Signed-off-by: Dmitry

Re: [PATCH] drm/msm/gpu: Check the status of registration to PM QoS

2024-10-18 Thread Dmitry Baryshkov
On Fri, Oct 18, 2024 at 12:18:11PM +0100, Lukasz Luba wrote: > There is a need to check the returned value of the registration function. Why? > In case of returned error, print that and stop the init process. > > Fixes: 7c0ffcd40b16 ("drm/msm/gpu: Respect PM QoS constraints") > Signed-off-by: Lu

Re: [PATCH v4 1/5] dt-bindings: display/msm: Document MDSS on SA8775P

2024-10-18 Thread Dmitry Baryshkov
On Wed, Oct 09, 2024 at 08:02:01PM +0530, Mahadevan wrote: > Document the MDSS hardware found on the Qualcomm SA8775P platform. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Mahadevan > --- > .../bindings/display/msm/qcom,sa8775p-mdss.yaml| 241 > + > 1 file cha

Re: [PATCH v5 0/5] Add support for DisplayPort on SA8775P platform

2024-10-18 Thread Dmitry Baryshkov
On Fri, Oct 18, 2024 at 12:37:01PM +0530, Soutrik Mukhopadhyay wrote: > This series adds support for the DisplayPort controller > and eDP PHY v5 found on the Qualcomm SA8775P platform. > > --- > v2: Fixed review comments from Dmitry and Bjorn > - Made aux_cfg array as const. > - Reused

Re: [PATCH v3] drm/display: Drop obsolete dependency on COMPILE_TEST

2024-10-17 Thread Dmitry Baryshkov
depends on OF > > Perhaps nobody landed this because you're missing the msm maintainers > as specified by `./scripts/get_maintainer.pl -f > drivers/gpu/drm/msm/Kconfig` ? I've added them here. It seems like > we'd at least need an Ack by those guys since this mod

Re: [PATCH] drm/msm/dpu: Don't always set merge_3d pending flush

2024-10-15 Thread Dmitry Baryshkov
ers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 5 - > 2 files changed, 8 insertions(+), 2 deletions(-) > Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry

  1   2   3   4   5   6   7   8   9   10   >