CI for the CI maintainers.
But otherwise, LGTM
Reviewed-by: Abhinav Kumar
Yes, good idea: https://gitlab.freedesktop.org/drm/msm/-/merge_requests/119
Nice to see new tests passing!
Acked-by: Helen Koike
I'm applying it to drm-misc-next
Thanks,
Helen
diff --git a/drivers/gp
On 03/05/2024 17:23, Dmitry Baryshkov wrote:
On Fri, 3 May 2024 at 21:15, Dmitry Baryshkov
wrote:
In order to remove pointless messages regarding missing lxml, skip
validation of MSM register files against the schema. Only the driver
developers really care and/or can fix the files.
Keep th
ng kernels.
This answered my second question actually. That basically I didnt also
want EXPERT to find its way into actual running kernels.
Hence, I am fine with this change now
Reviewed-by: Abhinav Kumar
But, I will wait to hear from helen, vignesh about what they think of this.
lgfm
Acked-by: Helen Koike
Thanks
Helen
On 25/04/2024 11:01, Helen Koike wrote:
On 08/04/2024 14:04, Abhinav Kumar wrote:
Hi Helen
Gentle reminder on this.
If you are okay, we can land it via msm-next tree...
Thanks
Abhinav
On 4/1/2024 1:48 PM, Abhinav Kumar wrote:
After IGT migrating to dynamic sub-tests, the pipe
x27;t correctly work and was
resulting in those failures not being seen.
Here is the passing pipeline for apq8016 with this change:
https://gitlab.freedesktop.org/drm/msm/-/jobs/57050562
Signed-off-by: Abhinav Kumar
I'm sorry about my delay.
Acked-by: Helen Koike
I'm also merging it t
On 20/02/2024 09:17, Dmitry Baryshkov wrote:
Bump IGT revision to pick up Rob Clark's fixes for the msm driver:
- msm_submit@invalid-duplicate-bo-submit,Fail
Signed-off-by: Dmitry Baryshkov
Do you have a gitlab pipeline link I can check?
Thanks
Helen
---
drivers/gpu/drm/ci/gitlab-ci.
On 19/02/2024 17:25, Helen Koike wrote:
On 18/02/2024 01:12, Dmitry Baryshkov wrote:
The test kms_universal_plane@universal-plane-sanity fails on both SC7180
platforms. The drm/msm returns -ERANGE as it can not handle passet
scaling range, however the test is not ready to handle that. Mark
On 19/02/2024 17:26, Helen Koike wrote:
On 18/02/2024 01:12, Dmitry Baryshkov wrote:
Mark two tests as passing on the APQ8096 / db820c platform.
Signed-off-by: Dmitry Baryshkov
Acked-by: Helen Koike
Applied to drm-misc/drm-misc-next
Thanks
Helen
---
drivers/gpu/drm/ci/xfails
On 19/02/2024 17:25, Helen Koike wrote:
On 19/02/2024 14:42, Dmitry Baryshkov wrote:
On Mon, 19 Feb 2024 at 18:48, Helen Koike
wrote:
On 19/02/2024 11:33, Dmitry Baryshkov wrote:
On Mon, 19 Feb 2024 at 15:21, Helen Koike
wrote:
Hi Dmitry,
On 18/02/2024 01:12, Dmitry Baryshkov
On 18/02/2024 01:12, Dmitry Baryshkov wrote:
Mark two tests as passing on the APQ8096 / db820c platform.
Signed-off-by: Dmitry Baryshkov
Acked-by: Helen Koike
---
drivers/gpu/drm/ci/xfails/msm-apq8096-fails.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/ci
merical result out of range
Signed-off-by: Dmitry Baryshkov
Acked-by: Helen Koike
---
.../gpu/drm/ci/xfails/msm-sc7180-trogdor-kingoftown-fails.txt| 1 +
.../drm/ci/xfails/msm-sc7180-trogdor-lazor-limozeen-fails.txt| 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/c
On 19/02/2024 14:42, Dmitry Baryshkov wrote:
On Mon, 19 Feb 2024 at 18:48, Helen Koike wrote:
On 19/02/2024 11:33, Dmitry Baryshkov wrote:
On Mon, 19 Feb 2024 at 15:21, Helen Koike wrote:
Hi Dmitry,
On 18/02/2024 01:12, Dmitry Baryshkov wrote:
Since the addition of testlist.txt
On 19/02/2024 11:47, Vignesh Raman wrote:
On 17/02/24 02:26, Dmitry Baryshkov wrote:
The commit ea489a3d983b ("drm/ci: add sc7180-trogdor-kingoftown")
dropped the msm-sc7180-skips.txt file, which disabled suspend-to-RAM
tests. However testing shows that STR tests still can fail. Restore the
On 19/02/2024 11:33, Dmitry Baryshkov wrote:
On Mon, 19 Feb 2024 at 15:21, Helen Koike wrote:
Hi Dmitry,
On 18/02/2024 01:12, Dmitry Baryshkov wrote:
Since the addition of testlist.txt the IGT has changed some of test
names. Some test names were changed to use '-' instead
Hi Dmitry,
On 18/02/2024 01:12, Dmitry Baryshkov wrote:
Since the addition of testlist.txt the IGT has changed some of test
names. Some test names were changed to use '-' instead of '_'. In other
cases tests were just renamed. Follow those changes.
Signed-off-by: Dmitry Baryshkov
Thanks for
On 14/02/2024 10:30, Helen Koike wrote:
On 14/02/2024 05:37, Dmitry Baryshkov wrote:
If the ADV7511 bridge driver is compiled as a module, while DRM_MSM is
built-in, the clk_disable_unused congests with the runtime PM handling
of the DSI PHY for the clk_prepare_lock(). This causes apq8016
ctory")
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Dmitry Baryshkov
Acked-by: Helen Koike
Thanks
Helen
---
Changes in v2:
- Added a comment, describing the issue and a way to reproduce it
(Javier)
---
drivers/gpu/drm/ci/test.yml | 5 -
1 file changed, 4 insertions(+),
On 04/01/2024 05:14, Vignesh Raman wrote:
Add job that executes the IGT test suite for sc7180-trogdor-kingoftown.
This commit also updates xfails for sc7180-trogdor-lazor-limozeen.
Signed-off-by: Vignesh Raman
Applied to drm-misc-next.
Thanks
Helen
---
See pipeline:
https://gitlab.fr
fetch issue. Uprev mesa in drm-ci to fix this.
This commit updates the kernel tag and adds .never-post-merge-rules
due to the mesa uprev. It also fixes an issue where the virtio-gpu
pipeline was not getting created with the mesa uprev.
Reviewed-by: David Heidelberg
Acked-by: Helen Koike
Reviewed
On 15/01/2024 07:17, Vignesh Raman wrote:
msm tests are added to testlist.txt, so update the xfails
for jobs in msm stage.
Signed-off-by: Vignesh Raman
Applied to drm-misc-next.
Thanks
Helen
---
Depends on
https://patchwork.kernel.org/project/linux-arm-msm/patch/20240108195016.156583-
On 08/01/2024 16:50, Rob Clark wrote:
From: Rob Clark
The msm tests should skip on non-msm hw, so I think it should be safe to
enable everywhere.
Signed-off-by: Rob Clark
Applied to drm-misc-next.
Thanks
Helen
---
drivers/gpu/drm/ci/testlist.txt | 49
-msm hw, so I think it should be
safe to
enable everywhere.
Signed-off-by: Rob Clark
Acked-by: Helen Koike
---
drivers/gpu/drm/ci/testlist.txt | 49
+
1 file changed, 49 insertions(+)
diff --git a/drivers/gpu/drm/ci/testlist.txt
b/drivers/gpu/drm/ci
/gfx-ci/linux/-/commit/4b49f902ec6f2bb382cbbf489870573f4b43371e
+#
https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/38cdf4c5559771e2474ae0fecef8469f65147bc1
Any chance we could make an upstream patch to solve this?
+msm_mapping@*
In any case:
Acked-by: Helen Koike
Thanks
Helen
On 04/01/2024 05:14, Vignesh Raman wrote:
Add job that executes the IGT test suite for sc7180-trogdor-kingoftown.
This commit also updates xfails for sc7180-trogdor-lazor-limozeen.
Signed-off-by: Vignesh Raman
lgtm
Acked-by: Helen Koike
Thanks
Helen
---
See pipeline:
https
-by: Helen Koike
Thanks
Helen
---
drivers/gpu/drm/ci/gitlab-ci.yml | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
.
Suggested-by: David Heidelberg
Signed-off-by: Dmitry Baryshkov
Acked-by: Helen Koike
Thanks!
Helen
---
drivers/gpu/drm/ci/build.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/ci/build.sh b/drivers/gpu/drm/ci/build.sh
index e5c5dcedd108..ca2923ed2290 100644
--- a
On 07/11/2023 21:10, Jessica Zhang wrote:
On 11/6/2023 9:35 AM, Jessica Zhang wrote:
On 11/4/2023 6:02 AM, Helen Koike wrote:
Hi Jessica,
On 10/10/2023 19:25, Jessica Zhang wrote:
Recently, we've registered a Gitlab runner for a Qualcomm RB5 device
that will be
hosted and maint
On 10/10/2023 19:25, Jessica Zhang wrote:
Add skips, fails and flakes for the SM8250 test.
Generated using update-xfails.py [1]
[1] https://patchwork.freedesktop.org/patch/561453/?series=124793&rev=1
Signed-off-by: Abhinav Kumar
Signed-off-by: Jessica Zhang
---
drivers/gpu/drm/ci/xfails
Hi Jessica,
On 10/10/2023 19:25, Jessica Zhang wrote:
Recently, we've registered a Gitlab runner for a Qualcomm RB5 device that will
be
hosted and maintained in Qualcomm labs.
This series will add a corresponding CI job for testing SM8250 devices and add
the
skip/fails/flakes list. We were ab
Since the script that collected the list of the expectation files was
bogus and placing test to the flakes list incorrectly, restart the
expectation files with the correct script.
This reduces a lot the number of tests in the flakes list.
Signed-off-by: Helen Koike
Reviewed-by: David Heidelberg
Since the script that collected the list of the expectation files was
bogus and placing test to the flakes list incorrectly, restart the
expectation files with the correct script.
This reduces a lot the number of tests in the flakes list.
Signed-off-by: Helen Koike
Reviewed-by: David Heidelberg
testing, before pushing them to the drm/drm
repo. Thus, if the CI run was triggered by merge request, also pick up
the -external fixes basing on the the CI_MERGE target repo / and branch.
Signed-off-by: Dmitry Baryshkov
Acked-by: Helen Koike
Thanks!
---
drivers/gpu/drm/ci/build.sh | 5 +
1
Since the script that collected the list of the expectation files was
bogus and placing test to the flakes list incorrectly, restart the
expectation files with the correct script.
This reduces a lot the number of tests in the flakes list.
Signed-off-by: Helen Koike
---
.../gpu/drm/ci/xfails
On 08/10/2023 10:23, Dmitry Baryshkov wrote:
Enable CONFIG_MSM_MMCC_8996, the multimedia clock controller on Qualcomm
MSM8996 to prevent the the board from hitting the probe deferral
timeouts in CI run.
Signed-off-by: Dmitry Baryshkov
Tested-by: Helen Koike
Pipeline:
https
On 08/10/2023 16:59, Dmitry Baryshkov wrote:
On Sun, 8 Oct 2023 at 20:56, Rob Clark wrote:
From: Rob Clark
i-g-t expects the CRC to reflect any applied CTM. But the layer mixer
source is upstream of the DSPP, so it is before the CTM is applied.
Switch the default source to 'encoder' ins
ldfb = fb1, newfb = fb2, prepare fb2, cleanup fb1
- Non-async commit, oldfb = fb2, newfb = fb1, prepare fb1, cleanup fb2
Where calls to prepare/cleanup are balanced.
Cc: # v4.14+
Fixes: 25dc194b34dd ("drm: Block fb changes for async plane updates")
Suggested-by: Boris Brezillon
Signed
Async update callbacks are expected to set the old_fb in the new_state
so prepare/cleanup framebuffers are balanced.
Cc: # v4.14+
Fixes: 224a4c970987 ("drm/msm: update cursors asynchronously through atomic")
Suggested-by: Boris Brezillon
Signed-off-by: Helen Koike
Acked-by:
tags
- Add TODO in drm_atomic_helper_async_commit()
Changes in v2:
- added reviewed-by tag
- update CC stable and Fixes tag
- Added reviewed-by tag
- updated CC stable and Fixes tag
- Change the order of the patch in the series, add this as the last one.
- Add documentation
- s/ballanced/balanced
On 5/7/19 5:18 PM, Sean Paul wrote:
> On Wed, Mar 13, 2019 at 09:20:26PM -0300, Helen Koike wrote:
>> In the case of a normal sync update, the preparation of framebuffers (be
>> it calling drm_atomic_helper_prepare_planes() or doing setups with
>> drm_framebuffer_get())
Hello,
On 3/13/19 9:20 PM, Helen Koike wrote:
> Async update callbacks are expected to set the old_fb in the new_state
> so prepare/cleanup framebuffers are balanced.
>
> Cc: # v4.14+
> Fixes: 224a4c970987 ("drm/msm: update cursors asynchronously through atomic")
> S
Hi Boris,
On 4/12/19 10:49 AM, Boris Brezillon wrote:
> Hi Helen,
>
> On Fri, 12 Apr 2019 09:58:25 -0300
> Helen Koike wrote:
>
>> Asynchronous update is the ability change the hw state at any time, not
>> only during vblank.
>>
>> Amend mode is th
On 4/12/19 9:58 AM, Helen Koike wrote:
> Add atomic_async_{check,update} hooks in drm_plane_helper_funcs.
> These hooks are called when userspace requests asyncronous page flip in
> the atomic api through the flag DRM_MODE_PAGE_FLIP_ASYNC.
>
> Update those hooks in the drivers
flag in the normal path, and rockchip who
doesn't support async page flip.
Signed-off-by: Helen Koike
---
Hi,
This patch is an attempt to expose the implementation that already exist
for true async page flips updates through atomic api when the
DRM_MODE_PAGE_FLIP_ASYNC is used.
In this commi
.
&drm_plane_helper_funcs.atomic_async_{update,check}() was being used by
drivers to implement amend and not async. So rename them to amend.
Also improve docs explaining the difference.
If asynchronous is required, normal page flip can be performed using
DRM_MODE_PAGE_FLIP_ASYNC flag.
Signed-off-by: Helen K
ny
pending commit to amend
Changes in v1:
- https://patchwork.freedesktop.org/patch/243088/
- Only enable it if userspace requests it.
- Only allow async update for cursor type planes.
- Rename ASYNC_UPDATE for ATOMIC_AMEND.
Helen Koike (4):
drm/uapi: add documentation for atomic flags
drm/a
Hi Rob,
On 3/27/19 11:52 AM, Rob Clark wrote:
> On Wed, Mar 13, 2019 at 8:21 PM Helen Koike wrote:
>>
>> Async update callbacks are expected to set the old_fb in the new_state
>> so prepare/cleanup framebuffers are balanced.
>>
>> Cc: # v4.14+
>> Fixes:
Async update callbacks are expected to set the old_fb in the new_state
so prepare/cleanup framebuffers are balanced.
Cc: # v4.14+
Fixes: 224a4c970987 ("drm/msm: update cursors asynchronously through atomic")
Suggested-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Hello,
As me
Changes in v2:
- added reviewed-by tag
- update CC stable and Fixes tag
- Added reviewed-by tag
- updated CC stable and Fixes tag
- Change the order of the patch in the series, add this as the last one.
- Add documentation
- s/ballanced/balanced
Helen Koike (5):
drm/rockchip: fix fb references in
ldfb = fb1, newfb = fb2, prepare fb2, cleanup fb1
- Non-async commit, oldfb = fb2, newfb = fb1, prepare fb1, cleanup fb2
Where calls to prepare/cleanup are balanced.
Cc: # v4.14+
Fixes: 25dc194b34dd ("drm: Block fb changes for async plane updates")
Suggested-by: Boris Brezillon
Signed
ldfb = fb1, newfb = fb2, prepare fb2, cleanup fb1
- Non-async commit, oldfb = fb2, newfb = fb1, prepare fb1, cleanup fb2
Where calls to prepare/cleanup are balanced.
Cc: # v4.14+
Fixes: 25dc194b34dd ("drm: Block fb changes for async plane updates")
Suggested-by: Boris Brezillon
Signed
Async update callbacks are expected to set the old_fb in the new_state
so prepare/cleanup framebuffers are balanced.
Cc: # v4.14+
Fixes: 224a4c970987 ("drm/msm: update cursors asynchronously through atomic")
Suggested-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Hello,
As me
- update CC stable and Fixes tag
- Added reviewed-by tag
- updated CC stable and Fixes tag
- Change the order of the patch in the series, add this as the last one.
- Add documentation
- s/ballanced/balanced
Helen Koike (5):
drm/rockchip: fix fb references in async update
drm/amd: fix fb refer
52 matches
Mail list logo
