Re: [PATCH v4 4/4] arm64: dts: qcom: add HDMI nodes for msm8998

2024-06-17 Thread Jeffrey Hugo
On 6/15/2024 5:35 AM, Konrad Dybcio wrote: On 14.06.2024 12:33 PM, Dmitry Baryshkov wrote: On Fri, Jun 14, 2024 at 01:55:46AM GMT, Konrad Dybcio wrote: [...] GCC_HDMI_CLKREF_CLK is a child of xo, so you can drop the latter. It would also be worth confirming whether it's really powering th

Re: [PATCH v2] arm64: dts: qcom: msm8998: enable adreno_smmu by default

2024-05-17 Thread Jeffrey Hugo
Signed-off-by: Marc Gonzalez Reviewed-by: Bryan O'Donoghue Reviewed-by: Jeffrey Hugo

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu1: Add MSM8998 to hw catalog

2021-09-08 Thread Jeffrey Hugo
On Wed, Sep 8, 2021 at 2:26 AM Dmitry Baryshkov wrote: > > Hi, > > On Tue, 7 Sept 2021 at 22:13, Jeffrey Hugo wrote: > > > > On Wed, Sep 1, 2021 at 12:11 PM AngeloGioacchino Del Regno > > wrote: > > > > > > Bringup functionality for MSM8998 in t

Re: [Freedreno] [PATCH 2/3] drm/msm/dpu1: Add MSM8998 to hw catalog

2021-09-07 Thread Jeffrey Hugo
On Wed, Sep 1, 2021 at 12:11 PM AngeloGioacchino Del Regno wrote: > > Bringup functionality for MSM8998 in the DPU, driver which is mostly > the same as SDM845 (just a few variations). > > Signed-off-by: AngeloGioacchino Del Regno > I don't seem to see a cover letter for this series. Eh, there

Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support

2021-05-26 Thread Jeffrey Hugo
On Tue, May 25, 2021 at 11:46 PM Vinod Koul wrote: > > Hello Jeff, > > On 21-05-21, 08:09, Jeffrey Hugo wrote: > > On Fri, May 21, 2021 at 6:50 AM Vinod Koul wrote: > > > > > > Display Stream Compression (DSC) compresses the display stream in host > &g

Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support

2021-05-21 Thread Jeffrey Hugo
On Fri, May 21, 2021 at 6:50 AM Vinod Koul wrote: > > Display Stream Compression (DSC) compresses the display stream in host which > is later decoded by panel. This series enables this for Qualcomm msm driver. > This was tested on Google Pixel3 phone which use LGE SW43408 panel. > > The changes in

Re: [Freedreno] [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-14 Thread Jeffrey Hugo
On Mon, Jul 13, 2020 at 5:50 PM Doug Anderson wrote: > > Hi, > > On Mon, Jul 13, 2020 at 1:25 PM Rob Herring wrote: > > > > On Mon, Jul 13, 2020 at 9:08 AM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote: > > > > > > > > On Fri, Jul 10, 2020 at

Re: [Freedreno] [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Jeffrey Hugo
On Mon, Jul 13, 2020 at 8:11 AM Rob Herring wrote: > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson > wrote: > > > > I found that if I ever had a little mistake in my kernel config, > > or device tree, or graphics driver that my system would sit in a loop > > at bootup trying again and again

Re: [Freedreno] [PATCH v6 0/5] Add support for DisplayPort driver on

2020-06-15 Thread Jeffrey Hugo
On Mon, Jun 15, 2020 at 4:51 PM wrote: > > On 2020-06-12 16:26, Stephen Boyd wrote: > > Thanks for reviews Stephen. > > > Quoting Tanmay Shah (2020-06-11 18:50:25) > >> These patches add support for Display-Port driver on SnapDragon > >> hardware. It adds > >> DP driver and DP PLL driver files alo

Re: [Freedreno] [PATCH] drivers: gpu: drm: Add MDP5 configuration for MSM8x36 and its derivatives, such as MSM8939.

2020-05-11 Thread Jeffrey Hugo
On Mon, May 11, 2020 at 3:03 PM Konrad Dybcio wrote: > > >Is the "| 0" really adding value here? > > As far as I can see, it is present in every other config. Ah, I forgot about that. Nothing to see here. ___ Freedreno mailing list Freedreno@lists.free

Re: [Freedreno] [PATCH] drivers: gpu: drm: Add MDP5 configuration for MSM8x36 and its derivatives, such as MSM8939.

2020-05-11 Thread Jeffrey Hugo
On Fri, May 1, 2020 at 2:52 PM Konrad Dybcio wrote: > > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 70 > 1 file changed, 70 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c > b/drivers/gpu/drm/msm/disp/mdp5/mdp

Re: [Freedreno] [PATCH v3 1/2] dt-bindings: display: msm: Convert GMU bindings to YAML

2020-03-03 Thread Jeffrey Hugo
On Tue, Mar 3, 2020 at 8:43 AM Jordan Crouse wrote: > > On Mon, Mar 02, 2020 at 09:49:06PM +0100, Sam Ravnborg wrote: > > Hi Jordan. > > > > On Mon, Mar 02, 2020 at 11:23:43AM -0700, Jordan Crouse wrote: > > > Convert display/msm/gmu.txt to display/msm/gmu.yaml and remove the old > > > text bindin

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-11 Thread Jeffrey Hugo
On Tue, Feb 11, 2020 at 5:28 PM Rob Clark wrote: > > On Tue, Feb 11, 2020 at 7:59 AM Jeffrey Hugo wrote: > > > > On Tue, Feb 11, 2020 at 8:44 AM Rob Clark wrote: > > > > > > On Mon, Feb 10, 2020 at 9:58 PM wrote: > > > > > > > > On 2

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-11 Thread Jeffrey Hugo
On Tue, Feb 11, 2020 at 8:44 AM Rob Clark wrote: > > On Mon, Feb 10, 2020 at 9:58 PM wrote: > > > > On 2020-02-07 19:40, Jeffrey Hugo wrote: > > > On Fri, Feb 7, 2020 at 5:38 AM wrote: > > >> > > >> On 2020-02-06 20:29, Jeffrey Hugo wrote: >

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-07 Thread Jeffrey Hugo
On Fri, Feb 7, 2020 at 5:38 AM wrote: > > On 2020-02-06 20:29, Jeffrey Hugo wrote: > > On Thu, Feb 6, 2020 at 2:13 AM Harigovindan P > > wrote: > >> > >> For a given byte clock, if VCO recalc value is exactly same as > >> vco set rate value, vco_set_

Re: [Freedreno] [v1] drm/msm/dsi/pll: call vco set rate explicitly

2020-02-06 Thread Jeffrey Hugo
On Thu, Feb 6, 2020 at 2:13 AM Harigovindan P wrote: > > For a given byte clock, if VCO recalc value is exactly same as > vco set rate value, vco_set_rate does not get called assuming > VCO is already set to required value. But Due to GDSC toggle, > VCO values are erased in the HW. To make sure VC

Re: [Freedreno] [v1] drm/msm/dsi: save pll state before dsi host is powered off

2020-02-06 Thread Jeffrey Hugo
On Thu, Feb 6, 2020 at 1:52 AM Harigovindan P wrote: > > Save pll state before dsi host is powered off. Without this change > some register values gets resetted. The phy driver already does this. Why is the current implementation insufficient? > > Signed-off-by: Harigovindan P > --- > > Change

Re: [Freedreno] [v1] dt-bindings: msm:disp: update dsi and dpu bindings

2020-02-04 Thread Jeffrey Hugo
On Tue, Feb 4, 2020 at 7:15 AM Harigovindan P wrote: > > Updating bindings of dsi and dpu by adding and removing certain > properties. > > Signed-off-by: Harigovindan P > --- > > Changes in v1: > - Adding "ahb" clock as a required property. > - Adding "bus", "rot", "lut" as option

Re: [Freedreno] [v1] drm/msm: update LANE_CTRL register value from default value

2019-12-23 Thread Jeffrey Hugo
On Mon, Dec 23, 2019 at 3:19 AM Harigovindan P wrote: > > Updating REG_DSI_LANE_CTRL register value by reading default > register value and writing it back using bitwise OR with > DSI_LANE_CTRL_CLKLN_HS_FORCE_REQUEST. This works for all panels. Why? You explain what the code does, which I can tel

Re: [Freedreno] [PATCH] drm/msm/mdp5: enable autocommit

2019-12-16 Thread Jeffrey Hugo
On Thu, Dec 12, 2019 at 7:40 PM Brian Masney wrote: > > Hi Jeffrey, > > On Tue, Dec 03, 2019 at 07:18:31AM -0700, Jeffrey Hugo wrote: > > On Mon, Dec 2, 2019 at 6:40 PM Brian Masney wrote: > > > On Wed, Nov 13, 2019 at 06:23:34AM -0500, Brian Masney wrote: > >

Re: [Freedreno] [DPU PATCH v3 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon 845

2019-12-13 Thread Jeffrey Hugo
On Mon, Dec 2, 2019 at 6:48 AM Chandan Uddaraju wrote: > > Add bindings for Snapdragon 845 DisplayPort and > display-port PLL driver. > > Changes in V2: > Provide details about sel-gpio > > Signed-off-by: Chandan Uddaraju > --- > .../devicetree/bindings/display/msm/dp.txt | 249 > ++

Re: [Freedreno] [PATCH] drm/msm/mdp5: enable autocommit

2019-12-03 Thread Jeffrey Hugo
On Mon, Dec 2, 2019 at 6:40 PM Brian Masney wrote: > > Hi Jeffrey, > > On Wed, Nov 13, 2019 at 06:23:34AM -0500, Brian Masney wrote: > > On Tue, Nov 12, 2019 at 08:38:27AM -0700, Jeffrey Hugo wrote: > > > On Tue, Nov 12, 2019 at 3:49 AM Brian Masney > > &

Re: [Freedreno] [PATCH v1 2/2] drm/msm: add DSI config changes to support DSI version

2019-11-14 Thread Jeffrey Hugo
On Thu, Nov 14, 2019 at 10:47 AM Rob Clark wrote: > > On Thu, Nov 14, 2019 at 2:16 AM Harigovindan P > wrote: > > > > Add DSI config changes to support DSI version. > > > > Signed-off-by: Harigovindan P > > Reviewed-by: Rob Clark Can we fix the subject/commit text for this to indicate what DS

Re: [Freedreno] [PATCH] drm/msm/mdp5: enable autocommit

2019-11-12 Thread Jeffrey Hugo
RT signal for command-mode panels. > > This fixes the error and gives us a counter for command-mode panels that > we can use to implement async commit support for the MDP5 in a follow up > patch. > > Signed-off-by: Brian Masney > Suggested-by: Jeffrey Hugo > --- > drive

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-11 Thread Jeffrey Hugo
On Mon, Nov 11, 2019 at 4:38 AM Brian Masney wrote: > > On Sun, Nov 10, 2019 at 10:37:33AM -0700, Jeffrey Hugo wrote: > > On Sun, Nov 10, 2019 at 6:53 AM Brian Masney wrote: > > > > > > On Fri, Nov 08, 2019 at 07:56:25AM -0700, Jeffrey Hugo wrote: > > > T

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-10 Thread Jeffrey Hugo
On Sun, Nov 10, 2019 at 6:53 AM Brian Masney wrote: > > On Fri, Nov 08, 2019 at 07:56:25AM -0700, Jeffrey Hugo wrote: > > On Thu, Nov 7, 2019 at 7:03 PM Rob Clark wrote: > > > > > > On Thu, Nov 7, 2019 at 9:40 AM Jeffrey Hugo > > > wrote: > > &

Re: [Freedreno] [PATCH] drm/msm/dsi: Delay drm_panel_enable() until dsi_mgr_bridge_enable()

2019-11-09 Thread Jeffrey Hugo
On Sat, Nov 9, 2019 at 5:02 AM Stephan Gerhold wrote: > > On Fri, Nov 08, 2019 at 08:47:08PM -0700, Jeffrey Hugo wrote: > > On Fri, Nov 8, 2019 at 4:47 PM Stephan Gerhold wrote: > > > > > > On Fri, Nov 08, 2019 at 03:12:28PM -0700, Jeffrey Hugo wrote: > >

Re: [Freedreno] [PATCH] drm/msm/dsi: Delay drm_panel_enable() until dsi_mgr_bridge_enable()

2019-11-08 Thread Jeffrey Hugo
On Fri, Nov 8, 2019 at 4:47 PM Stephan Gerhold wrote: > > On Fri, Nov 08, 2019 at 03:12:28PM -0700, Jeffrey Hugo wrote: > > On Fri, Nov 8, 2019 at 2:29 PM Stephan Gerhold wrote: > > > > > > At the moment, the MSM DSI driver calls drm_panel_enable() rather e

Re: [Freedreno] [PATCH] drm/msm/dsi: Delay drm_panel_enable() until dsi_mgr_bridge_enable()

2019-11-08 Thread Jeffrey Hugo
On Fri, Nov 8, 2019 at 2:29 PM Stephan Gerhold wrote: > > At the moment, the MSM DSI driver calls drm_panel_enable() rather early > from the DSI bridge pre_enable() function. At this point, the encoder > (e.g. MDP5) is not enabled, so we have not started transmitting > video data. > > However, the

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-08 Thread Jeffrey Hugo
On Thu, Nov 7, 2019 at 7:03 PM Rob Clark wrote: > > On Thu, Nov 7, 2019 at 9:40 AM Jeffrey Hugo wrote: > > > > On Thu, Nov 7, 2019 at 9:17 AM Rob Clark wrote: > > > > > > On Thu, Nov 7, 2019 at 3:10 AM Brian Masney wrote: > > > > > > &

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-07 Thread Jeffrey Hugo
On Thu, Nov 7, 2019 at 9:17 AM Rob Clark wrote: > > On Thu, Nov 7, 2019 at 3:10 AM Brian Masney wrote: > > > > On Wed, Nov 06, 2019 at 08:58:59AM -0800, Rob Clark wrote: > > > On Wed, Nov 6, 2019 at 8:47 AM Jeffrey Hugo > > > wrote: > > > >

Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes

2019-11-06 Thread Jeffrey Hugo
On Wed, Nov 6, 2019 at 9:30 AM Rob Clark wrote: > > On Wed, Nov 6, 2019 at 1:13 AM Brian Masney wrote: > > > > On Tue, Nov 05, 2019 at 08:23:27AM -0800, Rob Clark wrote: > > > On Tue, Nov 5, 2019 at 2:08 AM Brian Masney wrote: > > > > The 'pp done time out' errors go away if I revert the followi

Re: [Freedreno] [PATCH RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence

2019-10-15 Thread Jeffrey Hugo
ot; property is optional and never present on > i.MX5, turn the message into debug level instead. > > Signed-off-by: Fabio Estevam Seems reasonable. Reviewed-by: Jeffrey Hugo > --- > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1

[Freedreno] [PATCH v2] drm/msm/dsi: Implement reset correctly

2019-10-11 Thread Jeffrey Hugo
connector support) Signed-off-by: Jeffrey Hugo Reviewed-by: Sean Paul --- v2: -make a DEFINE for the delay drivers/gpu/drm/msm/dsi/dsi_host.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index

Re: [Freedreno] [PATCH] drm/msm/dsi: Implement reset correctly

2019-10-10 Thread Jeffrey Hugo
On Thu, Oct 10, 2019 at 12:49 PM Sean Paul wrote: > > On Thu, Oct 10, 2019 at 2:45 PM Sean Paul wrote: > > > > On Wed, Oct 09, 2019 at 02:34:54PM -0700, Jeffrey Hugo wrote: > > > On msm8998, vblank timeouts are observed because the DSI controller is not > >

[Freedreno] [PATCH] drm/msm/dsi: Implement reset correctly

2019-10-09 Thread Jeffrey Hugo
connector support) Signed-off-by: Jeffrey Hugo --- Rob et al, is it possible for this to go into a 5.4-rc? drivers/gpu/drm/msm/dsi/dsi_host.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index

Re: [Freedreno] [PATCH 1/5] drm/msm/mdp5: Add optional TBU and TBU_RT clocks

2019-09-22 Thread Jeffrey Hugo
On Sun, Sep 22, 2019 at 8:16 AM wrote: > > From: "Angelo G. Del Regno" > > Some SoCs, like MSM8956/8976 (and APQ variants), do feature these > clocks and we need to enable them in order to get the hardware to > properly work. > > Signed-off-by: Angelo G. Del Regno I don't see these clocks docum

Re: [Freedreno] [PATCH] drm/msm/dsi: Move static keyword to the front of declarations

2019-09-05 Thread Jeffrey Hugo
> drivers/gpu/drm/msm/dsi/dsi_cfg.c:172:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > Signed-off-by: Krzysztof Wilczynski Seems fine to me. Reviewed-by: Jeffrey Hugo ___ Freedreno

[Freedreno] [PATCH v2] drm/msm/mdp5: Find correct node for creating gem address space

2019-07-08 Thread Jeffrey Hugo
to see if that has an iommu reference, and if not, use the parent device instead. This should handle all the various iommu designs for mdp5 supported systems. Signed-off-by: Jeffrey Hugo --- v2: It turns out there isn't a universal way to get the iommu device, so check to see if its i

Re: [Freedreno] [PATCH] drm/msm/mdp5: Use eariler mixers when possible

2019-07-05 Thread Jeffrey Hugo
On Mon, Jul 1, 2019 at 1:55 PM Rob Clark wrote: > > On Mon, Jul 1, 2019 at 10:41 AM Jeffrey Hugo wrote: > > > > When assigning a mixer, we will iterate through the entire list looking for > > a suitable match. This results in selecting the last match. We should >

Re: [Freedreno] [PATCH] drm/msm/mdp5: Use drm_device for creating gem address space

2019-07-03 Thread Jeffrey Hugo
On Wed, Jul 3, 2019 at 6:25 AM Rob Clark wrote: > > On Tue, Jul 2, 2019 at 9:08 PM Bjorn Andersson > wrote: > > > > On Mon 01 Jul 10:39 PDT 2019, Jeffrey Hugo wrote: > > > > > Creating the msm gem address space requires a reference to the dev where >

Re: [Freedreno] [PATCH 3/3] drm/msm/dsi: make sure we have panel or bridge earlier

2019-07-02 Thread Jeffrey Hugo
On Tue, Jul 2, 2019 at 2:30 PM Jeffrey Hugo wrote: > > On Sun, Jun 30, 2019 at 7:16 AM Rob Clark wrote: > > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > > @@ -1824,6 +1824,20 @@ int msm_dsi_host_init(struct msm_dsi *msm_dsi)

Re: [Freedreno] [PATCH 3/3] drm/msm/dsi: make sure we have panel or bridge earlier

2019-07-02 Thread Jeffrey Hugo
__func__); pr_err() doesn't seem right for a probe defer condition. pr_dbg? > + return -EPROBE_DEFER; > + } > + > + Tested-by: Jeffrey Hugo Reviewed-by: Jeffrey Hugo ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [PATCH] drm/msm/mdp5: Use drm_device for creating gem address space

2019-07-01 Thread Jeffrey Hugo
On Mon, Jul 1, 2019 at 1:45 PM Rob Clark wrote: > > On Mon, Jul 1, 2019 at 10:39 AM Jeffrey Hugo wrote: > > > > Creating the msm gem address space requires a reference to the dev where > > the iommu is located. The driver currently assumes this is the same as > &

Re: [Freedreno] [PATCH 4/5] drm/msm/dsi: get the clocks into OFF state at init

2019-07-01 Thread Jeffrey Hugo
On 7/1/2019 12:58 PM, Rob Clark wrote: On Mon, Jul 1, 2019 at 11:37 AM Jeffrey Hugo wrote: On 6/30/2019 9:01 AM, Rob Clark wrote: From: Rob Clark Do an extra enable/disable cycle at init, to get the clks into disabled state in case bootloader left them enabled. In case they were already

Re: [Freedreno] [PATCH 5/5] drm/bridge: ti-sn65dsi86: support booloader enabled display

2019-07-01 Thread Jeffrey Hugo
On 6/30/2019 9:01 AM, Rob Clark wrote: From: Rob Clark Request the enable gpio ASIS to avoid disabling bridge during probe, if already enabled. And if already enabled, defer enabling runpm until attach to avoid cutting off the power to the bridge. Once we get to attach, we know panel and drm

Re: [Freedreno] [PATCH 4/5] drm/msm/dsi: get the clocks into OFF state at init

2019-07-01 Thread Jeffrey Hugo
.. Umm, why? Is this intentional? -- Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. ___ Free

Re: [Freedreno] [PATCH 3/5] drm/msm/dsi: split clk rate setting and enable

2019-07-01 Thread Jeffrey Hugo
On Sun, Jun 30, 2019 at 9:03 AM Rob Clark wrote: > > From: Rob Clark > > Prep work for the following patch. > > Signed-off-by: Rob Clark Reviewed-by: Jeffrey Hugo ___ Freedreno mailing list Freedreno@lists.fre

Re: [Freedreno] [PATCH 2/5] genpd/gdsc: inherit display powerdomain from bootloader

2019-07-01 Thread Jeffrey Hugo
kernel, the driver will most likely built as a module, and not probed > until we get to userspace (after late_initcall) > > Signed-off-by: Rob Clark Reviewed-by: Jeffrey Hugo ___ Freedreno mailing list Freedreno@lists.freedesktop.org http

Re: [Freedreno] [PATCH 1/5] clk: inherit clocks enabled by bootloader

2019-07-01 Thread Jeffrey Hugo
after > userspace starts, in a typical distro kernel), we don't want to kill > the clocks and power domains that are used by the display before > userspace starts. > > Signed-off-by: Rob Clark Seems sane to me. I'm curious what Stephen Boyd thinks. I'll

[Freedreno] [PATCH] drm/msm/mdp5: Add msm8998 support

2019-07-01 Thread Jeffrey Hugo
Add support for MDP5 version v3.0 found on msm8998. Signed-off-by: Jeffrey Hugo --- 8998 support could probably be MDP5 or DPU. This MDP5 support works, but may not support all of the features that 8998 supports. However, DPU seems to only support 845 (MDP v4.0) with fundamental assumptions

[Freedreno] [PATCH] drm/msm/mdp5: Use eariler mixers when possible

2019-07-01 Thread Jeffrey Hugo
looking to reuse the bootloader config in future. Signed-off-by: Jeffrey Hugo --- drivers/gpu/drm/msm/disp/mdp5/mdp5_mixer.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_mixer.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_mixer.c index 954db683ae44

[Freedreno] [PATCH] drm/msm/mdp5: Use drm_device for creating gem address space

2019-07-01 Thread Jeffrey Hugo
to the proper device. Signed-off-by: Jeffrey Hugo --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c index 4a60f5fca6b0..1347a5223918 100644 --- a

Re: [Freedreno] [PATCH 1/4] dt-bindings: chosen: document panel-id binding

2019-07-01 Thread Jeffrey Hugo
ed panel-id property. We also need to consider how the DSI case with panels as children of the DSI controller would work and how this would work with multiple displays each having multiple panel options. Rob -- Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm T

[Freedreno] [PATCH] drm/msm: Transition console to msm framebuffer

2019-06-28 Thread Jeffrey Hugo
Signed-off-by: Jeffrey Hugo --- drivers/gpu/drm/msm/msm_fbdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c index 2429d5e6ce9f..e3836c7725a6 100644 --- a/drivers/gpu/drm/msm/msm_fbdev.c +++ b/drivers/gpu/drm/msm

[Freedreno] [PATCH] drm: msm: Fix add_gpu_components

2019-06-26 Thread Jeffrey Hugo
, but it's status is disabled. Fix this by checking the node's status before adding it to the match list. Fixes: dc3ea265b856 ("drm/msm: Drop the gpu binding") Signed-off-by: Jeffrey Hugo --- drivers/gpu/drm/msm/msm_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 delet

Re: [Freedreno] [PATCH 5/5 v3] drm/msm/mdp5: Use the interconnect API

2019-06-20 Thread Jeffrey Hugo
case, updated commit msg from Georgi. > v3: split out icc setup into it's own function, and rework logic > slightly so no interconnect paths is not fatal. > > Signed-off-by: Georgi Djakov > Signed-off-by: Rob Clark Looks good to me. Reviewed-By: Jeffrey Hugo

Re: [Freedreno] [PATCH 5/5] drm/msm/mdp5: Use the interconnect API

2019-06-18 Thread Jeffrey Hugo
On Tue, Jun 18, 2019 at 2:25 PM Rob Clark wrote: > > From: Georgi Djakov > > The interconnect API provides an interface for consumer drivers to > express their bandwidth needs in the SoC. This data is aggregated > and the on-chip interconnect hardware is configured to the most > appropriate power

[Freedreno] [PATCH v3] drm/msm/adreno: Add A540 support

2019-06-11 Thread Jeffrey Hugo
The A540 is a derivative of the A530, and is found in the MSM8998 SoC. Signed-off-by: Jeffrey Hugo --- v3: -Adjusted MERCIU for A540 for best performance. drivers/gpu/drm/msm/adreno/a5xx.xml.h | 28 drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 26 +++- drivers/gpu/drm/msm

Re: [Freedreno] [PATCH] drm/msm/adreno: Ensure that the zap shader region is big enough

2019-06-03 Thread Jeffrey Hugo
On Fri, May 31, 2019 at 4:09 PM Jordan Crouse wrote: > > Before loading the zap shader we should ensure that the reserved memory > region is big enough to hold the loaded file. > > Signed-off-by: Jordan Crouse Reviewed-by: Jeffrey Hugo > --- > > drivers/gpu/drm/msm

Re: [Freedreno] [PATCH v3 2/6] drm/msm: add support for per-CRTC max_vblank_count on mdp5

2019-06-03 Thread Jeffrey Hugo
se > drm_crtc_set_max_vblank_count(). > > This change was tested on a LG Nexus 5 (hammerhead) phone. > > Signed-off-by: Brian Masney > Suggested-by: Jeffrey Hugo Reviewed-by: Jeffrey Hugo > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 16 +++- > drivers/gpu

[Freedreno] [PATCH 4/4] drm/msm/dsi: Add support for MSM8998 DSI controller

2019-05-30 Thread Jeffrey Hugo
The DSI controller on the MSM8998 SoC is a 6G v2.0.0 controller which is very similar to the v2.0.1 of SDM845. Signed-off-by: Jeffrey Hugo --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 21 + drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 22 insertions(+) diff --git a

[Freedreno] [PATCH 2/4] drm/msm/dsi: Add support for MSM8998 10nm dsi phy

2019-05-30 Thread Jeffrey Hugo
The MSM8998 dsi phy is 10nm v3.0.0 like SDM845, however there appear to be minor differences such as the address space location. Signed-off-by: Jeffrey Hugo --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 1 + drivers/gpu/drm/msm/dsi/phy

[Freedreno] [PATCH 3/4] drm/msm/dsi: Add old timings quirk for 10nm phy

2019-05-30 Thread Jeffrey Hugo
The v3.0.0 10nm phy has two different implementations between MSM8998 and SDM845, which require different timings calculations. Unfortunately, the hardware designers did not choose to revise the version to account for this delta so implement a quirk instead. Signed-off-by: Jeffrey Hugo

[Freedreno] [PATCH 1/4] dt-bindings: msm/dsi: Add 10nm phy for msm8998 compatible

2019-05-30 Thread Jeffrey Hugo
The DSI phy on MSM8998 is a 10nm design like SDM845, however it has some slightly different quirks which need to be handled by drivers. Provide a separate compatible to assist in handling the specifics. Signed-off-by: Jeffrey Hugo --- Documentation/devicetree/bindings/display/msm/dsi.txt | 1

[Freedreno] [PATCH 0/4] MSM8998 DSI support

2019-05-30 Thread Jeffrey Hugo
anout. Jeffrey Hugo (4): dt-bindings: msm/dsi: Add 10nm phy for msm8998 compatible drm/msm/dsi: Add support for MSM8998 10nm dsi phy drm/msm/dsi: Add old timings quirk for 10nm phy drm/msm/dsi: Add support for MSM8998 DSI controller .../devicetree/bindings/display/msm/dsi.txt | 1 + drivers/gp

Re: [Freedreno] [PATCH RFC v2 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-29 Thread Jeffrey Hugo
On 5/29/2019 1:30 PM, Brian Masney wrote: On Wed, May 29, 2019 at 08:41:31AM -0600, Jeffrey Hugo wrote: On Wed, May 29, 2019 at 4:28 AM Brian Masney wrote: On Tue, May 28, 2019 at 08:53:49PM -0600, Jeffrey Hugo wrote: On Tue, May 28, 2019 at 8:46 PM Brian Masney wrote: On Tue, May 28

[Freedreno] [PATCH v2 2/2] drm/msm/adreno: Add A540 support

2019-05-29 Thread Jeffrey Hugo
The A540 is a derivative of the A530, and is found in the MSM8998 SoC. Signed-off-by: Jeffrey Hugo --- drivers/gpu/drm/msm/adreno/a5xx.xml.h | 28 drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 21 ++ drivers/gpu/drm/msm/adreno/a5xx_power.c| 76

[Freedreno] [PATCH v2 1/2] a5xx: Define HLSQ_DBG_ECO_CNTL

2019-05-29 Thread Jeffrey Hugo
--- rnndb/adreno/a5xx.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/rnndb/adreno/a5xx.xml b/rnndb/adreno/a5xx.xml index ae654eeb..16203512 100644 --- a/rnndb/adreno/a5xx.xml +++ b/rnndb/adreno/a5xx.xml @@ -1523,6 +1523,7 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/ rules-ng.xs

[Freedreno] [PATCH v2 0/2] Adreno A540 support

2019-05-29 Thread Jeffrey Hugo
-Stripped extranious magic number comment Jeffrey Hugo (1): drm/msm/adreno: Add A540 support drivers/gpu/drm/msm/adreno/a5xx.xml.h | 28 drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 21 ++ drivers/gpu/drm/msm/adreno/a5xx_power.c| 76 +- drivers/gpu/drm/msm

Re: [Freedreno] [PATCH RFC v2 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-29 Thread Jeffrey Hugo
On Wed, May 29, 2019 at 4:28 AM Brian Masney wrote: > > On Tue, May 28, 2019 at 08:53:49PM -0600, Jeffrey Hugo wrote: > > On Tue, May 28, 2019 at 8:46 PM Brian Masney wrote: > > > > > > On Tue, May 28, 2019 at 07:42:19PM -0600, Jeffrey Hugo wrote: > > >

Re: [Freedreno] [PATCH RFC v2 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-28 Thread Jeffrey Hugo
On Tue, May 28, 2019 at 8:15 PM Rob Clark wrote: > > On Tue, May 28, 2019 at 6:17 PM Brian Masney wrote: > > > > On Tue, May 28, 2019 at 03:46:14PM +0200, Linus Walleij wrote: > > > On Thu, May 9, 2019 at 4:04 AM Brian Masney wrote: > > > > > > > Here is a patch series that adds initial display

Re: [Freedreno] [PATCH RFC v2 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-28 Thread Jeffrey Hugo
On Tue, May 28, 2019 at 7:37 PM Brian Masney wrote: > > On Tue, May 28, 2019 at 07:32:14PM -0600, Jeffrey Hugo wrote: > > On Tue, May 28, 2019 at 7:17 PM Brian Masney wrote: > > > > > > On Tue, May 28, 2019 at 03:46:14PM +0200, Linus Walleij wrote: > > >

Re: [Freedreno] [PATCH RFC v2 0/6] ARM: qcom: initial Nexus 5 display support

2019-05-28 Thread Jeffrey Hugo
On Tue, May 28, 2019 at 7:17 PM Brian Masney wrote: > > On Tue, May 28, 2019 at 03:46:14PM +0200, Linus Walleij wrote: > > On Thu, May 9, 2019 at 4:04 AM Brian Masney wrote: > > > > > Here is a patch series that adds initial display support for the LG > > > Nexus 5 (hammerhead) phone. It's not fu

Re: [Freedreno] [PATCH] drm/msm/adreno: Add A540 support

2019-05-28 Thread Jeffrey Hugo
On Tue, May 28, 2019 at 2:45 PM Jordan Crouse wrote: > > On Tue, May 28, 2019 at 10:06:12AM -0700, Jeffrey Hugo wrote: > > The A540 is a derivative of the A530, and is found in the MSM8998 SoC. > > > > Signed-off-by: Jeffrey Hugo > > --- > > drivers/gpu

[Freedreno] [PATCH] drm/msm/adreno: Add A540 support

2019-05-28 Thread Jeffrey Hugo
The A540 is a derivative of the A530, and is found in the MSM8998 SoC. Signed-off-by: Jeffrey Hugo --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 22 +++ drivers/gpu/drm/msm/adreno/a5xx_power.c| 76 +- drivers/gpu/drm/msm/adreno/adreno_device.c | 18 + drivers

[Freedreno] [PATCH RESEND] drm/msm/mdp5: Fix mdp5_cfg_init error return

2019-05-21 Thread Jeffrey Hugo
module) Signed-off-by: Jeffrey Hugo Reviewed-by: Bjorn Andersson --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c index ea8f7d7daf7f..52e23780fce1

[Freedreno] [PATCH] drm/msm/mdp5: Fix mdp5_cfg_init error return

2019-05-01 Thread Jeffrey Hugo
module) Signed-off-by: Jeffrey Hugo --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c index ea8f7d7daf7f..52e23780fce1 100644 --- a/drivers/gpu/drm/msm

Re: [Freedreno] [PATCH] drm/msm: Fix incorrect struct size for memory allocation

2019-02-21 Thread Jeffrey Hugo
t, GFP_KERNEL); if (!local) return -ENOMEM; Isn't msm_clk_bulk_get a duplication of devm_clk_bulk_get_all() ? Surely it would be better to just use that instead? -- Jeffrey Hugo Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qua