Re: [Freedreno] [PATCH 3/4] drm/msm/adreno: drop redundant pm_runtime_disable()

2023-03-03 Thread Johan Hovold
Hi Rob, Sorry about the late follow-up on this. Went down a bit of a DRM rabbit hole this week. On Wed, Feb 22, 2023 at 11:09:16AM -0800, Rob Clark wrote: > On Tue, Feb 21, 2023 at 2:16 AM Johan Hovold wrote: > > > > Since commit 4b18299b3365 ("drm/msm/adreno: Defer

Re: [Freedreno] [PATCH] drm/msm: Initialize mode_config earlier

2023-03-01 Thread Johan Hovold
On Tue, Jan 24, 2023 at 09:09:02AM +0100, Johan Hovold wrote: > On Mon, Jan 23, 2023 at 09:17:49AM -0800, Bjorn Andersson wrote: > > On Mon, Jan 23, 2023 at 05:01:45PM +0100, Johan Hovold wrote: > > > On Tue, Jan 17, 2023 at 09:04:39AM +0100, Johan Hovold wrote: > > > &

Re: [Freedreno] [PATCH AUTOSEL 6.1 18/58] drm/msm/dp: Remove INIT_SETUP delay

2023-02-27 Thread Johan Hovold
On Sun, Feb 26, 2023 at 09:04:16PM -0500, Sasha Levin wrote: > From: Bjorn Andersson > > [ Upstream commit e17af1c9d861dc177e5b56009bd4f71ace688d97 ] > > During initalization of the DisplayPort controller an EV_HPD_INIT_SETUP > event is generated, but with a delay of 100 units. This delay existe

Re: [Freedreno] [PATCH AUTOSEL 6.2 18/60] drm/msm/dp: Remove INIT_SETUP delay

2023-02-27 Thread Johan Hovold
On Sun, Feb 26, 2023 at 09:00:03PM -0500, Sasha Levin wrote: > From: Bjorn Andersson > > [ Upstream commit e17af1c9d861dc177e5b56009bd4f71ace688d97 ] > > During initalization of the DisplayPort controller an EV_HPD_INIT_SETUP > event is generated, but with a delay of 100 units. This delay existe

Re: [Freedreno] [RFC] drm/msm/adreno: Balance pm_runtime enable

2023-02-22 Thread Johan Hovold
On Fri, Feb 10, 2023 at 08:10:00AM -0800, Rob Clark wrote: > On Fri, Feb 3, 2023 at 10:12 AM Bjorn Andersson > wrote: > > > > When any of the components in the mdss hierarchy fails to bind, > > previously bound components are being unbound again. > > > > One such case happens when the DP controlle

[Freedreno] [PATCH 2/4] drm/msm/adreno: drop bogus pm_runtime_set_active()

2023-02-21 Thread Johan Hovold
dreno: Load the firmware before bringing up the hardware") Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/adreno/adreno_device.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index c5c4c93b3689.

[Freedreno] [PATCH 4/4] drm/msm/adreno: clean up component ops indentation

2023-02-21 Thread Johan Hovold
Clean up the component ops initialisers which were indented one level too far. Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/adreno/adreno_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm

[Freedreno] [PATCH 3/4] drm/msm/adreno: drop redundant pm_runtime_disable()

2023-02-21 Thread Johan Hovold
e on first open() is balanced by the pm_runtime_force_suspend() call at unbind(), adreno_gpu_cleanup() is now always called with runtime PM disabled so that its pm_runtime_disable() call can be removed. Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 5 - 1 file

[Freedreno] [PATCH 1/4] drm/msm/adreno: fix runtime PM imbalance at unbind

2023-02-21 Thread Johan Hovold
e GPU: -13 Fixes: 4b18299b3365 ("drm/msm/adreno: Defer enabling runpm until hw_init()") Reported-by: Bjorn Andersson Link: https://lore.kernel.org/lkml/20230203181245.3523937-1-quic_bjora...@quicinc.com Cc: sta...@vger.kernel.org # 6.0 Signed-off-by: Johan Hovold --- drivers/gpu

[Freedreno] [PATCH 0/4] drm/msm/adreno: fix runtime PM imbalance at unbind

2023-02-21 Thread Johan Hovold
, fix this by making the runtime PM disable call at unbind() conditional. The rest of the series removes a bogus pm_runtime_set_active() call and drops the redundant pm_runtime_disable() from adreno_gpu_cleanup(). Included is also a related indentation cleanup. Johan Johan Hovold (4): drm/msm

Re: [Freedreno] [PATCH] drm/msm: Initialize mode_config earlier

2023-01-24 Thread Johan Hovold
On Tue, Jan 24, 2023 at 09:09:02AM +0100, Johan Hovold wrote: > On Mon, Jan 23, 2023 at 09:17:49AM -0800, Bjorn Andersson wrote: > > On Mon, Jan 23, 2023 at 05:01:45PM +0100, Johan Hovold wrote: > > > On Tue, Jan 17, 2023 at 09:04:39AM +0100, Johan Hovold wrote: > > > &

Re: [Freedreno] [PATCH] drm/msm: Initialize mode_config earlier

2023-01-24 Thread Johan Hovold
On Mon, Jan 23, 2023 at 09:17:49AM -0800, Bjorn Andersson wrote: > On Mon, Jan 23, 2023 at 05:01:45PM +0100, Johan Hovold wrote: > > On Tue, Jan 17, 2023 at 09:04:39AM +0100, Johan Hovold wrote: > > > On Mon, Jan 16, 2023 at 08:51:22PM -0600, Bjorn Andersson wrote: >

Re: [Freedreno] [PATCH] drm/msm: Initialize mode_config earlier

2023-01-23 Thread Johan Hovold
On Tue, Jan 17, 2023 at 09:04:39AM +0100, Johan Hovold wrote: > On Mon, Jan 16, 2023 at 08:51:22PM -0600, Bjorn Andersson wrote: > > On Fri, Jan 13, 2023 at 10:57:18AM +0200, Dmitry Baryshkov wrote: > > > On 13/01/2023 06:23, Dmitry Baryshkov wrote: > > > > On 13/

Re: [Freedreno] [PATCH v6 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers

2023-01-18 Thread Johan Hovold
On Wed, Jan 18, 2023 at 07:30:13PM +, Mark Yacoub wrote: > From: Sean Paul > > This patch adds the bindings for the MSM DisplayPort HDCP registers > which are required to write the HDCP key into the display controller as > well as the registers to enable HDCP authentication/key > exchange/enc

Re: [Freedreno] [PATCH] drm/msm: Initialize mode_config earlier

2023-01-17 Thread Johan Hovold
On Mon, Jan 16, 2023 at 08:51:22PM -0600, Bjorn Andersson wrote: > On Fri, Jan 13, 2023 at 10:57:18AM +0200, Dmitry Baryshkov wrote: > > On 13/01/2023 06:23, Dmitry Baryshkov wrote: > > > On 13/01/2023 06:10, Bjorn Andersson wrote: > > > > Invoking drm_bridge_hpd_notify() on a drm_bridge with a HPD

Re: [Freedreno] [PATCH v5 11/12] arm64: dts: qcom: sc8280xp-crd: Enable EDP

2022-12-13 Thread Johan Hovold
On Tue, Dec 13, 2022 at 07:10:14AM -0800, Bjorn Andersson wrote: > On Fri, Dec 09, 2022 at 11:35:23AM +0100, Johan Hovold wrote: > > > + edp_reg_en: edp-reg-en-state { > > > + pins = "gpio25"; > > > + function = "gpio"; > >

Re: [Freedreno] [PATCH v5 10/12] arm64: dts: qcom: sc8280xp: Define some of the display blocks

2022-12-09 Thread Johan Hovold
On Wed, Dec 07, 2022 at 02:00:10PM -0800, Bjorn Andersson wrote: > From: Bjorn Andersson > > Define the display clock controllers, the MDSS instances, the DP phys > and connect these together. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > > Changes since v4: > -

Re: [Freedreno] [PATCH v5 12/12] arm64: dts: qcom: sa8295-adp: Enable DP instances

2022-12-09 Thread Johan Hovold
On Wed, Dec 07, 2022 at 02:00:12PM -0800, Bjorn Andersson wrote: > From: Bjorn Andersson > > The SA8295P ADP has, among other interfaces, six MiniDP connectors which > are connected to MDSS0 DP2 and DP3, and MDSS1 DP0 through DP3. > > Enable Display Clock controllers, MDSS instanced, MDPs, DP co

Re: [Freedreno] [PATCH v5 11/12] arm64: dts: qcom: sc8280xp-crd: Enable EDP

2022-12-09 Thread Johan Hovold
On Wed, Dec 07, 2022 at 02:00:11PM -0800, Bjorn Andersson wrote: > From: Bjorn Andersson > > The SC8280XP CRD has a EDP display on MDSS0 DP3, enable relevant nodes > and link it together with the backlight control. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > >

Re: [Freedreno] [PATCH v3 10/12] arm64: dts: qcom: sc8280xp: Define some of the display blocks

2022-10-26 Thread Johan Hovold
On Tue, Oct 25, 2022 at 08:26:22PM -0700, Bjorn Andersson wrote: > From: Bjorn Andersson > > Define the display clock controllers, the MDSS instances, the DP phys > and connect these together. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > > Changes since v2: > -

Re: [Freedreno] [PATCH v3 12/12] arm64: dts: qcom: sa8295-adp: Enable DP instances

2022-10-26 Thread Johan Hovold
On Tue, Oct 25, 2022 at 08:26:24PM -0700, Bjorn Andersson wrote: > From: Bjorn Andersson > > The SA8295P ADP has, among other interfaces, six MiniDP connectors which > are connected to MDSS0 DP2 and DP3, and MDSS1 DP0 through DP3. > > Enable Display Clock controllers, MDSS instanced, MDPs, DP co

Re: [Freedreno] [PATCH v2 00/10] drm/msm: probe deferral fixes

2022-10-24 Thread Johan Hovold
On Fri, Oct 21, 2022 at 09:05:52AM -0700, Abhinav Kumar wrote: > Hi Johan > > On 10/20/2022 11:27 PM, Johan Hovold wrote: > > On Tue, Sep 20, 2022 at 11:06:30AM +0200, Johan Hovold wrote: > >> On Tue, Sep 13, 2022 at 10:53:10AM +0200, Johan Hovold wrote: > >>

Re: [Freedreno] [PATCH v2 00/10] drm/msm: probe deferral fixes

2022-10-20 Thread Johan Hovold
On Tue, Sep 20, 2022 at 11:06:30AM +0200, Johan Hovold wrote: > On Tue, Sep 13, 2022 at 10:53:10AM +0200, Johan Hovold wrote: > > The MSM DRM driver is currently broken in multiple ways with respect to > > probe deferral. Not only does the driver currently fail to probe again &

Re: [Freedreno] [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks

2022-09-28 Thread Johan Hovold
On Wed, Sep 28, 2022 at 08:33:52AM -0700, Abhinav Kumar wrote: > On 9/28/2022 5:24 AM, Johan Hovold wrote: > > On Tue, Sep 27, 2022 at 11:42:53AM -0700, Abhinav Kumar wrote: > >> Discussed with Rob on IRC, we will apply everything except the last two > >> patches of th

Re: [Freedreno] [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks

2022-09-28 Thread Johan Hovold
On Tue, Sep 27, 2022 at 11:42:53AM -0700, Abhinav Kumar wrote: > On 9/27/2022 12:14 AM, Johan Hovold wrote: > > On Mon, Sep 26, 2022 at 11:17:20AM -0700, Abhinav Kumar wrote: > >> On 9/13/2022 1:53 AM, Johan Hovold wrote: > >>> Drop the overly defensive modeset sanity

Re: [Freedreno] [PATCH v2 10/10] drm/msm/dsi: drop modeset sanity checks

2022-09-27 Thread Johan Hovold
On Mon, Sep 26, 2022 at 11:21:38AM -0700, Abhinav Kumar wrote: > > > On 9/13/2022 1:53 AM, Johan Hovold wrote: > > Drop the overly defensive modeset sanity checks of function parameters > > which have already been checked or used by the callers. > > > > Reviewed

Re: [Freedreno] [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks

2022-09-27 Thread Johan Hovold
On Mon, Sep 26, 2022 at 11:17:20AM -0700, Abhinav Kumar wrote: > On 9/13/2022 1:53 AM, Johan Hovold wrote: > > Drop the overly defensive modeset sanity checks of function parameters > > which have already been checked or used by the callers. > > > > Reviewed-by: Dmitr

Re: [Freedreno] [PATCH v2 08/10] drm/msm/hdmi: fix IRQ lifetime

2022-09-22 Thread Johan Hovold
On Thu, Sep 22, 2022 at 12:55:03PM -0700, Kuogee Hsieh wrote: > > On 9/13/2022 1:53 AM, Johan Hovold wrote: > > Device-managed resources allocated post component bind must be tied to > > the lifetime of the aggregate DRM device or they will not necessarily be > > rele

Re: [Freedreno] [PATCH v2 00/10] drm/msm: probe deferral fixes

2022-09-20 Thread Johan Hovold
On Tue, Sep 13, 2022 at 10:53:10AM +0200, Johan Hovold wrote: > The MSM DRM driver is currently broken in multiple ways with respect to > probe deferral. Not only does the driver currently fail to probe again > after a late deferral, but due to a related use-after-free bug this also &

Re: [Freedreno] [PATCH v2 00/10] drm/msm: probe deferral fixes

2022-09-13 Thread Johan Hovold
On Tue, Sep 13, 2022 at 03:23:10PM -0500, Steev Klimaszewski wrote: > Hi Johan, > > On 9/13/22 3:53 AM, Johan Hovold wrote: > > The MSM DRM driver is currently broken in multiple ways with respect to > > probe deferral. Not only does the driver currently fail to probe a

Re: [Freedreno] [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-13 Thread Johan Hovold
On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > Johan Hovold has reported that returning a probe deferral from the > msm_dp_modeset_init() can cause issues because the IRQ is not freed > properly. This (compile-tested only) series tries to fix the issue by

[Freedreno] [PATCH v2 00/10] drm/msm: probe deferral fixes

2022-09-13 Thread Johan Hovold
But as doing so is not a general fix, this can be done later as a cleanup/optimisation. Johan Changes in v2 - use a custom devres action instead of amending the AUX bus interface (Doug) - split sanity check fixes and cleanups per bridge type (Dmitry) - add another Fixes tag for the missing

[Freedreno] [PATCH v2 05/10] drm/msm/dp: fix IRQ lifetime

2022-09-13 Thread Johan Hovold
to the DRM device so that it is released when bind fails. Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Cc: sta...@vger.kernel.org # 5.10 Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file change

[Freedreno] [PATCH v2 10/10] drm/msm/dsi: drop modeset sanity checks

2022-09-13 Thread Johan Hovold
Drop the overly defensive modeset sanity checks of function parameters which have already been checked or used by the callers. Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dsi/dsi.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a

[Freedreno] [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks

2022-09-13 Thread Johan Hovold
Drop the overly defensive modeset sanity checks of function parameters which have already been checked or used by the callers. Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff

[Freedreno] [PATCH v2 06/10] drm/msm/dp: fix aux-bus EP lifetime

2022-09-13 Thread Johan Hovold
ce. Fixes: c3bf8e21b38a ("drm/msm/dp: Add eDP support via aux_bus") Cc: sta...@vger.kernel.org # 5.19 Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_disp

[Freedreno] [PATCH v2 04/10] drm/msm/hdmi: fix memory corruption with too many bridges

2022-09-13 Thread Johan Hovold
Add the missing sanity check on the bridge counter to avoid corrupting data beyond the fixed-sized bridge array in case there are ever more than eight bridges. Fixes: a3376e3ec81c ("drm/msm: convert to drm_bridge") Cc: sta...@vger.kernel.org # 3.12 Signed-off-by: Johan Hovold --

[Freedreno] [PATCH v2 07/10] drm/msm/dp: fix bridge lifetime

2022-09-13 Thread Johan Hovold
("drm/msm/dp: Add eDP support via aux_bus") Cc: sta...@vger.kernel.org # 5.19 Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- drivers/gpu/drm/msm/dp/dp_parser.c | 6 +++--- drivers/gpu/drm/msm/dp/dp_parser.h | 5 +++-

[Freedreno] [PATCH v2 03/10] drm/msm/dsi: fix memory corruption with too many bridges

2022-09-13 Thread Johan Hovold
Add the missing sanity check on the bridge counter to avoid corrupting data beyond the fixed-sized bridge array in case there are ever more than eight bridges. Fixes: a689554ba6ed ("drm/msm: Initial add DSI connector support") Cc: sta...@vger.kernel.org # 4.1 Signed-off-by: Jo

[Freedreno] [PATCH v2 01/10] drm/msm: fix use-after-free on probe deferral

2022-09-13 Thread Johan Hovold
bridge array being corrupted. Fixes: d28ea556267c ("drm/msm: properly add and remove internal bridges") Fixes: a3376e3ec81c ("drm/msm: convert to drm_bridge") Cc: sta...@vger.kernel.org # 3.12 Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/gpu/d

[Freedreno] [PATCH v2 08/10] drm/msm/hdmi: fix IRQ lifetime

2022-09-13 Thread Johan Hovold
by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index a0ed6aa8e4e1..f28fb21e3891 100644 --- a/drivers/gpu/drm/msm/hdmi/hd

[Freedreno] [PATCH v2 02/10] drm/msm/dp: fix memory corruption with too many bridges

2022-09-13 Thread Johan Hovold
.17 Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 3e284fed8d30..fbe950edaefe 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drive

Re: [Freedreno] [PATCH 7/7] drm/msm: drop modeset sanity checks

2022-09-13 Thread Johan Hovold
On Mon, Sep 12, 2022 at 09:06:28PM +0300, Dmitry Baryshkov wrote: > On 12/09/2022 18:40, Johan Hovold wrote: > > Drop the overly defensive modeset sanity checks of function parameters > > which have already been checked or used by the callers. > > > > Signed-off-b

Re: [Freedreno] [PATCH 2/7] drm/msm: fix memory corruption with too many bridges

2022-09-13 Thread Johan Hovold
On Mon, Sep 12, 2022 at 08:55:55PM +0300, Dmitry Baryshkov wrote: > On 12/09/2022 18:40, Johan Hovold wrote: > > Add the missing sanity checks on the bridge counter to avoid corrupting > > data beyond the fixed-sized bridge array in case there are ever more > &g

Re: [Freedreno] [PATCH 1/7] drm/msm: fix use-after-free on probe deferral

2022-09-13 Thread Johan Hovold
On Mon, Sep 12, 2022 at 08:52:44PM +0300, Dmitry Baryshkov wrote: > On 12/09/2022 18:40, Johan Hovold wrote: > > The bridge counter was never reset when tearing down the DRM device so > > that stale pointers to deallocated structures would be accessed on the > > next tear down

Re: [Freedreno] [PATCH 4/7] drm/msm/dp: fix aux-bus EP lifetime

2022-09-13 Thread Johan Hovold
On Mon, Sep 12, 2022 at 04:55:58PM -0500, Steev Klimaszewski wrote: > > On 9/12/22 1:10 PM, Dmitry Baryshkov wrote: > > On 12/09/2022 18:40, Johan Hovold wrote: > >> Device-managed resources allocated post component bind must be tied to > >> the lifetime of the agg

Re: [Freedreno] [PATCH 4/7] drm/msm/dp: fix aux-bus EP lifetime

2022-09-13 Thread Johan Hovold
On Tue, Sep 13, 2022 at 07:35:15AM +0100, Doug Anderson wrote: > Hi, > > On Mon, Sep 12, 2022 at 7:10 PM Dmitry Baryshkov > wrote: > > > > On 12/09/2022 18:40, Johan Hovold wrote: > > > Device-managed resources allocated post component bind must be tied to > &

[Freedreno] [PATCH 0/7] drm/msm: probe deferral fixes

2022-09-12 Thread Johan Hovold
g so is not a general fix, this can be done later as a cleanup/optimisation. Johan Johan Hovold (7): drm/msm: fix use-after-free on probe deferral drm/msm: fix memory corruption with too many bridges drm/msm/dp: fix IRQ lifetime drm/msm/dp: fix aux-bus EP lifetime drm/msm/dp: fix bridg

[Freedreno] [PATCH 7/7] drm/msm: drop modeset sanity checks

2022-09-12 Thread Johan Hovold
Drop the overly defensive modeset sanity checks of function parameters which have already been checked or used by the callers. Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 7 +-- drivers/gpu/drm/msm/dsi/dsi.c | 7 +-- 2 files changed, 2 insertions(+), 12

[Freedreno] [PATCH 5/7] drm/msm/dp: fix bridge lifetime

2022-09-12 Thread Johan Hovold
("drm/msm/dp: Add eDP support via aux_bus") Cc: sta...@vger.kernel.org # 5.19 Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- drivers/gpu/drm/msm/dp/dp_parser.c | 6 +++--- drivers/gpu/drm/msm/dp/dp_parser.h | 5 +++-- 3 files changed, 7 insert

[Freedreno] [PATCH 3/7] drm/msm/dp: fix IRQ lifetime

2022-09-12 Thread Johan Hovold
to the DRM device so that it is released when bind fails. Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Cc: sta...@vger.kernel.org # 5.10 Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Freedreno] [PATCH 1/7] drm/msm: fix use-after-free on probe deferral

2022-09-12 Thread Johan Hovold
bridge array being corrupted. Fixes: d28ea556267c ("drm/msm: properly add and remove internal bridges") Cc: sta...@vger.kernel.org # 5.19 Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/msm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c

[Freedreno] [PATCH 4/7] drm/msm/dp: fix aux-bus EP lifetime

2022-09-12 Thread Johan Hovold
er than DP controller platform device. Fixes: c3bf8e21b38a ("drm/msm/dp: Add eDP support via aux_bus") Cc: sta...@vger.kernel.org # 5.19 Signed-off-by: Johan Hovold --- drivers/gpu/drm/bridge/parade-ps8640.c | 2 +- drivers/gpu/drm/display/drm_dp_aux_bus.c | 5 +++-- dr

[Freedreno] [PATCH 6/7] drm/msm/hdmi: fix IRQ lifetime

2022-09-12 Thread Johan Hovold
ned-off-by: Johan Hovold --- drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index a0ed6aa8e4e1..f28fb21e3891 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi.c +++ b/drivers/gpu/drm/msm/h

[Freedreno] [PATCH 2/7] drm/msm: fix memory corruption with too many bridges

2022-09-12 Thread Johan Hovold
") a689554ba6ed ("drm/msm: Initial add DSI connector support") Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable") Cc: sta...@vger.kernel.org # 3.12 Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 6 ++

Re: [Freedreno] [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-01 Thread Johan Hovold
On Thu, Sep 01, 2022 at 12:21:36PM +0300, Dmitry Baryshkov wrote: > On 01/09/2022 12:20, Johan Hovold wrote: > > On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > >> Johan Hovold has reported that returning a probe deferral from the > >> msm_dp_mode

Re: [Freedreno] [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-01 Thread Johan Hovold
On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > Johan Hovold has reported that returning a probe deferral from the > msm_dp_modeset_init() can cause issues because the IRQ is not freed > properly. This (compile-tested only) series tries to fix the issue by

Re: [Freedreno] [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-08-03 Thread Johan Hovold
On Fri, Jul 29, 2022 at 03:07:47PM +0100, Mark Brown wrote: > On Fri, Jul 29, 2022 at 03:35:33PM +0200, Johan Hovold wrote: > > > I guess we just need to drop all those regulator-allow-set-load > > properties for now even if using DT for power-management configuration > &g

Re: [Freedreno] [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-29 Thread Johan Hovold
Sorry about the late follow-up on this. Has been one of those constant-preemption weeks. And thanks Doug and Mark for the insightful comments in this and the dt-load RFC thread. On Thu, Jul 21, 2022 at 07:49:55AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Jul 21, 2022 at 6:25 AM Dmitry Barysh

Re: [Freedreno] [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Johan Hovold
On Thu, Jul 21, 2022 at 12:56:37PM +0100, Mark Brown wrote: > On Thu, Jul 21, 2022 at 12:20:31PM +0100, Mark Brown wrote: > > > You could add a way to specify constant base loads in DT on either a per > > regulator or per consumer basis. > > ...and also note that this is only an issue if the syst

Re: [Freedreno] [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Johan Hovold
On Tue, Jul 05, 2022 at 09:29:13AM -0700, Kuogee Hsieh wrote: > 0) rebase on > https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree > 1) add regulator_set_load() to eDP phy > 2) add regulator_set_load() to DP phy > 3) remove vdda related function out of eDP/DP controller > > Kuo

Re: [Freedreno] [PATCH 1/4] drm/msm: fix memleak on release

2019-11-12 Thread Johan Hovold
On Wed, Oct 30, 2019 at 11:01:46AM +0100, Johan Hovold wrote: > On Thu, Oct 10, 2019 at 03:13:30PM +0200, Johan Hovold wrote: > > If a process is interrupted while accessing the "gpu" debugfs file and > > the drm device struct_mutex is contended, release() could return e

Re: [Freedreno] [PATCH 1/4] drm/msm: fix memleak on release

2019-10-30 Thread Johan Hovold
On Thu, Oct 10, 2019 at 03:13:30PM +0200, Johan Hovold wrote: > If a process is interrupted while accessing the "gpu" debugfs file and > the drm device struct_mutex is contended, release() could return early > and fail to free related resources. > > Note that the retur

Re: [Freedreno] [PATCH 0/4] treewide: fix interrupted release

2019-10-21 Thread Johan Hovold
On Tue, Oct 15, 2019 at 04:07:26PM +0200, Daniel Vetter wrote: > On Mon, Oct 14, 2019 at 06:13:26PM +0200, Johan Hovold wrote: > > On Mon, Oct 14, 2019 at 10:48:47AM +0200, Daniel Vetter wrote: > > > Do you have a legit usecase for interruptible sleeps in fops->release? &

Re: [Freedreno] [PATCH 0/4] treewide: fix interrupted release

2019-10-14 Thread Johan Hovold
On Mon, Oct 14, 2019 at 10:48:47AM +0200, Daniel Vetter wrote: > On Fri, Oct 11, 2019 at 11:36:33AM +0200, Johan Hovold wrote: > > On Thu, Oct 10, 2019 at 03:50:43PM +0200, Daniel Vetter wrote: > > > On Thu, Oct 10, 2019 at 03:13:29PM +0200, Johan Hovold wrote: > > >

Re: [Freedreno] [PATCH 0/4] treewide: fix interrupted release

2019-10-11 Thread Johan Hovold
On Thu, Oct 10, 2019 at 03:50:43PM +0200, Daniel Vetter wrote: > On Thu, Oct 10, 2019 at 03:13:29PM +0200, Johan Hovold wrote: > > Two old USB drivers had a bug in them which could lead to memory leaks > > if an interrupted process raced with a disconnect event. > > >

[Freedreno] [PATCH 3/4] media: radio: wl1273: fix interrupt masking on release

2019-10-10 Thread Johan Hovold
o: TI WL1273 FM radio driver") Cc: stable # 2.6.38 Cc: Matti Aaltonen Cc: Mauro Carvalho Chehab Signed-off-by: Johan Hovold --- drivers/media/radio/radio-wl1273.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/radio/radio-wl1273.c b/drivers/media/r

[Freedreno] [PATCH 0/4] treewide: fix interrupted release

2019-10-10 Thread Johan Hovold
one has not even been built. Johan Johan Hovold (4): drm/msm: fix memleak on release media: bdisp: fix memleak on release media: radio: wl1273: fix interrupt masking on release s390/zcrypt: fix memleak at release drivers/gpu/drm/msm/msm_debugfs.c | 6 +- drivers/media

[Freedreno] [PATCH 1/4] drm/msm: fix memleak on release

2019-10-10 Thread Johan Hovold
U show function to use the GPU state") Cc: stable # 4.18 Cc: Jordan Crouse Cc: Rob Clark Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/msm_debugfs.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm

[Freedreno] [PATCH 2/4] media: bdisp: fix memleak on release

2019-10-10 Thread Johan Hovold
using v4l2 mem2mem framework") Cc: stable # 4.2 Cc: Fabien Dessenne Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Signed-off-by: Johan Hovold --- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform

[Freedreno] [PATCH 4/4] s390/zcrypt: fix memleak at release

2019-10-10 Thread Johan Hovold
berger Cc: Martin Schwidefsky Signed-off-by: Johan Hovold --- drivers/s390/crypto/zcrypt_api.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c index 45bdb47f84c1..9157e728a362 100644 --- a/drivers/s

<    1   2