Re: [PATCH 03/21] drm/msm/dsi: pass the right width to dsc

2024-09-03 Thread Jun Nie
Marijn Suijten 于2024年9月3日周二 18:12写道: > > On 2024-08-29 18:17:32, Jun Nie wrote: > > Data width for dsc engine is aligned with pipe, not with whole screen > > width. Because the width may be halved in DSI bonded case. > > > > The dsc width is not related to the t

Re: [PATCH 18/21] drm/msm/dpu: blend pipes by left and right

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:51写道: > > On Thu, 29 Aug 2024 at 13:21, Jun Nie wrote: > > > > Blend pipes by left and right. The first 2 pipes are for > > left half screen and the later 2 pipes are for right in quad > > pipe case. > > > > Signed-off

Re: [PATCH 14/21] drm/msm/dpu: Support quad-pipe in SSPP checking

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:38写道: > > > @@ -1033,13 +1030,10 @@ static int dpu_plane_atomic_check(struct drm_plane > > *plane, > > return -E2BIG; > > } > > > > - /* > > -* Use multirect for wide plane. We do not support d

Re: [PATCH 13/21] drm/msm/dpu: Support quad pipe in header files

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:30写道: > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > Support 4 pipes and their configs at most. They are for 2 SSPP > > and their multi-rect mode. Because one SSPP can co-work with > > 2 mixer at most, 2 pair of mixer

Re: [PATCH 10/21] drm/msm/dpu: fix lm number counter for quad-pipe

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:17写道: > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > Add the case to reserve multiple pair mixer for high resolution > > I think you already know what is missing here. Add the case to reserve multiple pair mixer for high resol

Re: [PATCH 09/21] drm/msm/dpu: request more mixer for 4K+ DSC case

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:12写道: > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > request more mixer for the case that hdisplay exceeding 4096 > > and DSC enabled. > > This doesn't seem to match the code. And it misses the _reason_ to do it.

Re: [PATCH 07/21] drm/msm/dpu: Support dynamic DSC number

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:10写道: > > On Thu, 29 Aug 2024 at 13:20, Jun Nie wrote: > > > > Do not assume DSC number as 2. Because there are 4 DSC in > > quad pipe case. > > Please expand the commit message. You prefer brevity, but your > comments lack cla

Re: [PATCH 06/21] drm/msm/dpu: Add utility to get mixer number

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 19:07写道: > > On Thu, 29 Aug 2024 at 13:19, Jun Nie wrote: > > > > Add utility to get mixer number via CRTC handler > > > > Signed-off-by: Jun Nie > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 7 +++ > &g

Re: [PATCH 03/21] drm/msm/dsi: pass the right width to dsc

2024-09-03 Thread Jun Nie
Dmitry Baryshkov 于2024年8月29日周四 18:57写道: > > On Thu, 29 Aug 2024 at 13:19, Jun Nie wrote: > > > > Data width for dsc engine is aligned with pipe, not with whole screen > > width. Because the width may be halved in DSI bonded case. > > Can't really parse this. P

[PATCH 21/21] drm/msm/dpu: revise debug info to support quad pipe

2024-08-29 Thread Jun Nie
Unify debug info to support dual pipe and quad pipe Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 16 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 35 +-- 2 files changed, 21 insertions(+), 30 deletions(-) diff --git a/drivers

[PATCH 20/21] drm/msm/dpu: support quad pipe in general operations

2024-08-29 Thread Jun Nie
Support quad pipe in general operations with unified method. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 87 +-- 1 file changed, 47 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm

[PATCH 19/21] drm/msm/dpu: bind correct pingpong for quad pipe

2024-08-29 Thread Jun Nie
There are 2 interface and 4 PP in quad pipe. Map the 2nd interface to 3rd PP instead of the 2nd PP. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

[PATCH 18/21] drm/msm/dpu: blend pipes by left and right

2024-08-29 Thread Jun Nie
Blend pipes by left and right. The first 2 pipes are for left half screen and the later 2 pipes are for right in quad pipe case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 13 +++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 +++--- drivers/gpu

[PATCH 17/21] drm/msm/dpu: setup pipes with 2 set of stage config

2024-08-29 Thread Jun Nie
The first 2 fields in multirect_index and stage array are for the first SSPP and its multi-rect. And the later 2 fields are for the 2nd SSPP and its multi-rect. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 76 +++- 1 file changed, 55

[PATCH 16/21] drm/msm/dpu: support SSPP assignment for quad-pipe case

2024-08-29 Thread Jun Nie
Support SSPP assignment for quad-pipe case with unified method Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 58 +-- 1 file changed, 25 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm

[PATCH 15/21] drm/msm/dpu: support plane splitting in quad-pipe case

2024-08-29 Thread Jun Nie
Clip plane into SSPPs per left and right half screen per ROI if topology is quad pipe. Then split the split rectangle by half if the clip width still exceed limit. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 97 ++- 1 file changed, 71

[PATCH 14/21] drm/msm/dpu: Support quad-pipe in SSPP checking

2024-08-29 Thread Jun Nie
Support quad-pipe in SSPP checking with unified method Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 108 ++ 1 file changed, 51 insertions(+), 57 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp

[PATCH 13/21] drm/msm/dpu: Support quad pipe in header files

2024-08-29 Thread Jun Nie
Support 4 pipes and their configs at most. They are for 2 SSPP and their multi-rect mode. Because one SSPP can co-work with 2 mixer at most, 2 pair of mixer are needed for 2 SSPP in quad- pipe case. So 2 mixer configs are needed in quad-pipe case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm

[PATCH 12/21] drm/msm/dpu: switch RM to use crtc_id rather than enc_id for allocation

2024-08-29 Thread Jun Nie
operation. While the sspp assignment is in drm_atomic_helper_check_planes() call tree. So CRTC is more central than encoder. Siwtching the id achieves above goal. Co-developed-by: Dmitry Baryshkov Signed-off-by: Dmitry Baryshkov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1

[PATCH 11/21] drm/msm/dpu: Support 4 mixers at most

2024-08-29 Thread Jun Nie
Support 4 mixers case with increasing array size and checking the usage case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 3 ++- drivers/gpu

[PATCH 10/21] drm/msm/dpu: fix lm number counter for quad-pipe

2024-08-29 Thread Jun Nie
Add the case to reserve multiple pair mixer for high resolution Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 8 +++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp

[PATCH 09/21] drm/msm/dpu: request more mixer for 4K+ DSC case

2024-08-29 Thread Jun Nie
request more mixer for the case that hdisplay exceeding 4096 and DSC enabled. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b

[PATCH 08/21] drm/msm/dpu: decide right side per last bit

2024-08-29 Thread Jun Nie
in case of multiple mixer pairs Signed-off-by: Jun Nie Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index

[PATCH 07/21] drm/msm/dpu: Support dynamic DSC number

2024-08-29 Thread Jun Nie
Do not assume DSC number as 2. Because there are 4 DSC in quad pipe case. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1

[PATCH 06/21] drm/msm/dpu: Add utility to get mixer number

2024-08-29 Thread Jun Nie
Add utility to get mixer number via CRTC handler Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 7 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 5 + 2 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm

[PATCH 05/21] drm/msm/dpu: polish log for resource allocation

2024-08-29 Thread Jun Nie
Add resource allocation type info. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c index 15b42a6683639

[PATCH 04/21] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2024-08-29 Thread Jun Nie
incorrect. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 25 ++--- include/drm/drm_mipi_dsi.h | 2 ++ 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/d

[PATCH 03/21] drm/msm/dsi: pass the right width to dsc

2024-08-29 Thread Jun Nie
Data width for dsc engine is aligned with pipe, not with whole screen width. Because the width may be halved in DSI bonded case. The dsc width is not related to the timing with back front porch in later stage, so update dsc timing earlier. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi

[PATCH 02/21] drm/msm/dsi: fix DSC width for the bonded DSI case

2024-08-29 Thread Jun Nie
that behave like single panel for display controller. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi.h | 3 ++- drivers/gpu/drm/msm/dsi/dsi_host.c| 6 +- drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +- 3 files changed, 8 insertions(+), 3

[PATCH 01/21] drm/msm/dsi: add support to DSI CTRL v2.8.0

2024-08-29 Thread Jun Nie
From: Jonathan Marek Add support to DSI CTRL v2.8.0 with priority support Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 185d7de0bf376

[PATCH 00/21] drm/msm: Support quad pipe with dual-DSI

2024-08-29 Thread Jun Nie
: Jun Nie --- Jonathan Marek (3): drm/msm/dsi: add support to DSI CTRL v2.8.0 drm/msm/dsi: fix DSC width for the bonded DSI case drm/msm/dsi: support DSC configurations with slice_per_pkt > 1 Jun Nie (18): drm/msm/dsi: pass the right width to dsc drm/msm/dpu: polish

[PATCH v6 6/6] drm/msm/dsi: add a comment to explain pkt_per_line encoding

2024-05-29 Thread Jun Nie
From: Jonathan Marek Make it clear why the pkt_per_line value is being "divided by 2". Signed-off-by: Jonathan Marek Reviewed-by: Dmitry Baryshkov Signed-off-by: Jun Nie Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armst

[PATCH v6 5/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC

2024-05-29 Thread Jun Nie
kov Signed-off-by: Jun Nie Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm

[PATCH v6 4/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2024-05-29 Thread Jun Nie
ewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Reviewed-by: Jessica Zhang Signed-off-by: Jun Nie Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 ++- 1 file changed, 2 i

[PATCH v6 3/6] drm/msm/dpu: enable compression bit in cfg2 for DSC

2024-05-29 Thread Jun Nie
Enable compression bit in cfg2 register for DSC in the DSI case per hardware version. Signed-off-by: Jun Nie Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm

[PATCH v6 2/6] drm/msm/dpu: adjust data width for widen bus case

2024-05-29 Thread Jun Nie
data is valid for only half the active window if widebus is enabled Signed-off-by: Jun Nie Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK Reviewed-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu

[PATCH v6 1/6] drm/msm/dpu: fix video mode DSC for DSI

2024-05-29 Thread Jun Nie
From: Jonathan Marek Add width change in DPU timing for DSC compression case to work with DSI video mode. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie Tested-by: Neil Armstrong # on SM8550-QRD Tested-by: Neil Armstrong # on SM8650-QRD Tested-by: Neil Armstrong # on SM8650-HDK

[PATCH v6 0/6] Add DSC support to DSI video panel

2024-05-29 Thread Jun Nie
olish warning usage - Add tags from reviewers Changes vs V2: - Drop the INTF_CFG2_DATA_HCTL_EN change as it is handled in latest mainline code. - Drop the bonded DSI patch as I do not have device to test it. - Address comments from version 2. Signed-off-by: Jun Nie --- Changes in v6: - Link

Re: [PATCH v5 2/6] drm/msm/dpu: adjust data width for widen bus case

2024-05-28 Thread Jun Nie
Dmitry Baryshkov 于2024年5月28日周二 08:48写道: > > On Mon, May 27, 2024 at 10:21:48PM +0800, Jun Nie wrote: > > data is valid for only half the active window if widebus > > is enabled > > > > Signed-off-by: Jun Nie > > --- > > drivers/gpu/drm/msm/disp/dp

[PATCH v5 6/6] drm/msm/dsi: add a comment to explain pkt_per_line encoding

2024-05-27 Thread Jun Nie
From: Jonathan Marek Make it clear why the pkt_per_line value is being "divided by 2". Signed-off-by: Jonathan Marek Reviewed-by: Dmitry Baryshkov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/d

[PATCH v5 5/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC

2024-05-27 Thread Jun Nie
kov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 47f5858334f6..7252d36687e6 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/

[PATCH v5 4/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2024-05-27 Thread Jun Nie
ewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Reviewed-by: Jessica Zhang Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c ind

[PATCH v5 3/6] drm/msm/dpu: enable compression bit in cfg2 for DSC

2024-05-27 Thread Jun Nie
Enable compression bit in cfg2 register for DSC in the DSI case Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c index

[PATCH v5 2/6] drm/msm/dpu: adjust data width for widen bus case

2024-05-27 Thread Jun Nie
data is valid for only half the active window if widebus is enabled Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c

[PATCH v5 1/6] drm/msm/dpu: fix video mode DSC for DSI

2024-05-27 Thread Jun Nie
From: Jonathan Marek Add width change in DPU timing for DSC compression case to work with DSI video mode. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 8

[PATCH v5 0/6] Add DSC support to DSI video panel

2024-05-27 Thread Jun Nie
p the INTF_CFG2_DATA_HCTL_EN change as it is handled in latest mainline code. - Drop the bonded DSI patch as I do not have device to test it. - Address comments from version 2. Signed-off-by: Jun Nie --- Changes in v5: - Link to v4: https://lore.kernel.org/r/20240524-msm-drm-dsc-dsi-video-upstream-4-v4-0-e61c

[PATCH v4 5/5] drm/msm/dsi: add a comment to explain pkt_per_line encoding

2024-05-24 Thread Jun Nie
From: Jonathan Marek Make it clear why the pkt_per_line value is being "divided by 2". Signed-off-by: Jonathan Marek Reviewed-by: Dmitry Baryshkov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/d

[PATCH v4 4/5] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC

2024-05-24 Thread Jun Nie
kov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 47f5858334f6..7252d36687e6 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/

[PATCH v4 3/5] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2024-05-24 Thread Jun Nie
ewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Reviewed-by: Jessica Zhang Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c ind

[PATCH v4 2/5] drm: adjust data width for widen bus case

2024-05-24 Thread Jun Nie
data is valid for only half the active window if widebus is enabled Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c index

[PATCH v4 1/5] drm/msm/dpu: fix video mode DSC for DSI

2024-05-24 Thread Jun Nie
From: Jonathan Marek Add necessary DPU timing and control changes for DSC to work with DSI video mode. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 8

[PATCH v4 0/5] Add DSC support to DSI video panel

2024-05-24 Thread Jun Nie
test it. - Address comments from version 2. Signed-off-by: Jun Nie --- Jonathan Marek (4): drm/msm/dpu: fix video mode DSC for DSI drm/msm/dsi: set video mode widebus enable bit when widebus is enabled drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC drm/msm/dsi: add a comme

Re: [PATCH v3 3/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC)

2024-04-08 Thread Jun Nie
Marijn Suijten 于2024年4月9日周二 00:45写道: > > Can we drop (fix video mode DSC) from this patch title? It looks like more > patches are required to get this done, such a mention is more something for > the > cover letter. > > We could also clarify further to "set Word Count for video-mode DSC". > Acce

Re: [PATCH v3 6/6] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2024-04-08 Thread Jun Nie
Dmitry Baryshkov 于2024年4月3日周三 18:51写道: > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > From: Jonathan Marek > > > > Support slice_per_pkt in msm driver. > > > > Note that the removed "pkt_per_line = slice_per_intf * slice_per_pkt" >

Re: [PATCH v3 5/6] drm/display: Add slice_per_pkt for dsc

2024-04-08 Thread Jun Nie
Dmitry Baryshkov 于2024年4月3日周三 17:41写道: > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > Add variable for slice number of a DSC compression bit stream packet. > > Its value shall be specified in panel driver, or default value can be set > > in display controll

Re: [PATCH v3 2/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2024-04-08 Thread Jun Nie
Dmitry Baryshkov 于2024年4月3日周三 18:10写道: > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > From: Jonathan Marek > > > > The value returned by msm_dsi_wide_bus_enabled() doesn't match what the > > driver is doing in video mode. Fix that by act

Re: [PATCH v3 1/6] drm/msm/dpu: fix video mode DSC for DSI

2024-04-03 Thread Jun Nie
Dmitry Baryshkov 于2024年4月3日周三 17:57写道: > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > From: Jonathan Marek > > > > Add necessary DPU timing and control changes for DSC to work with DSI > > video mode. > > > > Signed-of

Re: [PATCH v3 0/6] Add DSC support to DSI video panel

2024-04-03 Thread Jun Nie
Dmitry Baryshkov 于2024年4月3日周三 17:49写道: > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > This is follow up update to Jonathan's patch set. > > > > Changes vs V2: > > - Rebase to latest mainline. > > - Drop the INTF_CFG2_DATA_HCTL_EN change a

[PATCH v3 6/6] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2024-04-03 Thread Jun Nie
From: Jonathan Marek Support slice_per_pkt in msm driver. Note that the removed "pkt_per_line = slice_per_intf * slice_per_pkt" comment is incorrect. Also trim the code to simplify the dsc reference. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/d

[PATCH v3 5/6] drm/display: Add slice_per_pkt for dsc

2024-04-03 Thread Jun Nie
Add variable for slice number of a DSC compression bit stream packet. Its value shall be specified in panel driver, or default value can be set in display controller driver if panel driver does not set it. Signed-off-by: Jun Nie --- include/drm/display/drm_dsc.h | 4 1 file changed, 4

[PATCH v3 4/6] drm/msm/dsi: add a comment to explain pkt_per_line encoding

2024-04-03 Thread Jun Nie
From: Jonathan Marek Make it clear why the pkt_per_line value is being "divided by 2". Signed-off-by: Jonathan Marek Reviewed-by: Dmitry Baryshkov Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/dsi/dsi_host.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/d

[PATCH v3 3/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC)

2024-04-03 Thread Jun Nie
From: Jonathan Marek Video mode DSC won't work if this field is not set correctly. Set it to fix video mode DSC (for slice_per_pkt==1 cases at least). Fixes: 08802f515c3c ("drm/msm/dsi: Add support for DSC configuration") Signed-off-by: Jonathan Marek Reviewed-by: Dmitry Baryshkov --- drivers

[PATCH v3 2/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2024-04-03 Thread Jun Nie
From: Jonathan Marek The value returned by msm_dsi_wide_bus_enabled() doesn't match what the driver is doing in video mode. Fix that by actually enabling widebus for video mode. Fixes: efcbd6f9cdeb ("drm/msm/dsi: Enable widebus for DSI") Signed-off-by: Jonathan Marek Signed-

[PATCH v3 1/6] drm/msm/dpu: fix video mode DSC for DSI

2024-04-03 Thread Jun Nie
From: Jonathan Marek Add necessary DPU timing and control changes for DSC to work with DSI video mode. Signed-off-by: Jonathan Marek Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 9 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 8

[PATCH v3 0/6] Add DSC support to DSI video panel

2024-04-03 Thread Jun Nie
ff-by: Jun Nie --- Jonathan Marek (5): drm/msm/dpu: fix video mode DSC for DSI drm/msm/dsi: set video mode widebus enable bit when widebus is enabled drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC) drm/msm/dsi: add a comment to explain pkt_per_line enc

Re: [PATCH 1/3] drm/msm/dpu: fix DSC for DSI video mode

2024-03-28 Thread Jun Nie
Dmitry Baryshkov 于2024年3月28日周四 23:05写道: > > On Thu, 28 Mar 2024 at 13:12, Jun Nie wrote: > > > > Fix DSC timing and control configurations in DPU for DSI video mode. > > Only compression ratio 3:1 is handled and tested. > > > > This patch is modified from patc

[PATCH 3/3] drm/panel: Enable DSC for Visionox VTDR6130 panel

2024-03-28 Thread Jun Nie
- cmd mode + DSC Signed-off-by: Jun Nie --- .../gpu/drm/panel/panel-visionox-vtdr6130.c | 58 ++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c index 540099253e1b

[PATCH 2/3] dt-bindings: display: panel: visionox, vtdr6130: Add mode property

2024-03-28 Thread Jun Nie
Add DSI mode property and compression mode property Signed-off-by: Jun Nie --- .../bindings/display/panel/visionox,vtdr6130.yaml | 8 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation

[PATCH 1/3] drm/msm/dpu: fix DSC for DSI video mode

2024-03-28 Thread Jun Nie
Fix DSC timing and control configurations in DPU for DSI video mode. Only compression ratio 3:1 is handled and tested. This patch is modified from patchs of Jonathan Marek. Signed-off-by: Jun Nie --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- .../gpu/drm/msm/disp/dpu1