Re: [Freedreno] [Intel-gfx] [PATCH v6 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2023-03-10 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Mark > Yacoub > Sent: Thursday, January 19, 2023 1:00 AM > To: quic_khs...@quicinc.com; linux-arm-...@vger.kernel.org; dri- > de...@lists.freedesktop.org; freedreno@lists.freedesktop.org; > devicet...@vger.kernel.org; linux-ker...@vger

Re: [Freedreno] [Intel-gfx] [PATCH v6 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2023-03-10 Thread Kandpal, Suraj
> > From: Sean Paul > > This patch moves the hdcp atomic check from i915 to drm_hdcp so other > drivers can use it. No functional changes, just cleaned up some of the code > when moving it over. > > Acked-by: Jani Nikula > Acked-by: Jani Nikula > Reviewed-by: Rodrigo Vivi > Reviewed-by: Abhi

Re: [Freedreno] [PATCH v6 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-10 Thread Kandpal, Suraj
> Subject: [PATCH v6 06/10] drm/i915/hdcp: Retain hdcp_capable return codes > > From: Sean Paul > > The shim functions return error codes, but they are discarded in > intel_hdcp.c. This patch plumbs the return codes through so they are > properly handled. > > Acked-by: Jani Nikula > Reviewed-b

Re: [Freedreno] [Intel-gfx] [PATCH v6 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-03-13 Thread Kandpal, Suraj
> > From: Sean Paul > > Now that all of the HDCP 1.x logic has been migrated to the central HDCP > helpers, use it in the i915 driver. > > The majority of the driver code for HDCP 1.x will live in intel_hdcp.c, > however there are a few helper hooks which are connector-specific and > need to be

Re: [Freedreno] [PATCH v6 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-23 Thread Kandpal, Suraj
> -Original Message- > From: Kandpal, Suraj > Sent: Friday, March 10, 2023 1:55 PM > To: Mark Yacoub ; quic_khs...@quicinc.com; > linux-arm-...@vger.kernel.org; dri-de...@lists.freedesktop.org; > freedreno@lists.freedesktop.org; devicet...@vger.kernel

Re: [Freedreno] [PATCH v6 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-27 Thread Kandpal, Suraj
> -Original Message- > From: Mark Yacoub > Sent: Saturday, March 25, 2023 12:57 AM > To: Kandpal, Suraj > Cc: quic_khs...@quicinc.com; linux-arm-...@vger.kernel.org; dri- > de...@lists.freedesktop.org; freedreno@lists.freedesktop.org; > devicet...@vger.

Re: [Freedreno] [PATCH v8 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check

2023-04-02 Thread Kandpal, Suraj
> -Original Message- > From: Mark Yacoub > Sent: Saturday, April 1, 2023 3:42 AM > To: David Airlie ; Daniel Vetter > Cc: seanp...@chromium.org; Kandpal, Suraj ; > diand...@chromium.org; dri-de...@lists.freedesktop.org; > freedreno@lists.f

Re: [Freedreno] [PATCH v8 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-04-02 Thread Kandpal, Suraj
> -Original Message- > From: Mark Yacoub > Sent: Saturday, April 1, 2023 3:42 AM > To: Jani Nikula ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; David Airlie > ; Daniel Vetter > Cc: seanp...@chromium.org; Kandpal, Suraj ; > di

Re: [Freedreno] [PATCH v8 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-04-02 Thread Kandpal, Suraj
> -Original Message- > From: Kandpal, Suraj > Sent: Monday, April 3, 2023 12:12 PM > To: Mark Yacoub ; Jani Nikula > ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; David Airlie > ; Daniel Vetter > Cc: seanp...@chromium.org; diand

Re: [Freedreno] [PATCH v8 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-04-03 Thread Kandpal, Suraj
> -Original Message- > From: Mark Yacoub > Sent: Saturday, April 1, 2023 3:42 AM > To: Jani Nikula ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; David Airlie > ; Daniel Vetter > Cc: seanp...@chromium.org; Kandpal, Suraj ; > di

Re: [Freedreno] [PATCH v4 08/12] drm/display/dsc: add YCbCr 4:2:2 and 4:2:0 RC parameters

2023-04-13 Thread Kandpal, Suraj
Hi, > Include RC parameters for YCbCr 4:2:2 and 4:2:0 configurations. > Looks Good to me Reviewed-by: Suraj Kandpal > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dsc_helper.c | 438 > +++ > include/drm/display/drm_dsc_helper.h | 2 + > 2 files

Re: [Freedreno] [PATCH v9 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2023-04-17 Thread Kandpal, Suraj
Yacoub > ; linux-ker...@vger.kernel.org > Subject: [PATCH v9 01/10] drm/hdcp: Add drm_hdcp_atomic_check() > > From: Sean Paul > > Move the hdcp atomic check from i915 to drm_hdcp so other drivers can use > it. No functional changes, just cleaned up some of the code when moving it > over. > > Ac

Re: [Freedreno] [PATCH v9 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2023-04-17 Thread Kandpal, Suraj
> > From: Sean Paul > > Instead of forcing a modeset in the hdcp atomic check, rename to > drm_hdcp_has_changed and return true if the content protection value is > changing and let the driver decide whether a modeset is required or not. > > Acked-by: Jani Nikula > Reviewed-by: Rodrigo Vivi >

Re: [Freedreno] [PATCH v9 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-04-17 Thread Kandpal, Suraj
> -Original Message- > From: Mark Yacoub > Sent: Wednesday, April 12, 2023 12:52 AM > To: Jani Nikula ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; David Airlie > ; Daniel Vetter > Cc: seanp...@chromium.org; Kandpal, Suraj ; > diand...@

Re: [Freedreno] [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Kandpal, Suraj
> Subject: [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) > parameters > > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in preparation to > adding more configuration data. > > Signed-off

Re: [Freedreno] [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Kandpal, Suraj
> > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in preparation to > adding more configuration data. > Hi , Needed to add some more comments apart from the previous ones already given > Signed-off-by: Dmit

Re: [Freedreno] [PATCH v6 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Kandpal, Suraj
> > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in preparation to > adding more configuration data. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dsc_helper.c | 139

Re: [Freedreno] [PATCH v5 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-16 Thread Kandpal, Suraj
> -Original Message- > From: Dmitry Baryshkov > Sent: Wednesday, May 17, 2023 5:33 AM > To: Kandpal, Suraj ; David Airlie > ; Daniel Vetter ; Jani Nikula > ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; Rob Clark > ; Abhinav Kumar ; > Sean Paul ;

Re: [Freedreno] [PATCH v7 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-17 Thread Kandpal, Suraj
> > The array of rc_parameters contains a mixture of parameters from DSC 1.1 > and DSC 1.2 standards. Split these tow configuration arrays in preparation to > adding more configuration data. > > Signed-off-by: Dmitry Baryshkov LGTM. Reviewed-by: Suraj Kandpal > --- > drivers/gpu/drm/display/

Re: [Freedreno] [PATCH v7 6/8] drm/display/dsc: split DSC 1.2 and DSC 1.1 (pre-SCR) parameters

2023-05-19 Thread Kandpal, Suraj
> -Original Message- > From: Dmitry Baryshkov > Sent: Wednesday, May 17, 2023 3:58 PM > To: David Airlie ; Daniel Vetter ; Jani > Nikula ; Kandpal, Suraj > ; Joonas Lahtinen > ; Vivi, Rodrigo ; > Tvrtko Ursulin ; Rob Clark > ; Abhinav Kumar ; > Sean Paul ;