Re: [PATCH 3/3] dt-bindings: Batch-update Konrad Dybcio's email

2024-07-26 Thread Krzysztof Kozlowski
On 26/07/2024 13:18, Konrad Dybcio wrote: > Use my @kernel.org address everywhere. > > Signed-off-by: Konrad Dybcio > --- FWIW: Acked-by: Krzysztof Kozlowski Rob, will you take it directly? Best regards, Krzysztof

Re: [PATCH 1/1] dt-bindings: display/msm: dsi-controller-main: Add SM7150

2024-06-28 Thread Krzysztof Kozlowski
On 28/06/2024 10:23, Danila Tikhonov wrote: > Add the DSI host found on SM7150. > > Signed-off-by: Danila Tikhonov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied

2024-06-26 Thread Krzysztof Kozlowski
On 26/06/2024 06:31, Dmitry Baryshkov wrote: > On Tue, Jun 25, 2024 at 04:51:27PM GMT, Rob Herring wrote: >> On Sun, Jun 23, 2024 at 02:59:30PM +0200, Krzysztof Kozlowski wrote: >>> dtschema v2024.4, v2024.5 and maybe earlier do not select device nodes for >> >

Re: [PATCH 1/2] drm/msm/adreno: allow headless setup on SM8150 MTP

2024-06-24 Thread Krzysztof Kozlowski
On 24/06/2024 16:06, Konrad Dybcio wrote: > > > On 6/23/24 21:34, Krzysztof Kozlowski wrote: >> Commit f30ac26def18 ("arm64: dts: qcom: add sm8150 GPU nodes") re-used >> amd,imageon compatible for the SM8150 just to enable headless mode due >> to missing

Re: [PATCH v1 0/3] Support for Adreno X1-85 GPU

2024-06-24 Thread Krzysztof Kozlowski
On 24/06/2024 08:21, Akhil P Oommen wrote: > On Sun, Jun 23, 2024 at 01:11:48PM +0200, Krzysztof Kozlowski wrote: >> On 23/06/2024 13:06, Akhil P Oommen wrote: >>> This series adds support for the Adreno X1-85 GPU found in Qualcomm's >>> compute series chipset, Sn

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 17:16, Akhil P Oommen wrote: > On Sun, Jun 23, 2024 at 02:53:17PM +0200, Krzysztof Kozlowski wrote: >> On 23/06/2024 14:28, Akhil P Oommen wrote: >>> On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: >>>> On 23/06/2024 13:06, A

[PATCH v2 4/4] dt-bindings: display/msm/gpu: fix the schema being not applied

2024-06-23 Thread Krzysztof Kozlowski
a work-around do the binding can be used against DTS validation. Signed-off-by: Krzysztof Kozlowski --- This will uncover issues with DTS, which is expected and fixed in: 1. Incorrect AMD compatible: https://lore.kernel.org/linux-arm-msm/20240623193420.333735-1-krzysztof.kozlow...@linaro.org/T

[PATCH v2 2/4] dt-bindings: display/msm/gpu: define reg-names in top-level

2024-06-23 Thread Krzysztof Kozlowski
All devices should (and actually do) have same order of entries, if possible. That's the case for reg/reg-names, so define the reg-names in top-level to enforce that. Acked-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 5

[PATCH v2 3/4] dt-bindings: display/msm/gpu: simplify compatible regex

2024-06-23 Thread Krzysztof Kozlowski
Regex for newer Adreno compatibles can be simpler. Suggested-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml

[PATCH v2 1/4] dt-bindings: display/msm/gpu: constrain clocks in top-level

2024-06-23 Thread Krzysztof Kozlowski
We expect each schema with variable number of clocks, to have the widest constrains in top-level "properties:". This is more readable and also makes binding stricter, if there is no "if:then:" block for given variant. Acked-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski

[PATCH v2 0/4] dt-bindings: display/msm/gpu: few cleanups

2024-06-23 Thread Krzysztof Kozlowski
devicetree/bindings/display/msm/gpu.yaml | 27 ++ 1 file changed, 23 insertions(+), 4 deletions(-) --- base-commit: d47fa80a484f97ea51991c9547636a799c264652 change-id: 20240623-qcom-adreno-dts-bindings-driver-87521a145260 Best regards, -- Krzysztof Kozlowski

[PATCH 2/2] arm64: dts: qcom: sm8150-mtp: drop incorrect amd,imageon

2024-06-23 Thread Krzysztof Kozlowski
the SM8150 and later moved to the SM8150 MTP board in commit 1642ab96efa4 ("arm64: dts: qcom: sm8150: Don't start Adreno in headless mode") with an intention to allow headless mode. This should be solved via proper driver quirks, not fake compatibles. Signed-off-by: Krzysztof Kozlowsk

[PATCH 1/2] drm/msm/adreno: allow headless setup on SM8150 MTP

2024-06-23 Thread Krzysztof Kozlowski
ect way. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/adreno/adreno_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c index c3703a51287b..a8afe0b6429b 100644 --- a/driver

Re: [PATCH 3/3] dt-bindings: display/msm/gpu: constrain reg/reg-names per variant

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 16:13, Conor Dooley wrote: > On Sun, Jun 23, 2024 at 02:00:26PM +0200, Krzysztof Kozlowski wrote: >> MMIO address space is known per each variant of Adreno GPU, so we can >> constrain the reg/reg-names entries for each variant. There is no DTS >> f

[PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied

2024-06-23 Thread Krzysztof Kozlowski
a work-around do the binding can be used against DTS validation. Signed-off-by: Krzysztof Kozlowski --- Cc: Akhil P Oommen --- .../devicetree/bindings/display/msm/gmu.yaml | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 14:28, Akhil P Oommen wrote: > On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: >> On 23/06/2024 13:06, Akhil P Oommen wrote: >>> Add the necessary dt nodes for gpu support in X1E80100. >>> >>> Signed-off-by: Akhil P Oomm

Re: [PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > Document Adreno X185 GMU in the dt-binding specification. > > Signed-off-by: Akhil P Oommen > --- > > Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 > 1 file changed, 4 insertions(+) > > diff --git

[PATCH 3/3] dt-bindings: display/msm/gpu: constrain reg/reg-names per variant

2024-06-23 Thread Krzysztof Kozlowski
MMIO address space is known per each variant of Adreno GPU, so we can constrain the reg/reg-names entries for each variant. There is no DTS for A619, so that part is not accurate but could be corrected later. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/msm/gpu.yaml

[PATCH 2/3] dt-bindings: display/msm/gpu: define reg-names in top-level

2024-06-23 Thread Krzysztof Kozlowski
All devices should (and actually do) have same order of entries, if possible. That's the case for reg/reg-names, so define the reg-names in top-level to enforce that. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 5 - 1 file changed, 4

[PATCH 1/3] dt-bindings: display/msm/gpu: constrain clocks in top-level

2024-06-23 Thread Krzysztof Kozlowski
We expect each schema with variable number of clocks, to have the widest constrains in top-level "properties:". This is more readable and also makes binding stricter, if there is no "if:then:" block for given variant. Signed-off-by: Krzysztof Kozlowski --- Documentation

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > Add the necessary dt nodes for gpu support in X1E80100. > > Signed-off-by: Akhil P Oommen > --- > + gmu: gmu@3d6a000 { > + compatible = "qcom,adreno-gmu-x185.1", > "qcom,adreno-gmu"; > + reg = <0x0

Re: [PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > Document Adreno X185 GMU in the dt-binding specification. > > Signed-off-by: Akhil P Oommen > --- > > Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 ++++ Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v1 0/3] Support for Adreno X1-85 GPU

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > This series adds support for the Adreno X1-85 GPU found in Qualcomm's > compute series chipset, Snapdragon X1 Elite (x1e80100). In this new > naming scheme for Adreno GPU, 'X' stands for compute series, '1' denotes > 1st generation and '8' & '5' denotes

Re: [PATCH 3/4] dt-bindings: msm: dsi-phy-28nm: Document msm8937 compatible

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 01:25, Barnabás Czémán wrote: > The MSM8937 SoC uses a slightly different 28nm dsi phy. Add a new > compatible for it. > > Signed-off-by: Barnabás Czémán > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] dt-bindings: display/msm: qcom, mdp5: Add msm8937 compatible

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 01:25, Barnabás Czémán wrote: > Add the compatible for the MDP5 found on MSM8937. > > Signed-off-by: Barnabás Czémán > --- Reviewed-by: Krzysztof Kozlowski --- This is an automated instruction, just in case, because many review tags are being ignored. If you know

Re: [PATCH v2 3/4] dt-bindings: display/msm: Add SM7150 DPU

2024-06-13 Thread Krzysztof Kozlowski
On 13/06/2024 12:13, Dmitry Baryshkov wrote: > On Thu, Jun 13, 2024 at 11:23:50AM +0200, Krzysztof Kozlowski wrote: >> On 12/06/2024 20:43, Danila Tikhonov wrote: >>> Document the DPU hardware found on the Qualcomm SM7150 platform. >> >> In general, this should be b

Re: [PATCH v2 1/4] dt-bindings: display/msm: Add SM7150 MDSS

2024-06-13 Thread Krzysztof Kozlowski
On 12/06/2024 20:43, Danila Tikhonov wrote: > Document the MDSS hardware found on the Qualcomm SM7150 platform. > > Signed-off-by: Danila Tikhonov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 3/4] dt-bindings: display/msm: Add SM7150 DPU

2024-06-13 Thread Krzysztof Kozlowski
lcomm SM7150 Display DPU What is DPU? Such acronyms should be explained in description or expanded here, if there is space. Reviewed-by: Krzysztof Kozlowski > + > +maintainers: > + - Danila Tikhonov > + > +$ref: /schemas/display/msm/dpu-common.yaml# > + > +properties: > + compatible: > +const: qcom,sm7150-dpu > + Best regards, Krzysztof

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-05 Thread Krzysztof Kozlowski
On 04/06/2024 19:52, Abhinav Kumar wrote: > > > On 6/4/2024 8:36 AM, Krzysztof Kozlowski wrote: >> On 04/06/2024 17:32, Dmitry Baryshkov wrote: >>> On Tue, Jun 04, 2024 at 05:22:03PM +0200, Krzysztof Kozlowski wrote: >>>> On 04/06/2024 17:14, Dmitry Baryshkov

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Krzysztof Kozlowski
the default. In such case the property can > be skipped. > > Signed-off-by: Dmitry Baryshkov Maybe we need third DT maintainer review/ack... Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Krzysztof Kozlowski
On 04/06/2024 17:32, Dmitry Baryshkov wrote: > On Tue, Jun 04, 2024 at 05:22:03PM +0200, Krzysztof Kozlowski wrote: >> On 04/06/2024 17:14, Dmitry Baryshkov wrote: >>>>>>>> >>>>>>>> I didnt follow why this is a link

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-06-04 Thread Krzysztof Kozlowski
On 04/06/2024 17:14, Dmitry Baryshkov wrote: >> >> I didnt follow why this is a link property. Sorry , I didnt follow the >> split part. > > There is a link between the DSI host and the panel. I don't want to > end up in a situation when the properties of the link are split

Re: [PATCH 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-03-30 Thread Krzysztof Kozlowski
On 27/03/2024 11:11, Krzysztof Kozlowski wrote: > On 26/03/2024 21:02, Dmitry Baryshkov wrote: >> As Qualcomm SM8150 got support for the DisplayPort, add displayport@ >> node as a valid child to the MDSS node. >> >> Signed-off-by: Dmitry Baryshkov >> --- >

Re: [PATCH v2 2/3] dt-bindings: display: msm: sm6350-mdss: document DP controller subnode

2024-03-30 Thread Krzysztof Kozlowski
On 29/03/2024 08:45, Luca Weiss wrote: > Document the displayport controller subnode of the SM6350 MDSS. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/3] dt-bindings: display: panel: visionox, vtdr6130: Add mode property

2024-03-29 Thread Krzysztof Kozlowski
On 28/03/2024 12:11, Jun Nie wrote: > Add DSI mode property and compression mode property > > Signed-off-by: Jun Nie > --- > .../bindings/display/panel/visionox,vtdr6130.yaml | 8 > 1 file changed, 8 insertions(+) > Please use scripts/get_maintainers.pl to get a list of

Re: [PATCH 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-03-27 Thread Krzysztof Kozlowski
On 26/03/2024 21:02, Dmitry Baryshkov wrote: > As Qualcomm SM8150 got support for the DisplayPort, add displayport@ > node as a valid child to the MDSS node. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-03-27 Thread Krzysztof Kozlowski
On 27/03/2024 09:52, Dmitry Baryshkov wrote: > On Wed, 27 Mar 2024 at 10:45, Krzysztof Kozlowski > wrote: >> >> On 26/03/2024 21:02, Dmitry Baryshkov wrote: >>> diff --git >>> a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml >>>

Re: [RFC PATCH 1/1] dt-bindings: display/msm: gpu: Split Adreno schemas into separate files

2024-03-27 Thread Krzysztof Kozlowski
On 26/03/2024 21:05, Adam Skladowski wrote: > Split shared schema into per-gen and group adrenos by clocks used. > > Signed-off-by: Adam Skladowski > --- > .../devicetree/bindings/display/msm/gpu.yaml | 317 ++ > .../bindings/display/msm/qcom,adreno-306.yaml | 115 +++ >

Re: [PATCH 1/4] dt-bindings: display/msm: sm8150-mdss: add DP node

2024-03-27 Thread Krzysztof Kozlowski
On 26/03/2024 21:02, Dmitry Baryshkov wrote: > diff --git > a/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml > b/Documentation/devicetree/bindings/display/msm/qcom,sm8150-mdss.yaml > index c0d6a4fdff97..40b077fb20aa 100644 > ---

Re: [PATCH v2 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible

2024-02-27 Thread Krzysztof Kozlowski
On 22/02/2024 16:55, Abel Vesa wrote: > Add the X1E80100 to the list of compatibles and document the is-edp > flag. The controllers are expected to operate in DP mode by default, > and this flag can be used to select eDP mode. > > Signed-off-by: Abel Vesa > --- >

Re: [PATCH v2 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible

2024-02-25 Thread Krzysztof Kozlowski
On 24/02/2024 23:34, Dmitry Baryshkov wrote: > On Thu, 22 Feb 2024 at 17:55, Abel Vesa wrote: >> >> Add the X1E80100 to the list of compatibles and document the is-edp >> flag. The controllers are expected to operate in DP mode by default, >> and this flag can be used to select eDP mode. >> >>

Re: [PATCH v2 1/7] dt-bindings: clock: Add Qcom QCM2290 GPUCC

2024-02-24 Thread Krzysztof Kozlowski
On 23/02/2024 22:21, Konrad Dybcio wrote: > Add device tree bindings for graphics clock controller for Qualcomm > Technology Inc's QCM2290 SoCs. > > Signed-off-by: Konrad Dybcio > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 3/7] dt-bindings: arm-smmu: Document SM8650 GPU SMMU

2024-02-22 Thread Krzysztof Kozlowski
On 16/02/2024 12:03, Neil Armstrong wrote: > Document the GPU SMMU found on the SM8650 platform. > > Signed-off-by: Neil Armstrong > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Krzyszto

Re: [PATCH v3 2/7] dt-bindings: arm-smmu: fix SM8[45]50 GPU SMMU if condition

2024-02-22 Thread Krzysztof Kozlowski
U SMMU") > Suggested-by: Dmitry Baryshkov > Signed-off-by: Neil Armstrong Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] arm64: dts: qcom: sm6115: fix USB PHY configuration

2024-02-20 Thread Krzysztof Kozlowski
On 20/02/2024 22:23, Konrad Dybcio wrote: > On 20.02.2024 18:31, Dmitry Baryshkov wrote: >> The patch adding Type-C support for sm6115 was misapplied. All the >> orientation switch configuration ended up at the UFS PHY node instead of >> the USB PHY node. Move the data bits to the correct place.

Re: [PATCH v3 1/4] dt-bindings: display/msm: Document the DPU for X1E80100

2024-02-20 Thread Krzysztof Kozlowski
On 16/02/2024 18:01, Abel Vesa wrote: > Document the DPU for Qualcomm X1E80100 platform in the SM8650 schema, as > they are similar. > > Signed-off-by: Abel Vesa Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/8] dt-bindings: msm: qcom,mdss: Include ommited fam-b compatible

2024-02-05 Thread Krzysztof Kozlowski
On 21/01/2024 20:41, Adam Skladowski wrote: > During conversion 28nm-hpm-fam-b compat got lost, add it. > > Signed-off-by: Adam Skladowski > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties"

2024-02-05 Thread Krzysztof Kozlowski
| 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/5] dt-bindings: display/msm: document MDSS on X1E80100

2024-01-30 Thread Krzysztof Kozlowski
es some note. > .../bindings/display/msm/qcom,x1e80100-mdss.yaml | 249 > + > 1 file changed, 249 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/5] dt-bindings: display/msm: Document the DPU for X1E80100

2024-01-30 Thread Krzysztof Kozlowski
On 29/01/2024 14:18, Abel Vesa wrote: > Document the DPU for Qualcomm X1E80100 platform in the SM8650 schema, as > they are similar. > > Signed-off-by: Abel Vesa > --- > Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 5 - > 1 file changed, 4 insertions(+), 1

Re: [PATCH 5/8] dt-bindings: drm/msm/gpu: Document AON clock for A506/A510

2024-01-22 Thread Krzysztof Kozlowski
On 21/01/2024 20:41, Adam Skladowski wrote: > Adreno 506(MSM8953) and Adreno 510(MSM8976) require > Always-on branch clock to be enabled, describe it. > > Signed-off-by: Adam Skladowski > --- > Documentation/devicetree/bindings/display/msm/gpu.yaml | 6 -- > 1 file changed, 4 insertions(+),

Re: [PATCH 3/8] dt-bindings: msm: qcom,mdss: Include ommited fam-b compatible

2024-01-22 Thread Krzysztof Kozlowski
On 21/01/2024 20:41, Adam Skladowski wrote: > During conversion 28nm-hpm-fam-b compat got lost, add it. Please add Fixes tag and put this commit as first in your patchset or even as separate one. Best regards, Krzysztof

Re: [PATCH 2/8] dt-bindings: dsi-controller-main: Document missing msm8976 compatible

2024-01-22 Thread Krzysztof Kozlowski
On 21/01/2024 20:41, Adam Skladowski wrote: > When all dsi-ctrl compats were added msm8976 was missed, include it too. > > Signed-off-by: Adam Skladowski > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/8] dt-bindings: display: msm: dp: declare compatible string for sm8150

2023-12-12 Thread Krzysztof Kozlowski
On 11/12/2023 16:44, Dmitry Baryshkov wrote: > Add compatible string for the DisplayPort controller found on the > Qualcomm SM8150 platform. > > Signed-off-by: Dmitry Baryshkov > --- DT list... Best regards, Krzysztof

Re: [PATCH 1/9] dt-bindings: display: msm: dp: declare compatible string for sm8150

2023-12-11 Thread Krzysztof Kozlowski
On 10/12/2023 00:21, Dmitry Baryshkov wrote: > Add compatible string for the DisplayPort controller found on the > Qualcomm SM8150 platform. > > Signed-off-by: Dmitry Baryshkov > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/9] dt-bindings: display: msm: dp: declare compatible string for sm8150

2023-12-11 Thread Krzysztof Kozlowski
On 10/12/2023 00:21, Dmitry Baryshkov wrote: > Add compatible string for the DisplayPort controller found on the > Qualcomm SM8150 platform. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/3] dt-bindings: display: msm: dp-controller: document SM8650 compatible

2023-12-07 Thread Krzysztof Kozlowski
On 07/12/2023 17:37, Neil Armstrong wrote: > Document the DisplayPort controller found in the Qualcomm SM8650 SoC, > the Controller base addresses and layout differ and thus cannot use > the SM8350 compatible as fallback. > > Signed-off-by: Neil Armstrong > --- Reviewed-by: K

Re: [Freedreno] [PATCH 1/3] dt-bindings: display/msm: gpu: Allow multiple digits for patchid

2023-12-01 Thread Krzysztof Kozlowski
On 30/11/2023 21:35, Luca Weiss wrote: > Some GPUs like the Adreno A305B has a patchid higher than 9, in this > case 18. Make sure the regexes can account for that. > > Signed-off-by: Luca Weiss > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 02/12] dt-bindings: display: msm: Add reg bus and rotator interconnects

2023-11-28 Thread Krzysztof Kozlowski
y: Konrad Dybcio > --- Thanks, looks good. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 01/12] dt-bindings: display: msm: qcm2290-mdss: Use the non-deprecated DSI compat

2023-11-28 Thread Krzysztof Kozlowski
hat. > > Fix that. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 06/12] dt-bindings: firmware: qcom, scm: Allow interconnect for everyone

2023-11-26 Thread Krzysztof Kozlowski
On 25/11/2023 15:17, Konrad Dybcio wrote: > Every Qualcomm SoC physically has a "CRYPTO0<->DDR" interconnect lane. > Allow this property to be present, no matter the SoC. > > Signed-off-by: Konrad Dybcio > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 05/12] dt-bindings: interconnect: qcom, msm8998-bwmon: Add QCM2290 bwmon instance

2023-11-26 Thread Krzysztof Kozlowski
On 25/11/2023 15:17, Konrad Dybcio wrote: > QCM2290 has a single BWMONv4 intance for CPU. Document it. > > Signed-off-by: Konrad Dybcio > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 03/12] dt-bindings: display: msm: qcm2290-mdss: Allow 2 interconnects

2023-11-26 Thread Krzysztof Kozlowski
On 25/11/2023 15:17, Konrad Dybcio wrote: > In addition to MDP0, the cpu-cfg interconnect is also necessary. > Allow it. > > Signed-off-by: Konrad Dybcio > --- > Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: [Freedreno] [PATCH 02/12] dt-bindings: display: msm: Add reg bus and rotator interconnects

2023-11-26 Thread Krzysztof Kozlowski
erly, namely the "reg bus", a.k.a the CPU-MDSS CFG > interconnect. > > Describe these paths bindings to allow using them in device trees and in > the driver > > Signed-off-by: Dmitry Baryshkov > [Konrad: rework for one vs two MDP paths] > Signed-off-by: Konrad

Re: [Freedreno] [PATCH 01/12] dt-bindings: display: msm: qcm2290-mdss: Use the non-deprecated DSI compat

2023-11-26 Thread Krzysztof Kozlowski
On 25/11/2023 15:17, Konrad Dybcio wrote: > The "qcom,dsi-ctrl-6g-qcm2290" has been deprecated in commit 0c0f65c6dd44 > ("dt-bindings: msm: dsi-controller-main: Add compatible strings for every > current SoC"), but the example hasn't been updated to reflect that. > > Fix that. > > Fixes:

[Freedreno] [PATCH] dt-bindings: display/msm: qcom, sm8150-mdss: correct DSI PHY compatible

2023-11-11 Thread Krzysztof Kozlowski
Qualcomm SM8150 MDSS comes with a bit different 7nm DSI PHY with its own compatible. DTS already use it: sa8155p-adp.dtb: display-subsystem@ae0: phy@ae94400:compatible:0: 'qcom,dsi-phy-7nm' was expected Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/msm/qcom

[Freedreno] [PATCH] dt-bindings: display/msm: qcom, sm8250-mdss: add DisplayPort controller node

2023-11-07 Thread Krzysztof Kozlowski
Document the DisplayPort controller node in MDSS binding, already used in DTS: sm8250-xiaomi-elish-boe.dtb: display-subsystem@ae0: Unevaluated properties are not allowed ('displayport-controller@ae9' was unexpected) Signed-off-by: Krzysztof Kozlowski --- .../bindings/display/msm

Re: [Freedreno] [PATCH 4/8] dt-bindings: display: msm: document the SM8650 Mobile Display Subsystem

2023-10-27 Thread Krzysztof Kozlowski
tions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 3/8] dt-bindings: display: msm: document the SM8650 DPU

2023-10-27 Thread Krzysztof Kozlowski
On 25/10/2023 09:35, Neil Armstrong wrote: > Document the DPU Display Controller on the SM8650 Platform. > > Signed-off-by: Neil Armstrong > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 2/8] dt-bindings: display: msm-dsi-controller-main: document the SM8650 DSI Controller

2023-10-27 Thread Krzysztof Kozlowski
On 25/10/2023 09:35, Neil Armstrong wrote: > Document the DSI Controller on the SM8650 Platform. > > Signed-off-by: Neil Armstrong Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 1/8] dt-bindings: display: msm-dsi-phy-7nm: document the SM8650 DSI PHY

2023-10-27 Thread Krzysztof Kozlowski
On 25/10/2023 09:34, Neil Armstrong wrote: > Document the DSI PHY on the SM8650 Platform. > > Signed-off-by: Neil Armstrong Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 3/6] dt-bindings: display: msm: Add SDM670 MDSS

2023-10-03 Thread Krzysztof Kozlowski
On 03/10/2023 12:31, Dmitry Baryshkov wrote: >>> +patternProperties: >>> + "^display-controller@[0-9a-f]+$": >>> +type: object >>> +additionalProperties: true >>> + >>> +properties: >>> + compatible: >>> +const: qcom,sdm670-dpu >>> + >>> +

Re: [Freedreno] [PATCH v2 3/6] dt-bindings: display: msm: Add SDM670 MDSS

2023-10-03 Thread Krzysztof Kozlowski
On 03/10/2023 03:21, Richard Acayan wrote: > Add documentation for the SDM670 display subsystem, adapted from the > SDM845 and SM6125 documentation. > > Signed-off-by: Richard Acayan > --- > .../display/msm/qcom,sdm670-mdss.yaml | 287 ++ > 1 file changed, 287

[Freedreno] [PATCH] dt-bindings: display: msm/dp: restrict opp-table to objects

2023-08-20 Thread Krzysztof Kozlowski
Simple 'opp-table:true' accepts a boolean property as opp-table, so restrict it to object to properly enforce real OPP table nodes. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/msm/dp-controller.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [Freedreno] [PATCH v2 02/14] dt-bindings: display/msm/gmu: Allow passing QMP handle

2023-08-14 Thread Krzysztof Kozlowski
# on SM8550-QRD > Tested-by: Dmitry Baryshkov # sm8450 > Signed-off-by: Konrad Dybcio > --- > Documentation/devicetree/bindings/display/msm/gmu.yaml | 7 +++ > 1 file changed, 7 insertions(+) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v2 12/13] dt-bindings: drm/msm/gpu: Extend bindings for chip-id

2023-07-28 Thread Krzysztof Kozlowski
On 27/07/2023 23:20, Rob Clark wrote: > From: Rob Clark > > Upcoming GPUs use an opaque chip-id for identifying the GPU. Examples? Anyway, I think we should insist here of using something human-readable, even if Qualcomm/Adreno internally use some weird numbers. > > Signed-off-by: Rob Clark

Re: [Freedreno] [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs

2023-07-27 Thread Krzysztof Kozlowski
On 27/07/2023 14:21, Rohit Agarwal wrote: >>> https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohia...@quicinc.com/ >> Please mention the dependency in patch changelog ---, so it is obvious >> for people applying it and also for the bot. > Sure. Will send a cover letter for this

Re: [Freedreno] [PATCH v2] dt-bindings: qcom: Update RPMHPD entries for some SoCs

2023-07-27 Thread Krzysztof Kozlowski
On 27/07/2023 13:19, Rohit Agarwal wrote: > > On 7/27/2023 4:46 PM, Rob Herring wrote: >> On Thu, 27 Jul 2023 14:39:13 +0530, Rohit Agarwal wrote: >>> Update the RPMHPD references with new bindings defined in rpmhpd.h >>> for Qualcomm SoCs SM8[2345]50. >>> >>> Signed-off-by: Rohit Agarwal >>>

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved

2023-07-26 Thread Krzysztof Kozlowski
nning > v5.10.y. > > Cc: sta...@vger.kernel.org # v5.10+ > Reviewed-by: Caleb Connolly > Signed-off-by: Amit Pundir > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH v5 2/2] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved

2023-07-26 Thread Krzysztof Kozlowski
On 13/07/2023 18:52, Amit Pundir wrote: > Adding a reserved memory region for the framebuffer memory > (the splash memory region set up by the bootloader). > > Signed-off-by: Amit Pundir > --- I think your commit msg misses describing the actual problem, impact to users and finally cc-stable.

Re: [Freedreno] [PATCH v5 1/2] dt-bindings: display/msm: mdss-common: add memory-region property

2023-07-26 Thread Krzysztof Kozlowski
Pundir > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH] dt-bindings: display: msm: sm6125-mdss: drop unneeded status from examples

2023-07-26 Thread Krzysztof Kozlowski
On 26/07/2023 09:27, Krzysztof Kozlowski wrote: > On 25/07/2023 13:46, Marijn Suijten wrote: >> On 2023-07-25 12:16:10, Krzysztof Kozlowski wrote: >>> Example DTS should not have 'status' property. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> ---

Re: [Freedreno] [PATCH] dt-bindings: display: msm: sm6125-mdss: drop unneeded status from examples

2023-07-26 Thread Krzysztof Kozlowski
On 25/07/2023 13:46, Marijn Suijten wrote: > On 2023-07-25 12:16:10, Krzysztof Kozlowski wrote: >> Example DTS should not have 'status' property. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml |

[Freedreno] [PATCH] dt-bindings: display: msm: sm6125-mdss: drop unneeded status from examples

2023-07-25 Thread Krzysztof Kozlowski
Example DTS should not have 'status' property. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml | 6 -- 1 file changed, 6 deletions(-) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6125-mdss.yaml b/Documentation

Re: [Freedreno] [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev

2023-07-12 Thread Krzysztof Kozlowski
On 12/07/2023 20:31, Sean Paul wrote: >>> 216 struct drm_device *ddev >>> 234 struct drm_device *drm_dev >>> 611 struct drm_device *drm >>>4190 struct drm_device *dev >>> >>> This series starts with renaming struct drm_crtc::dev to drm_dev. If >>> it's not only me and others like

Re: [Freedreno] [PATCH v2 1/8] dt-bindings: display/msm: Add reg bus and rotator interconnects

2023-07-12 Thread Krzysztof Kozlowski
ure MDSS register access > functions properly, namely the "reg bus", a.k.a the CPU-MDSS CFG > interconnect. > > Describe these paths bindings to allow using them in device trees and in > the driver > > Signed-off-by: Konrad Dybcio > Signed-off-by: Dmitry Baryshkov Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 1/2] dt-bindings: display/msm: qcom, sdm845-mdss: add memory-region property

2023-07-12 Thread Krzysztof Kozlowski
On 12/07/2023 15:02, Amit Pundir wrote: > Add and document the reserved memory region property > in the qcom,sdm845-mdss schema. > > Signed-off-by: Amit Pundir Please keep consistent versioning, so this is new patch in v4. > --- > .../devicetree/bindings/display/msm/qcom,sdm845-mdss.yaml|

Re: [Freedreno] [PATCH 1/5] dt-bindings: display: msm: dp-controller: document SM8250 compatible

2023-07-10 Thread Krzysztof Kozlowski
On 09/07/2023 06:19, Dmitry Baryshkov wrote: > It looks like DP controlled on SM8250 is the same as DP controller on > SM8350. Use the SM8350 compatible as fallback for SM8250. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 11/12] dt-bindings: drm/msm/gpu: Extend bindings for chip-id

2023-07-07 Thread Krzysztof Kozlowski
On 06/07/2023 23:10, Rob Clark wrote: > From: Rob Clark > > Upcoming GPUs use an opaque chip-id for identifying the GPU. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated

Re: [Freedreno] [PATCH 03/14] dt-bindings: display/msm/gpu: Allow A7xx SKUs

2023-07-04 Thread Krzysztof Kozlowski
On 28/06/2023 22:35, Konrad Dybcio wrote: > Allow A7xx SKUs, such as the A730 GPU found on SM8450 and friends. > They use GMU for all things DVFS, just like most A6xx GPUs. > > Signed-off-by: Konrad Dybcio > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [Freedreno] [PATCH 02/14] dt-bindings: display/msm/gmu: Allow passing QMP handle

2023-07-04 Thread Krzysztof Kozlowski
On 28/06/2023 22:35, Konrad Dybcio wrote: > When booting the GMU, the QMP mailbox should be pinged about some tunables > (e.g. adaptive clock distribution state). To achieve that, a reference to > it is necessary. Allow it and require it with A730. > > Signed-off-by: Konrad Dybcio > --- >

Re: [Freedreno] [PATCH 01/14] dt-bindings: display/msm/gmu: Add Adreno 7[34]0 GMU

2023-07-04 Thread Krzysztof Kozlowski
il and HFI would hang after the first submitted OOB). > > Describe the A730 and A740 GMU. > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

[Freedreno] [PATCH] dt-bindings: cleanup DTS example whitespaces

2023-07-02 Thread Krzysztof Kozlowski
The DTS code coding style expects spaces around '=' sign. Signed-off-by: Krzysztof Kozlowski --- Rob, Maybe this could go via your tree? Rebased on your for-next: v6.4-rc2-45-gf0ac35049606 --- .../bindings/arm/arm,coresight-cti.yaml| 18 +- .../bindings/arm/keystone

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-27 Thread Krzysztof Kozlowski
On 27/06/2023 11:02, Marijn Suijten wrote: > So deleting a new item at the end does not matter. But what if I respin > this patch to add the new clock _at the end_, which will then be at the > same index as the previous GCC_DISP_AHB_CLK? I think you know the answer, right?

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-27 Thread Krzysztof Kozlowski
On 27/06/2023 09:49, Marijn Suijten wrote: > On 2023-06-27 09:29:53, Krzysztof Kozlowski wrote: >> On 27/06/2023 08:54, Marijn Suijten wrote: >>> On 2023-06-27 08:24:41, Krzysztof Kozlowski wrote: >>>> On 26/06/2023 20:53, Marijn Suijten wrote: >>>>>

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-27 Thread Krzysztof Kozlowski
On 27/06/2023 08:54, Marijn Suijten wrote: > On 2023-06-27 08:24:41, Krzysztof Kozlowski wrote: >> On 26/06/2023 20:53, Marijn Suijten wrote: >>> On 2023-06-26 20:51:38, Marijn Suijten wrote: >>> >>>>> Not really, binding also defines the list of clock

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-27 Thread Krzysztof Kozlowski
On 26/06/2023 20:53, Marijn Suijten wrote: > On 2023-06-26 20:51:38, Marijn Suijten wrote: > >>> Not really, binding also defines the list of clocks - their order and >>> specific entries. This changes. >> >> And so it does in "dt-bindings: clock: qcom,dispcc-sm6125: Remove unused >>

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-26 Thread Krzysztof Kozlowski
On 26/06/2023 19:49, Marijn Suijten wrote: > On 2023-06-26 18:10:44, Krzysztof Kozlowski wrote: >> On 25/06/2023 21:48, Marijn Suijten wrote: >>> On 2023-06-24 11:08:54, Krzysztof Kozlowski wrote: >>>> On 24/06/2023 03:45, Konrad Dybcio wrote: >>>>&

Re: [Freedreno] [PATCH 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125

2023-06-26 Thread Krzysztof Kozlowski
On 25/06/2023 21:52, Marijn Suijten wrote: > On 2023-06-24 11:12:52, Krzysztof Kozlowski wrote: >> On 24/06/2023 02:41, Marijn Suijten wrote: >>> SM6125 is identical to SM6375 except that while downstream also defines >>> a throttle clock, its presence results

Re: [Freedreno] [PATCH 03/15] dt-bindings: clock: qcom, dispcc-sm6125: Require GCC PLL0 DIV clock

2023-06-26 Thread Krzysztof Kozlowski
On 26/06/2023 16:26, Marijn Suijten wrote: > On 2023-06-26 11:43:39, Konrad Dybcio wrote: >> On 25.06.2023 21:48, Marijn Suijten wrote: >>> On 2023-06-24 03:45:02, Konrad Dybcio wrote: On 24.06.2023 02:41, Marijn Suijten wrote: > The "gcc_disp_gpll0_div_clk_src" clock is consumed by the

  1   2   3   4   5   >