Re: [v2,1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-08-31 Thread Leonard Lausen
Dear György, >> Do you observe this issue on every suspend-resume cycle? > > I just did 10 suspend/resume cycles in a row to double check, and without > this patch the screen never comes back (always have to switch VT > back-and-forth to bring it back). The > > [dpu error]connector not connect

Re: [v2,1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-08-31 Thread Leonard Lausen
(Resend as there was an email SPF record issue) Dear György, On 8/30/24 13:36, György Kurucz wrote: > For context, I have a Lenovo Yoga Slim 7x laptop, and was having issues with > the display staying black after sleep. As a workaround, I could switch to a > different VT and back. Do you obser

Re: [v2,1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-08-31 Thread Leonard Lausen
Dear György, On 8/30/24 13:36, György Kurucz wrote: > For context, I have a Lenovo Yoga Slim 7x laptop, and was having issues with > the display staying black after sleep. As a workaround, I could switch to a > different VT and back. Do you observe this issue on every suspend-resume cycle? On s

Re: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-08-07 Thread Leonard Lausen
On 8/7/24 06:44, Dmitry Baryshkov wrote:> Could you please clarify, I was under the impression that currently whole suspend/resume is broken, so it's more than a dmesg message. 71174f362d67 specifically, or v6.9 more broadly regress in that we get "[dpu error]connector not connected 3" and "[drm

Re: [PATCH v2 1/2] drm/msm/dpu1: don't choke on disabling the writeback connector

2024-08-04 Thread Leonard Lausen
back's atomic_check to > dpu_writeback.c") > Cc: sta...@vger.kernel.org > Reported-by: Leonard Lausen > Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/57 > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 3 ---

Re: [REGRESSION] sc7180-trogdor-lazor image corruption regression for USB-C DP Alt Mode ([PATCH 0/2] Add param for the highest bank bit)

2024-02-18 Thread Leonard Lausen
Hi Dmitry, thank you for sharing a patch. I tested and can confirm it fixes the issue. Best regards Leonard On 2/17/24 23:04, Dmitry Baryshkov wrote: > Hi Leonard, > > On Sun, 18 Feb 2024 at 03:17, Leonard Lausen wrote: >> >> Hi Connor, >> >>

[REGRESSION] sc7180-trogdor-lazor image corruption regression for USB-C DP Alt Mode ([PATCH 0/2] Add param for the highest bank bit)

2024-02-17 Thread Leonard Lausen
Hi Connor, unfortunately, your series https://patchwork.freedesktop.org/series/127529/ has introduced a regression for external displays connected through USB-C DP Alt Mode, at least on sc7180-trogdor-lazor devices. Do you think it's possible to fix this before the 6.8 release or would it be b

Re: [Freedreno] [PATCH v7 0/7] incorporate pm runtime framework and eDP clean up

2023-11-05 Thread Leonard Lausen
Verified this fixes the "[drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-107)" issue https://gitlab.freedesktop.org/drm/msm/-/issues/25 Tested-by: Leonard Lausen # on sc7180 lazor On 10/6/23 18:55, Kuogee Hsieh wrote: > The purpose of this patch series is to i

Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-06-22 Thread Leonard Lausen
> > https://patchwork.freedesktop.org/patch/538601/?series=118148&rev=3 > > Apologies if you were not CCed on this, if a next version is CCed, > > > > will ask kuogee to cc you. > > > > Meanwhile, will be great if you can verify if it works for you and > > > > provide Tested-by tags. > > >

Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-06-01 Thread Leonard Lausen
Hi Abhinav, June 1, 2023 at 3:20 PM, "Abhinav Kumar" wrote: > > > > [drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-107) > > > > We are not able to recreate this on sc7280 chromebooks , will need to check > on sc7180. This does not seem directly related to any of the hotplug c

Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-05-24 Thread Leonard Lausen
>> [  275.025497] [drm:dpu_encoder_phys_vid_wait_for_commit_done:488] >> [dpu error]vblank timeout >> [  275.025514] [drm:dpu_kms_wait_for_commit_done:510] [dpu error]wait >> for commit done returned -110 >> [  275.064141] [drm:dpu_encoder_frame_done_timeout:2382] [dpu >> er

Re: [Freedreno] [PATCH v6] drm/msm/dp: enable HDP plugin/unplugged interrupts at hpd_enable/disable

2023-05-24 Thread Leonard Lausen
display_host_start() with dp_display_host_init() > > Changes in V6: > -- squash remove enable_irq() and disable_irq() > > Fixes: cd198caddea7 ("drm/msm/dp: Rely on hpd_enable/disable callbacks") > Signed-off-by: Kuogee Hsieh Cherry-picked on top of v6.3.3 and verified fixes the USB-C DP regression on sc7180 lazor. Thank you! Tested-by: Leonard Lausen # on sc7180 lazor

Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-05-22 Thread Leonard Lausen
Abhinav Kumar writes: There is no need to add the 100ms delay back yet. thanks for posting this but NAK on this patch till we post the fix this week. Appreciate a bit of patience till then. >>> >>> This regression is already part of the 6.3 stable release series. Will

Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-05-08 Thread Leonard Lausen
Abhinav Kumar writes: > On 5/7/2023 7:15 PM, Bjorn Andersson wrote: >> When booting with the cable connected on my X13s, 100 is long enough for >> my display to time out and require me to disconnect and reconnect the >> cable again. >> >> Do we have any idea of why the reduction to 0 is causing a

[Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-05-07 Thread Leonard Lausen
affected by the regression, as they do not rely on mdss and dp_hot_plug_det for hot plug detection. Signed-off-by: Leonard Lausen Tested-by: Leonard Lausen # Trogdor (sc7180) Suggested-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Freedreno] [PATCH v2] drm/msm/dpu: Add support for AR30 format

2023-03-22 Thread Leonard Lausen
V2 adds missing AR30 swizzles in dpu_format_map_ubwc to avoid the following errors: [drm:dpu_get_dpu_format_ext:1044] [dpu error]unsupported fmt: AR30 modifier 0x501 msm_dpu ae01000.display-controller: [drm:msm_framebuffer_init] *ERROR* unsupported pixel format: AR30

[Freedreno] [PATCH v2] drm/msm/dpu: Add support for AR30 format

2023-03-20 Thread Leonard Lausen
er bugs in userspace. KDE KWin compositor versions prior to 5.27.3 for example prefer 10-bit color formats, rendering a 1cm^2 black box around the cursor due to missing per-pixel alpha-blending. Signed-off-by: Leonard Lausen --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c| 11 +++ drivers/g

[Freedreno] [PATCH] drm/msm/dpu: Add support for AR30 format

2023-03-18 Thread Leonard Lausen
around the cursor due to missing per-pixel alpha-blending if only XR30 but not AR30 support is declared. Signed-off-by: Leonard Lausen --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/g