Re: [Freedreno] [PATCH] drm/probe_helper: sort out poll_running vs poll_enabled

2023-01-12 Thread Marek Szyprowski
gt; kthread+0xfc/0x110 > ret_from_fork+0x10/0x20 > ---[ end trace ]--- > > Reported-by: Laurentiu Palcu > Fixes: c8268795c9a9 ("drm/probe-helper: enable and disable HPD on connectors") > Signed-off-by: Dmitry Baryshkov Seems to be fixing the issue I

Re: [Freedreno] [v3, 3/7] drm/bridge_connector: rely on drm_kms_helper_poll_* for HPD enablement

2023-01-12 Thread Marek Szyprowski
Hi Neil, On 12.01.2023 10:35, Neil Armstrong wrote: > On 11/01/2023 13:41, Marek Szyprowski wrote: >> On 02.11.2022 19:07, Dmitry Baryshkov wrote: >>> Use drm_connector's helpers enable_hpd and disable_hpd to enable and >>> disable HPD automatically by t

Re: [Freedreno] [v3, 3/7] drm/bridge_connector: rely on drm_kms_helper_poll_* for HPD enablement

2023-01-11 Thread Marek Szyprowski
d(connector, &drm_bridge_connector_helper_funcs); > > - if (bridge_connector->bridge_hpd) { > + if (bridge_connector->bridge_hpd) > connector->polled = DRM_CONNECTOR_POLL_HPD; > - drm_bridge_connector_enable_hpd(connector); > - } > else if (bridge_connector->bridge_detect) > connector->polled = DRM_CONNECTOR_POLL_CONNECT > | DRM_CONNECTOR_POLL_DISCONNECT; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [Freedreno] [v6, 02/21] drm/bridge: adv7511: Register and attach our DSI device at probe

2021-10-29 Thread Marek Szyprowski
Hi Mexime, On 29.10.2021 10:05, Maxime Ripard wrote: > On Fri, Oct 29, 2021 at 08:23:45AM +0200, Marek Szyprowski wrote: >> On 25.10.2021 17:15, Maxime Ripard wrote: >>> In order to avoid any probe ordering issue, the best practice is to move >>> the secondary MIPI-

Re: [Freedreno] [v6, 02/21] drm/bridge: adv7511: Register and attach our DSI device at probe

2021-10-28 Thread Marek Szyprowski
rr_unregister_audio; > + } > + > return 0; > > +err_unregister_audio: > + adv7511_audio_exit(adv7511); > + drm_bridge_remove(&adv7511->bridge); > err_unregister_cec: > i2c_unregister_device(adv7511->i2c_cec); > clk_disable_unprepare(adv7511->cec_clk); Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

Re: [Freedreno] [PATCH v4 24/24] drm/exynos: dsi: Adjust probe order

2021-09-23 Thread Marek Szyprowski
Hi Maxime, On 22.09.2021 10:53, Maxime Ripard wrote: > On Fri, Sep 17, 2021 at 02:35:05PM +0200, Marek Szyprowski wrote: >> On 13.09.2021 12:30, Andrzej Hajda wrote: >>> W dniu 10.09.2021 o 12:12, Maxime Ripard pisze: >>>> Without proper care and an agreement bet

Re: [Freedreno] [PATCH v4 24/24] drm/exynos: dsi: Adjust probe order

2021-09-17 Thread Marek Szyprowski
but it adds/removes panel/bridge > dynamically, so it creates drm_device without waiting for downstream sink. Right, this patch breaks Exynos DSI driver operation. Without it, the whole series works fine on all Exynos based test boards. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland

[Freedreno] [PATCH v10 12/30] drm: msm: fix common struct sg_table related issues

2020-09-04 Thread Marek Szyprowski
common dma-mapping wrappers operating directly on the struct sg_table objects and use scatterlist page iterators where possible. This, almost always, hides references to the nents and orig_nents entries, making the code robust, easier to follow and copy/paste safe. Signed-off-by: Marek Szyprowski

[Freedreno] [PATCH v9 12/32] drm: msm: fix common struct sg_table related issues

2020-08-25 Thread Marek Szyprowski
common dma-mapping wrappers operating directly on the struct sg_table objects and use scatterlist page iterators where possible. This, almost always, hides references to the nents and orig_nents entries, making the code robust, easier to follow and copy/paste safe. Signed-off-by: Marek Szyprowski

[Freedreno] [PATCH v7 13/36] drm: msm: fix common struct sg_table related issues

2020-06-19 Thread Marek Szyprowski
common dma-mapping wrappers operating directly on the struct sg_table objects and use scatterlist page iterators where possible. This, almost always, hides references to the nents and orig_nents entries, making the code robust, easier to follow and copy/paste safe. Signed-off-by: Marek Szyprowski

[Freedreno] [PATCH v6 13/36] drm: msm: fix common struct sg_table related issues

2020-06-18 Thread Marek Szyprowski
common dma-mapping wrappers operating directly on the struct sg_table objects and use scatterlist page iterators where possible. This, almost always, hides references to the nents and orig_nents entries, making the code robust, easier to follow and copy/paste safe. Signed-off-by: Marek Szyprowski

[Freedreno] [PATCH v5 16/38] drm: msm: fix common struct sg_table related issues

2020-05-13 Thread Marek Szyprowski
common dma-mapping wrappers operating directly on the struct sg_table objects and use scatterlist page iterators where possible. This, almost always, hides references to the nents and orig_nents entries, making the code robust, easier to follow and copy/paste safe. Signed-off-by: Marek Szyprowski

[Freedreno] [PATCH v4 16/38] drm: msm: fix common struct sg_table related issues

2020-05-12 Thread Marek Szyprowski
common dma-mapping wrappers operating directly on the struct sg_table objects and use scatterlist page iterators where possible. This, almost always, hides references to the nents and orig_nents entries, making the code robust, easier to follow and copy/paste safe. Signed-off-by: Marek Szyprowski

[Freedreno] [PATCH v3 09/25] drm: msm: fix common struct sg_table related issues

2020-05-05 Thread Marek Szyprowski
the struct sg_table objects and adjust references to the nents and orig_nents respectively. Signed-off-by: Marek Szyprowski --- For more information, see '[PATCH v3 00/25] DRM: fix struct sg_table nents vs. orig_nents misuse' thread: https://lkml.org/lkml/2020/5/5/187 --- drivers/

[Freedreno] [PATCH v2 08/21] drm: msm: fix sg_table nents vs. orig_nents misuse

2020-05-04 Thread Marek Szyprowski
nts in turn holds the result of the dma_map_sg call as stated in include/linux/scatterlist.h. Adapt the code to obey those rules. Signed-off-by: Marek Szyprowski --- For more information, see '[PATCH v2 00/21] DRM: fix struct sg_table nents vs. orig_nents misuse' thread: https://lkml.org/

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2019-06-05 Thread Marek Szyprowski
7251/ https://patchwork.kernel.org/patch/4677941/ https://patchwork.kernel.org/patch/4677401/ It looks that my idea was a bit ahead of its time ;) Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland ___ Freedreno mailin

Re: [Freedreno] [PATCH] of/device: add blacklist for iommu dma_ops

2018-12-03 Thread Marek Szyprowski
of_dma_configure(struct device *dev, struct >> device_node *np, bool force_dma) >> dev_dbg(dev, "device is%sbehind an iommu\n", >> iommu ? " " : " not "); >> >> + /* >> +* There is at least one case w

Re: [Freedreno] [PATCH v12 1/4] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-07-22 Thread Marek Szyprowski
Hi Rafael, On 2018-07-11 22:36, Rafael J. Wysocki wrote: > On Wed, Jul 11, 2018 at 3:40 PM, Marek Szyprowski > wrote: >> Hi Tomasz, >> >> On 2018-07-11 14:51, Tomasz Figa wrote: >>> On Wed, Jul 11, 2018 at 8:11 PM Rafael J. Wysocki wrote: >>>> O

Re: [Freedreno] [PATCH v12 1/4] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-07-11 Thread Marek Szyprowski
resume) >>>> This is suspicious. >>>> >>>> If you need a runtime suspend method, why do you think that it is not >>>> necessary >>>> to suspend the device during system-wide transitions? >>> Okay, so you suggest to put clock disabl