Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm

2024-05-08 Thread Masahiro Yamada
the problem for me since I > ran into it too [1]. > > Tested-by: Douglas Anderson > > [1] > https://lore.kernel.org/r/CAD=FV=XnpS-=cookkxzfm8og9wcsemxfesmftyh811438qg...@mail.gmail.com > I do not like Perl. IMHO, Python should be OK if Perl is OK. I agree that the required version should be documented changes.rst, at least. -- Best Regards Masahiro Yamada

Re: [PATCH RFC 01/12] kbuild: create destination directory for _shipped handling

2024-02-27 Thread Masahiro Yamada
On Mon, Feb 26, 2024 at 8:01 PM Dmitry Baryshkov wrote: > > On Mon, 26 Feb 2024 at 08:33, Masahiro Yamada wrote: > > > > On Mon, Feb 26, 2024 at 11:11 AM Dmitry Baryshkov > > wrote: > > > > > > The driver might decide to put the _shipped files to th

Re: [PATCH RFC 00/12] drm/msm: add support for regenerating shipped xml.h headers

2024-02-26 Thread Masahiro Yamada
o_gpu.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h @@ -12,7 +12,7 @@ #include #include -#include "msm_gpu.h" +#include "../msm_gpu.h" #include "adreno_common.xml.h" #include "adreno_pm4.xml.h" -- Best Regards Masahiro Yamada

Re: [PATCH RFC 05/12] drm/msm: use _shipped suffix for all xml.h files

2024-02-26 Thread Masahiro Yamada
@@ > # SPDX-License-Identifier: GPL-2.0 > ccflags-y := -I $(srctree)/$(src) > +ccflags-y := -I $(obj)/registers This accidentally overwrites ccflags-y defined above. So, "-I $(srctree)/$(src)" is lost. It should be ccflags-y += -I $(obj)/registers I see several build errors. -- Best Regards Masahiro Yamada

Re: [PATCH RFC 01/12] kbuild: create destination directory for _shipped handling

2024-02-25 Thread Masahiro Yamada
e. Use 'cat' instead in order to generate a writable file. > quiet_cmd_copy = COPY$@ > - cmd_copy = cat $< > $@ > + cmd_copy = mkdir -p $(shell dirname $@) && cat $< > $@ > > $(obj)/%: $(src)/%_shipped > $(call cmd,copy) > > -- > 2.39.2 > -- Best Regards Masahiro Yamada

Re: [PATCH RFC 00/12] drm/msm: add support for regenerating shipped xml.h headers

2024-02-25 Thread Masahiro Yamada
l.h_shipped}| 37 +- > .../mdp5.xml.h => registers/mdp5.xml.h_shipped}| 39 +- > .../gpu/drm/msm/registers/mdp_common.xml.h_shipped | 114 ++ > drivers/gpu/drm/msm/registers/sfpb.xml.h_shipped | 67 + > drivers/gpu/drm/msm/registers/xml/dsi.xml | 390 ++ > drivers/gpu/drm/msm/registers/xml/dsi_phy_10nm.xml | 102 ++ > drivers/gpu/drm/msm/registers/xml/dsi_phy_14nm.xml | 135 ++ > drivers/gpu/drm/msm/registers/xml/dsi_phy_20nm.xml | 100 ++ > drivers/gpu/drm/msm/registers/xml/dsi_phy_28nm.xml | 180 +++ > .../drm/msm/registers/xml/dsi_phy_28nm_8960.xml| 134 ++ > drivers/gpu/drm/msm/registers/xml/dsi_phy_7nm.xml | 230 > drivers/gpu/drm/msm/registers/xml/edp.xml | 239 > .../drm/msm/registers/xml/freedreno_copyright.xml | 40 + > drivers/gpu/drm/msm/registers/xml/hdmi.xml | 1015 +++ > drivers/gpu/drm/msm/registers/xml/mdp4.xml | 480 +++ > drivers/gpu/drm/msm/registers/xml/mdp5.xml | 806 > drivers/gpu/drm/msm/registers/xml/mdp_common.xml | 89 ++ > drivers/gpu/drm/msm/registers/xml/mmss_cc.xml | 48 + > drivers/gpu/drm/msm/registers/xml/msm.xml | 32 + > drivers/gpu/drm/msm/registers/xml/rules-ng.xsd | 457 +++ > drivers/gpu/drm/msm/registers/xml/sfpb.xml | 17 + > scripts/Makefile.lib |2 +- > 47 files changed, 8034 insertions(+), 587 deletions(-) > --- > base-commit: ffa0c87f172bf7a0132aa960db412f8d63b2f533 > change-id: 20240225-fd-xml-shipped-ba9a321cdedf > > Best regards, > -- > Dmitry Baryshkov > -- Best Regards Masahiro Yamada

Re: [Freedreno] [PATCH v2] drm: prefix header search paths with $(srctree)/

2019-04-25 Thread Masahiro Yamada
Hi. On Fri, Mar 29, 2019 at 8:37 PM Masahiro Yamada wrote: > > Currently, the Kbuild core manipulates header search paths in a crazy > way [1]. > > To fix this mess, I want all Makefiles to add explicit $(srctree)/ to > the search paths in the srctree. Some Makefiles are

[Freedreno] [PATCH v2] drm: prefix header search paths with $(srctree)/

2019-03-29 Thread Masahiro Yamada
consistent, and finally get rid of the gross hacks. Having whitespaces after -I does not matter since commit 48f6e3cf5bc6 ("kbuild: do not drop -I without parameter"). [1]: https://patchwork.kernel.org/patch/9632347/ Signed-off-by: Masahiro Yamada Reviewed-by: Sam Ravnborg --- I put a

Re: [Freedreno] [PATCH] drm: prefix header search paths with $(srctree)/

2019-02-17 Thread Masahiro Yamada
On Thu, Jan 31, 2019 at 1:01 PM Masahiro Yamada wrote: > > Currently, the Kbuild core manipulates header search paths in a crazy > way [1]. > > To fix this mess, I want all Makefiles to add explicit $(srctree)/ to > the search paths in the srctree. Some Makefiles are already wri

[Freedreno] [PATCH] drm: prefix header search paths with $(srctree)/

2019-01-30 Thread Masahiro Yamada
consistent, and finally get rid of the gross hacks. Having whitespaces after -I does not matter since commit 48f6e3cf5bc6 ("kbuild: do not drop -I without parameter"). [1]: https://patchwork.kernel.org/patch/9632347/ Signed-off-by: Masahiro Yamada --- I put all gpu/drm changes into a si

[Freedreno] [PATCH] drm: remove NULL pointer check for clk_disable_unprepare

2017-05-20 Thread Masahiro Yamada
After long term efforts of fixing non-common clock implementations, clk_disable() is a no-op for a NULL pointer input, and this is now tree-wide consistent. All clock consumers can safely call clk_disable(_unprepare) without NULL pointer check. Signed-off-by: Masahiro Yamada --- drivers/gpu

Re: [Freedreno] [PATCH] drm: remove NULL pointer check for clk_disable_unprepare

2017-05-20 Thread Masahiro Yamada
2017-05-21 2:58 GMT+09:00 Masahiro Yamada : > After long term efforts of fixing non-common clock implementations, > clk_disable() is a no-op for a NULL pointer input, and this is now > tree-wide consistent. > > All clock consumers can safely call clk_disable(_unprepare) without