Re: [Freedreno] [DPU PATCH v2 2/2] drm/msm/dsi: implement auto PHY timing calculator for 10nm PHY

re currently hardcoded > - * for a 1440x2560@60Hz panel with a byteclk of 100.618 Mhz, and a > - * default escape clock of 19.2 Mhz. > - */ > - > - timing->hs_halfbyte_en = 0; > - timing->clk_zero = 0x1c; > - timing->clk_p

Re: [Freedreno] [DPU PATCH v2 1/2] drm/msm/dsi: check video mode engine status before waiting

ost->enabled = false; This should go at the start of the function. Also, it's unclear from this patch, but I assume this is protected by a lock? Sean > return 0; > } > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundati

Re: [Freedreno] [DPU PATCH 2/2] drm/msm/dsi: Use one connector for dual DSI mode

al_dsi && (DSI_1 == id)) > + if (is_dual_dsi && (!IS_MASTER_DSI_LINK(id))) > return; > > msm_dsi_host_set_display_mode(host, adjusted_mode); > @@ -704,6 +627,23 @@ struct drm_connector *msm_dsi_manager_connector_init(u8 > i

Re: [Freedreno] [DPU PATCH 1/2] drm/msm/dsi: adjust dsi timing for dual dsi mode

host timing structures accordingly. > + */ > + if (is_dual_dsi) { > + msm_dsi_host_adjust_timing_config(host); > + if (other_dsi) > + msm_dsi_host_adjust_timing_config(other_dsi->host); > + } > + > } > &

Re: [Freedreno] [[RFC]DPU PATCH 1/2] drm/bridge: add support for sn65dsi86 bridge driver

(struct i2c_client *client, > + const struct i2c_device_id *id) > +{ > + struct sn65dsi86 *pdata; > + int ret = 0; > + struct drm_display_mode *mode, *n; > + > + if (!client || !client->dev.of_node) { > + pr_err("invalid input\n"); > + return -EINVAL; > + } > + > + if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { > + pr_err("device doesn't support I2C\n"); > + return -ENODEV; > + } > + > + pdata = devm_kzalloc(&client->dev, > + sizeof(struct sn65dsi86), GFP_KERNEL); > + if (!pdata) > + return -ENOMEM; > + > + pdata->power_on = false; > + pdata->is_pluggable = false; > + pdata->connector_status = connector_status_disconnected; > + pdata->dev = &client->dev; > + pdata->i2c_client = client; > + pr_debug("I2C address is %x\n", client->addr); > + > + ret = sn65dsi86_parse_dt(&client->dev, pdata); > + if (ret) { > + pr_err("failed to parse device tree\n"); > + goto err_dt_parse; > + } > + > + sn65dsi86_gpio_configure(pdata, true); > + > + ret = sn65dsi86_init_regulators(pdata); > + if (ret) { > + pr_err("failed to enable regulators\n"); > + goto err_gpio_config; > + } > + > + ret = sn65dsi86_read_device_rev(pdata); > + if (ret) { > + pr_err("failed to read chip rev\n"); > + goto err_gpio_config; > + } else { > + pr_debug("bridge chip enabled successfully\n"); > + pdata->power_on = true; > + } > + > + pdata->irq = gpiod_to_irq(pdata->gpios.irq_gpio); > + ret = request_threaded_irq(pdata->irq, NULL, > + sn65dsi86_irq_thread_handler, > + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, > + "sn65dsi86", pdata); > + > + i2c_set_clientdata(client, pdata); > + dev_set_drvdata(&client->dev, pdata); > + > + pdata->bridge.funcs = &sn65dsi86_bridge_funcs; > + pdata->bridge.of_node = client->dev.of_node; > + > + drm_bridge_add(&pdata->bridge); > + > + return ret; > + > +err_gpio_config: > + sn65dsi86_gpio_configure(pdata, false); > +err_dt_parse: > + if (!pdata->is_pluggable) { > + list_for_each_entry_safe(mode, n, &pdata->mode_list, head) { > + list_del(&mode->head); > + kfree(mode); > + } > + pdata->num_of_modes = 0; > + } > + devm_kfree(&client->dev, pdata); > + return ret; > +} > + > +static int sn65dsi86_remove(struct i2c_client *client) > +{ > + int ret = -EINVAL; > + struct sn65dsi86 *pdata = i2c_get_clientdata(client); > + struct drm_display_mode *mode, *n; > + > + if (!pdata) > + goto end; > + > + mipi_dsi_detach(pdata->dsi); > + mipi_dsi_device_unregister(pdata->dsi); > + > + drm_bridge_remove(&pdata->bridge); > + > + disable_irq(pdata->irq); > + free_irq(pdata->irq, pdata); > + > + sn65dsi86_gpio_configure(pdata, false); > + > + if (!pdata->is_pluggable) { > + list_for_each_entry_safe(mode, n, &pdata->mode_list, head) { > + list_del(&mode->head); > + kfree(mode); > + } > + } > + > + devm_kfree(&client->dev, pdata); > + > +end: > + return ret; > +} > + > +static struct i2c_device_id sn65dsi86_id[] = { > + { "ti,sn65dsi86", 0}, > + {} > +}; > +MODULE_DEVICE_TABLE(i2c, sn65dsi86_id); > + > +static const struct of_device_id sn65dsi86_match_table[] = { > + {.compatible = "ti,sn65dsi86"}, > + {} > +}; > +MODULE_DEVICE_TABLE(of, sn65dsi86_match_table); > + > +static struct i2c_driver sn65dsi86_driver = { > + .driver = { > + .name = "sn65dsi86", > + .owner = THIS_MODULE, > + .of_match_table = sn65dsi86_match_table, > + }, > + .probe = sn65dsi86_probe, > + .remove = sn65dsi86_remove, > + .id_table = sn65dsi86_id, > +}; > + > +module_i2c_driver(sn65dsi86_driver); > +MODULE_DESCRIPTION("SN65DSI86 DSI to eDP bridge driver"); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [[RFC]DPU PATCH 2/2] dt-bindings: drm/bridge: Document sn65dsi86 bridge bindings

On Fri, Apr 13, 2018 at 1:23 AM Sandeep Panda wrote: > Document the bindings used for the sn65dsi86 DSI to eDP bridge. > Signed-off-by: Sandeep Panda > --- > .../bindings/display/bridge/ti,sn65dsi86.txt | 75 ++ > 1 file changed, 75 insertions(+) > create mode 100

Re: [Freedreno] [DPU PATCH v2 0/2] Remove DPU RSC support

m/dpu_rsc.c > delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_hw.c > delete mode 100644 drivers/gpu/drm/msm/dpu_rsc_priv.h > delete mode 100644 include/linux/dpu_rsc.h > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Founda

Re: [Freedreno] [DPU PATCH 0/3] drm/msm: Fix build warnings

On Tue, Apr 03, 2018 at 02:24:16PM +0530, rya...@codeaurora.org wrote: > On 2018-04-03 01:40, Sean Paul wrote: > > Finally got around to this, I've split the worst 2 out into their own > > patches. > > > > Sean > > > > Sean Paul (3): > >

Re: [Freedreno] [DPU PATCH 3/3] drm/msm/dsi-staging: Gate bus scale code

taging/dsi_phy.c > index c13e5bb..e712c61 100644 > --- a/drivers/gpu/drm/msm/dsi-staging/dsi_phy.c > +++ b/drivers/gpu/drm/msm/dsi-staging/dsi_phy.c > @@ -17,7 +17,9 @@ > #include > #include > #include > +#ifdef CONFIG_QCOM_BUS_SCALING > #include > +#endif > #include > > #include "msm_drv.h" > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH 2/3] drm/msm: Fix return type mismatch for dpu_kms_init

On Wed, Mar 28, 2018 at 11:48:13AM +0530, Rajesh Yadav wrote: > dpu_kms_init returns pointer to struct msm_kms but > incase of platform_get_irq() failure, int was returned. > Fix the return type to avoid compilation error. > > Signed-off-by: Rajesh Yadav Reviewe

Re: [Freedreno] [DPU PATCH 1/3] drm/msm: Remove unused variables

On Wed, Mar 28, 2018 at 11:47:46AM +0530, Rajesh Yadav wrote: > Fix compilation errors due to unused variables. > > Signed-off-by: Rajesh Yadav Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_enc

[Freedreno] [PATCH v4 5/9] drm/msm: Move implicit sync handling to prepare_fb

In preparation for moving to atomic helpers, move the implicit sync fence handling out of atomic commit and into the plane->prepare_fb() hook. While we're at it, de-duplicate the mdp*_prepare_fb functions. Changes in v4: - Added Reported-by: Rob Clark Signed-off-by: Sean Paul --- dri

[Freedreno] [PATCH v4 3/9] drm/msm: Don't subclass drm_atomic_state anymore

te itself using the private objects. Remove the infrastructure that allowed subclassing of drm_atomic_state in the driver. Changes in v3: - Added to the msm atomic helper patch set Changes in v4: - None Signed-off-by: Archit Taneja Signed-off-by: Rob Clark Signed-off-by: Sean Paul --- drivers/g

[Freedreno] [PATCH v4 0/9] drm/msm: Switch to atomic helpers

private_obj state drm/msm: Don't subclass drm_atomic_state anymore Sean Paul (6): drm/msm: Refactor complete_commit() to look more the helpers drm/msm: Move implicit sync handling to prepare_fb drm/msm: Mark the crtc->state->event consumed drm/msm: Issue queued events when disabling crt

[Freedreno] [PATCH v4 4/9] drm/msm: Refactor complete_commit() to look more the helpers

aneja Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_atomic.c b/drivers/gpu/drm/msm/msm_atomic.c index 9d0a0ca1f0cb..c18f0bee20d4 100644 --- a/drivers/gpu/dr

[Freedreno] [PATCH v4 8/9] drm/msm: Remove msm_commit/worker, use atomic helper commit

swap_state to avoid abandoned events on disable Changes in v3: - Rebased on Archit's private_obj set Changes in v4: - None Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 153 +-- drivers/gpu/drm/msm/msm_drv.c| 1 - drivers/gpu/drm/msm/msm_

[Freedreno] [PATCH v4 7/9] drm/msm: Issue queued events when disabling crtc

hit Taneja Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c index 76b96081916f..10271359789e 100644 --- a/drivers/gpu/drm/msm

[Freedreno] [PATCH v4 1/9] drm/msm/mdp5: Add global state as a private atomic object

later once we mdp5_global_state is put to use everywhere. Changes in v3: - Added glob_state_lock instead of pushing it into the core - Added to the msm atomic helper patch set Changes in v4: - None Signed-off-by: Archit Taneja Signed-off-by: Rob Clark Signed-off-by: Sean Paul --- drivers/gpu

[Freedreno] [PATCH v4 9/9] drm/msm: Switch to atomic_helper_commit()

Now that all of the msm-specific goo is tucked safely away we can switch over to using the atomic helper commit directly. \o/ Changes in v2: - None Changes in v3: - Rebased on Archit's private_obj set Changes in v4: - None Cc: Abhinav Kumar Signed-off-by: Sean Paul --- drivers/gpu/dr

[Freedreno] [PATCH v4 2/9] drm/msm/mdp5: Use the new private_obj state

in v4: - None Signed-off-by: Archit Taneja Signed-off-by: Rob Clark Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 10 -- drivers/gpu/drm/msm/disp/mdp5/mdp5_mixer.c | 12 ++-- drivers/gpu/drm/msm/disp/mdp5/mdp5_pipe.c | 20 +++- drivers/gpu/

[Freedreno] [PATCH v4 6/9] drm/msm: Mark the crtc->state->event consumed

Taneja Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 + drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c index 6e5e1aa54ce1..b001699297

[Freedreno] [DPU PATCH 3/3] drm/msm: Fix dpu build warnings

A bunch of warning fixes, build is clean now. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c | 7 --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_reg_dma_v1.c | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c

[Freedreno] [DPU PATCH 0/3] drm/msm: Fix build warnings

Finally got around to this, I've split the worst 2 out into their own patches. Sean Sean Paul (3): drm/msm: Fix uninitialized use of prefill_lines drm/msm: Properly cast return with ERR_PTR drm/msm: Fix dpu build warnings drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c

[Freedreno] [DPU PATCH 2/3] drm/msm: Properly cast return with ERR_PTR

Return value is an error pointer, not an int. Fixes: 758128c1eda4 drm/msm: Populate kms->irq for dpu Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/

[Freedreno] [DPU PATCH 1/3] drm/msm: Fix uninitialized use of prefill_lines

prefill_lines initialization was removed in da61c67cdec4, but it's still being used :( Fixes: da61c67cdec4 drm/msm: remove hw rotation support Cc: Jeykumar Sankaran Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[Freedreno] [PATCH v3 8/8] drm/msm: Switch to atomic_helper_commit()

Now that all of the msm-specific goo is tucked safely away we can switch over to using the atomic helper commit directly. \o/ Changes in v2: - None Changes in v3: - Rebased on Archit's private_obj set Cc: Abhinav Kumar Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c

[Freedreno] [PATCH v3 7/8] drm/msm: Remove msm_commit/worker, use atomic helper commit

swap_state to avoid abandoned events on disable Changes in v3: - Rebased on Archit's private_obj set Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 153 +-- drivers/gpu/drm/msm/msm_drv.c| 1 - drivers/gpu/drm/msm/msm_drv.h| 4 - 3

[Freedreno] [PATCH v3 5/8] drm/msm: Mark the crtc->state->event consumed

Don't leave the event != NULL once it's consumed, this is used a signal to the atomic helpers that the event will be handled by the driver. Changes in v2: - None Changes in v3: - Rebased on Archit's private_obj set Cc: Jeykumar Sankaran Reviewed-by: Archit Taneja Signed-of

[Freedreno] [PATCH v3 3/8] drm/msm: Don't subclass drm_atomic_state anymore

te itself using the private objects. Remove the infrastructure that allowed subclassing of drm_atomic_state in the driver. Changes in v3: - Added to the msm atomic helper patch set Signed-off-by: Archit Taneja Signed-off-by: Rob Clark Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/mdp5/

[Freedreno] [PATCH v3 6/8] drm/msm: Issue queued events when disabling crtc

tate->event = NULL; + spin_unlock_irqrestore(&mdp5_kms->dev->event_lock, flags); + } + mdp5_crtc->enabled = false; } -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

[Freedreno] [PATCH v3 4/8] drm/msm: Refactor complete_commit() to look more the helpers

Factor out the commit_tail() portions of complete_commit() into a separate function to facilitate moving to the atomic helpers in future patches. Changes in v2: - None Changes in v3: - Rebased on Archit's private_obj set Cc: Jeykumar Sankaran Reviewed-by: Archit Taneja Signed-off-by: Sean

[Freedreno] [PATCH v3 2/8] drm/msm/mdp5: Use the new private_obj state

y: Archit Taneja Signed-off-by: Rob Clark Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 10 -- drivers/gpu/drm/msm/disp/mdp5/mdp5_mixer.c | 12 ++-- drivers/gpu/drm/msm/disp/mdp5/mdp5_pipe.c | 20 +++- drivers/gpu/drm/msm

[Freedreno] [PATCH v3 1/8] drm/msm/mdp5: Add global state as a private atomic object

later once we mdp5_global_state is put to use everywhere. Changes in v3: - Added glob_state_lock instead of pushing it into the core - Added to the msm atomic helper patch set Signed-off-by: Archit Taneja Signed-off-by: Rob Clark Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/mdp5

[Freedreno] [PATCH v3 0/8] drm/msm: Switch to atomic helpers

/msm: Don't subclass drm_atomic_state anymore Sean Paul (5): drm/msm: Refactor complete_commit() to look more the helpers drm/msm: Mark the crtc->state->event consumed drm/msm: Issue queued events when disabling crtc drm/msm: Remove msm_commit/worker, use atomic hel

Re: [Freedreno] [DPU PATCH 1/2] dt-bindings: msm/disp: Remove hw block offset DT entries for SDM845

s before them, I'm happy to discuss, but otherwise > folks have more than enough to review just for upstream. The goal is to get this driver upstream, and these patches are working towards that goal. It's really helpful to get your feedback, and in general I think we should encourag

Re: [Freedreno] [DPU PATCH v2 1/2] dt-bindings: msm/disp: Remove hw block offset DT entries for SDM845

removed from the DT file and added in the driver source. > Reviewed-by: Sean Paul > Change-Id: I63a366d7d7a26939ee1c20c702c7d4d976852067 (btw, please strip these out when you send patches upstream. I will remove it when applying) > Signed-off-by: Sravanthi Kollukuduru > --- &g

[Freedreno] [PATCH v2 6/6] drm/msm: Switch to atomic_helper_commit()

Now that all of the msm-specific goo is tucked safely away we can switch over to using the atomic helper commit directly. \o/ Changes in v2: - None Cc: Abhinav Kumar Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 120 +-- drivers/gpu/drm/msm

[Freedreno] [PATCH v2 5/6] drm/msm: Remove msm_commit/worker, use atomic helper commit

swap_state to avoid abandoned events on disable Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 153 +-- drivers/gpu/drm/msm/msm_drv.c| 1 - drivers/gpu/drm/msm/msm_drv.h| 4 - 3 files changed, 42 insertions(+), 116 deletions(-) diff --git

[Freedreno] [PATCH v2 4/6] drm/msm: Issue queued events when disabling crtc

Ensure that any queued events are issued when disabling the crtc. This avoids timeouts when we come back and wait for dependencies (like the previous frame's flip_done). Changes in v2: - None Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 9 + 1 file ch

[Freedreno] [PATCH v2 3/6] drm/msm: Mark the crtc->state->event consumed

Don't leave the event != NULL once it's consumed, this is used a signal to the atomic helpers that the event will be handled by the driver. Changes in v2: - None Cc: Jeykumar Sankaran Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 + drivers/gpu/drm/msm

[Freedreno] [PATCH v2 2/6] drm/msm: Refactor complete_commit() to look more the helpers

Factor out the commit_tail() portions of complete_commit() into a separate function to facilitate moving to the atomic helpers in future patches. Changes in v2: - None Cc: Jeykumar Sankaran Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 25 - 1 file

[Freedreno] [PATCH v2 1/6] drm/msm: Use drm_private_obj/state instead of subclassing

n do whatever it wants - * with the ->state ptr. On ->atomic_state_clear() the ->state ptr - * is kfree'd and set back to NULL. + * with the ->state ptr. */ struct msm_kms_state { - struct drm_atomic_state base; +

[Freedreno] [PATCH v2 0/6] drm/msm: Switch to atomic helpers

it shares the same theme. It's technically v5, but I'll label it v2 with the rest of the set. PTAL, Sean Sean Paul (6): drm/msm: Use drm_private_obj/state instead of subclassing drm/msm: Refactor complete_commit() to look more the helpers drm/msm: Mark the crtc->state->event

[Freedreno] [PATCH 2/4] drm/msm: Mark the crtc->state->event consumed

Don't leave the event != NULL once it's consumed, this is used a signal to the atomic helpers that the event will be handled by the driver. Cc: Jeykumar Sankaran Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 + drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.

[Freedreno] [PATCH 0/4] drm/msm: Switch to atomic helpers

I originally sent these patches targetted against the msm dpu code, but I've rebased them on msm-next since they're _mostly_ the same. The set is based on 'drm/msm: Use drm_private_obj/state instead of subclassing' which I sent up earlier. The set has been tested on mdp5 db41

[Freedreno] [PATCH 3/4] drm/msm: Remove msm_commit/worker, use atomic helper commit

Moving further towards switching fully to the the atomic helpers, this patch removes the hand-rolled worker nonblock commit code and uses the atomic helpers commit_work model. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 145 +-- drivers/gpu/drm

[Freedreno] [PATCH 4/4] drm/msm: Switch to atomic_helper_commit()

Now that all of the msm-specific goo is tucked safely away we can switch over to using the atomic helper commit directly. \o/ Cc: Abhinav Kumar Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 120 +-- drivers/gpu/drm/msm/msm_drv.c| 7

[Freedreno] [PATCH 1/4] drm/msm: Refactor complete_commit() to look more the helpers

Factor out the commit_tail() portions of complete_commit() into a separate function to facilitate moving to the atomic helpers in future patches. Cc: Jeykumar Sankaran Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 23 ++- 1 file changed, 14 insertions

[Freedreno] [PATCH v4] drm/msm: Use drm_private_obj/state instead of subclassing

v3: - Update comment describing msm_kms_state (Jeykumar) Changes in v4: - Rebased on msm-next - Don't always use private state from atomic state (Archit) - Renamed some of the state accessors - Tested on mdp5 db410c Cc: Jeykumar Sankaran Cc: Archit Taneja Signed-off-by: Sean Paul --- dri

Re: [Freedreno] [DPU PATCH 2/2] drm/msm: Add hardware catalog file for SDM845

On Wed, Mar 21, 2018 at 04:05:31PM +0530, skoll...@codeaurora.org wrote: > On 2018-03-20 20:47, Sean Paul wrote: > > On Tue, Mar 20, 2018 at 07:13:38PM +0530, skoll...@codeaurora.org wrote: > > > On 2018-03-19 19:29, Sean Paul wrote: > > > > On Wed, Mar 14, 2018

Re: [Freedreno] [DPU PATCH 2/2] drm/msm: Add hardware catalog file for SDM845

On Tue, Mar 20, 2018 at 07:13:38PM +0530, skoll...@codeaurora.org wrote: > On 2018-03-19 19:29, Sean Paul wrote: > > On Wed, Mar 14, 2018 at 11:21:38AM +0530, Sravanthi Kollukuduru wrote: > > > This change adds the hardware catalog information in driver source > > > f

[Freedreno] [DPU PATCH v3] drm/msm: Use atomic private_obj instead of subclassing

v3: - Update comment describing msm_kms_state (Jeykumar) Cc: Jeykumar Sankaran Reviewed-by: Jeykumar Sankaran Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 37 ++ drivers/gpu/drm/msm/msm_atomic.c | 30 --- drivers/gpu/drm/msm/msm_dr

[Freedreno] [DPU PATCH v2] drm/msm: Use atomic private_obj instead of subclassing

mar Sankaran Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 37 ++ drivers/gpu/drm/msm/msm_atomic.c | 30 --- drivers/gpu/drm/msm/msm_drv.c| 65 ++-- drivers/gpu/drm/msm/msm_drv.h| 4 +- drivers/gpu/drm/

Re: [Freedreno] [DPU PATCH 06/11] drm/msm: Remove msm_commit/kthread, use atomic helper commit

On Mon, Mar 12, 2018 at 04:23:10PM -0400, Sean Paul wrote: > On Thu, Mar 08, 2018 at 05:08:03PM -0800, Jeykumar Sankaran wrote: > > On 2018-03-02 06:56, Sean Paul wrote: > > > On Thu, Mar 01, 2018 at 07:37:10PM -0500, Rob Clark wrote: > > > > On Thu, Mar 1, 2018 at

Re: [Freedreno] [DPU PATCH 2/2] drm/msm: Add hardware catalog file for SDM845

mat_list = plane_formats_yuv, > + .virt_format_list = plane_formats, > + }; Instead of locating all of these parameters in one file, these should be located in their respective driver file. It also seems like you could separate

[Freedreno] [DPU PATCH v2] drm/msm: Don't duplicate modeset_enables atomic helper

Instead, shuffle things around so we kickoff crtc after enabling encoder during modesets. Also moves the vblank wait to after the frame. Changes in v2: - Remove the encoder.commit hack, it's not required (Jeykumar) Cc: Jeykumar Sankaran Signed-off-by: Sean Paul --- drivers/gpu/drm/msm

Re: [Freedreno] [DPU PATCH 02/11] drm/msm: Don't duplicate modeset_enables atomic helper

On Tue, Mar 13, 2018 at 04:57:35PM -0700, Jeykumar Sankaran wrote: > On 2018-03-12 13:21, Sean Paul wrote: > > On Thu, Mar 08, 2018 at 04:56:01PM -0800, Jeykumar Sankaran wrote: > > > On 2018-02-28 11:18, Sean Paul wrote: > > > > Instead, shuffle things around so

[Freedreno] [DPU PATCH] drm/msm: Add pm_runtime_get/put calls to dpu

Ensure that pm_runtime is properly referenced/unreferenced when we need it. Signed-off-by: Sean Paul --- Didn't get a response to my suggestion, so wrote the patch anyways. Thoughts? drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 ++ dr

Re: [Freedreno] [DPU PATCH 10/11] drm/msm: Switch to atomic_helper_commit()

On Thu, Mar 08, 2018 at 07:28:08PM -0800, abhin...@codeaurora.org wrote: > On 2018-02-28 11:19, Sean Paul wrote: > > Now that all of the msm-specific goo is tucked safely away we can switch > > over to using the atomic helper commit directly. \o/ > > > [Abhinav] Can we

Re: [Freedreno] [DPU PATCH 08/11] drm/msm: Remove hand-rolled out fences

On Fri, Mar 02, 2018 at 04:44:55PM -0800, Jeykumar Sankaran wrote: > On 2018-02-28 11:19, Sean Paul wrote: > > Remove release/output/retire fences from the dpu driver. These are > > already available via drm core's OUT_FENCE property. > > > > Change-Id: Id4238d0b

Re: [Freedreno] [DPU PATCH 07/11] drm/msm: Use atomic private_obj instead of subclassing

On Thu, Mar 08, 2018 at 05:59:11PM -0800, Jeykumar Sankaran wrote: > On 2018-02-28 11:19, Sean Paul wrote: > > Instead of subclassing atomic state, store driver private data in > > private_obj/state. This allows us to remove the swap_state driver hook > > for mdp5 and ge

Re: [Freedreno] [DPU PATCH 06/11] drm/msm: Remove msm_commit/kthread, use atomic helper commit

On Thu, Mar 08, 2018 at 05:08:03PM -0800, Jeykumar Sankaran wrote: > On 2018-03-02 06:56, Sean Paul wrote: > > On Thu, Mar 01, 2018 at 07:37:10PM -0500, Rob Clark wrote: > > > On Thu, Mar 1, 2018 at 3:37 PM, wrote: > > > > On 2018-03-01 07:27, Sean Paul wrote: &g

Re: [Freedreno] [DPU PATCH 02/11] drm/msm: Don't duplicate modeset_enables atomic helper

On Thu, Mar 08, 2018 at 04:56:01PM -0800, Jeykumar Sankaran wrote: > On 2018-02-28 11:18, Sean Paul wrote: > > Instead, shuffle things around so we kickoff crtc after enabling encoder > > during modesets. Also moves the vblank wait to after the frame. >

Re: [Freedreno] [DPU PATCH 01/11] drm/msm: Skip seamless disables in crtc/encoder

On Fri, Mar 02, 2018 at 04:04:24PM -0800, jsa...@codeaurora.org wrote: > On 2018-02-28 11:18, Sean Paul wrote: > > Instead of duplicating whole swaths of atomic helper functions (which > > are already out-of-date), just skip the encoder/crtc disables in the > > .disable hook

Re: [Freedreno] [DPU PATCH] msm/hdcp: Remove redundant stubs/CONFIG

On Tue, Feb 27, 2018 at 11:24:31AM -0500, Sean Paul wrote: > On Mon, Feb 26, 2018 at 03:01:14PM -0800, abhin...@codeaurora.org wrote: > > The change itself is okay. So, Reviewed-by? Sean > > However I am planning to do a bigger cleanup here > > ( removing the entire hdmi_

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

On Mon, Feb 26, 2018 at 02:23:40PM -0800, abhin...@codeaurora.org wrote: > On 2018-02-26 07:36, Sean Paul wrote: > > On Fri, Feb 23, 2018 at 05:48:48PM -0500, Rob Clark wrote: > > > On Fri, Feb 23, 2018 at 5:31 PM, wrote: > > > > The bitmaps in drm_hdmi_info dont s

Re: [Freedreno] [PATCH RESEND 08/10] drm/msm: Sprinkle pm_runtime calls around

On Thu, Mar 08, 2018 at 04:14:38PM -0800, Jeykumar Sankaran wrote: > On 2018-02-21 07:18, Sean Paul wrote: > > Adding missing pm_runtime references where appropriate. > > > > Signed-off-by: Sean Paul > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3

Re: [Freedreno] [DPU PATCH v3 2/2] drm/msm: remove partial update support

On Thu, Mar 01, 2018 at 04:52:35PM -0800, Jeykumar Sankaran wrote: > Implementation of partial update in DPU DRM is heavily > dependent on custom properties and dsi hooks. Removing the > support for now. We may need to revisit the support in the > future. > > changes since v1: > - get away w

Re: [Freedreno] [DPU PATCH 06/11] drm/msm: Remove msm_commit/kthread, use atomic helper commit

On Thu, Mar 01, 2018 at 07:37:10PM -0500, Rob Clark wrote: > On Thu, Mar 1, 2018 at 3:37 PM, wrote: > > On 2018-03-01 07:27, Sean Paul wrote: > >> > >> On Wed, Feb 28, 2018 at 08:07:00PM -0800, jsa...@codeaurora.org wrote: > >>> > >>> On 2018-0

Re: [Freedreno] [[RFC]DPU PATCH] drm/msm/dsi: Use one connector for dual DSI mode

it is > + * DSI 1 in case of dual DSI. I think the other dual-dsi implementations take the master/slave cues from device tree as opposed to hard-coding one or the other (I know of at least one case where DSI_1 was connected to the panel's first channel, whereas DSI_0 was connected to the second channel. Sean > + */ > + if (is_dual_dsi && (DSI_1 == id)) { > + DBG("Skip DSI_1 bridge registration for dual DSI.\n"); > + return false; > + } > + return true; > +} > + > /* initialize bridge */ > struct drm_bridge *msm_dsi_manager_bridge_init(u8 id) > { > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH v2 1/2] drm/msm/dsi-staging: remove support for partial update

what you've changed since the last version? This is super helpful for reviewers. > Change-Id: I02462f520cdf99c8445b18e60212ca46155f9710 I forgot this during my last patchset too, but please try to strip the Change-Id tag. With the commit message changes, Reviewed-by: Sean Paul > Si

Re: [Freedreno] [DPU PATCH v2 2/2] drm/msm: remove partial update support

411,6 @@ struct msm_display_info { > > bool is_primary; > bool is_te_using_watchdog_timer; > - struct msm_roi_caps roi_caps; > -}; > - > -#define MSM_MAX_ROI 4 > - > -/** > - * struct msm_roi_list - list of regions of interest for a drm object > - * @num_rects: number of valid rectangles in the roi array > - * @roi: list of roi rectangles > - */ > -struct msm_roi_list { > - uint32_t num_rects; > - struct drm_clip_rect roi[MSM_MAX_ROI]; > -}; > - > -/** > - * struct - msm_display_kickoff_params - info for display features at kickoff > - * @rois: Regions of interest structure for mapping CRTC to Connector output > - */ > -struct msm_display_kickoff_params { > - struct msm_roi_list *rois; > }; > > /** > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Sean Paul, Software Engineer, Google / Chromium OS ___ Freedreno mailing list Freedreno@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/freedreno

Re: [Freedreno] [DPU PATCH 06/11] drm/msm: Remove msm_commit/kthread, use atomic helper commit

On Wed, Feb 28, 2018 at 08:07:00PM -0800, jsa...@codeaurora.org wrote: > On 2018-02-28 11:19, Sean Paul wrote: > > Moving further towards switching fully to the the atomic helpers, this > > patch removes the hand-rolled kthread nonblock commit code and uses the > > atomic help

[Freedreno] [DPU PATCH 11/11] drm/msm: Remove dpu input fences

These are already provided by drm atomic core. In conjunction with the output fences removed earlier, this obsoletes dpu_fence, and it can be entirely removed as well. Change-Id: Ida4924a09c455d7a84bfee569bd0d2fb436418de Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/Makefile

[Freedreno] [DPU PATCH 09/11] drm/msm: Remove prepare_fence kms_function

This is the last piece that is keeping us from matching the atomic helper commit function. By removing this (now unused) hook, we can switch to drm_atomic_helper_commit() Change-Id: I081056a6e1689807871f5deedc76499bb91b6969 Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 10

[Freedreno] [DPU PATCH 02/11] drm/msm: Don't duplicate modeset_enables atomic helper

Instead, shuffle things around so we kickoff crtc after enabling encoder during modesets. Also moves the vblank wait to after the frame. Change-Id: I16c7b7f9390d04f6050aa20e17a5335fbf49eba3 Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 9 ++ drivers/gpu/drm/msm

[Freedreno] [DPU PATCH 07/11] drm/msm: Use atomic private_obj instead of subclassing

Instead of subclassing atomic state, store driver private data in private_obj/state. This allows us to remove the swap_state driver hook for mdp5 and get closer to using the atomic helpers entirely. Change-Id: I65a4a2887593ae257d584e00b352b5daf00e4e61 Signed-off-by: Sean Paul --- drivers/gpu

[Freedreno] [DPU PATCH 04/11] drm/msm: Move implicit sync fence handling to prepare_fb

This is another piece that can be moved out of atomic to facilitate using the atomic helpers. Change-Id: I6dc3c4e5df508942bbc378c73a44e46e511b8469 Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 8 drivers/gpu/drm/msm/msm_atomic.c | 13

[Freedreno] [DPU PATCH 05/11] drm/msm: Mark the crtc->state->event consumed

Don't leave the event != NULL once it's consumed, this is used a signal to the atomic helpers that the event will be handled by the driver. Change-Id: Ib934fb2e97bacbb4a1f9c780cc7369c2bb98ed50 Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++ drivers/g

[Freedreno] [DPU PATCH 00/11] drm/msm: Use atomic helper functions for msm

lper_commit patches, but I haven't tried to do that atm. I think I'll tackle the build warnings next, to ensure I'm not introducing more. Sean Sean Paul (11): drm/msm: Skip seamless disables in crtc/encoder drm/msm: Don't duplicate modeset_enables atomic helper drm/msm

[Freedreno] [DPU PATCH 06/11] drm/msm: Remove msm_commit/kthread, use atomic helper commit

ce private functions. These will be sorted out in a follow-on patch. Change-Id: I9fcba27824ba63d3fab96cb2bc194bfa6f3475b7 Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 199 ++- drivers/gpu/drm/msm/msm_drv.c| 1 - drivers/gpu/drm/msm/msm_drv.h

[Freedreno] [DPU PATCH 10/11] drm/msm: Switch to atomic_helper_commit()

Now that all of the msm-specific goo is tucked safely away we can switch over to using the atomic helper commit directly. \o/ Change-Id: Ieab0bd0c526b2a9d3b3345eeba402ac4857fe418 Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 120 +-- drivers/gpu/drm

[Freedreno] [DPU PATCH 01/11] drm/msm: Skip seamless disables in crtc/encoder

Instead of duplicating whole swaths of atomic helper functions (which are already out-of-date), just skip the encoder/crtc disables in the .disable hooks. Change-Id: I7bd9183ae60624204fb1de9550656b776efc7202 Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 8

[Freedreno] [DPU PATCH 08/11] drm/msm: Remove hand-rolled out fences

Remove release/output/retire fences from the dpu driver. These are already available via drm core's OUT_FENCE property. Change-Id: Id4238d0b5457f2c8ee2e87bb7814e1850a573623 Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_connector.c | 66 +-- drivers/gpu/drm/msm/disp

[Freedreno] [DPU PATCH 03/11] drm/msm: Refactor complete_commit() to look more the helpers

Factor out the commit_tail() portions of complete_commit() into a separate function to facilitate moving to the atomic helpers in future patches. Change-Id: I4b858ad9fe356b31ed0ed9eecdb394a61048e39c Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 25 - 1

Re: [Freedreno] [DPU PATCH] msm/hdcp: Remove redundant stubs/CONFIG

> > Abhinav > On 2018-02-26 12:48, Sean Paul wrote: > > We already have CONFIG_DRM_MSM_HDMI_HDCP, with accompanying stubs in > > hdmi/hdmi.h. > > > > Signed-off-by: Sean Paul > > --- > > drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c | 24 -

[Freedreno] [DPU PATCH] msm/hdcp: Remove redundant stubs/CONFIG

We already have CONFIG_DRM_MSM_HDMI_HDCP, with accompanying stubs in hdmi/hdmi.h. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_hdcp.c b/drivers/gpu/drm/msm/hdmi

[Freedreno] [DPU PATCH] drm: Remove unused drm_connector fields.

They're not used, so let's get rid of them. Signed-off-by: Sean Paul --- include/drm/drm_connector.h | 19 --- 1 file changed, 19 deletions(-) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 9d9d5405ebfd..ed38df4ac204 100644 --- a/i

Re: [Freedreno] [RFC 4/4] drm/msm/mdp5: writeback support

On Fri, Feb 23, 2018 at 01:15:54PM -0500, Rob Clark wrote: > On Fri, Feb 23, 2018 at 11:30 AM, Sean Paul wrote: > > On Fri, Feb 23, 2018 at 08:17:54AM -0500, Rob Clark wrote: > >> In a way, based on the original writeback patch from Jilai Wang, but a > >> lot ha

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

plementary data seems appropriate. We have some space left in modeinfo->flags, but that doesn't scale so well. Adding a property would be easiest since we could just expose the bitmap to userspace (more or less). We could also change "pad" in drm_mode_get_connector to flags and

Re: [Freedreno] [DPU PATCH 2/2] drm/msm: remove partial update support

On Thu, Feb 22, 2018 at 06:32:05PM -0800, Jeykumar Sankaran wrote: > Implementation of partial update in DPU DRM is heavily > dependent on custom properties and dsi hooks. Removing the > support for now. We may need to revisit the support in the > future. > > Change-Id: Idd87272fe4d4c0a26fcb405154

Re: [Freedreno] [DPU PATCH 1/2] drm/msm/dsi-staging: compile out partial update path

drivers/gpu/drm/msm/dsi-staging/dsi_panel.h > +++ b/drivers/gpu/drm/msm/dsi-staging/dsi_panel.h > @@ -155,8 +155,6 @@ struct dsi_panel { > enum dsi_op_mode panel_mode; > > struct dsi_dfps_capabilities dfps_caps; > - struct msm_roi_caps roi_caps; > - Removing this breaks thi

Re: [Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

nuxgraphics/gfx-docs/drm/gpu/drm-kms.html?highlight=drm_hdmi_info#c.drm_hdmi_info Is this sufficient? Sean > > Thanks > > Abhinav > > > On 2018-02-23 11:15, Sean Paul wrote: > > Use drm_edid to parse the edid instead of the hand rolled dpu version. > > &g

[Freedreno] [DPU PATCH] drm/msm: Remove dpu_edid_parser

Use drm_edid to parse the edid instead of the hand rolled dpu version. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/Makefile | 1 - drivers/gpu/drm/msm/dp/dp_audio.c | 22 +- drivers/gpu/drm/msm/dp/dp_display.c | 7 - drivers/gpu/drm/msm/dp/dp_panel.c | 77

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

On Fri, Feb 23, 2018 at 04:48:58PM +, Liviu Dudau wrote: > On Fri, Feb 23, 2018 at 11:43:29AM -0500, Sean Paul wrote: > > On Fri, Feb 23, 2018 at 11:25:11AM -0500, Rob Clark wrote: > > > On Fri, Feb 23, 2018 at 10:59 AM, Sean Paul wrote: > > > > > > >

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

On Fri, Feb 23, 2018 at 11:25:11AM -0500, Rob Clark wrote: > On Fri, Feb 23, 2018 at 10:59 AM, Sean Paul wrote: > > > > Have we considered hiding writeback behind a client cap instead? > > It is kinda *almost* unneeded, since the connector reports itself as > disconnected

Re: [Freedreno] [RFC 1/4] drm: Add writeback connector type

On Fri, Feb 23, 2018 at 04:21:05PM +, Liviu Dudau wrote: > On Fri, Feb 23, 2018 at 10:59:35AM -0500, Sean Paul wrote: > > On Fri, Feb 23, 2018 at 08:17:51AM -0500, Rob Clark wrote: > > > From: Brian Starkey > > > > > > Writeback connectors represent w

Re: [Freedreno] [RFC 3/4] drm/msm/mdp5: add config for writeback pipes

dp5/mdp5_kms.c > index 6d8e3a9a6fc0..1f44d8f15ce1 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > @@ -652,6 +652,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) > pm_runtime_get_sync(&pdev->dev); > f

Re: [Freedreno] [RFC 4/4] drm/msm/mdp5: writeback support

ct mdp5_wb_connector *mdp5_wb; > + > + mdp5_wb = kzalloc(sizeof(*mdp5_wb), GFP_KERNEL); > + if (!mdp5_wb) > + return ERR_PTR(-ENOMEM); > + > + mdp5_wb->id = wb_id; > + mdp5_wb->ctl = ctl; > + > + /* construct a dummy intf for WB: */ &g

Re: [Freedreno] [RFC 2/4] drm: writeback: Add out-fences for writeback connectors

entation around WRITEBACK_OUT_FENCE_PTR > > Signed-off-by: Brian Starkey > [rebased and fixed conflicts] > Signed-off-by: Mihail Atanassov > Signed-off-by: Liviu Dudau > Signed-off-by: Rob Clark Reviewed-by: Sean Paul > --- > dr

<    3   4   5   6   7   8   9   >