[Freedreno] [PATCH] drm/msm/dp: DisplayPort PHY compliance tests fixup

2020-09-25 Thread Tanmay Shah
Bandwidth code was being used as test link rate. Fix this by converting bandwidth code to test link rate Do not reset voltage and pre-emphasis level during IRQ HPD attention interrupt. Also fix pre-emphasis parsing during test link status process Signed-off-by: Tanmay Shah --- drivers/gpu/drm

Re: [Freedreno] [PATCH v12 0/5] Add support for DisplayPort driver on SnapDragon

2020-09-14 Thread Tanmay Shah
thing else is missing in driver. Sure, we will make sure to send changes in freedreno list as well. Thanks. BR, -R [1] https://gitlab.freedesktop.org/drm/msm/-/commits/msm-next-dp [2] https://patchwork.freedesktop.org/project/freedreno On Thu, Aug 27, 2020 at 2:17 PM Tanmay Shah wrote: The

[Freedreno] [PATCH v12 4/5] drm/msm/dpu: add display port support in DPU

2020-08-27 Thread Tanmay Shah
: None Changes in v9: None Signed-off-by: Jeykumar Sankaran Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 8 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 65 + 2 files changed, 58

[Freedreno] [PATCH v12 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-27 Thread Tanmay Shah
Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/Makefile| 4 +- drivers/gpu/drm/msm/dp/dp_catalog.c | 31 +- drivers/gpu/drm/msm/dp/dp_display.c | 18 +- drivers/gpu/drm/msm/dp/dp_display.h | 3 + drivers/gpu/drm/msm/dp

[Freedreno] [PATCH v12 5/5] drm/msm/dp: Add Display Port HPD feature

2020-08-27 Thread Tanmay Shah
Configure HPD registers in DP controller and enable HPD interrupt. Add interrupt to handle HPD connect and disconnect events. Changes in v8: None Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 drivers/gpu/drm/msm/dp/dp_catalog.c | 67

[Freedreno] [PATCH v12 0/5] Add support for DisplayPort driver on SnapDragon

2020-08-27 Thread Tanmay Shah
-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon drm: add constant N value in helper file drm/msm/dp: add displayPort driver support drm/msm/dp: add support for DP PLL driver Jeykumar Sankaran (1): drm/msm/dpu: add display port support in DPU Tanmay Shah (1): drm/msm/dp: Add

[Freedreno] [PATCH v12 1/5] drm: add constant N value in helper file

2020-08-27 Thread Tanmay Shah
Signed-off-by: Tanmay Shah Reviewed-by: Stephen Boyd Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- include/drm/drm_dp_helper.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b

[Freedreno] [PATCH v11 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-17 Thread Tanmay Shah
Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/Kconfig | 1 + drivers/gpu/drm/msm/Makefile| 4 +- drivers/gpu/drm/msm/dp/dp_catalog.c | 31 +- drivers/gpu/drm/msm/dp/dp_display.c | 18 +- drivers/gpu/drm/msm/dp/dp_display.h | 3 + drivers/gpu/drm/msm/dp

[Freedreno] [PATCH v11 5/5] drm/msm/dp: Add Display Port HPD feature

2020-08-17 Thread Tanmay Shah
Configure HPD registers in DP controller and enable HPD interrupt. Add interrupt to handle HPD connect and disconnect events. Changes in v8: None Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 drivers/gpu/drm/msm/dp/dp_catalog.c | 63

[Freedreno] [PATCH v11 4/5] drm/msm/dpu: add display port support in DPU

2020-08-17 Thread Tanmay Shah
: None Changes in v9: None Signed-off-by: Jeykumar Sankaran Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 8 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 65 + 2 files changed, 58

[Freedreno] [PATCH v11 0/5] Add support for DisplayPort driver on SnapDragon

2020-08-17 Thread Tanmay Shah
drm/msm/dp: add displayPort driver support drm/msm/dp: add support for DP PLL driver Jeykumar Sankaran (1): drm/msm/dpu: add display port support in DPU Tanmay Shah (1): drm/msm/dp: Add Display Port HPD feature drivers/gpu/drm/i915/display/intel_display.c |2 +- drivers/g

[Freedreno] [PATCH v11 1/5] drm: add constant N value in helper file

2020-08-17 Thread Tanmay Shah
Signed-off-by: Tanmay Shah Reviewed-by: Stephen Boyd Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- include/drm/drm_dp_helper.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b

[Freedreno] [PATCH v3] arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node

2020-08-17 Thread Tanmay Shah
This node defines alternate DP HPD functionality of GPIO. Signed-off-by: Tanmay Shah --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index bf2f2bb1aa79

Re: [Freedreno] [PATCH v6] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-08-17 Thread Tanmay Shah
On 2020-08-17 17:24, Stephen Boyd wrote: Quoting Tanmay Shah (2020-08-17 15:53:00) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 31b9217bb5bf..bf2f2bb1aa79 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180

[Freedreno] [PATCH v2] arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node

2020-08-17 Thread Tanmay Shah
This node defines alternate DP HPD functionality of GPIO. Signed-off-by: Tanmay Shah --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index bf2f2bb1aa79

[Freedreno] [PATCH v6] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-08-17 Thread Tanmay Shah
Changes in v6: - Remove redundant IRQ flag Signed-off-by: Tanmay Shah Co-developed-by: Kuogee Hsieh Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 76 +++- 1 file changed, 74 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180

[Freedreno] [PATCH v1] arm64: dts: qcom: sc7180: Add DisplayPort HPD pin dt node

2020-08-17 Thread Tanmay Shah
This node defines alternate DP HPD functionality of GPIO. Signed-off-by: Tanmay Shah --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index bf2f2bb1aa79

Re: [Freedreno] [PATCH v10 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-17 Thread Tanmay Shah
On 2020-08-15 15:45, Rob Clark wrote: On Sat, Aug 15, 2020 at 2:21 PM Jonathan Marek wrote: On 8/15/20 4:20 PM, Rob Clark wrote: > On Fri, Aug 14, 2020 at 10:05 AM Dmitry Baryshkov > wrote: >> >> >> On 12/08/2020 07:42, Tanmay Shah wrote: >> > From: Chanda

Re: [Freedreno] [PATCH v10 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-17 Thread Tanmay Shah
On 2020-08-15 04:45, Dmitry Baryshkov wrote: On 15/08/2020 02:22, Tanmay Shah wrote: On 2020-08-14 10:05, Dmitry Baryshkov wrote: On 12/08/2020 07:42, Tanmay Shah wrote: From: Chandan Uddaraju Add the needed DP PLL specific files to support display port interface on msm targets. [skipped

Re: [Freedreno] [PATCH v10 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-14 Thread Tanmay Shah
On 2020-08-14 10:05, Dmitry Baryshkov wrote: On 12/08/2020 07:42, Tanmay Shah wrote: From: Chandan Uddaraju Add the needed DP PLL specific files to support display port interface on msm targets. [skipped] diff --git a/drivers/gpu/drm/msm/dp/dp_pll_private.h b/drivers/gpu/drm/msm/dp

Re: [Freedreno] [PATCH v10 2/5] drm/msm/dp: add displayPort driver support

2020-08-14 Thread Tanmay Shah
On 2020-08-14 10:56, Tanmay Shah wrote: On 2020-08-14 10:12, Dmitry Baryshkov wrote: Hello, On 12/08/2020 07:42, Tanmay Shah wrote: From: Chandan Uddaraju [skipped] + } else if ((dp_parser_check_prefix("ctrl", clk_name) || + dp_parser_ch

Re: [Freedreno] [PATCH v10 2/5] drm/msm/dp: add displayPort driver support

2020-08-14 Thread Tanmay Shah
On 2020-08-14 10:12, Dmitry Baryshkov wrote: Hello, On 12/08/2020 07:42, Tanmay Shah wrote: From: Chandan Uddaraju [skipped] + } else if ((dp_parser_check_prefix("ctrl", clk_name) || + dp_parser_check_prefix("st

Re: [Freedreno] [PATCH v5] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-08-12 Thread Tanmay Shah
On 2020-08-11 12:30, Stephen Boyd wrote: Quoting Tanmay Shah (2020-08-10 19:15:53) @@ -2440,6 +2447,71 @@ dsi_phy: dsi-phy@ae94400 { status = "disabled"; }; + + msm_dp: displayport-controll

[Freedreno] [PATCH v10 4/5] drm/msm/dpu: add display port support in DPU

2020-08-11 Thread Tanmay Shah
: None Changes in v9: None Signed-off-by: Jeykumar Sankaran Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 8 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 65 + 2 files changed, 58

[Freedreno] [PATCH v10 5/5] drm/msm/dp: Add Display Port HPD feature

2020-08-11 Thread Tanmay Shah
Configure HPD registers in DP controller and enable HPD interrupt. Add interrupt to handle HPD connect and disconnect events. Changes in v8: None Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 drivers/gpu/drm/msm/dp/dp_catalog.c | 63

[Freedreno] [PATCH v10 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-11 Thread Tanmay Shah
-- Remove redundant cell-index property parsing Changes in v8: -- Unregister hardware clocks during driver cleanup Changes in v9: -- Remove redundant Kconfig option DRM_MSM_DP_10NM_PLL Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm

[Freedreno] [PATCH v10 0/5] Add support for DisplayPort driver on SnapDragon

2020-08-11 Thread Tanmay Shah
(1): drm/msm/dpu: add display port support in DPU Tanmay Shah (1): drm/msm/dp: Add Display Port HPD feature drivers/gpu/drm/i915/display/intel_display.c |2 +- drivers/gpu/drm/msm/Kconfig |9 + drivers/gpu/drm/msm/Makefile | 14 + drivers/gpu/drm/

[Freedreno] [PATCH v10 1/5] drm: add constant N value in helper file

2020-08-11 Thread Tanmay Shah
Signed-off-by: Tanmay Shah Reviewed-by: Stephen Boyd Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- include/drm/drm_dp_helper.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b

Re: [Freedreno] [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-11 Thread Tanmay Shah
On 2020-08-11 13:21, Randy Dunlap wrote: On 8/11/20 12:49 PM, tan...@codeaurora.org wrote: On 2020-08-07 13:28, Randy Dunlap wrote: On 8/7/20 1:24 PM, Stephen Boyd wrote: Quoting Rob Clark (2020-08-07 08:51:48) On Fri, Aug 7, 2020 at 8:27 AM Randy Dunlap wrote: On 8/7/20 12:17 AM, Tanmay

Re: [Freedreno] [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-11 Thread tanmay
On 2020-08-07 13:28, Randy Dunlap wrote: On 8/7/20 1:24 PM, Stephen Boyd wrote: Quoting Rob Clark (2020-08-07 08:51:48) On Fri, Aug 7, 2020 at 8:27 AM Randy Dunlap wrote: On 8/7/20 12:17 AM, Tanmay Shah wrote: diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index

[Freedreno] [PATCH v5] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-08-10 Thread Tanmay Shah
patch depends-on following series: https://lore.kernel.org/dri-devel/20200807071718.17937-1-tan...@codeaurora.org/ Signed-off-by: Tanmay Shah Co-developed-by: Kuogee Hsieh Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 76 +++- 1 file changed, 74

Re: [Freedreno] [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-07 Thread tanmay
On 2020-08-07 08:27, Randy Dunlap wrote: On 8/7/20 12:17 AM, Tanmay Shah wrote: diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index ea3c4d094d09..cc1392b29022 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -60,6 +60,7 @@ config

[Freedreno] [PATCH v4] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-08-07 Thread Tanmay Shah
-devel/20200807071718.17937-1-tan...@codeaurora.org/ Signed-off-by: Tanmay Shah --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 49 ++-- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index

[Freedreno] [PATCH v9 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-07 Thread Tanmay Shah
-- Remove redundant cell-index property parsing Changes in v8: -- Unregister hardware clocks during driver cleanup Changes in v9: -- Remove redundant Kconfig option DRM_MSM_DP_10NM_PLL Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm

[Freedreno] [PATCH v9 0/5] Add support for DisplayPort driver on SnapDragon

2020-08-07 Thread Tanmay Shah
dan Uddaraju (4): dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon drm: add constant N value in helper file drm/msm/dp: add displayPort driver support drm/msm/dp: add support for DP PLL driver Jeykumar Sankaran (1): drm/msm/dpu: add display port support in DPU Tanmay S

[Freedreno] [PATCH v9 1/5] drm: add constant N value in helper file

2020-08-07 Thread Tanmay Shah
Signed-off-by: Tanmay Shah Reviewed-by: Stephen Boyd Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- include/drm/drm_dp_helper.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b

[Freedreno] [PATCH v9 5/5] drm/msm/dp: Add Display Port HPD feature

2020-08-07 Thread Tanmay Shah
Configure HPD registers in DP controller and enable HPD interrupt. Add interrupt to handle HPD connect and disconnect events. Changes in v8: None Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 drivers/gpu/drm/msm/dp/dp_catalog.c | 63

[Freedreno] [PATCH v9 4/5] drm/msm/dpu: add display port support in DPU

2020-08-07 Thread Tanmay Shah
: None Changes in v9: None Signed-off-by: Jeykumar Sankaran Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 8 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 65 + 2 files changed, 58

Re: [Freedreno] [PATCH v8 0/6] Add support for DisplayPort driver on SnapDragon

2020-07-10 Thread tanmay
Thanks for reviews Rob. On 2020-07-09 13:21, Rob Herring wrote: On Tue, Jun 30, 2020 at 11:45:01AM -0700, Tanmay Shah wrote: These patches add Display-Port driver on SnapDragon/msm hardware. This series also contains device-tree bindings for msm DP driver. It also contains Makefile and Kconfig

[Freedreno] [PATCH v3] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-06-30 Thread Tanmay Shah
SOC dts - Assign DP to Port2 in MDP node - Add MDSS AHB clock in DP device node This patch depends-on: https://patchwork.freedesktop.org/series/78953/ Signed-off-by: Tanmay Shah --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 49 ++-- 1 file changed, 47 insertions(+), 2

[Freedreno] [PATCH v8 6/6] drm/msm/dp: Add Display Port HPD feature

2020-06-30 Thread Tanmay Shah
Configure HPD registers in DP controller and enable HPD interrupt. Add interrupt to handle HPD connect and disconnect events. Changes in v8: None Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 drivers/gpu/drm/msm/dp/dp_catalog.c | 67

[Freedreno] [PATCH v8 1/6] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-30 Thread Tanmay Shah
depends-on: - https://patchwork.freedesktop.org/patch/366159/ Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- .../display/msm/dp-controller-sc7180.yaml | 144 ++ .../bindings/display/msm/dp-controller.yaml | 61

[Freedreno] [PATCH v8 2/6] drm: add constant N value in helper file

2020-06-30 Thread Tanmay Shah
Signed-off-by: Tanmay Shah Reviewed-by: Stephen Boyd Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- include/drm/drm_dp_helper.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b

[Freedreno] [PATCH v8 4/6] drm/msm/dp: add support for DP PLL driver

2020-06-30 Thread Tanmay Shah
-- Remove redundant cell-index property parsing Changes in v8: -- Unregister hardware clocks during driver cleanup Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/Kconfig | 8 + drivers/gpu/drm/msm/Makefile| 4

[Freedreno] [PATCH v8 5/6] drm/msm/dpu: add display port support in DPU

2020-06-30 Thread Tanmay Shah
: None Signed-off-by: Jeykumar Sankaran Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 8 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 65 + 2 files changed, 58 insertions(+), 15

[Freedreno] [PATCH v8 0/6] Add support for DisplayPort driver on SnapDragon

2020-06-30 Thread Tanmay Shah
DPU Tanmay Shah (1): drm/msm/dp: Add Display Port HPD feature .../display/msm/dp-controller-sc7180.yaml | 144 ++ .../bindings/display/msm/dp-controller.yaml | 61 + .../bindings/display/msm/dpu-sc7180.yaml | 11 + drivers/gpu/drm/i915/display/intel_display.c |2 +- drivers/

Re: [Freedreno] [PATCH v2] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-06-19 Thread tanmay
Thanks Stephen for reviews. I will post new change addressing your all comments. On 2020-06-18 18:12, Stephen Boyd wrote: Quoting Tanmay Shah (2020-06-18 16:21:13) Enable DP driver for sc7180. Add DP device node on sc7180? This isn't a driver. Done. This change depends-on foll

[Freedreno] [PATCH v2] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-06-18 Thread Tanmay Shah
,sc7180-dp Signed-off-by: Tanmay Shah --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 57 ++-- 1 file changed, 53 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 916401f7e87c..26fe623e3b0f 100644

[Freedreno] [PATCH v7 6/6] drm/msm/dp: Add Display Port HPD feature

2020-06-18 Thread Tanmay Shah
Configure HPD registers in DP controller and enable HPD interrupt. Add interrupt to handle HPD connect and disconnect events. Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 drivers/gpu/drm/msm/dp/dp_catalog.c | 67 +-- drivers/gpu/drm/msm/dp

[Freedreno] [PATCH v7 4/6] drm/msm/dp: add support for DP PLL driver

2020-06-18 Thread Tanmay Shah
-- Remove redundant cell-index property parsing Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/Kconfig | 8 + drivers/gpu/drm/msm/Makefile| 4 +- drivers/gpu/drm/msm/dp/dp_catalog.c | 31 +- drivers/gpu/drm

[Freedreno] [PATCH v7 5/6] drm/msm/dpu: add display port support in DPU

2020-06-18 Thread Tanmay Shah
: Jeykumar Sankaran Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 8 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 65 + 2 files changed, 58 insertions(+), 15 deletions(-) diff --git

[Freedreno] [PATCH v7 0/6] Add support for DisplayPort driver on SnapDragon

2020-06-18 Thread Tanmay Shah
Uddaraju (4): dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon drm: add constant N value in helper file drm/msm/dp: add displayPort driver support drm/msm/dp: add support for DP PLL driver Jeykumar Sankaran (1): drm/msm/dpu: add display port support in DPU Tanmay Shah (1

[Freedreno] [PATCH v7 2/6] drm: add constant N value in helper file

2020-06-18 Thread Tanmay Shah
Signed-off-by: Tanmay Shah Reviewed-by: Stephen Boyd Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- include/drm/drm_dp_helper.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b

[Freedreno] [PATCH v7 1/6] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-18 Thread Tanmay Shah
://patchwork.freedesktop.org/patch/366159/ Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- .../display/msm/dp-controller-sc7180.yaml | 147 ++ .../bindings/display/msm/dp-controller.yaml | 59 +++ .../bindings/display/msm/dpu-sc7180.yaml | 11

Re: [Freedreno] [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-16 Thread tanmay
Thanks Stephen for your answers. On 2020-06-16 03:55, Stephen Boyd wrote: Quoting tan...@codeaurora.org (2020-06-11 13:07:09) On 2020-06-09 19:15, Stephen Boyd wrote: > Quoting Tanmay Shah (2020-06-08 20:38:18) >> diff --git >> a/Documentation/devicetree/bindings/display/msm

[Freedreno] [PATCH v1] arm64: dts: qcom: sc7180: Add Display Port dt node

2020-06-15 Thread Tanmay Shah
Enable DP driver for sc7180. This change depends-on following series: https://patchwork.freedesktop.org/series/78247/ and https://patchwork.freedesktop.org/patch/351990/ Signed-off-by: Tanmay Shah --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 58 ++-- 1 file changed, 54

Re: [Freedreno] [PATCH v6 0/5] Add support for DisplayPort driver on

2020-06-15 Thread tanmay
On 2020-06-15 16:04, Jeffrey Hugo wrote: On Mon, Jun 15, 2020 at 4:51 PM wrote: On 2020-06-12 16:26, Stephen Boyd wrote: Thanks for reviews Stephen. > Quoting Tanmay Shah (2020-06-11 18:50:25) >> These patches add support for Display-Port driver on SnapDragon >> hardware

Re: [Freedreno] [PATCH v6 0/5] Add support for DisplayPort driver on

2020-06-15 Thread tanmay
On 2020-06-12 16:26, Stephen Boyd wrote: Thanks for reviews Stephen. Quoting Tanmay Shah (2020-06-11 18:50:25) These patches add support for Display-Port driver on SnapDragon hardware. It adds DP driver and DP PLL driver files along with the needed device-tree bindings. The block diagram of

[Freedreno] [PATCH v6 4/5] drm/msm/dp: add support for DP PLL driver

2020-06-11 Thread Tanmay Shah
its functionality in dp_pll_10nm.c -- Introduce new data structures private to PLL module Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/Kconfig | 13 + drivers/gpu/drm/msm/Makefile| 3 + drivers/gpu/drm

[Freedreno] [PATCH v6 2/5] drm: add constant N value in helper file

2020-06-11 Thread Tanmay Shah
Signed-off-by: Tanmay Shah Reviewed-by: Stephen Boyd Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- include/drm/drm_dp_helper.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b

[Freedreno] [PATCH v6 5/5] drm/msm/dpu: add display port support in DPU

2020-06-11 Thread Tanmay Shah
Signed-off-by: Jeykumar Sankaran Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 8 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 65 + 2 files changed, 58 insertions(+), 15 deletions

[Freedreno] [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-11 Thread Tanmay Shah
- Add Display Port as interface of DPU in DPU bindings and add port mapping accordingly. Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- .../bindings/display/msm/dp-sc7180.yaml | 142 ++ .../devicetree/bindings/display/msm

[Freedreno] [PATCH v6 0/5] Add support for DisplayPort driver on

2020-06-11 Thread Tanmay Shah
These patches add support for Display-Port driver on SnapDragon hardware. It adds DP driver and DP PLL driver files along with the needed device-tree bindings. The block diagram of DP driver is shown below: +-+ |DRM FRAMEWORK| +-

Re: [Freedreno] [PATCH v6 4/5] drm/msm/dp: add support for DP PLL driver

2020-06-11 Thread tanmay
Hi Stephen, Thanks for reviews. Please ignore previous response to this patch. Here, I have re-organized it. Thanks, On 2020-06-11 13:07, tan...@codeaurora.org wrote: On 2020-06-09 19:06, Stephen Boyd wrote: Quoting Tanmay Shah (2020-06-08 20:46:23) diff --git a/drivers/gpu/drm/msm/dp

Re: [Freedreno] [PATCH v6 2/5] drm: add constant N value in helper file

2020-06-11 Thread tanmay
On 2020-06-09 19:20, Stephen Boyd wrote: Quoting Tanmay Shah (2020-06-08 20:40:47) From: Chandan Uddaraju The constant N value (0x8000) is used by i915 DP driver. Define this value in dp helper header file to use in multiple Display Port drivers. Change i915 driver accordingly. Change in v6

Re: [Freedreno] [PATCH v6 4/5] drm/msm/dp: add support for DP PLL driver

2020-06-11 Thread tanmay
On 2020-06-09 19:06, Stephen Boyd wrote: Quoting Tanmay Shah (2020-06-08 20:46:23) diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c b/drivers/gpu/drm/msm/dp/dp_catalog.c index d02f4eb..2b982f0 100644 --- a/drivers/gpu/drm/msm/dp/dp_catalog.c +++ b/drivers/gpu/drm/msm/dp/dp_catalog.c @@ -5,6

Re: [Freedreno] [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-11 Thread tanmay
On 2020-06-09 19:15, Stephen Boyd wrote: Quoting Tanmay Shah (2020-06-08 20:38:18) diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml new file mode 100644 index 000..5fdb915 --- /dev/null +++ b

[Freedreno] [PATCH v6 5/5] drm/msm/dpu: add display port support in DPU

2020-06-08 Thread Tanmay Shah
Signed-off-by: Jeykumar Sankaran Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 8 ++-- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 65 - 2 files changed, 58 insertions(+), 15

[Freedreno] [PATCH v6 4/5] drm/msm/dp: add support for DP PLL driver

2020-06-08 Thread Tanmay Shah
its functionality in dp_pll_10nm.c -- Introduce new data structures private to PLL module Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/Kconfig | 13 + drivers/gpu/drm/msm/Makefile| 3 + drivers/gpu/drm

[Freedreno] [PATCH v6 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-08 Thread Tanmay Shah
- Add Display Port as interface of DPU in DPU bindings and add port mapping accordingly. Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy Signed-off-by: Tanmay Shah --- .../devicetree/bindings/display/msm/dp-sc7180.yaml | 142 + .../devicetree/bindings/display

[Freedreno] [PATCH v6 2/5] drm: add constant N value in helper file

2020-06-08 Thread Tanmay Shah
Signed-off-by: Tanmay Shah --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- include/drm/drm_dp_helper.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index

Re: [Freedreno] [DPU PATCH v5 4/5] drm/msm/dp: add support for DP PLL driver

2020-06-08 Thread tanmay
On 2020-04-23 17:26, Stephen Boyd wrote: Quoting Tanmay Shah (2020-03-31 17:30:30) diff --git a/drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.c b/drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.c new file mode 100644 index 000..aa845d0 --- /dev/null +++ b/drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.c @@ -0,0

Re: [Freedreno] [DPU PATCH v5 2/5] drm: add constant N value in helper file

2020-06-08 Thread tanmay
On 2020-04-23 16:41, Stephen Boyd wrote: Quoting Tanmay Shah (2020-03-31 17:30:28) From: Chandan Uddaraju The constant N value (0x8000) is used by multiple DP There's one driver using it, not multiple. Changed commit message accordingly. drivers. Define this value in header file an

Re: [Freedreno] [DPU PATCH v5 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-08 Thread tanmay
Thanks for reviews Stephen. Please find my comments according to new design. On 2020-04-23 16:41, Stephen Boyd wrote: Quoting Tanmay Shah (2020-03-31 17:30:27) diff --git a/Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml b/Documentation/devicetree/bindings/display/msm/dp-sc7180

Re: [Freedreno] [DPU PATCH v5 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-06-08 Thread tanmay
Hi Tanmay Reviewing the yaml bindings triggered a few comments. See below. Sam Thanks for reviews Sam. Apologies for delayed response. We are redesigning our driver according to upstream comments and had to go through multiple discussions before we post v6. Please find my

Re: [Freedreno] [PATCH 1/2] dt-bindings: msm: disp: Add Display Port HPD GPIO bindings

2020-04-27 Thread tanmay
08:24, Rob Herring wrote: On Tue, Apr 07, 2020 at 03:48:28PM -0700, Tanmay Shah wrote: Add Display Port HPD GPIO description in bindings This Patch depends on: https://patchwork.kernel.org/patch/11468505/ This belongs below the '---' and probably means you should send all

[Freedreno] [PATCH 1/2] dt-bindings: msm: disp: Add Display Port HPD GPIO bindings

2020-04-07 Thread Tanmay Shah
Add Display Port HPD GPIO description in bindings This Patch depends on: https://patchwork.kernel.org/patch/11468505/ Signed-off-by: Tanmay Shah --- Documentation/devicetree/bindings/display/msm/dp-sc7180.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation

[Freedreno] [PATCH 2/2] drm/msm/dp: Add Hot Plug Detect feature

2020-04-07 Thread Tanmay Shah
/11468519 https://patchwork.kernel.org/patch/11468515 Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 ++ drivers/gpu/drm/msm/dp/dp_catalog.c | 69 +--- drivers/gpu/drm/msm/dp/dp_catalog.h | 5 +- drivers/gpu/drm/msm/dp/dp_ctrl.c

Re: [Freedreno] [DPU PATCH v5 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-04-06 Thread tanmay
Hi Sam, Thanks for reviews. The changes were posted by Vara Reddy. Due to some configuration errors, changes were posted with my E-mail ID. Vara will be addressing comments, and we will take care of this error with next patchset. Thanks, Tanmay -Original Message- From: Sam Ravnborg

[Freedreno] [DPU PATCH v5 5/5] drm/msm/dpu: add display port support in DPU

2020-03-31 Thread Tanmay Shah
From: Jeykumar Sankaran Add display port support in DPU by creating hooks for DP encoder enumeration and encoder mode initialization. This change is based on the Snapdragon Display port driver changes[1]. changes in v2: - rebase on [2] (Sean Paul) - remove unwanted error checks

[Freedreno] [DPU PATCH v5 4/5] drm/msm/dp: add support for DP PLL driver

2020-03-31 Thread Tanmay Shah
From: Chandan Uddaraju Add the needed DP PLL specific files to support display port interface on msm targets. The DP driver calls the DP PLL driver registration. The DP driver sets the link and pixel clock sources. Changes in v2: -- Update copyright markings on all relevant files. -- Use DRM_DE

[Freedreno] [DPU PATCH v5 1/5] dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon

2020-03-31 Thread Tanmay Shah
From: Chandan Uddaraju Add bindings for Snapdragon DisplayPort and display-port PLL driver. Changes in V2: Provide details about sel-gpio Changes in V4: Provide details about max dp lanes Change the commit text Changes in V5: Moved dp.txt to yaml file. Signed-off-by: Chandan Uddaraju Signed-

[Freedreno] [DPU PATCH v5 2/5] drm: add constant N value in helper file

2020-03-31 Thread Tanmay Shah
From: Chandan Uddaraju The constant N value (0x8000) is used by multiple DP drivers. Define this value in header file and use this in the existing i915 display driver. Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy --- drivers/gpu/drm/i915/display/intel_display.c | 2 +- include/dr

[Freedreno] [DPU PATCH v5 0/5] Add support for DisplayPort driver on SnapDragon.

2020-03-31 Thread Tanmay Shah
These patches add support for Display-Port driver on SnapDragon 845 hardware. It adds DP driver and DP PLL driver files along with the needed device-tree bindings. The block diagram of DP driver is shown below: +-+ |DRM FRAMEWORK| +

[Freedreno] [PATCH v3] drm/msm/dpu: Change definition of RGB565 and BGR565

2018-12-17 Thread Tanmay Shah
Correct definition of both formats by swapping red and blue channels v3: update commit message Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c b

[Freedreno] [DPU PATCH v2] drm/msm/dpu: Change RGB565 and BGR565 format map.

2018-12-14 Thread Tanmay Shah
Red and Blue colors will be interchanged on display with current format maps for RGB565 and BGR565. Change both format maps to display correct colors. Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Freedreno] [DPU PATCH v1] drm/msm/dpu: Change RGB565 and BGR565 format map.

2018-12-14 Thread Tanmay Shah
Red and Blue colors will be interchanged on display with current format maps for RGB565 and BGR565. Change both format maps to dispaly correct colors. Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[Freedreno] [PATCH libdrm v2] libdrm: add msm drm uapi header

2018-08-10 Thread Tanmay Shah
msm_drm.h file derived from drm-next kernel uapi header. Remove freedreno/msm/msm_drm.h to maintain only one copy of msm_drm.h and change freedreno Makefile accordingly. Signed-off-by: Tanmay Shah --- Makefile.sources | 1 + freedreno/Makefile.sources | 1