Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-22 Thread Rob Clark
On Thu, Jul 22, 2021 at 2:28 AM Christian König wrote: > > Am 22.07.21 um 11:08 schrieb Daniel Vetter: > > [SNIP] > >> As far as I know wake_up_state() tries to run the thread on the CPU it was > >> scheduled last, while wait_event_* makes the thread run on the CPU who > >> issues the wake by defa

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-22 Thread Rob Clark
On Thu, Jul 22, 2021 at 1:42 AM Christian König wrote: > > Am 21.07.21 um 21:03 schrieb Daniel Vetter: > > On Wed, Jul 21, 2021 at 09:34:43AM -0700, Rob Clark wrote: > >> On Wed, Jul 21, 2021 at 12:59 AM Daniel Vetter wrote: > >>> On Wed, Jul 21, 2021 at 12:32 AM Rob Clark wrote: > On Tue,

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-22 Thread Christian König
Am 22.07.21 um 12:47 schrieb Daniel Vetter: On Thu, Jul 22, 2021 at 11:28:01AM +0200, Christian König wrote: Am 22.07.21 um 11:08 schrieb Daniel Vetter: [SNIP] As far as I know wake_up_state() tries to run the thread on the CPU it was scheduled last, while wait_event_* makes the thread run on

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-22 Thread Daniel Vetter
On Thu, Jul 22, 2021 at 11:28:01AM +0200, Christian König wrote: > Am 22.07.21 um 11:08 schrieb Daniel Vetter: > > [SNIP] > > > As far as I know wake_up_state() tries to run the thread on the CPU it was > > > scheduled last, while wait_event_* makes the thread run on the CPU who > > > issues the wa

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-22 Thread Christian König
Am 22.07.21 um 11:08 schrieb Daniel Vetter: [SNIP] As far as I know wake_up_state() tries to run the thread on the CPU it was scheduled last, while wait_event_* makes the thread run on the CPU who issues the wake by default. And yes I've also noticed this already and it was one of the reason wh

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-22 Thread Daniel Vetter
On Thu, Jul 22, 2021 at 10:42:26AM +0200, Christian König wrote: > Am 21.07.21 um 21:03 schrieb Daniel Vetter: > > On Wed, Jul 21, 2021 at 09:34:43AM -0700, Rob Clark wrote: > > > On Wed, Jul 21, 2021 at 12:59 AM Daniel Vetter wrote: > > > > On Wed, Jul 21, 2021 at 12:32 AM Rob Clark wrote: > > >

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-22 Thread Christian König
Am 21.07.21 um 21:03 schrieb Daniel Vetter: On Wed, Jul 21, 2021 at 09:34:43AM -0700, Rob Clark wrote: On Wed, Jul 21, 2021 at 12:59 AM Daniel Vetter wrote: On Wed, Jul 21, 2021 at 12:32 AM Rob Clark wrote: On Tue, Jul 20, 2021 at 1:55 PM Daniel Vetter wrote: On Tue, Jul 20, 2021 at 8:26 P

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 09:34:43AM -0700, Rob Clark wrote: > On Wed, Jul 21, 2021 at 12:59 AM Daniel Vetter wrote: > > > > On Wed, Jul 21, 2021 at 12:32 AM Rob Clark wrote: > > > > > > On Tue, Jul 20, 2021 at 1:55 PM Daniel Vetter wrote: > > > > > > > > On Tue, Jul 20, 2021 at 8:26 PM Rob Clark

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-21 Thread Rob Clark
On Wed, Jul 21, 2021 at 12:59 AM Daniel Vetter wrote: > > On Wed, Jul 21, 2021 at 12:32 AM Rob Clark wrote: > > > > On Tue, Jul 20, 2021 at 1:55 PM Daniel Vetter wrote: > > > > > > On Tue, Jul 20, 2021 at 8:26 PM Rob Clark wrote: > > > > > > > > On Tue, Jul 20, 2021 at 11:03 AM Christian König

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 12:32 AM Rob Clark wrote: > > On Tue, Jul 20, 2021 at 1:55 PM Daniel Vetter wrote: > > > > On Tue, Jul 20, 2021 at 8:26 PM Rob Clark wrote: > > > > > > On Tue, Jul 20, 2021 at 11:03 AM Christian König > > > wrote: > > > > > > > > Hi Rob, > > > > > > > > Am 20.07.21 um 17

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-20 Thread Rob Clark
On Tue, Jul 20, 2021 at 1:55 PM Daniel Vetter wrote: > > On Tue, Jul 20, 2021 at 8:26 PM Rob Clark wrote: > > > > On Tue, Jul 20, 2021 at 11:03 AM Christian König > > wrote: > > > > > > Hi Rob, > > > > > > Am 20.07.21 um 17:07 schrieb Rob Clark: > > > > From: Rob Clark > > > > > > > > Somehow w

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-20 Thread Daniel Vetter
On Tue, Jul 20, 2021 at 8:26 PM Rob Clark wrote: > > On Tue, Jul 20, 2021 at 11:03 AM Christian König > wrote: > > > > Hi Rob, > > > > Am 20.07.21 um 17:07 schrieb Rob Clark: > > > From: Rob Clark > > > > > > Somehow we had neither ->wait() nor dma_fence_signal() calls, and no > > > one noticed.

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-20 Thread Rob Clark
On Tue, Jul 20, 2021 at 11:03 AM Christian König wrote: > > Hi Rob, > > Am 20.07.21 um 17:07 schrieb Rob Clark: > > From: Rob Clark > > > > Somehow we had neither ->wait() nor dma_fence_signal() calls, and no > > one noticed. Oops. > > > I'm not sure if that is a good idea. > > The dma_fence->wa

Re: [Freedreno] [Linaro-mm-sig] [PATCH] drm/msm: Add fence->wait() op

2021-07-20 Thread Christian König
Hi Rob, Am 20.07.21 um 17:07 schrieb Rob Clark: From: Rob Clark Somehow we had neither ->wait() nor dma_fence_signal() calls, and no one noticed. Oops. I'm not sure if that is a good idea. The dma_fence->wait() callback is pretty much deprecated and should not be used any more. What ex