Re: [Freedreno] [PATCH] drm/msm: return fence_fd = -1 if gem_submit fails

2016-12-12 Thread Gustavo Padovan
2016-12-12 Chris Wilson : > On Mon, Dec 12, 2016 at 05:41:08PM -0200, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Previously we were returning garbage here, fix it by setting it to -1 > > before the first possible point of

Re: [Freedreno] [PATCH] drm/msm: return fence_fd = -1 if gem_submit fails

2016-12-12 Thread Chris Wilson
On Mon, Dec 12, 2016 at 05:41:08PM -0200, Gustavo Padovan wrote: > From: Gustavo Padovan > > Previously we were returning garbage here, fix it by setting it to -1 > before the first possible point of failure. The convention is that on error paths you do not

[Freedreno] [PATCH] drm/msm: return fence_fd = -1 if gem_submit fails

2016-12-12 Thread Gustavo Padovan
From: Gustavo Padovan Previously we were returning garbage here, fix it by setting it to -1 before the first possible point of failure. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/msm/msm_gem_submit.c | 5 - 1 file