Re: [Freedreno] [PATCH] drm: improve the documentation of connector hpd ops

2023-12-04 Thread Abhinav Kumar
On 12/3/2023 10:14 AM, Dmitry Baryshkov wrote: On Sun, 3 Dec 2023 at 16:24, Laurent Pinchart wrote: Hi Abhinav, Thank you for the patch (and thank to Dmitry for pinging me on IRC, this patch got burried in my inbox). On Wed, Sep 20, 2023 at 01:13:58PM -0700, Abhinav Kumar wrote: While ma

Re: [Freedreno] [PATCH] drm: improve the documentation of connector hpd ops

2023-12-04 Thread Dmitry Baryshkov
On Wed, 20 Sep 2023 13:13:58 -0700, Abhinav Kumar wrote: > While making the changes in [1], it was noted that the documentation > of the enable_hpd() and disable_hpd() does not make it clear that > these ops should not try to do hpd state maintenance and should only > attempt to enable/disable hpd

Re: [Freedreno] [PATCH] drm: improve the documentation of connector hpd ops

2023-12-03 Thread Dmitry Baryshkov
On Sun, 3 Dec 2023 at 16:24, Laurent Pinchart wrote: > > Hi Abhinav, > > Thank you for the patch (and thank to Dmitry for pinging me on IRC, this > patch got burried in my inbox). > > On Wed, Sep 20, 2023 at 01:13:58PM -0700, Abhinav Kumar wrote: > > While making the changes in [1], it was noted t

Re: [Freedreno] [PATCH] drm: improve the documentation of connector hpd ops

2023-12-03 Thread Laurent Pinchart
Hi Abhinav, Thank you for the patch (and thank to Dmitry for pinging me on IRC, this patch got burried in my inbox). On Wed, Sep 20, 2023 at 01:13:58PM -0700, Abhinav Kumar wrote: > While making the changes in [1], it was noted that the documentation > of the enable_hpd() and disable_hpd() does n

[Freedreno] [PATCH] drm: improve the documentation of connector hpd ops

2023-09-20 Thread Abhinav Kumar
While making the changes in [1], it was noted that the documentation of the enable_hpd() and disable_hpd() does not make it clear that these ops should not try to do hpd state maintenance and should only attempt to enable/disable hpd related hardware for the connector. The state management of thes