Re: [Freedreno] [PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-22 Thread Dmitry Baryshkov
On 22/06/2022 18:22, Kuogee Hsieh wrote: On 6/22/2022 12:24 AM, Dmitry Baryshkov wrote: On 22/06/2022 05:59, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-06-17 16:07:58) On 17/06/2022 23:47, Stephen Boyd wrote: This struct member is stored to in the function that calls the function wh

Re: [Freedreno] [PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-22 Thread Kuogee Hsieh
On 6/22/2022 12:24 AM, Dmitry Baryshkov wrote: On 22/06/2022 05:59, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-06-17 16:07:58) On 17/06/2022 23:47, Stephen Boyd wrote: This struct member is stored to in the function that calls the function which uses it. That's possible with a funct

Re: [Freedreno] [PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-22 Thread Dmitry Baryshkov
On 22/06/2022 05:59, Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-06-17 16:07:58) On 17/06/2022 23:47, Stephen Boyd wrote: This struct member is stored to in the function that calls the function which uses it. That's possible with a function argument instead of storing to a struct member.

Re: [Freedreno] [PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-21 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-06-17 16:07:58) > On 17/06/2022 23:47, Stephen Boyd wrote: > > This struct member is stored to in the function that calls the function > > which uses it. That's possible with a function argument instead of > > storing to a struct member. Pass the pixel_rate as an argu

Re: [Freedreno] [PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-17 Thread Dmitry Baryshkov
On 17/06/2022 23:47, Stephen Boyd wrote: This struct member is stored to in the function that calls the function which uses it. That's possible with a function argument instead of storing to a struct member. Pass the pixel_rate as an argument instead to simplify the code. Note that dp_ctrl_link_m

[Freedreno] [PATCH 2/3] drm/msm/dp: Remove pixel_rate from struct dp_ctrl

2022-06-17 Thread Stephen Boyd
This struct member is stored to in the function that calls the function which uses it. That's possible with a function argument instead of storing to a struct member. Pass the pixel_rate as an argument instead to simplify the code. Note that dp_ctrl_link_maintenance() was storing the pixel_rate but