Re: [Freedreno] [PATCH RESEND] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state

2023-12-05 Thread Dmitry Baryshkov
On Tue, 5 Dec 2023 at 13:48, Maxime Ripard wrote: > > On Tue, Dec 05, 2023 at 03:37:15AM +0200, Dmitry Baryshkov wrote: > > On 04/12/2023 10:38, Maxime Ripard wrote: > > > On Sat, Dec 02, 2023 at 12:07:49AM +0200, Dmitry Baryshkov wrote: > > > > The drm_atomic_helper_check_wb_encoder_state() funct

Re: [Freedreno] [PATCH RESEND] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state

2023-12-05 Thread Maxime Ripard
On Tue, Dec 05, 2023 at 03:37:15AM +0200, Dmitry Baryshkov wrote: > On 04/12/2023 10:38, Maxime Ripard wrote: > > On Sat, Dec 02, 2023 at 12:07:49AM +0200, Dmitry Baryshkov wrote: > > > The drm_atomic_helper_check_wb_encoder_state() function doesn't use > > > encoder for anything other than getting

Re: [Freedreno] [PATCH RESEND] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state

2023-12-04 Thread Dmitry Baryshkov
On 04/12/2023 10:38, Maxime Ripard wrote: On Sat, Dec 02, 2023 at 12:07:49AM +0200, Dmitry Baryshkov wrote: The drm_atomic_helper_check_wb_encoder_state() function doesn't use encoder for anything other than getting the drm_device instance. The function's description talks about checking the wri

Re: [Freedreno] [PATCH RESEND] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state

2023-12-04 Thread Maxime Ripard
On Sat, Dec 02, 2023 at 12:07:49AM +0200, Dmitry Baryshkov wrote: > The drm_atomic_helper_check_wb_encoder_state() function doesn't use > encoder for anything other than getting the drm_device instance. The > function's description talks about checking the writeback connector > state, not the encod

[Freedreno] [PATCH RESEND] drm/atomic-helper: rename drm_atomic_helper_check_wb_encoder_state

2023-12-01 Thread Dmitry Baryshkov
The drm_atomic_helper_check_wb_encoder_state() function doesn't use encoder for anything other than getting the drm_device instance. The function's description talks about checking the writeback connector state, not the encoder state. Moreover, there is no such thing as an encoder state, encoders g